Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119236/?format=api
{ "id": 119236, "url": "http://patchwork.dpdk.org/api/patches/119236/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20221027140945.18249-1-juraj.linkes@pantheon.tech/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221027140945.18249-1-juraj.linkes@pantheon.tech>", "list_archive_url": "https://inbox.dpdk.org/dev/20221027140945.18249-1-juraj.linkes@pantheon.tech", "date": "2022-10-27T14:09:45", "name": "[v1] dts: fix ssh timeout and output", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "982e1b29712395b80171c7810779725cbcf0708e", "submitter": { "id": 1626, "url": "http://patchwork.dpdk.org/api/people/1626/?format=api", "name": "Juraj Linkeš", "email": "juraj.linkes@pantheon.tech" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20221027140945.18249-1-juraj.linkes@pantheon.tech/mbox/", "series": [ { "id": 25455, "url": "http://patchwork.dpdk.org/api/series/25455/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=25455", "date": "2022-10-27T14:09:45", "name": "[v1] dts: fix ssh timeout and output", "version": 1, "mbox": "http://patchwork.dpdk.org/series/25455/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/119236/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/119236/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B01DAA00C5;\n\tThu, 27 Oct 2022 16:09:49 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4B5BC42670;\n\tThu, 27 Oct 2022 16:09:49 +0200 (CEST)", "from lb.pantheon.sk (lb.pantheon.sk [46.229.239.20])\n by mails.dpdk.org (Postfix) with ESMTP id B557341153\n for <dev@dpdk.org>; Thu, 27 Oct 2022 16:09:47 +0200 (CEST)", "from localhost (localhost [127.0.0.1])\n by lb.pantheon.sk (Postfix) with ESMTP id 623F51B6ECF;\n Thu, 27 Oct 2022 16:09:47 +0200 (CEST)", "from lb.pantheon.sk ([127.0.0.1])\n by localhost (lb.pantheon.sk [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id WZ8_LarVrPEY; Thu, 27 Oct 2022 16:09:46 +0200 (CEST)", "from entguard.lab.pantheon.local (unknown [46.229.239.141])\n by lb.pantheon.sk (Postfix) with ESMTP id 27DC71B6ECA;\n Thu, 27 Oct 2022 16:09:46 +0200 (CEST)" ], "X-Virus-Scanned": "amavisd-new at siecit.sk", "From": "=?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "To": "", "Cc": "dev@dpdk.org, =?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "Subject": "[PATCH v1] dts: fix ssh timeout and output", "Date": "Thu, 27 Oct 2022 14:09:45 +0000", "Message-Id": "<20221027140945.18249-1-juraj.linkes@pantheon.tech>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "We were always waiting the full timeout because we always waited for\nthe MAGIC_PROMPT, which is only usable for cleaning the session of\nprevious data. That also meant that the actual prompt was appended to\nthe output, resulting in output being '[PEXPECT]#' when the executed\ncommand produced empty output. Both are fixed by using the MAGIC_PROMPT\nonly in self._clean_session.\n\nFixes: e81a070a1c7d (\"dts: add ssh session module\")\n\nSigned-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>\n---\n dts/framework/remote_session/ssh_session.py | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/dts/framework/remote_session/ssh_session.py b/dts/framework/remote_session/ssh_session.py\nindex f71acfb1ca..dc37e9772b 100644\n--- a/dts/framework/remote_session/ssh_session.py\n+++ b/dts/framework/remote_session/ssh_session.py\n@@ -116,7 +116,9 @@ def send_expect_base(self, command: str, prompt: str, timeout: float) -> str:\n return before\n \n def _clean_session(self) -> None:\n+ self.session.PROMPT = self.magic_prompt\n self.get_output(timeout=0.01)\n+ self.session.PROMPT = self.session.UNIQUE_PROMPT\n \n def _send_line(self, command: str) -> None:\n if not self.is_alive():\n@@ -134,7 +136,6 @@ def get_output(self, timeout: float = 15) -> str:\n \"\"\"\n Get all output before timeout\n \"\"\"\n- self.session.PROMPT = self.magic_prompt\n try:\n self.session.prompt(timeout)\n except Exception:\n@@ -143,7 +144,6 @@ def get_output(self, timeout: float = 15) -> str:\n before = self._get_output()\n self._flush()\n \n- self.logger.debug(before)\n return before\n \n def _get_output(self) -> str:\n", "prefixes": [ "v1" ] }