Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119438/?format=api
{ "id": 119438, "url": "http://patchwork.dpdk.org/api/patches/119438/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20221103134909.21791-3-andrew.boyer@amd.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221103134909.21791-3-andrew.boyer@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221103134909.21791-3-andrew.boyer@amd.com", "date": "2022-11-03T13:49:09", "name": "[2/2] net/ionic: fix up minor coverity issue in packet transmit", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3e0defe192d17e888ca203f678758d8fc72d7206", "submitter": { "id": 2861, "url": "http://patchwork.dpdk.org/api/people/2861/?format=api", "name": "Andrew Boyer", "email": "Andrew.Boyer@amd.com" }, "delegate": { "id": 3961, "url": "http://patchwork.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20221103134909.21791-3-andrew.boyer@amd.com/mbox/", "series": [ { "id": 25551, "url": "http://patchwork.dpdk.org/api/series/25551/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=25551", "date": "2022-11-03T13:49:07", "name": "net/ionic: fix up minor coverity issues", "version": 1, "mbox": "http://patchwork.dpdk.org/series/25551/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/119438/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/119438/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AD804A00C2;\n\tThu, 3 Nov 2022 14:49:51 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9872342D0C;\n\tThu, 3 Nov 2022 14:49:51 +0100 (CET)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2072.outbound.protection.outlook.com [40.107.237.72])\n by mails.dpdk.org (Postfix) with ESMTP id 0FDA642D02\n for <dev@dpdk.org>; Thu, 3 Nov 2022 14:49:50 +0100 (CET)", "from BN0PR04CA0122.namprd04.prod.outlook.com (2603:10b6:408:ed::7)\n by DM6PR12MB4299.namprd12.prod.outlook.com (2603:10b6:5:223::9) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Thu, 3 Nov\n 2022 13:49:46 +0000", "from BN8NAM11FT101.eop-nam11.prod.protection.outlook.com\n (2603:10b6:408:ed:cafe::5a) by BN0PR04CA0122.outlook.office365.com\n (2603:10b6:408:ed::7) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend\n Transport; Thu, 3 Nov 2022 13:49:46 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n BN8NAM11FT101.mail.protection.outlook.com (10.13.177.126) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.5791.20 via Frontend Transport; Thu, 3 Nov 2022 13:49:46 +0000", "from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 3 Nov\n 2022 08:49:45 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=HmS9rjSL4LEMCFEAWwe3lDlTCWokB25oAO9Gptj+5tD56WDtTV+Zj/dQAAOaBuozu1Y1aL1BR9yecOzmqJczsVWw6HRR5ecKLwThEQy0EkYVPRQE8QJC4TMhn+WPMM9meoeyFY0t0Yee/aEJ3xbSSfjWjnGyQ67MFXdJQbdrYiROXsGfoA22w2YiRYLZyCNlGe3uRcI25jHGqc8fJDSNGCuOyXZvlLFASoCEIPGKC6wlSvSWDbphv8RItnywD2Fyj1+h62j5je2Iz3WcaVIT/Q58Oj9Od9fpVcUxnJZs0U4E6InLdYr6RMfx9JKcxz4CtHjNTbfU5F2oG9xFIISAsA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=ElqeCs2hTxSr/F3FqE3RqxVhLge+9Knis6Qw0yGH+BQ=;\n b=Z6wU7zNq48mSJ0Zri/mqXPZuSKplcAzZRjPkzizduwV4ryBow6VAu5l/nEnZuObZ8Mel2Den1+IGWdHLM3oe6PvK79ubBUeCf9yk9tMYGr8zDnxe46ppDI7Uv4w79sP4r8DV1lejH9Yl/fzw9wuTDsl0CG4A69WbgJwJLGBE+RADy8qamMKINazSkAwTndk++OJ5xxlJlTdhYuyyP3ZHojapEA+fS6+kmVOoe0YZL2AGVgPHC46J/WAtcA/kRER3O4xSt4Q01rhmlsMCYLq2eZV7wg9YW18RSPusPJdGL7lpz0vVTAbHVEBMHShQ2KVOXSsonSr3iW6lHqQopf9GeQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ElqeCs2hTxSr/F3FqE3RqxVhLge+9Knis6Qw0yGH+BQ=;\n b=odn6onfwnvPz1UwMNYJSDV7UwLs/ZvQZejUAdu7d8w9VtKS1UOabDhNHKq0r2cfMkITH+jH1LelG1r8cN9ODuDXAnmoZ1GiMymAo1kTHsBwMmZJBfML2qU9MpE/qw/lCWOll5ER9TF4pbi6DCqMMYcIO69B1XLzy6aPQ9NRBQ+Q=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Andrew Boyer <andrew.boyer@amd.com>", "To": "<dev@dpdk.org>", "CC": "Andrew Boyer <andrew.boyer@amd.com>", "Subject": "[PATCH 2/2] net/ionic: fix up minor coverity issue in packet transmit", "Date": "Thu, 3 Nov 2022 06:49:09 -0700", "Message-ID": "<20221103134909.21791-3-andrew.boyer@amd.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20221103134909.21791-1-andrew.boyer@amd.com>", "References": "<20221103134909.21791-1-andrew.boyer@amd.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BN8NAM11FT101:EE_|DM6PR12MB4299:EE_", "X-MS-Office365-Filtering-Correlation-Id": "3adea669-4590-4c37-99cc-08dabda244f8", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n xZ0i0XboFTNjtPKKaZXAlyNLI6NDzNBGENAzI/cGJ+/yCwI7865zzP55TW+VHCDrtNwReuEOvIJFRK5m+FXE/N1hBnelbfnS3v4tzE14jtQkXkXQGfxsgeZRXVDYhpdhNienNpXa+6YWx0qAbCGsUj51SYJWWrmGlCWfjYMk9Wbb/iqS+WvyCVM1NUOozksJY5IDbiRUMWXiIE3WJ0h/LFyofzIdR2jGmLR95jwGll64t6QcvaR2kCMj2IQHBXyhvFA+T3WSnjq4LrZ2AgwbScTFmMTEYxvToxVtnWCYseKYW3GFaj3sJzzIlY2ZxcCKza2j4UC7HJWOD36o2e6B8eRsuURaLraR0gIB2xLqZT7gyKXXIBhkemN5p16tRjzOmHgGtrAicoToR6TeLEUjG0Qiuyx6YYuYjBYJYp90pOvqFLf0CTbDErvGqz3qMq6HPcHhxTYgvEiRocvcqx1qycyb57lTT9nc3HNPFMGOLPpCmippJISZyusK/QDgL3QqWbeeQ7ReUn/3z+5UBQhibQ23BNdt75N9/LUEiyF84ce+Q2ZrUfvtymn0gu2tP5+dSXAlTcYSnELnwLzXUBg6aqSHZnl3Tl+Dqz09olj7Vx2r6zbG4ubOujk7RH+ewD1o7kv8cIbb+m7YxGjgSfHKOe3UqUTenPAYTckOqmKfwJuZhYz9Y9EUqVrs+YIinBrMzkQv39IWx5jYs51rUE2pG/hKGJNLh8TwDY5RkvzfKcTNF+TBiVegooPKDxqYoKe483zZJczUDPc0jvsAVTs7Q0lfgIqBNNfoi9G3j0nES4E=", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199015)(46966006)(40470700004)(36840700001)(82740400003)(356005)(478600001)(36756003)(40460700003)(86362001)(40480700001)(2906002)(44832011)(70586007)(81166007)(6666004)(316002)(70206006)(4326008)(8936002)(8676002)(41300700001)(5660300002)(6916009)(16526019)(82310400005)(186003)(26005)(36860700001)(2616005)(1076003)(336012)(426003)(47076005)(83380400001)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 Nov 2022 13:49:46.5372 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 3adea669-4590-4c37-99cc-08dabda244f8", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT101.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR12MB4299", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "If tx_pkts is NULL, nb_pkts must be 0. Coverity doesn't know\nthis so it thinks this is a forward-NULL violation.\nMake things more clear by checking for nb_pkts instead.\n\nCoverity issue: 381614\nCoverity issue: 381619\nFixes: e86a6fcc7cf3 (\"net/ionic: add optimized non-scattered Rx/Tx\")\n\nSigned-off-by: Andrew Boyer <andrew.boyer@amd.com>\n---\n drivers/net/ionic/ionic_rxtx_sg.c | 2 +-\n drivers/net/ionic/ionic_rxtx_simple.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_rxtx_sg.c b/drivers/net/ionic/ionic_rxtx_sg.c\nindex 2752ba2acd..ab8e56e91c 100644\n--- a/drivers/net/ionic/ionic_rxtx_sg.c\n+++ b/drivers/net/ionic/ionic_rxtx_sg.c\n@@ -175,7 +175,7 @@ ionic_xmit_pkts_sg(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\trte_prefetch0(&desc_base[q->head_idx]);\n \trte_prefetch0(IONIC_INFO_PTR(q, q->head_idx));\n \n-\tif (tx_pkts) {\n+\tif (nb_pkts) {\n \t\trte_mbuf_prefetch_part1(tx_pkts[0]);\n \t\trte_mbuf_prefetch_part2(tx_pkts[0]);\n \t}\ndiff --git a/drivers/net/ionic/ionic_rxtx_simple.c b/drivers/net/ionic/ionic_rxtx_simple.c\nindex 0421fb32b2..5f81856256 100644\n--- a/drivers/net/ionic/ionic_rxtx_simple.c\n+++ b/drivers/net/ionic/ionic_rxtx_simple.c\n@@ -148,7 +148,7 @@ ionic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\trte_prefetch0(&desc_base[q->head_idx]);\n \trte_prefetch0(&q->info[q->head_idx]);\n \n-\tif (tx_pkts) {\n+\tif (nb_pkts) {\n \t\trte_mbuf_prefetch_part1(tx_pkts[0]);\n \t\trte_mbuf_prefetch_part2(tx_pkts[0]);\n \t}\n", "prefixes": [ "2/2" ] }