Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/120193/?format=api
{ "id": 120193, "url": "http://patchwork.dpdk.org/api/patches/120193/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20221128085935.161671-2-rjarry@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221128085935.161671-2-rjarry@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221128085935.161671-2-rjarry@redhat.com", "date": "2022-11-28T08:59:32", "name": "[v2,1/4] eal: add lcore info in telemetry", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4e0164c9eb148d2e4c292ea3b1a7405cd719f8cb", "submitter": { "id": 2850, "url": "http://patchwork.dpdk.org/api/people/2850/?format=api", "name": "Robin Jarry", "email": "rjarry@redhat.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20221128085935.161671-2-rjarry@redhat.com/mbox/", "series": [ { "id": 25905, "url": "http://patchwork.dpdk.org/api/series/25905/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=25905", "date": "2022-11-28T08:59:31", "name": "lcore telemetry improvements", "version": 2, "mbox": "http://patchwork.dpdk.org/series/25905/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/120193/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/120193/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1BC0DA00C3;\n\tMon, 28 Nov 2022 09:59:56 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E59AD42BAC;\n\tMon, 28 Nov 2022 09:59:51 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id ED73842C76\n for <dev@dpdk.org>; Mon, 28 Nov 2022 09:59:49 +0100 (CET)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-249-kajoQiKwP9eTRIue10p_0g-1; Mon, 28 Nov 2022 03:59:46 -0500", "from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com\n [10.11.54.5])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0F9F63C0D18F;\n Mon, 28 Nov 2022 08:59:45 +0000 (UTC)", "from paul.home (unknown [10.39.208.22])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 31CF117582;\n Mon, 28 Nov 2022 08:59:44 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1669625989;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=N2PhIafiaEgPrbHw5tO4vWFx9mHrMjsyclbhBkcYaDQ=;\n b=ZlS7zTCkgumqgK//mzNHHDtgdWbQULrTXBBowasPDeK8G66wk6shhdIk07Ubmh5FJoN6Pa\n A8H/LUNUZ2M7V2xqbAcxzmGiQkRXl1mDaoAOzfRGvJFu5izaHRlmfMIiD19DgZmx7tTaw7\n 6ppBasHIjreUok8NGC/ST/sgfX+XsSU=", "X-MC-Unique": "kajoQiKwP9eTRIue10p_0g-1", "From": "Robin Jarry <rjarry@redhat.com>", "To": "dev@dpdk.org", "Cc": "Robin Jarry <rjarry@redhat.com>,\n Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v2 1/4] eal: add lcore info in telemetry", "Date": "Mon, 28 Nov 2022 09:59:32 +0100", "Message-Id": "<20221128085935.161671-2-rjarry@redhat.com>", "In-Reply-To": "<20221128085935.161671-1-rjarry@redhat.com>", "References": "<20221123102612.1688865-1-rjarry@redhat.com>\n <20221128085935.161671-1-rjarry@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.5", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Report the same information than rte_lcore_dump() in the telemetry\nAPI into /eal/lcore/list and /eal/lcore/info,ID.\n\nExample:\n\n --> /eal/lcore/info,3\n {\n \"/eal/lcore/info\": {\n \"lcore_id\": 3,\n \"socket\": 0,\n \"role\": \"RTE\",\n \"cpuset\": [\n 3\n ]\n }\n }\n\nCc: Stephen Hemminger <stephen@networkplumber.org>\nSigned-off-by: Robin Jarry <rjarry@redhat.com>\n---\nv1 -> v2: Changed \"cpuset\" to an array of CPU ids instead of a string.\n\n lib/eal/common/eal_common_lcore.c | 92 +++++++++++++++++++++++++++++++\n 1 file changed, 92 insertions(+)\n\n--\n2.38.1", "diff": "diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_lcore.c\nindex 06c594b0224f..8a6c12550238 100644\n--- a/lib/eal/common/eal_common_lcore.c\n+++ b/lib/eal/common/eal_common_lcore.c\n@@ -10,6 +10,7 @@\n #include <rte_errno.h>\n #include <rte_lcore.h>\n #include <rte_log.h>\n+#include <rte_telemetry.h>\n\n #include \"eal_private.h\"\n #include \"eal_thread.h\"\n@@ -456,3 +457,94 @@ rte_lcore_dump(FILE *f)\n {\n \trte_lcore_iterate(lcore_dump_cb, f);\n }\n+\n+static int\n+lcore_telemetry_id_cb(unsigned int lcore_id, void *arg)\n+{\n+\tstruct rte_tel_data *d = arg;\n+\treturn rte_tel_data_add_array_int(d, lcore_id);\n+}\n+\n+static int\n+handle_lcore_list(const char *cmd __rte_unused,\n+\t\t\tconst char *params __rte_unused,\n+\t\t\tstruct rte_tel_data *d)\n+{\n+\tint ret = rte_tel_data_start_array(d, RTE_TEL_INT_VAL);\n+\tif (ret)\n+\t\treturn ret;\n+\treturn rte_lcore_iterate(lcore_telemetry_id_cb, d);\n+}\n+\n+struct lcore_telemetry_info {\n+\tunsigned int lcore_id;\n+\tstruct rte_tel_data *d;\n+};\n+\n+static int\n+lcore_telemetry_info_cb(unsigned int lcore_id, void *arg)\n+{\n+\tstruct lcore_telemetry_info *info = arg;\n+\tstruct rte_config *cfg = rte_eal_get_configuration();\n+\tstruct rte_tel_data *cpuset;\n+\tconst char *role;\n+\tunsigned int cpu;\n+\n+\tif (info->lcore_id != lcore_id)\n+\t\treturn 0;\n+\n+\tswitch (cfg->lcore_role[lcore_id]) {\n+\tcase ROLE_RTE:\n+\t\trole = \"RTE\";\n+\t\tbreak;\n+\tcase ROLE_SERVICE:\n+\t\trole = \"SERVICE\";\n+\t\tbreak;\n+\tcase ROLE_NON_EAL:\n+\t\trole = \"NON_EAL\";\n+\t\tbreak;\n+\tdefault:\n+\t\trole = \"UNKNOWN\";\n+\t\tbreak;\n+\t}\n+\trte_tel_data_start_dict(info->d);\n+\trte_tel_data_add_dict_int(info->d, \"lcore_id\", lcore_id);\n+\trte_tel_data_add_dict_int(info->d, \"socket\", rte_lcore_to_socket_id(lcore_id));\n+\trte_tel_data_add_dict_string(info->d, \"role\", role);\n+\tcpuset = rte_tel_data_alloc();\n+\tif (!cpuset)\n+\t\treturn -ENOMEM;\n+\trte_tel_data_start_array(cpuset, RTE_TEL_INT_VAL);\n+\tfor (cpu = 0; cpu < CPU_SETSIZE; cpu++)\n+\t\tif (CPU_ISSET(cpu, &lcore_config[lcore_id].cpuset))\n+\t\t\trte_tel_data_add_array_int(cpuset, cpu);\n+\trte_tel_data_add_dict_container(info->d, \"cpuset\", cpuset, 0);\n+\n+\treturn 0;\n+}\n+\n+static int\n+handle_lcore_info(const char *cmd __rte_unused, const char *params, struct rte_tel_data *d)\n+{\n+\tstruct lcore_telemetry_info info = { .d = d };\n+\tchar *endptr = NULL;\n+\tif (params == NULL || strlen(params) == 0)\n+\t\treturn -EINVAL;\n+\terrno = 0;\n+\tinfo.lcore_id = strtoul(params, &endptr, 10);\n+\tif (errno)\n+\t\treturn -errno;\n+\tif (endptr == params)\n+\t\treturn -EINVAL;\n+\treturn rte_lcore_iterate(lcore_telemetry_info_cb, &info);\n+}\n+\n+RTE_INIT(lcore_telemetry)\n+{\n+\trte_telemetry_register_cmd(\n+\t\t\t\"/eal/lcore/list\", handle_lcore_list,\n+\t\t\t\"List of lcore ids. Takes no parameters\");\n+\trte_telemetry_register_cmd(\n+\t\t\t\"/eal/lcore/info\", handle_lcore_info,\n+\t\t\t\"Returns lcore info. Parameters: int lcore_id\");\n+}\n", "prefixes": [ "v2", "1/4" ] }