Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/121331/?format=api
{ "id": 121331, "url": "http://patchwork.dpdk.org/api/patches/121331/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20221223015558.3143279-20-mingxia.liu@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221223015558.3143279-20-mingxia.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221223015558.3143279-20-mingxia.liu@intel.com", "date": "2022-12-23T01:55:56", "name": "[19/21] net/cpfl: add RSS set/get ops", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9b5b30115d6997881f4c0a103850dfbb244966bc", "submitter": { "id": 2514, "url": "http://patchwork.dpdk.org/api/people/2514/?format=api", "name": "Liu, Mingxia", "email": "mingxia.liu@intel.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20221223015558.3143279-20-mingxia.liu@intel.com/mbox/", "series": [ { "id": 26253, "url": "http://patchwork.dpdk.org/api/series/26253/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=26253", "date": "2022-12-23T01:55:37", "name": "add support for cpfl PMD in DPDK", "version": 1, "mbox": "http://patchwork.dpdk.org/series/26253/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/121331/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/121331/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 955F2A0093;\n\tFri, 23 Dec 2022 03:53:38 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9EB8F42D6E;\n\tFri, 23 Dec 2022 03:52:21 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id A3B2F42D5F\n for <dev@dpdk.org>; Fri, 23 Dec 2022 03:52:19 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Dec 2022 18:52:19 -0800", "from dpdk-mingxial-01.sh.intel.com ([10.67.119.112])\n by orsmga006.jf.intel.com with ESMTP; 22 Dec 2022 18:52:17 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1671763939; x=1703299939;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Y4gByhY+VyPhxtxFHWV88fwtYORyfy+HUsd3tT9EnbM=;\n b=BFJGv0hhYhnPR4CBi/42nesYOpelIFvplclZLjbF0XJHbS43UUmNoYd3\n 7dFR9rornxIOOYRdiABLESPa/chW4J2Bb8R1StXsn/J+GcPL/r5Uel5Hm\n Pg5wKg0QhRGmhD4szAROr/l48wKFuiwYb6rqQzfMbk9eGW3Rfurdhdcpc\n r5i4wV1TfLKyg4lswbyVz/UnKU1m1ZTfJoF/SRdVa0f6cF+I+I0kw2rGg\n PJdV04Ffax0oht1Hd6Tj0GCSpC8g29hPdjf0dO0+yOekjZf6K7g+kZIXW\n a7nRtlulOS5ECf05ZmeJkrlBK2iifYiuoeWauOmycAgeROI3Wtm21d6JO A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10569\"; a=\"321467137\"", "E=Sophos;i=\"5.96,267,1665471600\"; d=\"scan'208\";a=\"321467137\"", "E=McAfee;i=\"6500,9779,10569\"; a=\"629707206\"", "E=Sophos;i=\"5.96,267,1665471600\"; d=\"scan'208\";a=\"629707206\"" ], "X-ExtLoop1": "1", "From": "Mingxia Liu <mingxia.liu@intel.com>", "To": "dev@dpdk.org", "Cc": "jingjing.wu@intel.com, beilei.xing@intel.com, qi.z.zhang@intel.com,\n Mingxia Liu <mingxia.liu@intel.com>", "Subject": "[PATCH 19/21] net/cpfl: add RSS set/get ops", "Date": "Fri, 23 Dec 2022 01:55:56 +0000", "Message-Id": "<20221223015558.3143279-20-mingxia.liu@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221223015558.3143279-1-mingxia.liu@intel.com>", "References": "<20221223015558.3143279-1-mingxia.liu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add support for these device ops:\n- rss_reta_update\n- rss_reta_query\n- rss_hash_update\n- rss_hash_conf_get\n\nSigned-off-by: Mingxia Liu <mingxia.liu@intel.com>\n---\n drivers/net/cpfl/cpfl_ethdev.c | 303 +++++++++++++++++++++++++++++++++\n 1 file changed, 303 insertions(+)", "diff": "diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c\nindex 026ac52997..578137dca0 100644\n--- a/drivers/net/cpfl/cpfl_ethdev.c\n+++ b/drivers/net/cpfl/cpfl_ethdev.c\n@@ -30,6 +30,56 @@ static const char * const cpfl_valid_args[] = {\n \tNULL\n };\n \n+static const uint64_t cpfl_map_hena_rss[] = {\n+\t[IDPF_HASH_NONF_UNICAST_IPV4_UDP] =\n+\t\t\tRTE_ETH_RSS_NONFRAG_IPV4_UDP,\n+\t[IDPF_HASH_NONF_MULTICAST_IPV4_UDP] =\n+\t\t\tRTE_ETH_RSS_NONFRAG_IPV4_UDP,\n+\t[IDPF_HASH_NONF_IPV4_UDP] =\n+\t\t\tRTE_ETH_RSS_NONFRAG_IPV4_UDP,\n+\t[IDPF_HASH_NONF_IPV4_TCP_SYN_NO_ACK] =\n+\t\t\tRTE_ETH_RSS_NONFRAG_IPV4_TCP,\n+\t[IDPF_HASH_NONF_IPV4_TCP] =\n+\t\t\tRTE_ETH_RSS_NONFRAG_IPV4_TCP,\n+\t[IDPF_HASH_NONF_IPV4_SCTP] =\n+\t\t\tRTE_ETH_RSS_NONFRAG_IPV4_SCTP,\n+\t[IDPF_HASH_NONF_IPV4_OTHER] =\n+\t\t\tRTE_ETH_RSS_NONFRAG_IPV4_OTHER,\n+\t[IDPF_HASH_FRAG_IPV4] = RTE_ETH_RSS_FRAG_IPV4,\n+\n+\t/* IPv6 */\n+\t[IDPF_HASH_NONF_UNICAST_IPV6_UDP] =\n+\t\t\tRTE_ETH_RSS_NONFRAG_IPV6_UDP,\n+\t[IDPF_HASH_NONF_MULTICAST_IPV6_UDP] =\n+\t\t\tRTE_ETH_RSS_NONFRAG_IPV6_UDP,\n+\t[IDPF_HASH_NONF_IPV6_UDP] =\n+\t\t\tRTE_ETH_RSS_NONFRAG_IPV6_UDP,\n+\t[IDPF_HASH_NONF_IPV6_TCP_SYN_NO_ACK] =\n+\t\t\tRTE_ETH_RSS_NONFRAG_IPV6_TCP,\n+\t[IDPF_HASH_NONF_IPV6_TCP] =\n+\t\t\tRTE_ETH_RSS_NONFRAG_IPV6_TCP,\n+\t[IDPF_HASH_NONF_IPV6_SCTP] =\n+\t\t\tRTE_ETH_RSS_NONFRAG_IPV6_SCTP,\n+\t[IDPF_HASH_NONF_IPV6_OTHER] =\n+\t\t\tRTE_ETH_RSS_NONFRAG_IPV6_OTHER,\n+\t[IDPF_HASH_FRAG_IPV6] = RTE_ETH_RSS_FRAG_IPV6,\n+\n+\t/* L2 Payload */\n+\t[IDPF_HASH_L2_PAYLOAD] = RTE_ETH_RSS_L2_PAYLOAD\n+};\n+\n+static const uint64_t cpfl_ipv4_rss = RTE_ETH_RSS_NONFRAG_IPV4_UDP |\n+\t\t\t RTE_ETH_RSS_NONFRAG_IPV4_TCP |\n+\t\t\t RTE_ETH_RSS_NONFRAG_IPV4_SCTP |\n+\t\t\t RTE_ETH_RSS_NONFRAG_IPV4_OTHER |\n+\t\t\t RTE_ETH_RSS_FRAG_IPV4;\n+\n+static const uint64_t cpfl_ipv6_rss = RTE_ETH_RSS_NONFRAG_IPV6_UDP |\n+\t\t\t RTE_ETH_RSS_NONFRAG_IPV6_TCP |\n+\t\t\t RTE_ETH_RSS_NONFRAG_IPV6_SCTP |\n+\t\t\t RTE_ETH_RSS_NONFRAG_IPV6_OTHER |\n+\t\t\t RTE_ETH_RSS_FRAG_IPV6;\n+\n static int\n cpfl_dev_link_update(struct rte_eth_dev *dev,\n \t\t __rte_unused int wait_to_complete)\n@@ -97,6 +147,9 @@ cpfl_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \tdev_info->max_mtu = dev_info->max_rx_pktlen - CPFL_ETH_OVERHEAD;\n \tdev_info->min_mtu = RTE_ETHER_MIN_MTU;\n \n+\tdev_info->hash_key_size = vport->rss_key_size;\n+\tdev_info->reta_size = vport->rss_lut_size;\n+\n \tdev_info->flow_type_rss_offloads = CPFL_RSS_OFFLOAD_ALL;\n \n \tdev_info->rx_offload_capa =\n@@ -250,6 +303,54 @@ cpfl_dev_stats_reset(struct rte_eth_dev *dev)\n \treturn 0;\n }\n \n+static int cpfl_config_rss_hf(struct idpf_vport *vport, uint64_t rss_hf)\n+{\n+\tuint64_t hena = 0, valid_rss_hf = 0;\n+\tint ret = 0;\n+\tuint16_t i;\n+\n+\t/**\n+\t * RTE_ETH_RSS_IPV4 and RTE_ETH_RSS_IPV6 can be considered as 2\n+\t * generalizations of all other IPv4 and IPv6 RSS types.\n+\t */\n+\tif (rss_hf & RTE_ETH_RSS_IPV4)\n+\t\trss_hf |= cpfl_ipv4_rss;\n+\n+\tif (rss_hf & RTE_ETH_RSS_IPV6)\n+\t\trss_hf |= cpfl_ipv6_rss;\n+\n+\tfor (i = 0; i < RTE_DIM(cpfl_map_hena_rss); i++) {\n+\t\tuint64_t bit = BIT_ULL(i);\n+\n+\t\tif (cpfl_map_hena_rss[i] & rss_hf) {\n+\t\t\tvalid_rss_hf |= cpfl_map_hena_rss[i];\n+\t\t\thena |= bit;\n+\t\t}\n+\t}\n+\n+\tvport->rss_hf = hena;\n+\n+\tret = idpf_vc_set_rss_hash(vport);\n+\tif (ret != 0) {\n+\t\tPMD_DRV_LOG(WARNING,\n+\t\t\t \"fail to set RSS offload types, ret: %d\", ret);\n+\t\treturn ret;\n+\t}\n+\n+\tif (valid_rss_hf & cpfl_ipv4_rss)\n+\t\tvalid_rss_hf |= rss_hf & RTE_ETH_RSS_IPV4;\n+\n+\tif (valid_rss_hf & cpfl_ipv6_rss)\n+\t\tvalid_rss_hf |= rss_hf & RTE_ETH_RSS_IPV6;\n+\n+\tif (rss_hf & ~valid_rss_hf)\n+\t\tPMD_DRV_LOG(WARNING, \"Unsupported rss_hf 0x%\" PRIx64,\n+\t\t\t rss_hf & ~valid_rss_hf);\n+\tvport->last_general_rss_hf = valid_rss_hf;\n+\n+\treturn ret;\n+}\n+\n static int\n cpfl_init_rss(struct idpf_vport *vport)\n {\n@@ -286,6 +387,204 @@ cpfl_init_rss(struct idpf_vport *vport)\n \treturn ret;\n }\n \n+static int\n+cpfl_rss_reta_update(struct rte_eth_dev *dev,\n+\t\t struct rte_eth_rss_reta_entry64 *reta_conf,\n+\t\t uint16_t reta_size)\n+{\n+\tstruct idpf_vport *vport = dev->data->dev_private;\n+\tstruct idpf_adapter *adapter = vport->adapter;\n+\tuint16_t idx, shift;\n+\tuint32_t *lut;\n+\tint ret = 0;\n+\tuint16_t i;\n+\n+\tif (adapter->caps.rss_caps == 0 || dev->data->nb_rx_queues == 0) {\n+\t\tPMD_DRV_LOG(DEBUG, \"RSS is not supported\");\n+\t\treturn -ENOTSUP;\n+\t}\n+\n+\tif (reta_size != vport->rss_lut_size) {\n+\t\tPMD_DRV_LOG(ERR, \"The size of hash lookup table configured \"\n+\t\t\t\t \"(%d) doesn't match the number of hardware can \"\n+\t\t\t\t \"support (%d)\",\n+\t\t\t reta_size, vport->rss_lut_size);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\t/* It MUST use the current LUT size to get the RSS lookup table,\n+\t * otherwise if will fail with -100 error code.\n+\t */\n+\tlut = rte_zmalloc(NULL, reta_size * sizeof(uint32_t), 0);\n+\tif (!lut) {\n+\t\tPMD_DRV_LOG(ERR, \"No memory can be allocated\");\n+\t\treturn -ENOMEM;\n+\t}\n+\t/* store the old lut table temporarily */\n+\trte_memcpy(lut, vport->rss_lut, reta_size);\n+\n+\tfor (i = 0; i < reta_size; i++) {\n+\t\tidx = i / RTE_ETH_RETA_GROUP_SIZE;\n+\t\tshift = i % RTE_ETH_RETA_GROUP_SIZE;\n+\t\tif (reta_conf[idx].mask & (1ULL << shift))\n+\t\t\tlut[i] = reta_conf[idx].reta[shift];\n+\t}\n+\n+\trte_memcpy(vport->rss_lut, lut, reta_size);\n+\t/* send virtchnl ops to configure RSS */\n+\tret = idpf_vc_set_rss_lut(vport);\n+\tif (ret) {\n+\t\tPMD_INIT_LOG(ERR, \"Failed to configure RSS lut\");\n+\t\tgoto out;\n+\t}\n+out:\n+\trte_free(lut);\n+\n+\treturn ret;\n+}\n+\n+static int\n+cpfl_rss_reta_query(struct rte_eth_dev *dev,\n+\t\t struct rte_eth_rss_reta_entry64 *reta_conf,\n+\t\t uint16_t reta_size)\n+{\n+\tstruct idpf_vport *vport = dev->data->dev_private;\n+\tstruct idpf_adapter *adapter = vport->adapter;\n+\tuint16_t idx, shift;\n+\tint ret = 0;\n+\tuint16_t i;\n+\n+\tif (adapter->caps.rss_caps == 0 || dev->data->nb_rx_queues == 0) {\n+\t\tPMD_DRV_LOG(DEBUG, \"RSS is not supported\");\n+\t\treturn -ENOTSUP;\n+\t}\n+\n+\tif (reta_size != vport->rss_lut_size) {\n+\t\tPMD_DRV_LOG(ERR, \"The size of hash lookup table configured \"\n+\t\t\t\"(%d) doesn't match the number of hardware can \"\n+\t\t\t\"support (%d)\", reta_size, vport->rss_lut_size);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tret = idpf_vc_get_rss_lut(vport);\n+\tif (ret) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to get RSS LUT\");\n+\t\treturn ret;\n+\t}\n+\n+\tfor (i = 0; i < reta_size; i++) {\n+\t\tidx = i / RTE_ETH_RETA_GROUP_SIZE;\n+\t\tshift = i % RTE_ETH_RETA_GROUP_SIZE;\n+\t\tif (reta_conf[idx].mask & (1ULL << shift))\n+\t\t\treta_conf[idx].reta[shift] = vport->rss_lut[i];\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+cpfl_rss_hash_update(struct rte_eth_dev *dev,\n+\t\t struct rte_eth_rss_conf *rss_conf)\n+{\n+\tstruct idpf_vport *vport = dev->data->dev_private;\n+\tstruct idpf_adapter *adapter = vport->adapter;\n+\tint ret = 0;\n+\n+\tif (adapter->caps.rss_caps == 0 || dev->data->nb_rx_queues == 0) {\n+\t\tPMD_DRV_LOG(DEBUG, \"RSS is not supported\");\n+\t\treturn -ENOTSUP;\n+\t}\n+\n+\tif (!rss_conf->rss_key || rss_conf->rss_key_len == 0) {\n+\t\tPMD_DRV_LOG(DEBUG, \"No key to be configured\");\n+\t\tgoto skip_rss_key;\n+\t} else if (rss_conf->rss_key_len != vport->rss_key_size) {\n+\t\tPMD_DRV_LOG(ERR, \"The size of hash key configured \"\n+\t\t\t\t \"(%d) doesn't match the size of hardware can \"\n+\t\t\t\t \"support (%d)\",\n+\t\t\t rss_conf->rss_key_len,\n+\t\t\t vport->rss_key_size);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\trte_memcpy(vport->rss_key, rss_conf->rss_key,\n+\t\t vport->rss_key_size);\n+\tret = idpf_vc_set_rss_key(vport);\n+\tif (ret != 0) {\n+\t\tPMD_INIT_LOG(ERR, \"Failed to configure RSS key\");\n+\t\treturn ret;\n+\t}\n+\n+skip_rss_key:\n+\tret = cpfl_config_rss_hf(vport, rss_conf->rss_hf);\n+\tif (ret != 0) {\n+\t\tPMD_INIT_LOG(ERR, \"Failed to configure RSS hash\");\n+\t\treturn ret;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static uint64_t\n+cpfl_map_general_rss_hf(uint64_t config_rss_hf, uint64_t last_general_rss_hf)\n+{\n+\tuint64_t valid_rss_hf = 0;\n+\tuint16_t i;\n+\n+\tfor (i = 0; i < RTE_DIM(cpfl_map_hena_rss); i++) {\n+\t\tuint64_t bit = BIT_ULL(i);\n+\n+\t\tif (bit & config_rss_hf)\n+\t\t\tvalid_rss_hf |= cpfl_map_hena_rss[i];\n+\t}\n+\n+\tif (valid_rss_hf & cpfl_ipv4_rss)\n+\t\tvalid_rss_hf |= last_general_rss_hf & RTE_ETH_RSS_IPV4;\n+\n+\tif (valid_rss_hf & cpfl_ipv6_rss)\n+\t\tvalid_rss_hf |= last_general_rss_hf & RTE_ETH_RSS_IPV6;\n+\n+\treturn valid_rss_hf;\n+}\n+\n+static int\n+cpfl_rss_hash_conf_get(struct rte_eth_dev *dev,\n+\t\t struct rte_eth_rss_conf *rss_conf)\n+{\n+\tstruct idpf_vport *vport = dev->data->dev_private;\n+\tstruct idpf_adapter *adapter = vport->adapter;\n+\tint ret = 0;\n+\n+\tif (adapter->caps.rss_caps == 0 || dev->data->nb_rx_queues == 0) {\n+\t\tPMD_DRV_LOG(DEBUG, \"RSS is not supported\");\n+\t\treturn -ENOTSUP;\n+\t}\n+\n+\tret = idpf_vc_get_rss_hash(vport);\n+\tif (ret) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to get RSS hf\");\n+\t\treturn ret;\n+\t}\n+\n+\trss_conf->rss_hf = cpfl_map_general_rss_hf(vport->rss_hf, vport->last_general_rss_hf);\n+\n+\tif (!rss_conf->rss_key)\n+\t\treturn 0;\n+\n+\tret = idpf_vc_get_rss_key(vport);\n+\tif (ret) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to get RSS key\");\n+\t\treturn ret;\n+\t}\n+\n+\tif (rss_conf->rss_key_len > vport->rss_key_size)\n+\t\trss_conf->rss_key_len = vport->rss_key_size;\n+\n+\trte_memcpy(rss_conf->rss_key, vport->rss_key, rss_conf->rss_key_len);\n+\n+\treturn 0;\n+}\n+\n static int\n cpfl_dev_configure(struct rte_eth_dev *dev)\n {\n@@ -845,6 +1144,10 @@ static const struct eth_dev_ops cpfl_eth_dev_ops = {\n \t.dev_supported_ptypes_get\t= cpfl_dev_supported_ptypes_get,\n \t.stats_get\t\t\t= cpfl_dev_stats_get,\n \t.stats_reset\t\t\t= cpfl_dev_stats_reset,\n+\t.reta_update\t\t\t= cpfl_rss_reta_update,\n+\t.reta_query\t\t\t= cpfl_rss_reta_query,\n+\t.rss_hash_update\t\t= cpfl_rss_hash_update,\n+\t.rss_hash_conf_get\t\t= cpfl_rss_hash_conf_get,\n };\n \n static uint16_t\n", "prefixes": [ "19/21" ] }