Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/121822/?format=api
{ "id": 121822, "url": "http://patchwork.dpdk.org/api/patches/121822/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230110163442.1157560-1-mahmad@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230110163442.1157560-1-mahmad@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230110163442.1157560-1-mahmad@marvell.com", "date": "2023-01-10T14:56:13", "name": "[v1] examples/l3fwd: fix for coverity scan", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0ac428c5db6ed68265d7c2b2c9b0dc2b558de388", "submitter": { "id": 2914, "url": "http://patchwork.dpdk.org/api/people/2914/?format=api", "name": "Mohammad Iqbal Ahmad", "email": "mahmad@marvell.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230110163442.1157560-1-mahmad@marvell.com/mbox/", "series": [ { "id": 26473, "url": "http://patchwork.dpdk.org/api/series/26473/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=26473", "date": "2023-01-10T14:56:13", "name": "[v1] examples/l3fwd: fix for coverity scan", "version": 1, "mbox": "http://patchwork.dpdk.org/series/26473/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/121822/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/121822/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 50873423AC;\n\tWed, 11 Jan 2023 10:39:48 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E3E4F42D26;\n\tWed, 11 Jan 2023 10:39:34 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 4525E40687\n for <dev@dpdk.org>; Tue, 10 Jan 2023 17:36:23 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 30AECUON003867; Tue, 10 Jan 2023 08:36:22 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3my94tv59x-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 10 Jan 2023 08:36:22 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.42;\n Tue, 10 Jan 2023 08:36:20 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.42 via Frontend\n Transport; Tue, 10 Jan 2023 08:36:20 -0800", "from localhost.localdomain (unknown [10.28.34.23])\n by maili.marvell.com (Postfix) with ESMTP id AC7EF3F7062;\n Tue, 10 Jan 2023 08:36:14 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=Ifbtq1BqTJBb6Dejyt4WuWu4UeD+nsskplsnnkUKsZQ=;\n b=J5IgVViTlc8UC+/8PBwQJhY8hpQZ9Sq/rh7U6Ic9QTKkE+kE5xjQTEnBdq/NXAAYetFT\n +rJfMxeUGdIjgsC1dJ78HNMp1NxP0UeJktIgXXmc2F/B0P88Ta/MNmFm0FZRlDY17cwM\n 81+0hoL+7NISzy7SPCvSQjt/WTLrZBgilfWqd/3yK7lO4wHqd/PwZlQBcJFvQg0j0zOp\n AoxnCyxo+BpOHBApxdKHA975RqwQDfydX6N64CS1DaZWapeQdCsPosLRv6V5cKrDPMkx\n OOc843Jw3CfSFsawBjhc8agjH8a1PLNFLMLsXnxRmwu573O25HuvlGtW4+miz2AXmSgb bQ==", "From": "Mohammad Iqbal Ahmad <mahmad@marvell.com>", "To": "<dev@dpdk.org>, Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Konstantin Ananyev <konstantin.ananyev@huawei.com>, Conor Walsh\n <conor.walsh@intel.com>", "CC": "<jerinj@marvell.com>, <skori@marvell.com>, <skoteshwar@marvell.com>,\n <pbhagavatula@marvell.com>, <kirankumark@marvell.com>,\n <psatheesh@marvell.com>, <asekhar@marvell.com>, <anoobj@marvell.com>,\n <gakhil@marvell.com>, <hkalra@marvell.com>, <ndabilpuram@marvell.com>,\n Mohammad Iqbal Ahmad <mahmad@marvell.com>", "Subject": "[PATCH v1] examples/l3fwd: fix for coverity scan", "Date": "Tue, 10 Jan 2023 20:26:13 +0530", "Message-ID": "<20230110163442.1157560-1-mahmad@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221216073958.1645736-1-mahmad@marvell.com>", "References": "<20221216073958.1645736-1-mahmad@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "OBkqZqMvYwu1s2mJSzYx8q7-LOaKRwTJ", "X-Proofpoint-GUID": "OBkqZqMvYwu1s2mJSzYx8q7-LOaKRwTJ", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1\n definitions=2023-01-10_06,2023-01-10_03,2022-06-22_01", "X-Mailman-Approved-At": "Wed, 11 Jan 2023 10:39:30 +0100", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch fixes (Logically dead code) coverity issue.\nThis patch also fixes (Uninitialized scalar variable) coverity issue.\n\nCoverity issue: 381687\nCoverity issue: 381686\nFixes: 6a094e328598 (\"examples/l3fwd: implement FIB lookup method\")\n\nSigned-off-by: Mohammad Iqbal Ahmad <mahmad@marvell.com>\n---\n examples/l3fwd/l3fwd_fib.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/examples/l3fwd/l3fwd_fib.c b/examples/l3fwd/l3fwd_fib.c\nindex edc0dd69b9..18398492ae 100644\n--- a/examples/l3fwd/l3fwd_fib.c\n+++ b/examples/l3fwd/l3fwd_fib.c\n@@ -359,10 +359,10 @@ fib_event_loop(struct l3fwd_event_resources *evt_rsrc,\n \t\t\t\tnh = (uint16_t)hopsv4[ipv4_arr_assem++];\n \t\t\telse\n \t\t\t\tnh = (uint16_t)hopsv6[ipv6_arr_assem++];\n-\t\t\tif (nh != FIB_DEFAULT_HOP)\n-\t\t\t\thops[i] = nh != FIB_DEFAULT_HOP ?\n-\t\t\t\t\t\t nh :\n-\t\t\t\t\t\t events[i].mbuf->port;\n+\n+\t\t\thops[i] = nh != FIB_DEFAULT_HOP ?\n+\t\t\t\t nh :\n+\t\t\t\t events[i].mbuf->port;\n \t\t\tprocess_packet(events[i].mbuf, &hops[i]);\n \t\t\tevents[i].mbuf->port = hops[i] != BAD_PORT ?\n \t\t\t\t\t\t hops[i] :\n", "prefixes": [ "v1" ] }