Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/121903/?format=api
{ "id": 121903, "url": "http://patchwork.dpdk.org/api/patches/121903/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230112105903.46341-10-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230112105903.46341-10-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230112105903.46341-10-bruce.richardson@intel.com", "date": "2023-01-12T10:59:03", "name": "[v2,9/9] telemetry: change public API to use 64-bit signed values", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3bd579f6c31b609048edc7a6b7dff72d806ecb65", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230112105903.46341-10-bruce.richardson@intel.com/mbox/", "series": [ { "id": 26504, "url": "http://patchwork.dpdk.org/api/series/26504/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=26504", "date": "2023-01-12T10:58:54", "name": "Standardize telemetry int types", "version": 2, "mbox": "http://patchwork.dpdk.org/series/26504/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/121903/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/121903/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3BDD3423B5;\n\tThu, 12 Jan 2023 12:00:21 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7818442D5B;\n\tThu, 12 Jan 2023 11:59:47 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 3116B42D2A\n for <dev@dpdk.org>; Thu, 12 Jan 2023 11:59:45 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Jan 2023 02:59:45 -0800", "from silpixa00401385.ir.intel.com ([10.237.214.166])\n by orsmga004.jf.intel.com with ESMTP; 12 Jan 2023 02:59:42 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1673521186; x=1705057186;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=l3PjSvXq1OyIVzUGA8CakUncJZvu8ZjjMEiXYThDxwA=;\n b=Tqv3/iFiVHSpyEikglW2IMElm4T4Mg4IezPY6VdZciHWfKjToQGcgZwC\n rOFY2QvbhazzML/pYTd7yG853EaEIY5I+dNNnaxBbbQkTuS/2gkAxllxV\n l5Au2UXxg7AfihOxoGzMtMk2vkhx+cKSqXyicFExg1+XIaGU1ESEqAaGa\n oURz7RdLHGQnmSaXQk94n/IB2JbgFq74ySpTR56mHDB2ZB+7UBF4TFyI4\n gObzmt15KCH+lI/tAzqDO9GJAr0gd+RxUvy+7xVCZpOAiqLm0XJzvf/1M\n LKGSzJ0THyFYvTWI+zk8qov3KXWrf+Rpxy4k6hXdn5BZRlnGSMj56Ssg0 Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10586\"; a=\"321365738\"", "E=Sophos;i=\"5.96,319,1665471600\"; d=\"scan'208\";a=\"321365738\"", "E=McAfee;i=\"6500,9779,10586\"; a=\"781746914\"", "E=Sophos;i=\"5.96,319,1665471600\"; d=\"scan'208\";a=\"781746914\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, =?utf-8?q?Morten_Br=C3=B8?=\n\t=?utf-8?q?rup?= <mb@smartsharesystems.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Ciara Power <ciara.power@intel.com>", "Subject": "[PATCH v2 9/9] telemetry: change public API to use 64-bit signed\n values", "Date": "Thu, 12 Jan 2023 10:59:03 +0000", "Message-Id": "<20230112105903.46341-10-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20230112105903.46341-1-bruce.richardson@intel.com>", "References": "<20221213182730.97065-1-bruce.richardson@intel.com>\n <20230112105903.46341-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "While the unsigned values added to telemetry dicts/arrays were up to\n64-bits in size, the sized values were only up to 32-bits. We can\nstandardize the API by having both int and uint functions take 64-bit\nvalues. For ABI compatibility, we use function versioning to ensure\nolder binaries can still use the older functions taking a 32-bit\nparameter.\n\nSuggested-by: Morten Brørup <mb@smartsharesystems.com>\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/telemetry/meson.build | 1 +\n lib/telemetry/rte_telemetry.h | 4 ++--\n lib/telemetry/telemetry_data.c | 33 +++++++++++++++++++++++++++++----\n lib/telemetry/telemetry_data.h | 6 ++++++\n lib/telemetry/version.map | 7 +++++++\n 5 files changed, 45 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/telemetry/meson.build b/lib/telemetry/meson.build\nindex f84c9aa3be..73750d9ef4 100644\n--- a/lib/telemetry/meson.build\n+++ b/lib/telemetry/meson.build\n@@ -6,3 +6,4 @@ includes = [global_inc]\n sources = files('telemetry.c', 'telemetry_data.c', 'telemetry_legacy.c')\n headers = files('rte_telemetry.h')\n includes += include_directories('../metrics')\n+use_function_versioning = true\ndiff --git a/lib/telemetry/rte_telemetry.h b/lib/telemetry/rte_telemetry.h\nindex 4598303d5d..b481c112dd 100644\n--- a/lib/telemetry/rte_telemetry.h\n+++ b/lib/telemetry/rte_telemetry.h\n@@ -120,7 +120,7 @@ rte_tel_data_add_array_string(struct rte_tel_data *d, const char *str);\n * 0 on success, negative errno on error\n */\n int\n-rte_tel_data_add_array_int(struct rte_tel_data *d, int x);\n+rte_tel_data_add_array_int(struct rte_tel_data *d, int64_t x);\n \n /**\n * Add an unsigned value to an array.\n@@ -208,7 +208,7 @@ rte_tel_data_add_dict_string(struct rte_tel_data *d, const char *name,\n * 0 on success, negative errno on error, E2BIG on string truncation of name.\n */\n int\n-rte_tel_data_add_dict_int(struct rte_tel_data *d, const char *name, int val);\n+rte_tel_data_add_dict_int(struct rte_tel_data *d, const char *name, int64_t val);\n \n /**\n * Add an unsigned value to a dictionary.\ndiff --git a/lib/telemetry/telemetry_data.c b/lib/telemetry/telemetry_data.c\nindex 9a180937fd..ac7be795df 100644\n--- a/lib/telemetry/telemetry_data.c\n+++ b/lib/telemetry/telemetry_data.c\n@@ -8,6 +8,7 @@\n #undef RTE_USE_LIBBSD\n #include <stdbool.h>\n \n+#include <rte_function_versioning.h>\n #include <rte_string_fns.h>\n \n #include \"telemetry_data.h\"\n@@ -58,8 +59,8 @@ rte_tel_data_add_array_string(struct rte_tel_data *d, const char *str)\n \treturn bytes < RTE_TEL_MAX_STRING_LEN ? 0 : E2BIG;\n }\n \n-int\n-rte_tel_data_add_array_int(struct rte_tel_data *d, int x)\n+int __vsym\n+rte_tel_data_add_array_int_v24(struct rte_tel_data *d, int64_t x)\n {\n \tif (d->type != TEL_ARRAY_INT)\n \t\treturn -EINVAL;\n@@ -69,6 +70,18 @@ rte_tel_data_add_array_int(struct rte_tel_data *d, int x)\n \treturn 0;\n }\n \n+int __vsym\n+rte_tel_data_add_array_int_v23(struct rte_tel_data *d, int x)\n+{\n+\treturn rte_tel_data_add_array_int_v24(d, x);\n+}\n+\n+/* mark the v23 function as the older version, and v24 as the default version */\n+VERSION_SYMBOL(rte_tel_data_add_array_int, _v23, 23);\n+BIND_DEFAULT_SYMBOL(rte_tel_data_add_array_int, _v24, 24);\n+MAP_STATIC_SYMBOL(int rte_tel_data_add_array_int(struct rte_tel_data *d,\n+\t\tint64_t x), rte_tel_data_add_array_int_v24);\n+\n int\n rte_tel_data_add_array_uint(struct rte_tel_data *d, uint64_t x)\n {\n@@ -146,8 +159,8 @@ rte_tel_data_add_dict_string(struct rte_tel_data *d, const char *name,\n \treturn 0;\n }\n \n-int\n-rte_tel_data_add_dict_int(struct rte_tel_data *d, const char *name, int val)\n+int __vsym\n+rte_tel_data_add_dict_int_v24(struct rte_tel_data *d, const char *name, int64_t val)\n {\n \tstruct tel_dict_entry *e = &d->data.dict[d->data_len];\n \tif (d->type != TEL_DICT)\n@@ -165,6 +178,18 @@ rte_tel_data_add_dict_int(struct rte_tel_data *d, const char *name, int val)\n \treturn bytes < RTE_TEL_MAX_STRING_LEN ? 0 : E2BIG;\n }\n \n+int __vsym\n+rte_tel_data_add_dict_int_v23(struct rte_tel_data *d, const char *name, int val)\n+{\n+\treturn rte_tel_data_add_dict_int_v24(d, name, val);\n+}\n+\n+/* mark the v23 function as the older version, and v24 as the default version */\n+VERSION_SYMBOL(rte_tel_data_add_dict_int, _v23, 23);\n+BIND_DEFAULT_SYMBOL(rte_tel_data_add_dict_int, _v24, 24);\n+MAP_STATIC_SYMBOL(int rte_tel_data_add_dict_int(struct rte_tel_data *d,\n+\t\tconst char *name, int64_t val), rte_tel_data_add_dict_int_v24);\n+\n int\n rte_tel_data_add_dict_uint(struct rte_tel_data *d,\n \t\tconst char *name, uint64_t val)\ndiff --git a/lib/telemetry/telemetry_data.h b/lib/telemetry/telemetry_data.h\nindex 205509c5a2..53e4cabea5 100644\n--- a/lib/telemetry/telemetry_data.h\n+++ b/lib/telemetry/telemetry_data.h\n@@ -49,4 +49,10 @@ struct rte_tel_data {\n \t} data; /* data container */\n };\n \n+/* versioned functions */\n+int rte_tel_data_add_array_int_v23(struct rte_tel_data *d, int val);\n+int rte_tel_data_add_array_int_v24(struct rte_tel_data *d, int64_t val);\n+int rte_tel_data_add_dict_int_v23(struct rte_tel_data *d, const char *name, int val);\n+int rte_tel_data_add_dict_int_v24(struct rte_tel_data *d, const char *name, int64_t val);\n+\n #endif\ndiff --git a/lib/telemetry/version.map b/lib/telemetry/version.map\nindex d661180317..accfad5011 100644\n--- a/lib/telemetry/version.map\n+++ b/lib/telemetry/version.map\n@@ -21,6 +21,13 @@ DPDK_23 {\n \tlocal: *;\n };\n \n+DPDK_24 {\n+\tglobal:\n+\n+\trte_tel_data_add_array_int;\n+\trte_tel_data_add_dict_int;\n+} DPDK_23;\n+\n INTERNAL {\n \trte_telemetry_legacy_register;\n \trte_telemetry_init;\n", "prefixes": [ "v2", "9/9" ] }