Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/122051/?format=api
http://patchwork.dpdk.org/api/patches/122051/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230113203656.1864072-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230113203656.1864072-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230113203656.1864072-4-bruce.richardson@intel.com", "date": "2023-01-13T20:36:56", "name": "[v3,3/3] telemetry: use standard logging", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "038ddbf3a5c9ac4134bb425451b280eb7104bdbe", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230113203656.1864072-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 26543, "url": "http://patchwork.dpdk.org/api/series/26543/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=26543", "date": "2023-01-13T20:36:53", "name": "Split logging functionality out of EAL", "version": 3, "mbox": "http://patchwork.dpdk.org/series/26543/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/122051/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/122051/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3F3DD423C7;\n\tFri, 13 Jan 2023 21:37:25 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DCD9742E2B;\n\tFri, 13 Jan 2023 21:37:10 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id E012942E17\n for <dev@dpdk.org>; Fri, 13 Jan 2023 21:37:08 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Jan 2023 12:37:08 -0800", "from silpixa00401385.ir.intel.com ([10.237.214.166])\n by orsmga002.jf.intel.com with ESMTP; 13 Jan 2023 12:37:06 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1673642229; x=1705178229;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=NIf9e7ArfW60pgPNU7DfhV8sWMJJfp4awGaoinOB9js=;\n b=irrcZ8PGoC3DesPQBQ0csklhE24YzAlpDUSetoF2KG1zjHDUpetcm2UP\n 1MAfw/L6WrynID4zwKu4eQ0NAyDyg7VIvOl9HVn+mlDwpIb3ikdl6e3+I\n ndMN4bTK7YS3CjQOP/W4fcWlKbShncBVgLi9VdEMea1y5s9Ttjed8/JWO\n v9dvDEyBlTfkvoQl60yZ7Zz1KTNT0MFQC+bQpOHIg8HfSRNk0m15vlKB9\n vNHkKeKPB9eoeIVUBCljk+zRsZ0S2aHDJl22AeT9jQAXuBMjnfvmEctA5\n 28uBe8ZLD7fc3xLgyYLsPXCFQWfHAMY23eTf+J4xolqugVunt5fI1bRjw Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10589\"; a=\"388592393\"", "E=Sophos;i=\"5.97,214,1669104000\"; d=\"scan'208\";a=\"388592393\"", "E=McAfee;i=\"6500,9779,10589\"; a=\"658334407\"", "E=Sophos;i=\"5.97,214,1669104000\"; d=\"scan'208\";a=\"658334407\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, Bruce Richardson <bruce.richardson@intel.com>,\n\t=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v3 3/3] telemetry: use standard logging", "Date": "Fri, 13 Jan 2023 20:36:56 +0000", "Message-Id": "<20230113203656.1864072-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20230113203656.1864072-1-bruce.richardson@intel.com>", "References": "<20220829151901.376754-1-bruce.richardson@intel.com>\n <20230113203656.1864072-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Now that logging is moved out of EAL, we don't need injection of the\nlogtype and logging function from EAL to telemetry library, simplifying\nthings.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/eal/freebsd/eal.c | 6 +-----\n lib/eal/linux/eal.c | 6 +-----\n lib/telemetry/telemetry.c | 11 +++--------\n lib/telemetry/telemetry_internal.h | 3 +--\n 4 files changed, 6 insertions(+), 20 deletions(-)", "diff": "diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex 607684c1a3..820c4524e5 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -871,13 +871,9 @@ rte_eal_init(int argc, char **argv)\n \t\treturn -1;\n \t}\n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY && !internal_conf->no_telemetry) {\n-\t\tint tlog = rte_log_register_type_and_pick_level(\n-\t\t\t\t\"lib.telemetry\", RTE_LOG_WARNING);\n-\t\tif (tlog < 0)\n-\t\t\ttlog = RTE_LOGTYPE_EAL;\n \t\tif (rte_telemetry_init(rte_eal_get_runtime_dir(),\n \t\t\t\trte_version(),\n-\t\t\t\t&internal_conf->ctrl_cpuset, rte_log, tlog) != 0)\n+\t\t\t\t&internal_conf->ctrl_cpuset) != 0)\n \t\t\treturn -1;\n \t}\n \ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex 0df9f1f353..dec0041094 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -1319,13 +1319,9 @@ rte_eal_init(int argc, char **argv)\n \t\treturn -1;\n \t}\n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY && !internal_conf->no_telemetry) {\n-\t\tint tlog = rte_log_register_type_and_pick_level(\n-\t\t\t\t\"lib.telemetry\", RTE_LOG_WARNING);\n-\t\tif (tlog < 0)\n-\t\t\ttlog = RTE_LOGTYPE_EAL;\n \t\tif (rte_telemetry_init(rte_eal_get_runtime_dir(),\n \t\t\t\trte_version(),\n-\t\t\t\t&internal_conf->ctrl_cpuset, rte_log, tlog) != 0)\n+\t\t\t\t&internal_conf->ctrl_cpuset) != 0)\n \t\t\treturn -1;\n \t}\n \ndiff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c\nindex 8fbb4f3060..13a32f4279 100644\n--- a/lib/telemetry/telemetry.c\n+++ b/lib/telemetry/telemetry.c\n@@ -54,11 +54,9 @@ static struct socket v1_socket; /* socket for v1 telemetry */\n static const char *telemetry_version; /* save rte_version */\n static const char *socket_dir; /* runtime directory */\n static rte_cpuset_t *thread_cpuset;\n-static rte_log_fn rte_log_ptr;\n-static uint32_t logtype;\n \n-#define TMTY_LOG(l, ...) \\\n- rte_log_ptr(RTE_LOG_ ## l, logtype, \"TELEMETRY: \" __VA_ARGS__)\n+RTE_LOG_REGISTER_DEFAULT(logtype, WARNING);\n+#define TMTY_LOG(l, ...) rte_log(RTE_LOG_ ## l, logtype, \"TELEMETRY: \" __VA_ARGS__)\n \n /* list of command callbacks, with one command registered by default */\n static struct cmd_callback *callbacks;\n@@ -612,14 +610,11 @@ telemetry_v2_init(void)\n #endif /* !RTE_EXEC_ENV_WINDOWS */\n \n int32_t\n-rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset,\n-\t\trte_log_fn log_fn, uint32_t registered_logtype)\n+rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset)\n {\n \ttelemetry_version = rte_version;\n \tsocket_dir = runtime_dir;\n \tthread_cpuset = cpuset;\n-\trte_log_ptr = log_fn;\n-\tlogtype = registered_logtype;\n \n #ifndef RTE_EXEC_ENV_WINDOWS\n \tif (telemetry_v2_init() != 0)\ndiff --git a/lib/telemetry/telemetry_internal.h b/lib/telemetry/telemetry_internal.h\nindex d085c492dc..5c75d73183 100644\n--- a/lib/telemetry/telemetry_internal.h\n+++ b/lib/telemetry/telemetry_internal.h\n@@ -109,7 +109,6 @@ typedef int (*rte_log_fn)(uint32_t level, uint32_t logtype, const char *format,\n */\n __rte_internal\n int\n-rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset,\n-\t\trte_log_fn log_fn, uint32_t registered_logtype);\n+rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset);\n \n #endif\n", "prefixes": [ "v3", "3/3" ] }{ "id": 122051, "url": "