Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/122231/?format=api
{ "id": 122231, "url": "http://patchwork.dpdk.org/api/patches/122231/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230118025347.1567078-7-junfeng.guo@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230118025347.1567078-7-junfeng.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230118025347.1567078-7-junfeng.guo@intel.com", "date": "2023-01-18T02:53:45", "name": "[RFC,6/8] net/gve: support basic stats for DQO", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1edc1cfebe16eda3b64d158a50d1016c78276956", "submitter": { "id": 1785, "url": "http://patchwork.dpdk.org/api/people/1785/?format=api", "name": "Junfeng Guo", "email": "junfeng.guo@intel.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230118025347.1567078-7-junfeng.guo@intel.com/mbox/", "series": [ { "id": 26583, "url": "http://patchwork.dpdk.org/api/series/26583/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=26583", "date": "2023-01-18T02:53:39", "name": "gve PMD enhancement", "version": 1, "mbox": "http://patchwork.dpdk.org/series/26583/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/122231/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/122231/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DED2042407;\n\tWed, 18 Jan 2023 03:59:38 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A973A42C4D;\n\tWed, 18 Jan 2023 03:59:18 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id DDF0440151\n for <dev@dpdk.org>; Wed, 18 Jan 2023 03:59:16 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Jan 2023 18:59:16 -0800", "from dpdk-jf-ntb-one.sh.intel.com ([10.67.111.104])\n by fmsmga008.fm.intel.com with ESMTP; 17 Jan 2023 18:59:13 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1674010757; x=1705546757;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=f1oh1P2U3l6PWwQKo75ZV2M+hQy/BWnK+GN9J7civvY=;\n b=dVUsZIKyf08U1G5ZElf+7LCy/r4EA0SCWGlyNwnaiSdAY0kOl+LdTSUU\n OsNTwvPp/rKPp4XKA6hhY4pPQIT1OAO1wQ+C81UbUJ1MqCeCb9muMfo+a\n /fNK7EMiXvTZqZ376YdSmXFwwupBqaCgUSc9NnSslIZCoEBi+p5kFS/NZ\n HWll2il1RWcxJDt8G5XOQwKvFiSQYia4ttG6MLQGJXlwlPxXqKvP8Bw3O\n 7ZL2Ejfamsue14hi+f/Tp7AEi3R+qHDaWZ/QNOJPHqO2rYzhprWEX3U5B\n TWyVmWquWmadbHXFc/dt/If2U0/blgQyPuDw2c9nFxGjGiaBZSwC2K9KZ g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10593\"; a=\"322575527\"", "E=Sophos;i=\"5.97,224,1669104000\"; d=\"scan'208\";a=\"322575527\"", "E=McAfee;i=\"6500,9779,10593\"; a=\"722911220\"", "E=Sophos;i=\"5.97,224,1669104000\"; d=\"scan'208\";a=\"722911220\"" ], "X-ExtLoop1": "1", "From": "Junfeng Guo <junfeng.guo@intel.com>", "To": "qi.z.zhang@intel.com, jingjing.wu@intel.com, ferruh.yigit@amd.com,\n beilei.xing@intel.com", "Cc": "dev@dpdk.org, xiaoyun.li@intel.com, helin.zhang@intel.com,\n Junfeng Guo <junfeng.guo@intel.com>, Rushil Gupta <rushilg@google.com>,\n Jordan Kimbrough <jrkim@google.com>, Jeroen de Borst <jeroendb@google.com>", "Subject": "[RFC 6/8] net/gve: support basic stats for DQO", "Date": "Wed, 18 Jan 2023 10:53:45 +0800", "Message-Id": "<20230118025347.1567078-7-junfeng.guo@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230118025347.1567078-1-junfeng.guo@intel.com>", "References": "<20230118025347.1567078-1-junfeng.guo@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add basic stats support for DQO.\n\nSigned-off-by: Junfeng Guo <junfeng.guo@intel.com>\nSigned-off-by: Rushil Gupta <rushilg@google.com>\nSigned-off-by: Jordan Kimbrough <jrkim@google.com>\nSigned-off-by: Jeroen de Borst <jeroendb@google.com>\n---\n drivers/net/gve/gve_ethdev.c | 60 ++++++++++++++++++++++++++++++++++++\n drivers/net/gve/gve_ethdev.h | 11 +++++++\n drivers/net/gve/gve_rx_dqo.c | 12 +++++++-\n drivers/net/gve/gve_tx_dqo.c | 6 ++++\n 4 files changed, 88 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c\nindex 89e3f09c37..fae00305f9 100644\n--- a/drivers/net/gve/gve_ethdev.c\n+++ b/drivers/net/gve/gve_ethdev.c\n@@ -369,6 +369,64 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \treturn 0;\n }\n \n+static int\n+gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n+{\n+\tuint16_t i;\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\tstruct gve_tx_queue *txq = dev->data->tx_queues[i];\n+\t\tif (txq == NULL)\n+\t\t\tcontinue;\n+\n+\t\tstats->opackets += txq->packets;\n+\t\tstats->obytes += txq->bytes;\n+\t\tstats->oerrors += txq->errors;\n+\t}\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\tstruct gve_rx_queue *rxq = dev->data->rx_queues[i];\n+\t\tif (rxq == NULL)\n+\t\t\tcontinue;\n+\n+\t\tstats->ipackets += rxq->packets;\n+\t\tstats->ibytes += rxq->bytes;\n+\t\tstats->ierrors += rxq->errors;\n+\t\tstats->rx_nombuf += rxq->no_mbufs;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+gve_dev_stats_reset(struct rte_eth_dev *dev)\n+{\n+\tuint16_t i;\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\tstruct gve_tx_queue *txq = dev->data->tx_queues[i];\n+\t\tif (txq == NULL)\n+\t\t\tcontinue;\n+\n+\t\ttxq->packets = 0;\n+\t\ttxq->bytes = 0;\n+\t\ttxq->errors = 0;\n+\t}\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\tstruct gve_rx_queue *rxq = dev->data->rx_queues[i];\n+\t\tif (rxq == NULL)\n+\t\t\tcontinue;\n+\n+\t\trxq->packets = 0;\n+\t\trxq->bytes = 0;\n+\t\trxq->errors = 0;\n+\t\trxq->no_mbufs = 0;\n+\t}\n+\n+\treturn 0;\n+}\n+\n static int\n gve_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n {\n@@ -407,6 +465,8 @@ static const struct eth_dev_ops gve_eth_dev_ops = {\n \t.rx_queue_release = gve_rx_queue_release,\n \t.tx_queue_release = gve_tx_queue_release,\n \t.link_update = gve_link_update,\n+\t.stats_get = gve_dev_stats_get,\n+\t.stats_reset = gve_dev_stats_reset,\n \t.mtu_set = gve_dev_mtu_set,\n };\n \ndiff --git a/drivers/net/gve/gve_ethdev.h b/drivers/net/gve/gve_ethdev.h\nindex d434f9babe..2e0f96499d 100644\n--- a/drivers/net/gve/gve_ethdev.h\n+++ b/drivers/net/gve/gve_ethdev.h\n@@ -105,6 +105,11 @@ struct gve_tx_queue {\n \tstruct gve_queue_page_list *qpl;\n \tstruct gve_tx_iovec *iov_ring;\n \n+\t/* stats items */\n+\tuint64_t packets;\n+\tuint64_t bytes;\n+\tuint64_t errors;\n+\n \tuint16_t port_id;\n \tuint16_t queue_id;\n \n@@ -156,6 +161,12 @@ struct gve_rx_queue {\n \t/* only valid for GQI_QPL queue format */\n \tstruct gve_queue_page_list *qpl;\n \n+\t/* stats items */\n+\tuint64_t packets;\n+\tuint64_t bytes;\n+\tuint64_t errors;\n+\tuint64_t no_mbufs;\n+\n \tstruct gve_priv *hw;\n \tconst struct rte_memzone *qres_mz;\n \tstruct gve_queue_resources *qres;\ndiff --git a/drivers/net/gve/gve_rx_dqo.c b/drivers/net/gve/gve_rx_dqo.c\nindex 244517ce5d..41ead5bd98 100644\n--- a/drivers/net/gve/gve_rx_dqo.c\n+++ b/drivers/net/gve/gve_rx_dqo.c\n@@ -37,6 +37,7 @@ gve_rx_refill_dqo(struct gve_rx_queue *rxq)\n \t\t\tnext_avail = 0;\n \t\t\trxq->nb_rx_hold -= delta;\n \t\t} else {\n+\t\t\trxq->no_mbufs += nb_desc - next_avail;\n \t\t\tdev = &rte_eth_devices[rxq->port_id];\n \t\t\tdev->data->rx_mbuf_alloc_failed += nb_desc - next_avail;\n \t\t\tPMD_DRV_LOG(DEBUG, \"RX mbuf alloc failed port_id=%u queue_id=%u\",\n@@ -57,6 +58,7 @@ gve_rx_refill_dqo(struct gve_rx_queue *rxq)\n \t\t\tnext_avail += nb_refill;\n \t\t\trxq->nb_rx_hold -= nb_refill;\n \t\t} else {\n+\t\t\trxq->no_mbufs += nb_desc - next_avail;\n \t\t\tdev = &rte_eth_devices[rxq->port_id];\n \t\t\tdev->data->rx_mbuf_alloc_failed += nb_desc - next_avail;\n \t\t\tPMD_DRV_LOG(DEBUG, \"RX mbuf alloc failed port_id=%u queue_id=%u\",\n@@ -80,7 +82,9 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \tuint16_t pkt_len;\n \tuint16_t rx_id;\n \tuint16_t nb_rx;\n+\tuint64_t bytes;\n \n+\tbytes = 0;\n \tnb_rx = 0;\n \trxq = rx_queue;\n \trx_id = rxq->rx_tail;\n@@ -94,8 +98,10 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \t\tif (rx_desc->generation != rxq->cur_gen_bit)\n \t\t\tbreak;\n \n-\t\tif (unlikely(rx_desc->rx_error))\n+\t\tif (unlikely(rx_desc->rx_error)) {\n+\t\t\trxq->errors++;\n \t\t\tcontinue;\n+\t\t}\n \n \t\tpkt_len = rx_desc->packet_len;\n \n@@ -120,6 +126,7 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \t\trxm->hash.rss = rte_be_to_cpu_32(rx_desc->hash);\n \n \t\trx_pkts[nb_rx++] = rxm;\n+\t\tbytes += pkt_len;\n \t}\n \n \tif (nb_rx > 0) {\n@@ -128,6 +135,9 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \t\t\trxq->next_avail = rx_id_bufq;\n \n \t\tgve_rx_refill_dqo(rxq);\n+\n+\t\trxq->packets += nb_rx;\n+\t\trxq->bytes += bytes;\n \t}\n \n \treturn nb_rx;\ndiff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c\nindex 3583c82246..9c1361c894 100644\n--- a/drivers/net/gve/gve_tx_dqo.c\n+++ b/drivers/net/gve/gve_tx_dqo.c\n@@ -80,10 +80,12 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \tuint16_t nb_used;\n \tuint16_t tx_id;\n \tuint16_t sw_id;\n+\tuint64_t bytes;\n \n \tsw_ring = txq->sw_ring;\n \ttxr = txq->tx_ring;\n \n+\tbytes = 0;\n \tmask = txq->nb_tx_desc - 1;\n \tsw_mask = txq->sw_size - 1;\n \ttx_id = txq->tx_tail;\n@@ -118,6 +120,7 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\t\ttx_id = (tx_id + 1) & mask;\n \t\t\tsw_id = (sw_id + 1) & sw_mask;\n \n+\t\t\tbytes += tx_pkt->pkt_len;\n \t\t\ttx_pkt = tx_pkt->next;\n \t\t} while (tx_pkt);\n \n@@ -141,6 +144,9 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\trte_write32(tx_id, txq->qtx_tail);\n \t\ttxq->tx_tail = tx_id;\n \t\ttxq->sw_tail = sw_id;\n+\n+\t\ttxq->packets += nb_tx;\n+\t\ttxq->bytes += bytes;\n \t}\n \n \treturn nb_tx;\n", "prefixes": [ "RFC", "6/8" ] }