Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/122654/?format=api
{ "id": 122654, "url": "http://patchwork.dpdk.org/api/patches/122654/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230130062642.3337239-4-junfeng.guo@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230130062642.3337239-4-junfeng.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230130062642.3337239-4-junfeng.guo@intel.com", "date": "2023-01-30T06:26:36", "name": "[RFC,v2,3/9] net/gve: support device start and close for DQO", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3126a31e5e102e23cc8074b7a889a5a54c93e58b", "submitter": { "id": 1785, "url": "http://patchwork.dpdk.org/api/people/1785/?format=api", "name": "Junfeng Guo", "email": "junfeng.guo@intel.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230130062642.3337239-4-junfeng.guo@intel.com/mbox/", "series": [ { "id": 26684, "url": "http://patchwork.dpdk.org/api/series/26684/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=26684", "date": "2023-01-30T06:26:33", "name": "gve PMD enhancement", "version": 2, "mbox": "http://patchwork.dpdk.org/series/26684/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/122654/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/122654/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 804C1424BA;\n\tMon, 30 Jan 2023 07:32:36 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C6D9942BC9;\n\tMon, 30 Jan 2023 07:32:26 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 4A9E742B8E\n for <dev@dpdk.org>; Mon, 30 Jan 2023 07:32:24 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 Jan 2023 22:32:23 -0800", "from dpdk-jf-ntb-one.sh.intel.com ([10.67.111.104])\n by orsmga004.jf.intel.com with ESMTP; 29 Jan 2023 22:32:20 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1675060344; x=1706596344;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=P+tfqKUjECT0v0kb7XTy5YLGMn2+ySTWEpDhUaQ/1oI=;\n b=Vuf17bNkQlMr9xYgzXAHAfEiW3guWRUI2sTTkKUWAjklpz2WtH2/yeV4\n 9ykCTySumdvr4KuFAs3yyrFw+proHuZ1/hgssJ7SVHB8EhjoR0N+dPfrm\n k/vZvOA59H9JWxWA5a70rvy5IgGjXRIeO2JKEUtB4+dwF+Lcx71zH7PLM\n jNagkgedaSBglyrY2bDW64auWcv2+l/37pPOZOUReSl1KhOgXLSBRg1ga\n NvYzzQSl0/AOYHe9GolMKVQjj6xCm5m5TdlRCLEZmwC9+6yi6782ZtcE3\n dOLZCV9/bMep3k3+9hKWYT93PK/2xPkVX7YYGG0RAVQ+CciTMip4quoMt Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10605\"; a=\"392035676\"", "E=Sophos;i=\"5.97,257,1669104000\"; d=\"scan'208\";a=\"392035676\"", "E=McAfee;i=\"6500,9779,10605\"; a=\"787906443\"", "E=Sophos;i=\"5.97,257,1669104000\"; d=\"scan'208\";a=\"787906443\"" ], "X-ExtLoop1": "1", "From": "Junfeng Guo <junfeng.guo@intel.com>", "To": "qi.z.zhang@intel.com, jingjing.wu@intel.com, ferruh.yigit@amd.com,\n beilei.xing@intel.com", "Cc": "dev@dpdk.org, xiaoyun.li@intel.com, helin.zhang@intel.com,\n Junfeng Guo <junfeng.guo@intel.com>, Rushil Gupta <rushilg@google.com>,\n Jordan Kimbrough <jrkim@google.com>, Jeroen de Borst <jeroendb@google.com>", "Subject": "[RFC v2 3/9] net/gve: support device start and close for DQO", "Date": "Mon, 30 Jan 2023 14:26:36 +0800", "Message-Id": "<20230130062642.3337239-4-junfeng.guo@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230130062642.3337239-1-junfeng.guo@intel.com>", "References": "<20230118025347.1567078-1-junfeng.guo@intel.com>\n <20230130062642.3337239-1-junfeng.guo@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add device start and close support for DQO.\n\nSigned-off-by: Junfeng Guo <junfeng.guo@intel.com>\nSigned-off-by: Rushil Gupta <rushilg@google.com>\nSigned-off-by: Jordan Kimbrough <jrkim@google.com>\nSigned-off-by: Jeroen de Borst <jeroendb@google.com>\n---\n drivers/net/gve/base/gve_adminq.c | 10 +++----\n drivers/net/gve/gve_ethdev.c | 43 ++++++++++++++++++++++++++++++-\n 2 files changed, 47 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/gve/base/gve_adminq.c b/drivers/net/gve/base/gve_adminq.c\nindex e745b709b2..e963f910a0 100644\n--- a/drivers/net/gve/base/gve_adminq.c\n+++ b/drivers/net/gve/base/gve_adminq.c\n@@ -497,11 +497,11 @@ static int gve_adminq_create_tx_queue(struct gve_priv *priv, u32 queue_index)\n \t\tcmd.create_tx_queue.queue_page_list_id = cpu_to_be32(qpl_id);\n \t} else {\n \t\tcmd.create_tx_queue.tx_ring_size =\n-\t\t\tcpu_to_be16(txq->nb_tx_desc);\n+\t\t\tcpu_to_be16(priv->tx_desc_cnt);\n \t\tcmd.create_tx_queue.tx_comp_ring_addr =\n-\t\t\tcpu_to_be64(txq->complq->tx_ring_phys_addr);\n+\t\t\tcpu_to_be64(txq->compl_ring_phys_addr);\n \t\tcmd.create_tx_queue.tx_comp_ring_size =\n-\t\t\tcpu_to_be16(priv->tx_compq_size);\n+\t\t\tcpu_to_be16(priv->tx_compq_size * DQO_TX_MULTIPLIER);\n \t}\n \n \treturn gve_adminq_issue_cmd(priv, &cmd);\n@@ -549,9 +549,9 @@ static int gve_adminq_create_rx_queue(struct gve_priv *priv, u32 queue_index)\n \t\tcmd.create_rx_queue.rx_ring_size =\n \t\t\tcpu_to_be16(priv->rx_desc_cnt);\n \t\tcmd.create_rx_queue.rx_desc_ring_addr =\n-\t\t\tcpu_to_be64(rxq->rx_ring_phys_addr);\n+\t\t\tcpu_to_be64(rxq->compl_ring_phys_addr);\n \t\tcmd.create_rx_queue.rx_data_ring_addr =\n-\t\t\tcpu_to_be64(rxq->bufq->rx_ring_phys_addr);\n+\t\t\tcpu_to_be64(rxq->rx_ring_phys_addr);\n \t\tcmd.create_rx_queue.packet_buffer_size =\n \t\t\tcpu_to_be16(rxq->rx_buf_len);\n \t\tcmd.create_rx_queue.rx_buff_ring_size =\ndiff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c\nindex 26182b0422..3543378978 100644\n--- a/drivers/net/gve/gve_ethdev.c\n+++ b/drivers/net/gve/gve_ethdev.c\n@@ -78,6 +78,9 @@ gve_free_qpls(struct gve_priv *priv)\n \tuint16_t nb_rxqs = priv->max_nb_rxq;\n \tuint32_t i;\n \n+\tif (priv->queue_format != GVE_GQI_QPL_FORMAT)\n+\t\treturn;\n+\n \tfor (i = 0; i < nb_txqs + nb_rxqs; i++) {\n \t\tif (priv->qpl[i].mz != NULL)\n \t\t\trte_memzone_free(priv->qpl[i].mz);\n@@ -138,6 +141,41 @@ gve_refill_pages(struct gve_rx_queue *rxq)\n \treturn 0;\n }\n \n+static int\n+gve_refill_dqo(struct gve_rx_queue *rxq)\n+{\n+\tstruct rte_mbuf *nmb;\n+\tuint16_t i;\n+\tint diag;\n+\n+\tdiag = rte_pktmbuf_alloc_bulk(rxq->mpool, &rxq->sw_ring[0], rxq->nb_rx_desc);\n+\tif (diag < 0) {\n+\t\tfor (i = 0; i < rxq->nb_rx_desc - 1; i++) {\n+\t\t\tnmb = rte_pktmbuf_alloc(rxq->mpool);\n+\t\t\tif (!nmb)\n+\t\t\t\tbreak;\n+\t\t\trxq->sw_ring[i] = nmb;\n+\t\t}\n+\t\tif (i < rxq->nb_rx_desc - 1)\n+\t\t\treturn -ENOMEM;\n+\t}\n+\n+\tfor (i = 0; i < rxq->nb_rx_desc; i++) {\n+\t\tif (i == rxq->nb_rx_desc - 1)\n+\t\t\tbreak;\n+\t\tnmb = rxq->sw_ring[i];\n+\t\trxq->rx_ring[i].buf_addr = rte_cpu_to_le_64(rte_mbuf_data_iova_default(nmb));\n+\t\trxq->rx_ring[i].buf_id = rte_cpu_to_le_16(i);\n+\t}\n+\n+\trxq->nb_rx_hold = 0;\n+\trxq->bufq_tail = rxq->nb_rx_desc - 1;\n+\n+\trte_write32(rxq->bufq_tail, rxq->qrx_tail);\n+\n+\treturn 0;\n+}\n+\n static int\n gve_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complete)\n {\n@@ -206,7 +244,10 @@ gve_dev_start(struct rte_eth_dev *dev)\n \n \t\trte_write32(rte_cpu_to_be_32(GVE_IRQ_MASK), rxq->ntfy_addr);\n \n-\t\terr = gve_refill_pages(rxq);\n+\t\tif (gve_is_gqi(priv))\n+\t\t\terr = gve_refill_pages(rxq);\n+\t\telse\n+\t\t\terr = gve_refill_dqo(rxq);\n \t\tif (err) {\n \t\t\tPMD_DRV_LOG(ERR, \"Failed to refill for RX\");\n \t\t\tgoto err_rx;\n", "prefixes": [ "RFC", "v2", "3/9" ] }