Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124256/?format=api
{ "id": 124256, "url": "http://patchwork.dpdk.org/api/patches/124256/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230221055205.22984-2-kamalakshitha.aligeri@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230221055205.22984-2-kamalakshitha.aligeri@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230221055205.22984-2-kamalakshitha.aligeri@arm.com", "date": "2023-02-21T05:52:04", "name": "[v4,1/2] net/i40e: replace put function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5f77405a196a0b7d91de822f16ef09f4cea0022f", "submitter": { "id": 2887, "url": "http://patchwork.dpdk.org/api/people/2887/?format=api", "name": "Kamalakshitha Aligeri", "email": "kamalakshitha.aligeri@arm.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230221055205.22984-2-kamalakshitha.aligeri@arm.com/mbox/", "series": [ { "id": 27103, "url": "http://patchwork.dpdk.org/api/series/27103/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=27103", "date": "2023-02-21T05:52:03", "name": "Integrated mempool cache zero-copy API's", "version": 4, "mbox": "http://patchwork.dpdk.org/series/27103/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/124256/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/124256/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B658B41CF8;\n\tTue, 21 Feb 2023 06:52:27 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 175D643152;\n\tTue, 21 Feb 2023 06:52:27 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id E5EDB43151\n for <dev@dpdk.org>; Tue, 21 Feb 2023 06:52:25 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 536E5106F;\n Mon, 20 Feb 2023 21:53:08 -0800 (PST)", "from ampere-altra-2-1.usa.Arm.com (ampere-altra-2-1.usa.arm.com\n [10.118.91.158])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 405BC3F881;\n Mon, 20 Feb 2023 21:52:25 -0800 (PST)" ], "From": "Kamalakshitha Aligeri <kamalakshitha.aligeri@arm.com>", "To": "Yuying.Zhang@intel.com, beilei.xing@intel.com, olivier.matz@6wind.com,\n andrew.rybchenko@oktetlabs.ru, bruce.richardson@intel.com,\n mb@smartsharesystems.com, konstantin.ananyev@huawei.com,\n Honnappa.Nagarahalli@arm.com, ruifeng.wang@arm.com, feifei.wang2@arm.com", "Cc": "dev@dpdk.org, nd@arm.com,\n Kamalakshitha Aligeri <kamalakshitha.aligeri@arm.com>", "Subject": "[PATCH v4 1/2] net/i40e: replace put function", "Date": "Tue, 21 Feb 2023 05:52:04 +0000", "Message-Id": "<20230221055205.22984-2-kamalakshitha.aligeri@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230221055205.22984-1-kamalakshitha.aligeri@arm.com>", "References": "<20230210065407.209567-2-kamalakshitha.aligeri@arm.com>\n <20230221055205.22984-1-kamalakshitha.aligeri@arm.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Integrated zero-copy put API in mempool cache in i40e PMD.\nOn Ampere Altra server, l3fwd single core's performance improves by 5%\nwith the new API\n\nSigned-off-by: Kamalakshitha Aligeri <kamalakshitha.aligeri@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\nReviewed-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Morten Brørup <mb@smartsharesystems.com>\n---\nDepends-on: series-26984 (\"[v9] mempool cache: add zero-copy get and put functions\")\n\n .mailmap | 1 +\n drivers/net/i40e/i40e_rxtx_vec_common.h | 27 ++++++++++++++++++++-----\n 2 files changed, 23 insertions(+), 5 deletions(-)\n\n--\n2.25.1", "diff": "diff --git a/.mailmap b/.mailmap\nindex 75884b6fe2..05a42edbcf 100644\n--- a/.mailmap\n+++ b/.mailmap\n@@ -670,6 +670,7 @@ Kai Ji <kai.ji@intel.com>\n Kaiwen Deng <kaiwenx.deng@intel.com>\n Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n Kamalakannan R <kamalakannan.r@intel.com>\n+Kamalakshitha Aligeri <kamalakshitha.aligeri@arm.com>\n Kamil Bednarczyk <kamil.bednarczyk@intel.com>\n Kamil Chalupnik <kamilx.chalupnik@intel.com>\n Kamil Rytarowski <kamil.rytarowski@caviumnetworks.com>\ndiff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h\nindex fe1a6ec75e..35cdb31b2e 100644\n--- a/drivers/net/i40e/i40e_rxtx_vec_common.h\n+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h\n@@ -95,18 +95,35 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)\n\n \tn = txq->tx_rs_thresh;\n\n-\t /* first buffer to free from S/W ring is at index\n-\t * tx_next_dd - (tx_rs_thresh-1)\n-\t */\n+\t/* first buffer to free from S/W ring is at index\n+\t * tx_next_dd - (tx_rs_thresh-1)\n+\t */\n \ttxep = &txq->sw_ring[txq->tx_next_dd - (n - 1)];\n\n \tif (txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) {\n+\t\tstruct rte_mempool *mp = txep[0].mbuf->pool;\n+\t\tstruct rte_mempool_cache *cache = rte_mempool_default_cache(mp, rte_lcore_id());\n+\t\tvoid **cache_objs;\n+\n+\t\tif (unlikely(!cache))\n+\t\t\tgoto fallback;\n+\n+\t\tcache_objs = rte_mempool_cache_zc_put_bulk(cache, mp, n);\n+\t\tif (unlikely(!cache_objs))\n+\t\t\tgoto fallback;\n+\n \t\tfor (i = 0; i < n; i++) {\n-\t\t\tfree[i] = txep[i].mbuf;\n+\t\t\tcache_objs[i] = txep[i].mbuf;\n \t\t\t/* no need to reset txep[i].mbuf in vector path */\n \t\t}\n-\t\trte_mempool_put_bulk(free[0]->pool, (void **)free, n);\n \t\tgoto done;\n+\n+fallback:\n+\t\tfor (i = 0; i < n; i++)\n+\t\t\tfree[i] = txep[i].mbuf;\n+\t\trte_mempool_generic_put(mp, (void **)free, n, cache);\n+\t\tgoto done;\n+\n \t}\n\n \tm = rte_pktmbuf_prefree_seg(txep[0].mbuf);\n", "prefixes": [ "v4", "1/2" ] }