Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124478/?format=api
{ "id": 124478, "url": "http://patchwork.dpdk.org/api/patches/124478/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230224054813.2855914-3-ktejasree@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230224054813.2855914-3-ktejasree@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230224054813.2855914-3-ktejasree@marvell.com", "date": "2023-02-24T05:48:04", "name": "[02/11] crypto/cnxk: make sg version check const", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8f5935e449bc765beb78f209c0337d34b3819807", "submitter": { "id": 1789, "url": "http://patchwork.dpdk.org/api/people/1789/?format=api", "name": "Tejasree Kondoj", "email": "ktejasree@marvell.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230224054813.2855914-3-ktejasree@marvell.com/mbox/", "series": [ { "id": 27165, "url": "http://patchwork.dpdk.org/api/series/27165/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=27165", "date": "2023-02-24T05:48:02", "name": "fixes and improvements to cnxk crypto PMD", "version": 1, "mbox": "http://patchwork.dpdk.org/series/27165/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/124478/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/124478/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 756DA41D5B;\n\tFri, 24 Feb 2023 06:48:25 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AD6A740EF0;\n\tFri, 24 Feb 2023 06:48:23 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 364F940DF6\n for <dev@dpdk.org>; Fri, 24 Feb 2023 06:48:22 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 31O3N3Dp009275 for <dev@dpdk.org>; Thu, 23 Feb 2023 21:48:21 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3nxfkwa3an-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 23 Feb 2023 21:48:21 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.42;\n Thu, 23 Feb 2023 21:48:20 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.42 via Frontend\n Transport; Thu, 23 Feb 2023 21:48:20 -0800", "from hyd1554.marvell.com (unknown [10.29.57.11])\n by maili.marvell.com (Postfix) with ESMTP id 8D1CD3F7080;\n Thu, 23 Feb 2023 21:48:18 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=UwoXYDdfJ8qUyb0D7a/jgCmfcaTfQRnuDwANueriP1M=;\n b=HmSTzey07DcS+VdYhOa0tfX4IsDEsrM12V37T96XY8QGyYUnEsqMegIlQlhfA+JYfyav\n N8sSbCrMTKg/IgFmzQiVbAuK7J82K+HeZY5Ic3rFykn3Uvq1SMBFMHLsk8Vw9D676Esf\n +tnHVNZR369V89nAEjLgQgdbSoSW4TE9jAd/wXMLnMc/evA2BHGPDEbc8A7/xaOQpd/r\n kRlL5fJ9GVhUF+tzJhS6aP1SLRDETRIrEUg3Ocdql8F01VkneX08s665U16R/q9JFv7S\n XFghH+M+A/38Xz6nZFyqMnX9a38fVXtWbOazsArlUt0KMwZfLNQe9BCkezHvdoL7mEVa PA==", "From": "Tejasree Kondoj <ktejasree@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>", "CC": "Anoob Joseph <anoobj@marvell.com>, Gowrishankar Muthukrishnan\n <gmuthukrishn@marvell.com>, <dev@dpdk.org>", "Subject": "[PATCH 02/11] crypto/cnxk: make sg version check const", "Date": "Fri, 24 Feb 2023 11:18:04 +0530", "Message-ID": "<20230224054813.2855914-3-ktejasree@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230224054813.2855914-1-ktejasree@marvell.com>", "References": "<20230224054813.2855914-1-ktejasree@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "XlUFzoPbk3LhQAuIHSpCY4PVEkxWGVDT", "X-Proofpoint-ORIG-GUID": "XlUFzoPbk3LhQAuIHSpCY4PVEkxWGVDT", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22\n definitions=2023-02-24_02,2023-02-23_01,2023-02-09_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Remove sg_ver2 from burst structure and make it as\nconst argument for compiler optimized code.\n\nSigned-off-by: Tejasree Kondoj <ktejasree@marvell.com>\n---\n drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 26 +++++++++++------------\n 1 file changed, 13 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c b/drivers/crypto/cnxk/cn10k_cryptodev_ops.c\nindex 4ee6b944c4..92f7002db9 100644\n--- a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c\n+++ b/drivers/crypto/cnxk/cn10k_cryptodev_ops.c\n@@ -38,7 +38,6 @@ struct ops_burst {\n \tstruct cn10k_sso_hws *ws;\n \tstruct cnxk_cpt_qp *qp;\n \tuint16_t nb_ops;\n-\tbool is_sg_ver2;\n };\n \n /* Holds information required to send vector of operations */\n@@ -489,7 +488,8 @@ cn10k_cpt_vec_submit(struct vec_request vec_tbl[], uint16_t vec_tbl_len, struct\n }\n \n static inline int\n-ca_lmtst_vec_submit(struct ops_burst *burst, struct vec_request vec_tbl[], uint16_t *vec_tbl_len)\n+ca_lmtst_vec_submit(struct ops_burst *burst, struct vec_request vec_tbl[], uint16_t *vec_tbl_len,\n+\t\t const bool is_sg_ver2)\n {\n \tstruct cpt_inflight_req *infl_reqs[PKTS_PER_LOOP];\n \tuint64_t lmt_base, lmt_arg, io_addr;\n@@ -537,7 +537,7 @@ ca_lmtst_vec_submit(struct ops_burst *burst, struct vec_request vec_tbl[], uint1\n \t\tinfl_req = infl_reqs[i];\n \t\tinfl_req->op_flags = 0;\n \n-\t\tret = cn10k_cpt_fill_inst(qp, &burst->op[i], inst, infl_req, burst->is_sg_ver2);\n+\t\tret = cn10k_cpt_fill_inst(qp, &burst->op[i], inst, infl_req, is_sg_ver2);\n \t\tif (unlikely(ret != 1)) {\n \t\t\tplt_cpt_dbg(\"Could not process op: %p\", burst->op[i]);\n \t\t\tif (i != 0)\n@@ -620,7 +620,7 @@ next_op:;\n }\n \n static inline uint16_t\n-ca_lmtst_burst_submit(struct ops_burst *burst)\n+ca_lmtst_burst_submit(struct ops_burst *burst, const bool is_sg_ver2)\n {\n \tstruct cpt_inflight_req *infl_reqs[PKTS_PER_LOOP];\n \tuint64_t lmt_base, lmt_arg, io_addr;\n@@ -660,7 +660,7 @@ ca_lmtst_burst_submit(struct ops_burst *burst)\n \t\tinfl_req = infl_reqs[i];\n \t\tinfl_req->op_flags = 0;\n \n-\t\tret = cn10k_cpt_fill_inst(qp, &burst->op[i], inst, infl_req, burst->is_sg_ver2);\n+\t\tret = cn10k_cpt_fill_inst(qp, &burst->op[i], inst, infl_req, is_sg_ver2);\n \t\tif (unlikely(ret != 1)) {\n \t\t\tplt_dp_dbg(\"Could not process op: %p\", burst->op[i]);\n \t\t\tif (i != 0)\n@@ -729,7 +729,6 @@ cn10k_cpt_crypto_adapter_enqueue(void *ws, struct rte_event ev[], uint16_t nb_ev\n \tburst.ws = ws;\n \tburst.qp = NULL;\n \tburst.nb_ops = 0;\n-\tburst.is_sg_ver2 = is_sg_ver2;\n \n \tfor (i = 0; i < nb_events; i++) {\n \t\top = ev[i].event_ptr;\n@@ -743,8 +742,8 @@ cn10k_cpt_crypto_adapter_enqueue(void *ws, struct rte_event ev[], uint16_t nb_ev\n \t\tif (qp != burst.qp) {\n \t\t\tif (burst.nb_ops) {\n \t\t\t\tif (is_vector) {\n-\t\t\t\t\tsubmitted =\n-\t\t\t\t\t\tca_lmtst_vec_submit(&burst, vec_tbl, &vec_tbl_len);\n+\t\t\t\t\tsubmitted = ca_lmtst_vec_submit(&burst, vec_tbl,\n+\t\t\t\t\t\t\t\t\t&vec_tbl_len, is_sg_ver2);\n \t\t\t\t\t/*\n \t\t\t\t\t * Vector submission is required on qp change, but not in\n \t\t\t\t\t * other cases, since we could send several vectors per\n@@ -753,7 +752,7 @@ cn10k_cpt_crypto_adapter_enqueue(void *ws, struct rte_event ev[], uint16_t nb_ev\n \t\t\t\t\tcn10k_cpt_vec_submit(vec_tbl, vec_tbl_len, burst.qp);\n \t\t\t\t\tvec_tbl_len = 0;\n \t\t\t\t} else {\n-\t\t\t\t\tsubmitted = ca_lmtst_burst_submit(&burst);\n+\t\t\t\t\tsubmitted = ca_lmtst_burst_submit(&burst, is_sg_ver2);\n \t\t\t\t}\n \t\t\t\tcount += submitted;\n \t\t\t\tif (unlikely(submitted != burst.nb_ops))\n@@ -769,9 +768,10 @@ cn10k_cpt_crypto_adapter_enqueue(void *ws, struct rte_event ev[], uint16_t nb_ev\n \t\t/* Max nb_ops per burst check */\n \t\tif (++burst.nb_ops == PKTS_PER_LOOP) {\n \t\t\tif (is_vector)\n-\t\t\t\tsubmitted = ca_lmtst_vec_submit(&burst, vec_tbl, &vec_tbl_len);\n+\t\t\t\tsubmitted = ca_lmtst_vec_submit(&burst, vec_tbl, &vec_tbl_len,\n+\t\t\t\t\t\t\t\tis_sg_ver2);\n \t\t\telse\n-\t\t\t\tsubmitted = ca_lmtst_burst_submit(&burst);\n+\t\t\t\tsubmitted = ca_lmtst_burst_submit(&burst, is_sg_ver2);\n \t\t\tcount += submitted;\n \t\t\tif (unlikely(submitted != burst.nb_ops))\n \t\t\t\tgoto vec_submit;\n@@ -781,9 +781,9 @@ cn10k_cpt_crypto_adapter_enqueue(void *ws, struct rte_event ev[], uint16_t nb_ev\n \t/* Submit the rest of crypto operations */\n \tif (burst.nb_ops) {\n \t\tif (is_vector)\n-\t\t\tcount += ca_lmtst_vec_submit(&burst, vec_tbl, &vec_tbl_len);\n+\t\t\tcount += ca_lmtst_vec_submit(&burst, vec_tbl, &vec_tbl_len, is_sg_ver2);\n \t\telse\n-\t\t\tcount += ca_lmtst_burst_submit(&burst);\n+\t\t\tcount += ca_lmtst_burst_submit(&burst, is_sg_ver2);\n \t}\n \n vec_submit:\n", "prefixes": [ "02/11" ] }