Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 124634,
    "url": "http://patchwork.dpdk.org/api/patches/124634/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1677718068-2412-17-git-send-email-roretzla@linux.microsoft.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1677718068-2412-17-git-send-email-roretzla@linux.microsoft.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1677718068-2412-17-git-send-email-roretzla@linux.microsoft.com",
    "date": "2023-03-02T00:47:47",
    "name": "[16/17] app/test: use previous value atomic fetch operations",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "2bb284f9e1541498dc27617ddc71b9b15b5a2e64",
    "submitter": {
        "id": 2077,
        "url": "http://patchwork.dpdk.org/api/people/2077/?format=api",
        "name": "Tyler Retzlaff",
        "email": "roretzla@linux.microsoft.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1677718068-2412-17-git-send-email-roretzla@linux.microsoft.com/mbox/",
    "series": [
        {
            "id": 27214,
            "url": "http://patchwork.dpdk.org/api/series/27214/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=27214",
            "date": "2023-03-02T00:47:32",
            "name": "use __atomic operations returning previous value",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/27214/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/124634/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/124634/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5B9F641DAF;\n\tThu,  2 Mar 2023 01:49:30 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1260D42D5D;\n\tThu,  2 Mar 2023 01:48:20 +0100 (CET)",
            "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id E67E24161A\n for <dev@dpdk.org>; Thu,  2 Mar 2023 01:48:03 +0100 (CET)",
            "by linux.microsoft.com (Postfix, from userid 1086)\n id ADA7E20BC5F3; Wed,  1 Mar 2023 16:48:02 -0800 (PST)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com ADA7E20BC5F3",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1677718082;\n bh=7keIDftaQzbL3Tp7yP2VJJZYWoQ+dvutVmw3kQx+mnw=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=SHd/e7PVzgFZ7KfEONCRth06BFE/eaDWAlcs5EIlPvSjm3WDmzHV0Q25pr/zSUsnX\n qafumMqxPxfesuHhwkZI1PVQ5lQpBsMLIXBoPo1RAdViWg3Jd0CH66M1CQhbfRqQsS\n NndphgfRvWQ8ILviJfFdWSevOfetdixFUt1C7Moc=",
        "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "To": "dev@dpdk.org",
        "Cc": "Honnappa.Nagarahalli@arm.com, thomas@monjalon.net,\n Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "Subject": "[PATCH 16/17] app/test: use previous value atomic fetch operations",
        "Date": "Wed,  1 Mar 2023 16:47:47 -0800",
        "Message-Id": "<1677718068-2412-17-git-send-email-roretzla@linux.microsoft.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1677718068-2412-1-git-send-email-roretzla@linux.microsoft.com>",
        "References": "<1677718068-2412-1-git-send-email-roretzla@linux.microsoft.com>",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Use __atomic_fetch_{add,and,or,sub,xor} instead of\n__atomic_{add,and,or,sub,xor}_fetch when we have no interest in the\nresult of the operation.\n\nReduces unnecessary codegen that provided the result of the atomic\noperation that was not used.\n\nChange brings closer alignment with atomics available in C11 standard\nand will reduce review effort when they are integrated.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n app/test/test_lcores.c        | 2 +-\n app/test/test_service_cores.c | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/app/test/test_lcores.c b/app/test/test_lcores.c\nindex 5b43aa5..2c945b0 100644\n--- a/app/test/test_lcores.c\n+++ b/app/test/test_lcores.c\n@@ -40,7 +40,7 @@ static uint32_t thread_loop(void *arg)\n \t\tt->state = Thread_ERROR;\n \t}\n \t/* Report register happened to the control thread. */\n-\t__atomic_add_fetch(t->registered_count, 1, __ATOMIC_RELEASE);\n+\t__atomic_fetch_add(t->registered_count, 1, __ATOMIC_RELEASE);\n \n \t/* Wait for release from the control thread. */\n \twhile (__atomic_load_n(t->registered_count, __ATOMIC_ACQUIRE) != 0)\ndiff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c\nindex 637fcd7..9175736 100644\n--- a/app/test/test_service_cores.c\n+++ b/app/test/test_service_cores.c\n@@ -751,12 +751,12 @@ static int32_t dummy_mt_safe_cb(void *args)\n \tuint32_t *lock = &params[1];\n \n \twhile (!*done) {\n-\t\t__atomic_add_fetch(lock, 1, __ATOMIC_RELAXED);\n+\t\t__atomic_fetch_add(lock, 1, __ATOMIC_RELAXED);\n \t\trte_delay_us(500);\n \t\tif (__atomic_load_n(lock, __ATOMIC_RELAXED) > 1)\n \t\t\t/* pass: second core has simultaneously incremented */\n \t\t\t*done = 1;\n-\t\t__atomic_sub_fetch(lock, 1, __ATOMIC_RELAXED);\n+\t\t__atomic_fetch_sub(lock, 1, __ATOMIC_RELAXED);\n \t}\n \n \treturn 0;\n",
    "prefixes": [
        "16/17"
    ]
}