Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124758/?format=api
{ "id": 124758, "url": "http://patchwork.dpdk.org/api/patches/124758/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230303081013.589868-1-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230303081013.589868-1-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230303081013.589868-1-ndabilpuram@marvell.com", "date": "2023-03-03T08:09:59", "name": "[01/15] net/cnxk: resolve sefgault caused during transmit completion", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4ebec9922f430eb39c2d4ec91352cd8e5594f693", "submitter": { "id": 1202, "url": "http://patchwork.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230303081013.589868-1-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 27237, "url": "http://patchwork.dpdk.org/api/series/27237/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=27237", "date": "2023-03-03T08:09:59", "name": "[01/15] net/cnxk: resolve sefgault caused during transmit completion", "version": 1, "mbox": "http://patchwork.dpdk.org/series/27237/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/124758/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/124758/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 53BDA41DC3;\n\tFri, 3 Mar 2023 09:10:56 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3983440EE3;\n\tFri, 3 Mar 2023 09:10:56 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 1D3A940687\n for <dev@dpdk.org>; Fri, 3 Mar 2023 09:10:54 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 3236OVv8007642 for <dev@dpdk.org>; Fri, 3 Mar 2023 00:10:53 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3p1wr9xbh1-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Fri, 03 Mar 2023 00:10:53 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.42;\n Fri, 3 Mar 2023 00:10:50 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.42 via Frontend\n Transport; Fri, 3 Mar 2023 00:10:50 -0800", "from hyd1588t430.caveonetworks.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id 697465B695B;\n Fri, 3 Mar 2023 00:10:47 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=6I3x/jhc8Q9ZQ7B1+TEaX6kDyWGZVz7tD/00dB19f0s=;\n b=aUfMH2noQcWcHxRb4GhUEalep3TPUAzkj6qKJgGmYOXUjwH8MDcUQEVidoYYu5QnRujx\n 2td+vHTE2NPrnWKcWmhY2eaa7qvtYxXwvxX4IuNyijrW8bt2gjQR4VCM07JM9AHwZA3n\n c9JKAXMEdQ1DamWSP0JHqnDM5PRPh4nkC3BT23V7QP0dLL6Zj7vqz4XdaqO0uWhnlWW9\n QBi7JXGTv3kdEr0CKaspc1QLrMGN5TzOlq9mBfx9HVqm1JRDv6369hJeYrIyrgYQ1BX9\n rBG56iEV7+7ueA50jjUdxv8u5wY+lL8Qmsdr8bBtxniBesVp2qjkGweqWNrXAhWq49Dm Mg==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<jerinj@marvell.com>, <dev@dpdk.org>, Rakesh Kudurumalla\n <rkudurumalla@marvell.com>", "Subject": "[PATCH 01/15] net/cnxk: resolve sefgault caused during transmit\n completion", "Date": "Fri, 3 Mar 2023 13:39:59 +0530", "Message-ID": "<20230303081013.589868-1-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "p4l42RI2DwlLb4r7XZVDQsO82m0TgneE", "X-Proofpoint-GUID": "p4l42RI2DwlLb4r7XZVDQsO82m0TgneE", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22\n definitions=2023-03-03_01,2023-03-02_02,2023-02-09_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Rakesh Kudurumalla <rkudurumalla@marvell.com>\n\nwhile sending external buffers from application\nif tx_compl_ena is not provided as devargs, cq for\ntransmit completion is not initialized but the same\nis accessed in driver resulting in segfault.\nThis patch fixes the same by calling callback handler\nbefore the actual packet is transmitted\n\nSigned-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>\n---\n\nDepends-on: series-27133 (\"common/cnxk: add cnf10ka A1 platform\")\n\n drivers/net/cnxk/cn10k_tx.h | 4 ++++\n drivers/net/cnxk/cn9k_tx.h | 4 ++++\n 2 files changed, 8 insertions(+)", "diff": "diff --git a/drivers/net/cnxk/cn10k_tx.h b/drivers/net/cnxk/cn10k_tx.h\nindex 1c1ce9642a..d0f7bc22a4 100644\n--- a/drivers/net/cnxk/cn10k_tx.h\n+++ b/drivers/net/cnxk/cn10k_tx.h\n@@ -650,6 +650,10 @@ cn10k_nix_prefree_seg(struct rte_mbuf *m, struct cn10k_eth_txq *txq,\n \tuint32_t sqe_id;\n \n \tif (RTE_MBUF_HAS_EXTBUF(m)) {\n+\t\tif (unlikely(txq->tx_compl.ena == 0)) {\n+\t\t\trte_pktmbuf_free_seg(m);\n+\t\t\treturn 1;\n+\t\t}\n \t\tif (send_hdr->w0.pnc) {\n \t\t\ttxq->tx_compl.ptr[send_hdr->w1.sqe_id]->next = m;\n \t\t} else {\ndiff --git a/drivers/net/cnxk/cn9k_tx.h b/drivers/net/cnxk/cn9k_tx.h\nindex b4ef45d65c..52661a624c 100644\n--- a/drivers/net/cnxk/cn9k_tx.h\n+++ b/drivers/net/cnxk/cn9k_tx.h\n@@ -88,6 +88,10 @@ cn9k_nix_prefree_seg(struct rte_mbuf *m, struct cn9k_eth_txq *txq,\n \tuint32_t sqe_id;\n \n \tif (RTE_MBUF_HAS_EXTBUF(m)) {\n+\t\tif (unlikely(txq->tx_compl.ena == 0)) {\n+\t\t\trte_pktmbuf_free_seg(m);\n+\t\t\treturn 1;\n+\t\t}\n \t\tif (send_hdr->w0.pnc) {\n \t\t\ttxq->tx_compl.ptr[send_hdr->w1.sqe_id]->next = m;\n \t\t} else {\n", "prefixes": [ "01/15" ] }