Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124880/?format=api
{ "id": 124880, "url": "http://patchwork.dpdk.org/api/patches/124880/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230309042842.8709-2-ivan.malov@arknetworks.am/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230309042842.8709-2-ivan.malov@arknetworks.am>", "list_archive_url": "https://inbox.dpdk.org/dev/20230309042842.8709-2-ivan.malov@arknetworks.am", "date": "2023-03-09T04:28:42", "name": "[2/2] net/sfc: fix resetting mark in tunnel offload switch rules", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b141463ad178ffaa9d37179f0e8c60e6035c4390", "submitter": { "id": 2962, "url": "http://patchwork.dpdk.org/api/people/2962/?format=api", "name": "Ivan Malov", "email": "ivan.malov@arknetworks.am" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230309042842.8709-2-ivan.malov@arknetworks.am/mbox/", "series": [ { "id": 27297, "url": "http://patchwork.dpdk.org/api/series/27297/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=27297", "date": "2023-03-09T04:28:41", "name": "[1/2] common/sfc_efx/base: allow to request MAE mark reset action", "version": 1, "mbox": "http://patchwork.dpdk.org/series/27297/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/124880/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/124880/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8D73441E2F;\n\tThu, 9 Mar 2023 05:28:26 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3112842B7E;\n\tThu, 9 Mar 2023 05:28:23 +0100 (CET)", "from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80])\n by mails.dpdk.org (Postfix) with ESMTP id 85E2B40A7E;\n Thu, 9 Mar 2023 05:28:20 +0100 (CET)", "from localhost.localdomain (unknown [78.109.74.25])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by agw.arknetworks.am (Postfix) with ESMTPSA id E5B8EE119A;\n Thu, 9 Mar 2023 08:28:19 +0400 (+04)" ], "From": "Ivan Malov <ivan.malov@arknetworks.am>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Ferruh Yigit <ferruh.yigit@amd.com>, stable@dpdk.org,\n Andy Moreton <amoreton@xilinx.com>", "Subject": "[PATCH 2/2] net/sfc: fix resetting mark in tunnel offload switch\n rules", "Date": "Thu, 9 Mar 2023 08:28:42 +0400", "Message-Id": "<20230309042842.8709-2-ivan.malov@arknetworks.am>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20230309042842.8709-1-ivan.malov@arknetworks.am>", "References": "<20230309042842.8709-1-ivan.malov@arknetworks.am>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The currently used API is unfit for the purpose as it\nchecks the order in which the action is being added.\nUse a dedicated API to request the reset.\n\nFixes: 012bf708c20f (\"net/sfc: support group flows in tunnel offload\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ivan Malov <ivan.malov@arknetworks.am>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/net/sfc/sfc_mae.c | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c\nindex 3daeed81b9..e5e9257998 100644\n--- a/drivers/net/sfc/sfc_mae.c\n+++ b/drivers/net/sfc/sfc_mae.c\n@@ -3896,12 +3896,10 @@ sfc_mae_rule_parse_actions(struct sfc_adapter *sa,\n \t\tbreak;\n \tcase SFC_FT_RULE_SWITCH:\n \t\t/*\n-\t\t * Packets that go to the rule's AR have FT mark set (from the\n-\t\t * TUNNEL rule OR's RECIRC_ID). Remove this mark in matching\n-\t\t * packets. The user may have provided their own action\n-\t\t * MARK above, so don't check the return value here.\n+\t\t * Packets that go to the rule's AR have FT mark set (from\n+\t\t * the TUNNEL rule OR's RECIRC_ID). Reset the mark to zero.\n \t\t */\n-\t\t(void)efx_mae_action_set_populate_mark(ctx.spec, 0);\n+\t\tefx_mae_action_set_populate_mark_reset(ctx.spec);\n \n \t\tctx.ft_switch_hit_counter =\n \t\t\t&spec_mae->ft_ctx->switch_hit_counter;\n", "prefixes": [ "2/2" ] }