Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124908/?format=api
{ "id": 124908, "url": "http://patchwork.dpdk.org/api/patches/124908/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230309160212.1200403-1-yogesh.jangra@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230309160212.1200403-1-yogesh.jangra@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230309160212.1200403-1-yogesh.jangra@intel.com", "date": "2023-03-09T16:02:12", "name": "[v2] app/testpmd: fix closing softnic port before ethdev ports", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "ed05c055e41d40abb2f060f1631a6c5e6b7a41bd", "submitter": { "id": 2025, "url": "http://patchwork.dpdk.org/api/people/2025/?format=api", "name": "Yogesh Jangra", "email": "yogesh.jangra@intel.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230309160212.1200403-1-yogesh.jangra@intel.com/mbox/", "series": [ { "id": 27313, "url": "http://patchwork.dpdk.org/api/series/27313/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=27313", "date": "2023-03-09T16:02:12", "name": "[v2] app/testpmd: fix closing softnic port before ethdev ports", "version": 2, "mbox": "http://patchwork.dpdk.org/series/27313/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/124908/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/124908/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3FC0541E1C;\n\tThu, 9 Mar 2023 17:05:37 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 206A240ED7;\n\tThu, 9 Mar 2023 17:05:37 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id C403040695\n for <dev@dpdk.org>; Thu, 9 Mar 2023 17:05:35 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Mar 2023 08:03:51 -0800", "from ena4.iind.intel.com ([10.190.200.224])\n by orsmga007.jf.intel.com with ESMTP; 09 Mar 2023 08:03:48 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1678377936; x=1709913936;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=4r8hdIYW0gpmmqkTZDooVBCpEj3qoJbedBv857/cb58=;\n b=hB56GTbeWjQHVtRkbgBAIL52MgSZ/Pj/74cgnt22RCRrf4GeLwqzw6SJ\n nN8PYMsanQZYBfYkUadOfuX3ne8Jzt6okxpm99rgulsIkO4UkHTgRo1JE\n H4sLRTFIrNA677cCUFPf1BZ2Y7foDvwqC6CGJtlAAeYHNcrjy29TvjX33\n hNjQC6W4FvM1fO627XWzUjP3XAd5kZNrAWz+5q9vTNe0WzM5FzAEYbTMD\n S8M0GdESZesIqSoKL47EoCv27w28rJHkNQaap+sgv4m+q0ejlaPzbGBJE\n akD4RP0YL1N6VcUe2zHX61OUufPngro8ygnAOExPL/M8Ep9fSHsyuWhcV A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10644\"; a=\"422752333\"", "E=Sophos;i=\"5.98,246,1673942400\"; d=\"scan'208\";a=\"422752333\"", "E=McAfee;i=\"6500,9779,10644\"; a=\"670784555\"", "E=Sophos;i=\"5.98,246,1673942400\"; d=\"scan'208\";a=\"670784555\"" ], "X-ExtLoop1": "1", "From": "Yogesh Jangra <yogesh.jangra@intel.com>", "To": "dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com, kamalakannan.r@intel.com,\n harshad.suresh.narayane@intel.com, yogesh.jangra@intel.com", "Subject": "[PATCH v2] app/testpmd: fix closing softnic port before ethdev ports", "Date": "Thu, 9 Mar 2023 16:02:12 +0000", "Message-Id": "<20230309160212.1200403-1-yogesh.jangra@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230309144249.1199517-1-yogesh.jangra@intel.com>", "References": "<20230309144249.1199517-1-yogesh.jangra@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "SoftNIC runs on the service core, it uses the resources from\nthe testpmd application. When we run quit command, the testpmd\napplication stops ethdev ports first, SoftNIC will try to\naccess the port and sometimes that results in segmentation\nerror. This fix will first close the SoftNIC port.\n\nSigned-off-by: Yogesh Jangra <yogesh.jangra@intel.com>\nSigned-off-by: Kamalakannan R <kamalakannan.r@intel.com>\nAcked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\n---\n app/test-pmd/testpmd.c | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)", "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 0032696608..88464ea582 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -3767,6 +3767,21 @@ pmd_test_exit(void)\n #endif\n \tif (ports != NULL) {\n \t\tno_link_check = 1;\n+\n+\t\t/*\n+\t\t * SoftNIC runs on the service core, it uses the resources from\n+\t\t * the testpmd application. When we run quit command, the testpmd\n+\t\t * application stops ethdev ports first, SoftNIC will try to\n+\t\t * access the port and sometimes that results in segmentation\n+\t\t * error. So first closing the SoftNIC port.\n+\t\t */\n+\t\tRTE_ETH_FOREACH_DEV(pt_id) {\n+\t\t\tif (!strcmp(ports[pt_id].dev_info.driver_name, \"net_softnic\")) {\n+\t\t\t\tstop_port(pt_id);\n+\t\t\t\tclose_port(pt_id);\n+\t\t\t}\n+\t\t}\n+\n \t\tRTE_ETH_FOREACH_DEV(pt_id) {\n \t\t\tprintf(\"\\nStopping port %d...\\n\", pt_id);\n \t\t\tfflush(stdout);\n", "prefixes": [ "v2" ] }