Patch Comment Detail
get:
Show a patch comment.
patch:
Update a patch comment.
put:
Update a patch comment.
GET /api/patches/124908/comments/169569/?format=api
{ "id": 169569, "web_url": "http://patchwork.dpdk.org/comment/169569/", "msgid": "<775abdb3-2a94-4e45-b03d-58e9560812ce@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/775abdb3-2a94-4e45-b03d-58e9560812ce@amd.com", "date": "2024-04-18T15:29:00", "subject": "Re: [PATCH v2] app/testpmd: fix closing softnic port before ethdev\n ports", "submitter": { "id": 2700, "url": "http://patchwork.dpdk.org/api/people/2700/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@amd.com" }, "content": "On 3/9/2023 4:02 PM, Yogesh Jangra wrote:\n> SoftNIC runs on the service core, it uses the resources from\n> the testpmd application. When we run quit command, the testpmd\n> application stops ethdev ports first, SoftNIC will try to\n> access the port and sometimes that results in segmentation\n> error. This fix will first close the SoftNIC port.\n> \n> Signed-off-by: Yogesh Jangra <yogesh.jangra@intel.com>\n> Signed-off-by: Kamalakannan R <kamalakannan.r@intel.com>\n> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\n> \n\nI am cleaning up old patches in patchwork.\n\nNACK to this patch as it is, testpmd should not behave different for any\n specific driver/device. This can go out of hand if we open the door.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AA5BB43EA7;\n\tThu, 18 Apr 2024 17:29:08 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 92A8D40272;\n\tThu, 18 Apr 2024 17:29:08 +0200 (CEST)", "from NAM10-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam10on2057.outbound.protection.outlook.com [40.107.94.57])\n by mails.dpdk.org (Postfix) with ESMTP id 0CF7840689\n for <dev@dpdk.org>; Thu, 18 Apr 2024 17:29:07 +0200 (CEST)", "from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11)\n by MW4PR12MB7238.namprd12.prod.outlook.com (2603:10b6:303:229::16)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.37; Thu, 18 Apr\n 2024 15:29:04 +0000", "from CH2PR12MB4294.namprd12.prod.outlook.com\n ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com\n ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7452.049; Thu, 18 Apr 2024\n 15:29:04 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=MmhWVQq9VfXKJ5v0cUVpw7zUy7V1EbiMmuDKRdaH2t0c+sJvSk4QXeKbllbzHjRwmnFr/eqOKUWXnKXP8TIFiR9v4Yv8AP11Nr3j0GTH3B6YpGZpb80ZWzqGa8YCebv+5JEA3ojm04AYMrgUozGd0KR83sbnjp3XAeLvC3OkOM5QtXHHEqfSDEozSNn2LR8xpQyfB8PrwvzvGpWNPF3msoWyzQeGp/qGnpuaS5N9DaYcNb1NYVBygDWjOb0EIurtqmM2rqMDTH9x80bqI6R14k/ygn++LjsIHDXNd/TVGBW2EhO0BMhlVY0RxFyg6fCs6piKyst33h89MD1zjakSPQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=uwrM5FhkVfsueAwl3xKH2ogBh8kWaqlOTVaEgaPDDIU=;\n b=FTYwk1W6hnfWTB+YDHQXD4Pt5GmCfRa1E4Wetno2jvda4GGREp7eh5fEUkY2zMC2gC/O2ID7BcmGVcqb5t0VHBhsBqtpMCmNLUVxBjoPUZadD6z2WIvQL8LZ7CP3F+sbhN9EbjvIQvaublS4n32vj+xKOBqCJotEyXaAx2IBqADqLMvOg/z+vy3JSH3tLilHXCAvT2rNcRqEsuqj1Hd2b5/dZ7dSefhDVOY464joHFTLmi9z8x4ltMHMK41nf6PnIPTO2v1W06Z4hYEA66rabS7+zCGn3aOmd2Qf/1VD8yqWZy08Dj7l+tVXl8nv9k674f9l1UxcH8vqSwsZaDVKoQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass\n header.d=amd.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=uwrM5FhkVfsueAwl3xKH2ogBh8kWaqlOTVaEgaPDDIU=;\n b=x11SOQ78Wu4dwZxsatFquMQwO5ciDoVcb4g6B5G4BxICb+wdUMU6HzseBlrtAJ4vPLzKa1Xr2ZrhcSQiqDlMP8kMIgqQVbGYNjfQYJ6vDXnfIBAIMbUCb4ZTrQbytA/jwGortQednsdrUG/7YPOl5NEVv4A8Ups+BurjxnsbQ/8=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=amd.com;", "Message-ID": "<775abdb3-2a94-4e45-b03d-58e9560812ce@amd.com>", "Date": "Thu, 18 Apr 2024 16:29:00 +0100", "User-Agent": "Mozilla Thunderbird", "Subject": "Re: [PATCH v2] app/testpmd: fix closing softnic port before ethdev\n ports", "To": "Yogesh Jangra <yogesh.jangra@intel.com>, dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com, kamalakannan.r@intel.com,\n harshad.suresh.narayane@intel.com, \"Mcnamara, John\"\n <john.mcnamara@intel.com>, Bruce Richardson <bruce.richardson@intel.com>", "References": "<20230309144249.1199517-1-yogesh.jangra@intel.com>\n <20230309160212.1200403-1-yogesh.jangra@intel.com>", "Content-Language": "en-US", "From": "Ferruh Yigit <ferruh.yigit@amd.com>", "Autocrypt": "addr=ferruh.yigit@amd.com; keydata=\n xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9\n 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J\n eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg\n B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9\n RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ\n N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ\n vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S\n 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum\n CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA\n XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln\n aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID\n AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK\n Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3\n tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU\n 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs\n cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD\n VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg\n Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc\n GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV\n gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW\n VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD\n DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG\n CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe\n WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi\n 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl\n 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv\n VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA\n fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr\n ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC\n IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk\n 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak\n oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq\n b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ\n Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX\n W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW\n honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA\n g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn\n GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ\n NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs\n SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe\n cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH\n dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk=", "In-Reply-To": "<20230309160212.1200403-1-yogesh.jangra@intel.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "7bit", "X-ClientProxiedBy": "LO4P265CA0305.GBRP265.PROD.OUTLOOK.COM\n (2603:10a6:600:391::9) To CH2PR12MB4294.namprd12.prod.outlook.com\n (2603:10b6:610:a9::11)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CH2PR12MB4294:EE_|MW4PR12MB7238:EE_", "X-MS-Office365-Filtering-Correlation-Id": "0f99ea9b-3a1a-4693-88ef-08dc5fbc47f6", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n G4eTjCKvYn1gW8a5itxjvVWZ3tMIYbCS0iJ9r0nL4PsCWu5v6px2bMryBj0PTKeHlMjRHyzO5XisNtlcfNki15hijdEFNNaNx+mZr9Ok1/RudubrKwxrvkoqKt90rGfxZbc5PnSd4a+dLECj3PBvWZkc+kJSB4im6WhguvNxGGokLh5h660WaMdxDytS5ZIWC3TeXzsPYfyyCf0ZxlM0ASXi/Z8DD5K4hHUQ4uGnXDBrHR4kormOZ2vIePdM3ZAwayKp6onMbTna2p0limVvtVgpoAax8zIaA7DIYpCiFz+/MWHW2Qydugx62TPLIrq9POZppaa4Z/KjMMPJI15c0BL65idSGbBkb7zhyYf1nY0b6QWtJingwUbKF5mYmcGL3VyT3vA4mfZeTq15hwlDy5wJ3no5+gHjVC+znUsmO9MRVpkT0RMEFm72i7K3J2+rANM1mSZCcmCkqViVIGT4Q46QbMx3Odx0hLpc373+WZQaDPkQZQcDLzruezROwhMYKSkfRZzpKbDusCuKoToiDzGxwasoEjMLtjHtEGbvoeygdbyfzvp4W+8bFtu3WVkmjqpEbtu/pa/OC038AX3ZyKbjvHzOvgly7FHx+iotFRBI8+eMqHSHhlX/n1FpRLZtv3/Ct+/vzo01/EsZGuLvRrvmSwQgcfxp9xd9Qg4rYVE=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(1800799015)(376005)(366007); DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?Dhe/eXS8JsfkUdJjblELxFYqNcl0?=\n\t=?utf-8?q?4hIov/XZKN1z3Re3r49025zGL88bjnV1SSznOOidmv3H3B0tsjBeLvUj5xuPzUSIA?=\n\t=?utf-8?q?PL5IwpCNxVqko17z+1LQ1sNWO4iQ6Jeq1EUzIzKFJRi11nMsIWY1A2chBvBQMA5rd?=\n\t=?utf-8?q?fqHs06zmFWf1NV6G+AGzLwht1wtmnaSVL4PakWY5FhP+BJCEvOEOd3bmH8T8tqetz?=\n\t=?utf-8?q?WSQTjKCXjSZtlqo6pxxIMvH1GqJtT2drmWyD1un6DCqYMq7ADkokJVg6gg46FoUqG?=\n\t=?utf-8?q?4gUEQ4EBwQJ3MporuIK0dfFfM6fzWYTYF98QNIdh77JeP5FSyv+Wht5H//UVcoQWY?=\n\t=?utf-8?q?FErFjkT2A0IMmohOjezY90tSC5+NWgVx1BV4xglll/tOR75kOXcmf8iHP3psWwMqP?=\n\t=?utf-8?q?KVvgazkC0JRXcOctHSZprJ5xAhnoMW4IqZ3572UGwGZ7EXuPUMEHSmuPEFL0o10YX?=\n\t=?utf-8?q?vpYwn5JfObrYYWGmUx4jnxnDE1WZy59PgIX/+2uaFo9Tf/P1CX1bgUbULmYXTokkJ?=\n\t=?utf-8?q?AA9iinoY7ALB4DizgdipoGJEFb3jnddNqR3L/iEFX+ywy2KtXVkbxyiYC3De1FXuN?=\n\t=?utf-8?q?shcRPbt2dzZpQh+oButi3gK9nC0BI3QBz7e3WuanfMaFGAnh2/F7yfQOIQmCV26tT?=\n\t=?utf-8?q?PaIQX4NqlNhs0Wl0MkVr/d541fSgH80ufmi7rB2Je6H9XeKzjZ7qlwINbw2TdPm0B?=\n\t=?utf-8?q?+wqNdCFfqL3TvZqp3ICJVq6H7iRmGqp2FWVKXEpB8kbLoLOEqHyrJ7E+tSt1IL3mZ?=\n\t=?utf-8?q?FbMv/TyZtXP5MsjZ+luwJgsw4GtTXwCxyB87tfWSzNsFMhDd8toXaIJ4NE6BDbatC?=\n\t=?utf-8?q?9usw38PM7/IeWLxSmGazUA3g4pVBkxxwxGRWbg1rrzYVUfDejWvbiMmvSv51GsfRm?=\n\t=?utf-8?q?qIjgO5OhRI6R5zsZXDtZNzcSwk1qhigu9M0HhntMUi8fsPpIkH0MfP+hwADe2W7z1?=\n\t=?utf-8?q?jyjiULfT4P/TSPEl4h9AMkX/8ZleoFSWTNJNHtheDgDFKNHs2hP1xa8JSiMFT9WvN?=\n\t=?utf-8?q?MmFHCcqt9IOihr/AvG5xFndTLkjzW/saQl5MXz4L0Buv8moHJG00bV+sh/rCmV8Tq?=\n\t=?utf-8?q?7RoaOvWFm7v4m3fxXyZONVvqcVSaCkZJwQhNdFh/e84LsxlLWU8Z5Z6+h08XHuL0e?=\n\t=?utf-8?q?Gh+5jcVjBlbQCXpna3nMHJa2tA651Bx+sSnDdqR8558PUGD6BPk9Dhklcul/P1r8Q?=\n\t=?utf-8?q?bMHAGfi0OeBywe5zke1J2sUAHZVTHlEDY6dca0UwPUh9byN5pzAqByuhUapuBA3ai?=\n\t=?utf-8?q?GXr7ovCMOVth6CLlJV5O/qjeEP96RhAcPDZ+JSwRnOngow0wPiqVsiQEq3UlehuV9?=\n\t=?utf-8?q?/1X9qac8Tkf7KoHSyQoTR3iH310/uRW8liuFTLG6XxT98HD54lddBZYaTH9GSGlzU?=\n\t=?utf-8?q?Aey19j2ofAR3fJy7JyXsy3s5biBy/Txdcux+JzlF+HNsPs3e839D44CWm4DoVn6NS?=\n\t=?utf-8?q?pJXN2RUTWdaqIUGz1UkvEdWmm0vu+DNUufUqQTdQDfihN5Dd/zhBPzcJH0MLi/8Uk?=\n\t=?utf-8?q?j1DyZQGTZWLG?=", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 0f99ea9b-3a1a-4693-88ef-08dc5fbc47f6", "X-MS-Exchange-CrossTenant-AuthSource": "CH2PR12MB4294.namprd12.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "18 Apr 2024 15:29:04.7859 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n bLPA+Q8M24cVdDnugA3LK5RigjeNdCzfJ6EgamIHMsd5tD8GRwZwUpfBwdE0msUy", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MW4PR12MB7238", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "addressed": null }