Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125460/?format=api
{ "id": 125460, "url": "http://patchwork.dpdk.org/api/patches/125460/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230323162111.5303-1-syalavarthi@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230323162111.5303-1-syalavarthi@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230323162111.5303-1-syalavarthi@marvell.com", "date": "2023-03-23T16:21:11", "name": "[1/1] app/mldev: add check for model and filelist option", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "725a9fd217e93e0386a8bb6054efe918981ac19f", "submitter": { "id": 2480, "url": "http://patchwork.dpdk.org/api/people/2480/?format=api", "name": "Srikanth Yalavarthi", "email": "syalavarthi@marvell.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230323162111.5303-1-syalavarthi@marvell.com/mbox/", "series": [ { "id": 27524, "url": "http://patchwork.dpdk.org/api/series/27524/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=27524", "date": "2023-03-23T16:21:11", "name": "[1/1] app/mldev: add check for model and filelist option", "version": 1, "mbox": "http://patchwork.dpdk.org/series/27524/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/125460/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/125460/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8F3D44281F;\n\tThu, 23 Mar 2023 17:21:20 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 29F8C40689;\n\tThu, 23 Mar 2023 17:21:20 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 6C7794021E\n for <dev@dpdk.org>; Thu, 23 Mar 2023 17:21:18 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 32NBG8WI024016 for <dev@dpdk.org>; Thu, 23 Mar 2023 09:21:17 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3pg9urcj7e-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 23 Mar 2023 09:21:17 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.42;\n Thu, 23 Mar 2023 09:21:15 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.42 via Frontend\n Transport; Thu, 23 Mar 2023 09:21:15 -0700", "from ml-host-33.caveonetworks.com (unknown [10.110.143.233])\n by maili.marvell.com (Postfix) with ESMTP id 6C56F3F7090;\n Thu, 23 Mar 2023 09:21:15 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-type; s=pfpt0220;\n bh=/CfVgXorhPJx+gVuj9awo3+8RsSz0feZ+f5JJ/KsfQs=;\n b=Ke1JlwafjJ6PNWUoKT1Y9txQiRQUo0CZFeGue+9pXaj4CiF8dXOtQOYFQ2jBOd01MBpF\n dsWv1J2nOEIrrgvirT+XgSWk0H1pqfQx1fmNvNyA5niKeYzzhrd2fcr4J0+u5M6D3oi0\n ZNqAGDmN4wcfBi9Zk3p15+uISdJyWCB2iT4VnVuMhUeie74QCUvvzwRUgQFpK1y746Qm\n XaX1HG2ZfXtR7622DdmZWgsJUAVy2/ep66v4z1+juCBL3/orkVmMMVbmLBEQWIHf+WWv\n ew34SPZ13zER4s2vZIQ1wSp4DoyM6XTHn6NMgayMp4AWVq71IHZx0RfIiqyyriKhJd7/ vg==", "From": "Srikanth Yalavarthi <syalavarthi@marvell.com>", "To": "Srikanth Yalavarthi <syalavarthi@marvell.com>, Anup Prabhu\n <aprabhu@marvell.com>", "CC": "<dev@dpdk.org>, <sshankarnara@marvell.com>, <ptakkar@marvell.com>", "Subject": "[PATCH 1/1] app/mldev: add check for model and filelist option", "Date": "Thu, 23 Mar 2023 09:21:11 -0700", "Message-ID": "<20230323162111.5303-1-syalavarthi@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-GUID": "sGKqUB6EYMEMxvJt9gjleGWzuc_V8Xez", "X-Proofpoint-ORIG-GUID": "sGKqUB6EYMEMxvJt9gjleGWzuc_V8Xez", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22\n definitions=2023-03-22_21,2023-03-23_02,2023-02-09_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Application currently doesn't check for empty models list and\nfilelist entries. This causes the app to report an incorrect\nerror messages and test status when the lists are empty.\n\nFixes: bbd272edcb14 (\"app/mldev: add ordered inferences\")\nFixes: f6661e6d9a3a (\"app/mldev: validate model operations\")\n\nSigned-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>\n---\n app/test-mldev/test_inference_common.c | 6 ++++++\n app/test-mldev/test_model_ops.c | 6 ++++++\n 2 files changed, 12 insertions(+)", "diff": "diff --git a/app/test-mldev/test_inference_common.c b/app/test-mldev/test_inference_common.c\nindex c8cd80d69f..410e63bca4 100644\n--- a/app/test-mldev/test_inference_common.c\n+++ b/app/test-mldev/test_inference_common.c\n@@ -344,6 +344,12 @@ test_inference_opt_check(struct ml_options *opt)\n \tif (ret != 0)\n \t\treturn ret;\n \n+\t/* check for at least one filelist */\n+\tif (opt->nb_filelist == 0) {\n+\t\tml_err(\"Filelist empty, need at least one filelist to run the test\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n \t/* check file availability */\n \tfor (i = 0; i < opt->nb_filelist; i++) {\n \t\tif (access(opt->filelist[i].model, F_OK) == -1) {\ndiff --git a/app/test-mldev/test_model_ops.c b/app/test-mldev/test_model_ops.c\nindex 5bbbcb1a6c..9de13247ae 100644\n--- a/app/test-mldev/test_model_ops.c\n+++ b/app/test-mldev/test_model_ops.c\n@@ -30,6 +30,12 @@ test_model_ops_opt_check(struct ml_options *opt)\n \tif (ret != 0)\n \t\treturn ret;\n \n+\t/* check for at least one model */\n+\tif (opt->nb_filelist == 0) {\n+\t\tml_err(\"Models list empty, need at least one model to run the test\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n \t/* check model file availability */\n \tfor (i = 0; i < opt->nb_filelist; i++) {\n \t\tif (access(opt->filelist[i].model, F_OK) == -1) {\n", "prefixes": [ "1/1" ] }