Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125461/?format=api
{ "id": 125461, "url": "http://patchwork.dpdk.org/api/patches/125461/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230323162313.13295-1-syalavarthi@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230323162313.13295-1-syalavarthi@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230323162313.13295-1-syalavarthi@marvell.com", "date": "2023-03-23T16:23:13", "name": "[1/1] app/mldev: fix code formatting and alignment", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6e2a760c5cda063bee1d1dd754af6734312c93d3", "submitter": { "id": 2480, "url": "http://patchwork.dpdk.org/api/people/2480/?format=api", "name": "Srikanth Yalavarthi", "email": "syalavarthi@marvell.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230323162313.13295-1-syalavarthi@marvell.com/mbox/", "series": [ { "id": 27525, "url": "http://patchwork.dpdk.org/api/series/27525/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=27525", "date": "2023-03-23T16:23:13", "name": "[1/1] app/mldev: fix code formatting and alignment", "version": 1, "mbox": "http://patchwork.dpdk.org/series/27525/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/125461/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/125461/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 100084281F;\n\tThu, 23 Mar 2023 17:23:20 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EDCD840689;\n\tThu, 23 Mar 2023 17:23:19 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 54FF14021E\n for <dev@dpdk.org>; Thu, 23 Mar 2023 17:23:18 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 32NBpgtN024001; Thu, 23 Mar 2023 09:23:17 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3pg9urcjn5-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Thu, 23 Mar 2023 09:23:16 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.42;\n Thu, 23 Mar 2023 09:23:15 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.42 via Frontend\n Transport; Thu, 23 Mar 2023 09:23:15 -0700", "from ml-host-33.caveonetworks.com (unknown [10.110.143.233])\n by maili.marvell.com (Postfix) with ESMTP id 2B6FA3F7075;\n Thu, 23 Mar 2023 09:23:15 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-type; s=pfpt0220;\n bh=Jj1S/TLJqsOrCHg8mfjU9twfa2seSjMPqnAtyNx8OZ4=;\n b=Tex691MWCDkMVMZ7la7Xal0TFtCA2ss5RkNcucEGJL9zduPtW+eTAIuYbxw1qYxdm7mH\n oKeCo2Pwo43A5MakmAtM54UX2TfOnnd2MwQ39LY7VD3Lr656rxiG5iOZtCA9JzT8PmUc\n LUZPorl/Sfml//K6Ys14dOrSZS3F5xZizfuoLLFEy1B0AEyp0Ad+Gz5+rM9BnyPfNlgH\n qAEUiCgMAHIO4IJQv/Kc3vuk67gtGIBtTxL1/WSk6Y4ciMKRSeabqu7D8FxeERZ/T85i\n qBiOwxi8CrYLF/szIkUOOizBELg+vfr+6sDhN4XmS4iGPXKUssme9NADymmxEcLKk+jA FA==", "From": "Srikanth Yalavarthi <syalavarthi@marvell.com>", "To": "Srikanth Yalavarthi <syalavarthi@marvell.com>, David Marchand\n <david.marchand@redhat.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Anup Prabhu <aprabhu@marvell.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH 1/1] app/mldev: fix code formatting and alignment", "Date": "Thu, 23 Mar 2023 09:23:13 -0700", "Message-ID": "<20230323162313.13295-1-syalavarthi@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-GUID": "c9ppswGT_CsqRkFUuBx_Lz49rfpwIv6Z", "X-Proofpoint-ORIG-GUID": "c9ppswGT_CsqRkFUuBx_Lz49rfpwIv6Z", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22\n definitions=2023-03-22_21,2023-03-23_02,2023-02-09_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Updated ML application source files to have uniform code\nformatting style across. Remove extra blank lines.\n\nFixes: 8cb22a545447 (\"app/mldev: fix debug build\")\nFixes: c9f073cdca95 (\"mldev: remove unnecessary null checks\")\nFixes: da6793390596 (\"app/mldev: support inference validation\")\n\nSigned-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>\n---\n app/test-mldev/test_inference_common.c | 38 ++++++++++++--------------\n 1 file changed, 18 insertions(+), 20 deletions(-)", "diff": "diff --git a/app/test-mldev/test_inference_common.c b/app/test-mldev/test_inference_common.c\nindex 410e63bca4..f8960ae726 100644\n--- a/app/test-mldev/test_inference_common.c\n+++ b/app/test-mldev/test_inference_common.c\n@@ -20,23 +20,23 @@\n \n #define ML_TEST_READ_TYPE(buffer, type) (*((type *)buffer))\n \n-#define ML_TEST_CHECK_OUTPUT(output, reference, tolerance) \\\n+#define ML_TEST_CHECK_OUTPUT(output, reference, tolerance) \\\n \t(((float)output - (float)reference) <= (((float)reference * tolerance) / 100.0))\n \n-#define ML_OPEN_WRITE_GET_ERR(name, buffer, size, err) \\\n-\tdo { \\\n-\t\tFILE *fp = fopen(name, \"w+\"); \\\n-\t\tif (fp == NULL) { \\\n-\t\t\tml_err(\"Unable to create file: %s, error: %s\", name, strerror(errno)); \\\n-\t\t\terr = true; \\\n-\t\t} else { \\\n-\t\t\tif (fwrite(buffer, 1, size, fp) != size) { \\\n-\t\t\t\tml_err(\"Error writing output, file: %s, error: %s\", name, \\\n-\t\t\t\t strerror(errno)); \\\n-\t\t\t\terr = true; \\\n-\t\t\t} \\\n-\t\t\tfclose(fp); \\\n-\t\t} \\\n+#define ML_OPEN_WRITE_GET_ERR(name, buffer, size, err) \\\n+\tdo { \\\n+\t\tFILE *fp = fopen(name, \"w+\"); \\\n+\t\tif (fp == NULL) { \\\n+\t\t\tml_err(\"Unable to create file: %s, error: %s\", name, strerror(errno)); \\\n+\t\t\terr = true; \\\n+\t\t} else { \\\n+\t\t\tif (fwrite(buffer, 1, size, fp) != size) { \\\n+\t\t\t\tml_err(\"Error writing output, file: %s, error: %s\", name, \\\n+\t\t\t\t strerror(errno)); \\\n+\t\t\t\terr = true; \\\n+\t\t\t} \\\n+\t\t\tfclose(fp); \\\n+\t\t} \\\n \t} while (0)\n \n static void\n@@ -937,7 +937,7 @@ ml_request_finish(struct rte_mempool *mp, void *opaque, void *obj, unsigned int\n \tif (t->cmn.opt->debug) {\n \t\t/* dump quantized output buffer */\n \t\tif (asprintf(&dump_path, \"%s.q.%u\", t->cmn.opt->filelist[req->fid].output,\n-\t\t\t\tobj_idx) == -1)\n+\t\t\t obj_idx) == -1)\n \t\t\treturn;\n \t\tML_OPEN_WRITE_GET_ERR(dump_path, req->output, model->out_qsize, error);\n \t\tfree(dump_path);\n@@ -945,8 +945,8 @@ ml_request_finish(struct rte_mempool *mp, void *opaque, void *obj, unsigned int\n \t\t\treturn;\n \n \t\t/* dump dequantized output buffer */\n-\t\tif (asprintf(&dump_path, \"%s.%u\", t->cmn.opt->filelist[req->fid].output,\n-\t\t\t\tobj_idx) == -1)\n+\t\tif (asprintf(&dump_path, \"%s.%u\", t->cmn.opt->filelist[req->fid].output, obj_idx) ==\n+\t\t -1)\n \t\t\treturn;\n \t\tML_OPEN_WRITE_GET_ERR(dump_path, model->output, model->out_dsize, error);\n \t\tfree(dump_path);\n@@ -1077,7 +1077,6 @@ ml_inference_stats_get(struct ml_test *test, struct ml_options *opt)\n \n \t/* release buffers */\n \trte_free(t->xstats_map);\n-\n \trte_free(t->xstats_values);\n \n \t/* print end-to-end stats */\n@@ -1116,7 +1115,6 @@ ml_inference_stats_get(struct ml_test *test, struct ml_options *opt)\n \n error:\n \trte_free(t->xstats_map);\n-\n \trte_free(t->xstats_values);\n \n \treturn ret;\n", "prefixes": [ "1/1" ] }