Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125983/?format=api
{ "id": 125983, "url": "http://patchwork.dpdk.org/api/patches/125983/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230413061650.796940-4-junfeng.guo@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230413061650.796940-4-junfeng.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230413061650.796940-4-junfeng.guo@intel.com", "date": "2023-04-13T06:16:43", "name": "[03/10] net/gve: support device start and close for DQO", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "30dbd28f7acbf269d26e556e03ab29d6942577fb", "submitter": { "id": 1785, "url": "http://patchwork.dpdk.org/api/people/1785/?format=api", "name": "Junfeng Guo", "email": "junfeng.guo@intel.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230413061650.796940-4-junfeng.guo@intel.com/mbox/", "series": [ { "id": 27687, "url": "http://patchwork.dpdk.org/api/series/27687/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=27687", "date": "2023-04-13T06:16:40", "name": "gve PMD enhancement", "version": 1, "mbox": "http://patchwork.dpdk.org/series/27687/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/125983/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/125983/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CADBB4292F;\n\tThu, 13 Apr 2023 08:17:29 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3226941153;\n\tThu, 13 Apr 2023 08:17:21 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 2FB1F41143\n for <dev@dpdk.org>; Thu, 13 Apr 2023 08:17:19 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Apr 2023 23:17:18 -0700", "from dpdk-jf-ntb-one.sh.intel.com ([10.67.111.104])\n by fmsmga007.fm.intel.com with ESMTP; 12 Apr 2023 23:17:16 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1681366639; x=1712902639;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=vBVu0pjpFzuU2jfEm57liWrA35tgkh5FFU1B2bfPR+g=;\n b=hd2heL4cYyRnkVMFw9ZH/heX5rsFd6M1cr9S20ZMXaXpIKav3zeNitoQ\n iY8Xs9QVKCNOzcyQ9M4p8V7qbptVPJyVjve3q6OcU1yAz5EkBuVoExQvw\n HiPPYENeNzU4YyNPxJ6gcK8MGiXqogOyZ4oaP681UyJz+RF02A6jBovp0\n OgcGe/3Kgf+aaVRezgFWJT67Ju+Keg10hIY+HYtadGS1tv9xsSgZUU13y\n cdD1vPdtOEj96kstH3I5RZs0lDu6CCeXgSHmQR/LcL2iZGQyR6GqmZiqi\n hYzv0Fg4z1sQHDoGQHqU4qLO/tJmMpLtswKeznFvongXGZxTyNslDbhg7 Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10678\"; a=\"341595352\"", "E=Sophos;i=\"5.98,339,1673942400\"; d=\"scan'208\";a=\"341595352\"", "E=McAfee;i=\"6600,9927,10678\"; a=\"691824264\"", "E=Sophos;i=\"5.98,339,1673942400\"; d=\"scan'208\";a=\"691824264\"" ], "X-ExtLoop1": "1", "From": "Junfeng Guo <junfeng.guo@intel.com>", "To": "qi.z.zhang@intel.com, jingjing.wu@intel.com, ferruh.yigit@amd.com,\n beilei.xing@intel.com", "Cc": "dev@dpdk.org, Junfeng Guo <junfeng.guo@intel.com>,\n Rushil Gupta <rushilg@google.com>, Joshua Washington <joshwash@google.com>,\n Jeroen de Borst <jeroendb@google.com>", "Subject": "[PATCH 03/10] net/gve: support device start and close for DQO", "Date": "Thu, 13 Apr 2023 14:16:43 +0800", "Message-Id": "<20230413061650.796940-4-junfeng.guo@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230413061650.796940-1-junfeng.guo@intel.com>", "References": "<20230413061650.796940-1-junfeng.guo@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add device start and close support for DQO.\n\nSigned-off-by: Junfeng Guo <junfeng.guo@intel.com>\nSigned-off-by: Rushil Gupta <rushilg@google.com>\nSigned-off-by: Joshua Washington <joshwash@google.com>\nSigned-off-by: Jeroen de Borst <jeroendb@google.com>\n---\n drivers/net/gve/gve_ethdev.c | 43 +++++++++++++++++++++++++++++++++++-\n 1 file changed, 42 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c\nindex d387d7154b..fc60db63c5 100644\n--- a/drivers/net/gve/gve_ethdev.c\n+++ b/drivers/net/gve/gve_ethdev.c\n@@ -78,6 +78,9 @@ gve_free_qpls(struct gve_priv *priv)\n \tuint16_t nb_rxqs = priv->max_nb_rxq;\n \tuint32_t i;\n \n+\tif (priv->queue_format != GVE_GQI_QPL_FORMAT)\n+\t\treturn;\n+\n \tfor (i = 0; i < nb_txqs + nb_rxqs; i++) {\n \t\tif (priv->qpl[i].mz != NULL)\n \t\t\trte_memzone_free(priv->qpl[i].mz);\n@@ -138,6 +141,41 @@ gve_refill_pages(struct gve_rx_queue *rxq)\n \treturn 0;\n }\n \n+static int\n+gve_refill_dqo(struct gve_rx_queue *rxq)\n+{\n+\tstruct rte_mbuf *nmb;\n+\tuint16_t i;\n+\tint diag;\n+\n+\tdiag = rte_pktmbuf_alloc_bulk(rxq->mpool, &rxq->sw_ring[0], rxq->nb_rx_desc);\n+\tif (diag < 0) {\n+\t\tfor (i = 0; i < rxq->nb_rx_desc - 1; i++) {\n+\t\t\tnmb = rte_pktmbuf_alloc(rxq->mpool);\n+\t\t\tif (!nmb)\n+\t\t\t\tbreak;\n+\t\t\trxq->sw_ring[i] = nmb;\n+\t\t}\n+\t\tif (i < rxq->nb_rx_desc - 1)\n+\t\t\treturn -ENOMEM;\n+\t}\n+\n+\tfor (i = 0; i < rxq->nb_rx_desc; i++) {\n+\t\tif (i == rxq->nb_rx_desc - 1)\n+\t\t\tbreak;\n+\t\tnmb = rxq->sw_ring[i];\n+\t\trxq->rx_ring[i].buf_addr = rte_cpu_to_le_64(rte_mbuf_data_iova_default(nmb));\n+\t\trxq->rx_ring[i].buf_id = rte_cpu_to_le_16(i);\n+\t}\n+\n+\trxq->nb_rx_hold = 0;\n+\trxq->bufq_tail = rxq->nb_rx_desc - 1;\n+\n+\trte_write32(rxq->bufq_tail, rxq->qrx_tail);\n+\n+\treturn 0;\n+}\n+\n static int\n gve_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complete)\n {\n@@ -206,7 +244,10 @@ gve_dev_start(struct rte_eth_dev *dev)\n \n \t\trte_write32(rte_cpu_to_be_32(GVE_IRQ_MASK), rxq->ntfy_addr);\n \n-\t\terr = gve_refill_pages(rxq);\n+\t\tif (gve_is_gqi(priv))\n+\t\t\terr = gve_refill_pages(rxq);\n+\t\telse\n+\t\t\terr = gve_refill_dqo(rxq);\n \t\tif (err) {\n \t\t\tPMD_DRV_LOG(ERR, \"Failed to refill for RX\");\n \t\t\tgoto err_rx;\n", "prefixes": [ "03/10" ] }