Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126010/?format=api
{ "id": 126010, "url": "http://patchwork.dpdk.org/api/patches/126010/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230413094502.1714755-9-wenjing.qiao@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230413094502.1714755-9-wenjing.qiao@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230413094502.1714755-9-wenjing.qiao@intel.com", "date": "2023-04-13T09:44:52", "name": "[08/18] common/idpf: swap opcode and retval location in msg struct", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0032ff5d6331cd945fb95239a47a34cefeb81c56", "submitter": { "id": 2680, "url": "http://patchwork.dpdk.org/api/people/2680/?format=api", "name": "Wenjing Qiao", "email": "wenjing.qiao@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230413094502.1714755-9-wenjing.qiao@intel.com/mbox/", "series": [ { "id": 27692, "url": "http://patchwork.dpdk.org/api/series/27692/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=27692", "date": "2023-04-13T09:44:44", "name": "update idpf shared code", "version": 1, "mbox": "http://patchwork.dpdk.org/series/27692/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/126010/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/126010/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 423F842931;\n\tThu, 13 Apr 2023 11:51:11 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2523642D37;\n\tThu, 13 Apr 2023 11:50:28 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 149F942D36\n for <dev@dpdk.org>; Thu, 13 Apr 2023 11:50:25 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2023 02:50:25 -0700", "from dpdk-wenjing-01.sh.intel.com ([10.67.119.244])\n by FMSMGA003.fm.intel.com with ESMTP; 13 Apr 2023 02:50:23 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1681379426; x=1712915426;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=iJS8b289BbEG/ftluEVn/OUjC0eQe2qMP8SQk1HdJwY=;\n b=FnxWMjWWSjHukAeWRnlgFw3g1seugB90Js/lyN6dUukIeJPlXOFcnx5/\n ritmvniQQv74OSjlWTl5RVgEMBO6kvgSOzMH20PH+CQ9Wpcg/XkfcPFfg\n GKh7R+90AGjMDSr1kIA8PFIW+ZYfucPWpIBEwj2UVqUqDWjL/1orzei2n\n TVTFoUQL4IJSjbN3K9BUUZZQoohYrD3k4oei7dxP2v3Lq/hwdKq73pkgI\n OH9o+2VmBUKCQk1xcjkMViE/jKMAMSLPADsENSi7CiD3vbSnpUKf8Qj8R\n QgEAHeWLsuZeZFpUKmMEffdu4G/EgyxYbxOp5F5ablW00wCIJ4qs8SF1V Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10678\"; a=\"409290442\"", "E=Sophos;i=\"5.98,341,1673942400\"; d=\"scan'208\";a=\"409290442\"", "E=McAfee;i=\"6600,9927,10678\"; a=\"778699292\"", "E=Sophos;i=\"5.98,341,1673942400\"; d=\"scan'208\";a=\"778699292\"" ], "X-ExtLoop1": "1", "From": "Wenjing Qiao <wenjing.qiao@intel.com>", "To": "jingjing.wu@intel.com,\n\tbeilei.xing@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "dev@dpdk.org, Wenjing Qiao <wenjing.qiao@intel.com>,\n Charles Stoll <charles.stoll@intel.com>", "Subject": "[PATCH 08/18] common/idpf: swap opcode and retval location in msg\n struct", "Date": "Thu, 13 Apr 2023 05:44:52 -0400", "Message-Id": "<20230413094502.1714755-9-wenjing.qiao@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230413094502.1714755-1-wenjing.qiao@intel.com>", "References": "<20230413094502.1714755-1-wenjing.qiao@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "To make the code more readable and make it clearer that the opcode goes\nin cookie_high and retval goes in cookie_low.\n\nAdd macro definitions for filling opcode and retval.\n\nSigned-off-by: Charles Stoll <charles.stoll@intel.com>\nSigned-off-by: Wenjing Qiao <wenjing.qiao@intel.com>\n---\n drivers/common/idpf/base/idpf_controlq.c | 2 ++\n drivers/common/idpf/base/idpf_controlq_api.h | 6 +++++-\n 2 files changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/common/idpf/base/idpf_controlq.c b/drivers/common/idpf/base/idpf_controlq.c\nindex 8e4d3ee54f..8381e4000f 100644\n--- a/drivers/common/idpf/base/idpf_controlq.c\n+++ b/drivers/common/idpf/base/idpf_controlq.c\n@@ -288,6 +288,8 @@ int idpf_ctlq_deinit(struct idpf_hw *hw)\n * send routine via the q_msg struct / control queue specific data struct.\n * The control queue will hold a reference to each send message until\n * the completion for that message has been cleaned.\n+ * Since all q_msgs being sent are store in native endianness, these values\n+ * must be converted to LE before being written to the hw descriptor.\n */\n int idpf_ctlq_send(struct idpf_hw *hw, struct idpf_ctlq_info *cq,\n \t\t u16 num_q_msg, struct idpf_ctlq_msg q_msg[])\ndiff --git a/drivers/common/idpf/base/idpf_controlq_api.h b/drivers/common/idpf/base/idpf_controlq_api.h\nindex 32d17baadf..80be282b42 100644\n--- a/drivers/common/idpf/base/idpf_controlq_api.h\n+++ b/drivers/common/idpf/base/idpf_controlq_api.h\n@@ -63,9 +63,13 @@ struct idpf_ctlq_msg {\n \t\tu16 status;\t/* when receiving a message */\n \t};\n \tunion {\n+#ifndef __KERNEL__\n+#define FILL_OPCODE_V1(msg, opcode) ((msg).cookie.cfg.mbx.chnl_opcode = opcode)\n+#define FILL_RETVAL_V1(msg, retval) ((msg).cookie.cfg.mbx.chnl_retval = retval)\n+#endif /* __KERNEL__ */\n \t\tstruct {\n-\t\t\tu32 chnl_retval;\n \t\t\tu32 chnl_opcode;\n+\t\t\tu32 chnl_retval;\n \t\t} mbx;\n \t} cookie;\n \tunion {\n", "prefixes": [ "08/18" ] }