Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126431/?format=api
{ "id": 126431, "url": "http://patchwork.dpdk.org/api/patches/126431/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230423051403.31971-4-syalavarthi@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230423051403.31971-4-syalavarthi@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230423051403.31971-4-syalavarthi@marvell.com", "date": "2023-04-23T05:14:01", "name": "[v1,3/5] mldev: implement xstats library functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6b710e640c50e60aa989c661e58922b1dad6db11", "submitter": { "id": 2480, "url": "http://patchwork.dpdk.org/api/people/2480/?format=api", "name": "Srikanth Yalavarthi", "email": "syalavarthi@marvell.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230423051403.31971-4-syalavarthi@marvell.com/mbox/", "series": [ { "id": 27830, "url": "http://patchwork.dpdk.org/api/series/27830/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=27830", "date": "2023-04-23T05:13:58", "name": "Implementation of revised ML xstats spec", "version": 1, "mbox": "http://patchwork.dpdk.org/series/27830/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/126431/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/126431/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B247A429BA;\n\tSun, 23 Apr 2023 07:14:28 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 965D042D2C;\n\tSun, 23 Apr 2023 07:14:14 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 6A1C540156\n for <dev@dpdk.org>; Sun, 23 Apr 2023 07:14:12 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 33N4pXa7019841 for <dev@dpdk.org>; Sat, 22 Apr 2023 22:14:11 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3q4egjjvd5-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Sat, 22 Apr 2023 22:14:11 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Sat, 22 Apr 2023 22:14:09 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Sat, 22 Apr 2023 22:14:09 -0700", "from ml-host-33.caveonetworks.com (unknown [10.110.143.233])\n by maili.marvell.com (Postfix) with ESMTP id 65A873F706A;\n Sat, 22 Apr 2023 22:14:09 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=/t3aGAy/hXbBg8yoRTJhDNkP2rsWThu4QwVzWsvgFRQ=;\n b=ipZO/wXDgaxeDa22XCQQUL8A975uuwJSHLi7T4ptGzIuNWCLlkeFBfsAZBsDMgJsf1+7\n wyLNTwjEGmdhs8trfDHdlNgJHRWrIL9kGvZ0ph19riBLJ250i2je04Z65lAJscbZZNry\n k+0jXrpzQeIDswiev4Bt+eJByR1MT6t42TK5v1s0Cpc51Iu1G6fueXV5vo9iDOTae75X\n CxjtTgG6aNs2LgVcek6jxZQrktIvTf45ylBt2+ZIcNtv91SLr0PNlwIrcE5FFWkrUPrY\n QM4lqEGI0znQv50466OH6DNv/hyPRdf19MXTzTHKbwCYLPAnVvQgERuI9fqbtyZ8T5DU qA==", "From": "Srikanth Yalavarthi <syalavarthi@marvell.com>", "To": "Srikanth Yalavarthi <syalavarthi@marvell.com>", "CC": "<dev@dpdk.org>, <sshankarnara@marvell.com>, <aprabhu@marvell.com>,\n <ptakkar@marvell.com>", "Subject": "[PATCH v1 3/5] mldev: implement xstats library functions", "Date": "Sat, 22 Apr 2023 22:14:01 -0700", "Message-ID": "<20230423051403.31971-4-syalavarthi@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20230423051403.31971-1-syalavarthi@marvell.com>", "References": "<20230423051403.31971-1-syalavarthi@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "hdGPQRjGnt8WgPAyt1lm1wvmMImpfXYG", "X-Proofpoint-GUID": "hdGPQRjGnt8WgPAyt1lm1wvmMImpfXYG", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22\n definitions=2023-04-23_02,2023-04-21_01,2023-02-09_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Implemented xstats library functions as per revised spec.\n\nSigned-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>\n---\n lib/mldev/rte_mldev.c | 91 +++++++++++++++++++++++++++++++\n lib/mldev/rte_mldev_core.h | 107 +++++++++++++++++++++++++++++++++++++\n lib/mldev/version.map | 4 ++\n 3 files changed, 202 insertions(+)", "diff": "diff --git a/lib/mldev/rte_mldev.c b/lib/mldev/rte_mldev.c\nindex 72d4d7a165..0d8ccd3212 100644\n--- a/lib/mldev/rte_mldev.c\n+++ b/lib/mldev/rte_mldev.c\n@@ -438,6 +438,97 @@ rte_ml_dev_stats_reset(int16_t dev_id)\n \t(*dev->dev_ops->dev_stats_reset)(dev);\n }\n \n+int\n+rte_ml_dev_xstats_names_get(int16_t dev_id, enum rte_ml_dev_xstats_mode mode, int32_t model_id,\n+\t\t\t struct rte_ml_dev_xstats_map *xstats_map, uint32_t size)\n+{\n+\tstruct rte_ml_dev *dev;\n+\n+\tif (!rte_ml_dev_is_valid_dev(dev_id)) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Invalid dev_id = %d\\n\", dev_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tdev = rte_ml_dev_pmd_get_dev(dev_id);\n+\tif (*dev->dev_ops->dev_xstats_names_get == NULL)\n+\t\treturn -ENOTSUP;\n+\n+\treturn (*dev->dev_ops->dev_xstats_names_get)(dev, mode, model_id, xstats_map, size);\n+}\n+\n+int\n+rte_ml_dev_xstats_by_name_get(int16_t dev_id, const char *name, uint16_t *stat_id, uint64_t *value)\n+{\n+\tstruct rte_ml_dev *dev;\n+\n+\tif (!rte_ml_dev_is_valid_dev(dev_id)) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Invalid dev_id = %d\\n\", dev_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tdev = rte_ml_dev_pmd_get_dev(dev_id);\n+\tif (*dev->dev_ops->dev_xstats_by_name_get == NULL)\n+\t\treturn -ENOTSUP;\n+\n+\tif (name == NULL) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Dev %d, name cannot be NULL\\n\", dev_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (value == NULL) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Dev %d, value cannot be NULL\\n\", dev_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\treturn (*dev->dev_ops->dev_xstats_by_name_get)(dev, name, stat_id, value);\n+}\n+\n+int\n+rte_ml_dev_xstats_get(int16_t dev_id, enum rte_ml_dev_xstats_mode mode, int32_t model_id,\n+\t\t const uint16_t stat_ids[], uint64_t values[], uint16_t nb_ids)\n+{\n+\tstruct rte_ml_dev *dev;\n+\n+\tif (!rte_ml_dev_is_valid_dev(dev_id)) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Invalid dev_id = %d\\n\", dev_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tdev = rte_ml_dev_pmd_get_dev(dev_id);\n+\tif (*dev->dev_ops->dev_xstats_get == NULL)\n+\t\treturn -ENOTSUP;\n+\n+\tif (stat_ids == NULL) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Dev %d, stat_ids cannot be NULL\\n\", dev_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (values == NULL) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Dev %d, values cannot be NULL\\n\", dev_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\treturn (*dev->dev_ops->dev_xstats_get)(dev, mode, model_id, stat_ids, values, nb_ids);\n+}\n+\n+int\n+rte_ml_dev_xstats_reset(int16_t dev_id, enum rte_ml_dev_xstats_mode mode, int32_t model_id,\n+\t\t\tconst uint16_t stat_ids[], uint16_t nb_ids)\n+{\n+\tstruct rte_ml_dev *dev;\n+\n+\tif (!rte_ml_dev_is_valid_dev(dev_id)) {\n+\t\tRTE_MLDEV_LOG(ERR, \"Invalid dev_id = %d\\n\", dev_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tdev = rte_ml_dev_pmd_get_dev(dev_id);\n+\tif (*dev->dev_ops->dev_xstats_reset == NULL)\n+\t\treturn -ENOTSUP;\n+\n+\treturn (*dev->dev_ops->dev_xstats_reset)(dev, mode, model_id, stat_ids, nb_ids);\n+}\n+\n int\n rte_ml_dev_dump(int16_t dev_id, FILE *fd)\n {\ndiff --git a/lib/mldev/rte_mldev_core.h b/lib/mldev/rte_mldev_core.h\nindex 926a652397..78b8b7633d 100644\n--- a/lib/mldev/rte_mldev_core.h\n+++ b/lib/mldev/rte_mldev_core.h\n@@ -236,6 +236,101 @@ typedef int (*mldev_stats_get_t)(struct rte_ml_dev *dev, struct rte_ml_dev_stats\n */\n typedef void (*mldev_stats_reset_t)(struct rte_ml_dev *dev);\n \n+/**\n+ * @internal\n+ *\n+ * Function used to get names of extended stats.\n+ *\n+ * @param dev\n+ *\tML device pointer.\n+ * @param mode\n+ *\tMode of stats to retrieve.\n+ * @param model_id\n+ *\tUsed to specify model id in model mode. Ignored in device mode.\n+ * @param xstats_map\n+ *\tArray to insert id and names into.\n+ * @param size\n+ *\tSize of xstats_map array.\n+ *\n+ * @return\n+ *\t- >= 0 and <= size on success.\n+ *\t- > size, error. Returns the size of xstats_map array required.\n+ *\t- < 0, error code on failure.\n+ */\n+typedef int (*mldev_xstats_names_get_t)(struct rte_ml_dev *dev, enum rte_ml_dev_xstats_mode mode,\n+\t\t\t\t\tint32_t model_id, struct rte_ml_dev_xstats_map *xstats_map,\n+\t\t\t\t\tuint32_t size);\n+\n+/**\n+ * @internal\n+ *\n+ * Function used to get a single extended stat by name.\n+ *\n+ * @param dev\n+ *\tML device pointer.\n+ * @param name\n+ *\tName of the stat to retrieve.\n+ * @param stat_id\n+ *\tID of the stat to be returned.\n+ * @param value\n+ *\tValue of the stat to be returned.\n+ *\n+ * @return\n+ *\t- = 0 success.\n+ *\t- < 0, error code on failure.\n+ */\n+typedef int (*mldev_xstats_by_name_get_t)(struct rte_ml_dev *dev, const char *name,\n+\t\t\t\t\t uint16_t *stat_id, uint64_t *value);\n+\n+/**\n+ * @internal\n+ *\n+ * Function used to retrieve extended stats of a device.\n+ *\n+ * @param dev\n+ *\tML device pointer.\n+ * @param mode\n+ *\tMode of stats to retrieve.\n+ * @param model_id\n+ *\tUsed to specify model id in model mode. Ignored in device mode.\n+ * @param stat_ids\n+ *\tArray of ID numbers of the stats to be retrieved.\n+ * @param values\n+ *\tValues of the stats requested by the ID.\n+ * @param nb_ids\n+ *\tNumber of stats requested.\n+ *\n+ * @return\n+ *\t- >= 0, number of entries filled into the values array.\n+ *\t- < 0, error code on failure.\n+ */\n+typedef int (*mldev_xstats_get_t)(struct rte_ml_dev *dev, enum rte_ml_dev_xstats_mode mode,\n+\t\t\t\t int32_t model_id, const uint16_t stat_ids[], uint64_t values[],\n+\t\t\t\t uint16_t nb_ids);\n+\n+/**\n+ * @internal\n+ *\n+ * Function used to reset extended stats.\n+ *\n+ * @param dev\n+ *\tML device pointer.\n+ * @param mode\n+ *\tMode of stats to retrieve.\n+ * @param model_id\n+ *\tUsed to specify model id in model mode. Ignored in device mode.\n+ * @param stat_ids\n+ *\tArray of stats IDs to be reset.\n+ * @param nb_ids\n+ *\tNumber of IDs in the stat_ids array.\n+ *\n+ * @return\n+ *\t- 0 on success.\n+ *\t- < 0, error code on failure.\n+ */\n+typedef int (*mldev_xstats_reset_t)(struct rte_ml_dev *dev, enum rte_ml_dev_xstats_mode mode,\n+\t\t\t\t int32_t model_id, const uint16_t stat_ids[], uint16_t nb_ids);\n+\n /**\n * @internal\n *\n@@ -498,6 +593,18 @@ struct rte_ml_dev_ops {\n \t/** Reset device statistics. */\n \tmldev_stats_reset_t dev_stats_reset;\n \n+\t/** Get names of extended stats. */\n+\tmldev_xstats_names_get_t dev_xstats_names_get;\n+\n+\t/** Get value of a single extended stat. */\n+\tmldev_xstats_by_name_get_t dev_xstats_by_name_get;\n+\n+\t/** Get extended stats of a device. */\n+\tmldev_xstats_get_t dev_xstats_get;\n+\n+\t/** Reset extended stats of the device. */\n+\tmldev_xstats_reset_t dev_xstats_reset;\n+\n \t/** Dump ML device debug info. */\n \tmldev_dump_t dev_dump;\n \ndiff --git a/lib/mldev/version.map b/lib/mldev/version.map\nindex c774a87a5e..0706b565be 100644\n--- a/lib/mldev/version.map\n+++ b/lib/mldev/version.map\n@@ -17,6 +17,10 @@ EXPERIMENTAL {\n \trte_ml_dev_stats_get;\n \trte_ml_dev_stats_reset;\n \trte_ml_dev_stop;\n+\trte_ml_dev_xstats_by_name_get;\n+\trte_ml_dev_xstats_get;\n+\trte_ml_dev_xstats_names_get;\n+\trte_ml_dev_xstats_reset;\n \trte_ml_enqueue_burst;\n \trte_ml_io_dequantize;\n \trte_ml_io_input_size_get;\n", "prefixes": [ "v1", "3/5" ] }