Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126455/?format=api
{ "id": 126455, "url": "http://patchwork.dpdk.org/api/patches/126455/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230424091707.488045-8-wenjing.qiao@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230424091707.488045-8-wenjing.qiao@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230424091707.488045-8-wenjing.qiao@intel.com", "date": "2023-04-24T09:17:07", "name": "[v3,7/7] net/idpf: register timestamp mbuf when starting dev", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "a7ffaa5d5f66d9c9de7469859342b73064a86c73", "submitter": { "id": 2680, "url": "http://patchwork.dpdk.org/api/people/2680/?format=api", "name": "Wenjing Qiao", "email": "wenjing.qiao@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230424091707.488045-8-wenjing.qiao@intel.com/mbox/", "series": [ { "id": 27841, "url": "http://patchwork.dpdk.org/api/series/27841/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=27841", "date": "2023-04-24T09:17:00", "name": "fix and enhance idpf and cpfl timestamp", "version": 3, "mbox": "http://patchwork.dpdk.org/series/27841/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/126455/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/126455/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 83345429D9;\n\tMon, 24 Apr 2023 11:23:40 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DEE4742D3F;\n\tMon, 24 Apr 2023 11:23:07 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id B9DC842D4D;\n Mon, 24 Apr 2023 11:23:05 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Apr 2023 02:23:05 -0700", "from dpdk-wenjing-01.sh.intel.com ([10.67.118.239])\n by fmsmga001.fm.intel.com with ESMTP; 24 Apr 2023 02:23:03 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1682328186; x=1713864186;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=DLebQUkHpK4cO26Q3/63+/WSbu7fIKWWQZSDJZpc8MU=;\n b=Wuesw2RHMrK75ByHvBtlSZLPU53M0q8SDby7/OE4T/GGsQ6qk5kd46Xf\n VAfFW6ik2chzhDFpUGKCC3oboro60XehAHGlv3oMAw29H0Wr18rcE5w1Q\n tKYsYpL8c82/33kS27u9Kco2kH82/LeQ31PWIVUdwdzhxYX8JeRztnbGj\n BXqIECTZ+aWO19Y3EsM+zVS0CmpxWr43PN+ppF4jCv+mMDIedxFTyxUA4\n 7zlrX+ffwLDOnv2xRfmHw8KaA6c8ZUefPh243Sawez2+Is7ofpKCllc3F\n h/i/EDTxEHmPfAYF9huyBkrFsX4KppO5ojORcYcXdOL5JodITZLxR7B2+ Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10689\"; a=\"411680103\"", "E=Sophos;i=\"5.99,222,1677571200\"; d=\"scan'208\";a=\"411680103\"", "E=McAfee;i=\"6600,9927,10689\"; a=\"836895210\"", "E=Sophos;i=\"5.99,222,1677571200\"; d=\"scan'208\";a=\"836895210\"" ], "X-ExtLoop1": "1", "From": "Wenjing Qiao <wenjing.qiao@intel.com>", "To": "jingjing.wu@intel.com,\n\tbeilei.xing@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "dev@dpdk.org, mingxia.liu@intel.com,\n Wenjing Qiao <wenjing.qiao@intel.com>,\n stable@dpdk.org", "Subject": "[PATCH v3 7/7] net/idpf: register timestamp mbuf when starting dev", "Date": "Mon, 24 Apr 2023 05:17:07 -0400", "Message-Id": "<20230424091707.488045-8-wenjing.qiao@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230424091707.488045-1-wenjing.qiao@intel.com>", "References": "<20230421071603.55680-2-wenjing.qiao@intel.com>\n <20230424091707.488045-1-wenjing.qiao@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Due to only support timestamp at port level, registering\ntimestamp mbuf should be at dev start stage.\n\nFixes: 8c6098afa075 (\"common/idpf: add Rx/Tx data path\")\nCc: stable@dpdk.org\n\nSigned-off-by: Wenjing Qiao <wenjing.qiao@intel.com>\nSuggested-by: Jingjing Wu <jingjing.wu@intel.com>\n---\n drivers/net/idpf/idpf_ethdev.c | 7 +++++++\n drivers/net/idpf/idpf_ethdev.h | 3 +++\n drivers/net/idpf/idpf_rxtx.c | 3 +++\n 3 files changed, 13 insertions(+)", "diff": "diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c\nindex 3f33ffbc78..7c43f51c25 100644\n--- a/drivers/net/idpf/idpf_ethdev.c\n+++ b/drivers/net/idpf/idpf_ethdev.c\n@@ -765,6 +765,13 @@ idpf_dev_start(struct rte_eth_dev *dev)\n \t\trte_eal_alarm_set(1000 * 1000,\n \t\t\t\t &idpf_dev_read_time_hw,\n \t\t\t\t (void *)base);\n+\t\t/* Register mbuf field and flag for Rx timestamp */\n+\t\tret = rte_mbuf_dyn_rx_timestamp_register(&idpf_timestamp_dynfield_offset,\n+\t\t\t\t\t\t\t &idpf_timestamp_dynflag);\n+\t\tif (ret != 0) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Cannot register mbuf field/flag for timestamp\");\n+\t\t\treturn -EINVAL;\n+\t\t}\n \t}\n \n \tret = idpf_vc_vectors_alloc(vport, req_vecs_num);\ndiff --git a/drivers/net/idpf/idpf_ethdev.h b/drivers/net/idpf/idpf_ethdev.h\nindex 3c2c932438..256e348710 100644\n--- a/drivers/net/idpf/idpf_ethdev.h\n+++ b/drivers/net/idpf/idpf_ethdev.h\n@@ -55,6 +55,9 @@\n \n #define IDPF_ALARM_INTERVAL\t50000 /* us */\n \n+extern int idpf_timestamp_dynfield_offset;\n+extern uint64_t idpf_timestamp_dynflag;\n+\n struct idpf_vport_param {\n \tstruct idpf_adapter_ext *adapter;\n \tuint16_t devarg_id; /* arg id from user */\ndiff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_rxtx.c\nindex 414f9a37f6..1aaf0142d2 100644\n--- a/drivers/net/idpf/idpf_rxtx.c\n+++ b/drivers/net/idpf/idpf_rxtx.c\n@@ -529,6 +529,9 @@ idpf_rx_queue_init(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \t frame_size > rxq->rx_buf_len)\n \t\tdev->data->scattered_rx = 1;\n \n+\tif (dev->data->dev_conf.rxmode.offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP)\n+\t\trxq->ts_enable = TRUE;\n+\n \terr = idpf_qc_ts_mbuf_register(rxq);\n \tif (err != 0) {\n \t\tPMD_DRV_LOG(ERR, \"fail to residter timestamp mbuf %u\",\n", "prefixes": [ "v3", "7/7" ] }