Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126494/?format=api
{ "id": 126494, "url": "http://patchwork.dpdk.org/api/patches/126494/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230424152412.3784016-2-arnaud.fiorini@polymtl.ca/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230424152412.3784016-2-arnaud.fiorini@polymtl.ca>", "list_archive_url": "https://inbox.dpdk.org/dev/20230424152412.3784016-2-arnaud.fiorini@polymtl.ca", "date": "2023-04-24T15:24:12", "name": "[1/1] eal: add tracepoints to track lcores and services", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f8516e4f7f50f0649e10504543f8aff575d7f2d4", "submitter": { "id": 3052, "url": "http://patchwork.dpdk.org/api/people/3052/?format=api", "name": "Arnaud Fiorini", "email": "arnaud.fiorini@polymtl.ca" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230424152412.3784016-2-arnaud.fiorini@polymtl.ca/mbox/", "series": [ { "id": 27852, "url": "http://patchwork.dpdk.org/api/series/27852/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=27852", "date": "2023-04-24T15:24:11", "name": "eal: add tracepoints to track lcores and services", "version": 1, "mbox": "http://patchwork.dpdk.org/series/27852/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/126494/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/126494/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 38830429DC;\n\tMon, 24 Apr 2023 17:24:23 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EBABE410EC;\n\tMon, 24 Apr 2023 17:24:22 +0200 (CEST)", "from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11])\n by mails.dpdk.org (Postfix) with ESMTP id 9E57840DF8\n for <dev@dpdk.org>; Mon, 24 Apr 2023 17:24:21 +0200 (CEST)", "from octosquare.dorsal.polymtl.ca (octosquare.dorsal.polymtl.ca\n [132.207.72.20]) (authenticated bits=0)\n by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 33OFOD9X022604\n (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Mon, 24 Apr 2023 11:24:19 -0400" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 smtp.polymtl.ca 33OFOD9X022604", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca;\n s=default; t=1682349860;\n bh=t8etHidE8UJWl5JMnD2QvNMY/B1f5X+pXAa+24OgWxU=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=pDwqvGIkP0Giy7u24nnW63ke74YdMh/RWTp9FGe7SCGg1UWJLpOc2fH9IYDQNILNA\n 3Vt06YFykHkTZQC5GpO4mO8rY5vKGzYM1BBTUjhG4dlajcD7kQ9lAyWkX7U5ImYNkp\n Ude5KiEMc3/h/f+p++CVmKmlIOoO95g5pTc4mB9c=", "From": "Arnaud Fiorini <arnaud.fiorini@polymtl.ca>", "To": "Thomas Monjalon <thomas@monjalon.net>, Jerin Jacob <jerinj@marvell.com>,\n Sunil Kumar Kori <skori@marvell.com>,\n Harry van Haaren <harry.van.haaren@intel.com>", "Cc": "dev@dpdk.org, Arnaud Fiorini <arnaud.fiorini@polymtl.ca>", "Subject": "[PATCH 1/1] eal: add tracepoints to track lcores and services", "Date": "Mon, 24 Apr 2023 15:24:12 +0000", "Message-Id": "<20230424152412.3784016-2-arnaud.fiorini@polymtl.ca>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230424152412.3784016-1-arnaud.fiorini@polymtl.ca>", "References": "<20230424152412.3784016-1-arnaud.fiorini@polymtl.ca>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Poly-FromMTA": "(octosquare.dorsal.polymtl.ca [132.207.72.20]) at Mon,\n 24 Apr 2023 15:24:13 +0000", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The tracepoints added are used to track lcore role and status,\nas well as service mapping and service runstates. These\ntracepoints are then used in analyses in Trace Compass.\n\nSigned-off-by: Arnaud Fiorini <arnaud.fiorini@polymtl.ca>\n---\n .mailmap | 1 +\n lib/eal/common/eal_common_thread.c | 4 ++\n lib/eal/common/eal_common_trace_points.c | 21 +++++++++\n lib/eal/common/rte_service.c | 18 ++++++-\n lib/eal/include/eal_trace_internal.h | 60 ++++++++++++++++++++++++\n 5 files changed, 103 insertions(+), 1 deletion(-)", "diff": "diff --git a/.mailmap b/.mailmap\nindex dc30369117..2a0b132572 100644\n--- a/.mailmap\n+++ b/.mailmap\n@@ -120,6 +120,7 @@ Archana Muniganti <marchana@marvell.com> <muniganti.archana@caviumnetworks.com>\n Archit Pandey <architpandeynitk@gmail.com>\n Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>\n Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>\n+Arnaud Fiorini <arnaud.fiorini@polymtl.ca>\n Arnon Warshavsky <arnon@qwilt.com>\n Arshdeep Kaur <arshdeep.kaur@intel.com>\n Artem V. Andreev <artem.andreev@oktetlabs.ru>\ndiff --git a/lib/eal/common/eal_common_thread.c b/lib/eal/common/eal_common_thread.c\nindex 079a385630..25dbdd68e3 100644\n--- a/lib/eal/common/eal_common_thread.c\n+++ b/lib/eal/common/eal_common_thread.c\n@@ -205,6 +205,8 @@ eal_thread_loop(void *arg)\n \t\t\t\t__ATOMIC_ACQUIRE)) == NULL)\n \t\t\trte_pause();\n \n+\t\trte_eal_trace_thread_lcore_running(lcore_id, f);\n+\n \t\t/* call the function and store the return value */\n \t\tfct_arg = lcore_config[lcore_id].arg;\n \t\tret = f(fct_arg);\n@@ -219,6 +221,8 @@ eal_thread_loop(void *arg)\n \t\t */\n \t\t__atomic_store_n(&lcore_config[lcore_id].state, WAIT,\n \t\t\t__ATOMIC_RELEASE);\n+\n+\t\trte_eal_trace_thread_lcore_stopped(lcore_id);\n \t}\n \n \t/* never reached */\ndiff --git a/lib/eal/common/eal_common_trace_points.c b/lib/eal/common/eal_common_trace_points.c\nindex 3f5bf5c55c..0f1240ea3a 100644\n--- a/lib/eal/common/eal_common_trace_points.c\n+++ b/lib/eal/common/eal_common_trace_points.c\n@@ -70,6 +70,27 @@ RTE_TRACE_POINT_REGISTER(rte_eal_trace_thread_remote_launch,\n \tlib.eal.thread.remote.launch)\n RTE_TRACE_POINT_REGISTER(rte_eal_trace_thread_lcore_ready,\n \tlib.eal.thread.lcore.ready)\n+RTE_TRACE_POINT_REGISTER(rte_eal_trace_thread_lcore_running,\n+\tlib.eal.thread.lcore.running)\n+RTE_TRACE_POINT_REGISTER(rte_eal_trace_thread_lcore_stopped,\n+\tlib.eal.thread.lcore.stopped)\n+\n+RTE_TRACE_POINT_REGISTER(rte_eal_trace_service_map_lcore,\n+\tlib.eal.service.map.lcore)\n+RTE_TRACE_POINT_REGISTER(rte_eal_trace_service_lcore_state_change,\n+\tlib.eal.service.lcore.state.change)\n+RTE_TRACE_POINT_REGISTER(rte_eal_trace_service_lcore_start,\n+\tlib.eal.service.lcore.start)\n+RTE_TRACE_POINT_REGISTER(rte_eal_trace_service_lcore_stop,\n+\tlib.eal.service.lcore.stop)\n+RTE_TRACE_POINT_REGISTER(rte_eal_trace_service_run_begin,\n+\tlib.eal.service.run.begin)\n+RTE_TRACE_POINT_REGISTER(rte_eal_trace_service_runstate_set,\n+\tlib.eal.service.run.state.set)\n+RTE_TRACE_POINT_REGISTER(rte_eal_trace_service_run_end,\n+\tlib.eal.service.run.end)\n+RTE_TRACE_POINT_REGISTER(rte_eal_trace_service_component_register,\n+\tlib.eal.service.component.register)\n \n RTE_TRACE_POINT_REGISTER(rte_eal_trace_intr_callback_register,\n \tlib.eal.intr.register)\ndiff --git a/lib/eal/common/rte_service.c b/lib/eal/common/rte_service.c\nindex 42ca1d001d..5daec007aa 100644\n--- a/lib/eal/common/rte_service.c\n+++ b/lib/eal/common/rte_service.c\n@@ -9,6 +9,7 @@\n #include <rte_service.h>\n #include <rte_service_component.h>\n \n+#include <eal_trace_internal.h>\n #include <rte_lcore.h>\n #include <rte_branch_prediction.h>\n #include <rte_common.h>\n@@ -16,6 +17,7 @@\n #include <rte_atomic.h>\n #include <rte_malloc.h>\n #include <rte_spinlock.h>\n+#include <rte_trace_point.h>\n \n #include \"eal_private.h\"\n \n@@ -276,6 +278,8 @@ rte_service_component_register(const struct rte_service_spec *spec,\n \tif (id_ptr)\n \t\t*id_ptr = free_slot;\n \n+\trte_eal_trace_service_component_register(free_slot, spec->name);\n+\n \treturn 0;\n }\n \n@@ -336,6 +340,7 @@ rte_service_runstate_set(uint32_t id, uint32_t runstate)\n \t\t__atomic_store_n(&s->app_runstate, RUNSTATE_STOPPED,\n \t\t\t__ATOMIC_RELEASE);\n \n+\trte_eal_trace_service_runstate_set(id, runstate);\n \treturn 0;\n }\n \n@@ -427,11 +432,15 @@ service_run(uint32_t i, struct core_state *cs, uint64_t service_mask,\n \t\tif (!rte_spinlock_trylock(&s->execute_lock))\n \t\t\treturn -EBUSY;\n \n+\t\trte_eal_trace_service_run_begin(i, rte_lcore_id());\n \t\tservice_runner_do_callback(s, cs, i);\n \t\trte_spinlock_unlock(&s->execute_lock);\n-\t} else\n+\t} else {\n+\t\trte_eal_trace_service_run_begin(i, rte_lcore_id());\n \t\tservice_runner_do_callback(s, cs, i);\n+\t}\n \n+\trte_eal_trace_service_run_end(i, rte_lcore_id());\n \treturn 0;\n }\n \n@@ -658,6 +667,7 @@ int32_t\n rte_service_map_lcore_set(uint32_t id, uint32_t lcore, uint32_t enabled)\n {\n \tuint32_t on = enabled > 0;\n+\trte_eal_trace_service_map_lcore(id, lcore, enabled);\n \treturn service_update(id, lcore, &on, 0);\n }\n \n@@ -683,6 +693,8 @@ set_lcore_state(uint32_t lcore, int32_t state)\n \n \t/* update per-lcore optimized state tracking */\n \tlcore_states[lcore].is_service_core = (state == ROLE_SERVICE);\n+\n+\trte_eal_trace_service_lcore_state_change(lcore, state);\n }\n \n int32_t\n@@ -780,6 +792,8 @@ rte_service_lcore_start(uint32_t lcore)\n \t */\n \t__atomic_store_n(&cs->runstate, RUNSTATE_RUNNING, __ATOMIC_RELEASE);\n \n+\trte_eal_trace_service_lcore_start(lcore);\n+\n \tint ret = rte_eal_remote_launch(service_runner_func, 0, lcore);\n \t/* returns -EBUSY if the core is already launched, 0 on success */\n \treturn ret;\n@@ -824,6 +838,8 @@ rte_service_lcore_stop(uint32_t lcore)\n \t__atomic_store_n(&lcore_states[lcore].runstate, RUNSTATE_STOPPED,\n \t\t__ATOMIC_RELEASE);\n \n+\trte_eal_trace_service_lcore_stop(lcore);\n+\n \treturn 0;\n }\n \ndiff --git a/lib/eal/include/eal_trace_internal.h b/lib/eal/include/eal_trace_internal.h\nindex 57d6de2535..9a37a08567 100644\n--- a/lib/eal/include/eal_trace_internal.h\n+++ b/lib/eal/include/eal_trace_internal.h\n@@ -174,6 +174,66 @@ RTE_TRACE_POINT(\n \trte_trace_point_emit_u32(lcore_id);\n \trte_trace_point_emit_string(cpuset);\n )\n+RTE_TRACE_POINT_FP(\n+\trte_eal_trace_thread_lcore_running,\n+\tRTE_TRACE_POINT_ARGS(unsigned int lcore_id, void *f),\n+\trte_trace_point_emit_u32(lcore_id);\n+\trte_trace_point_emit_ptr(f);\n+)\n+RTE_TRACE_POINT_FP(\n+\trte_eal_trace_thread_lcore_stopped,\n+\tRTE_TRACE_POINT_ARGS(unsigned int lcore_id),\n+\trte_trace_point_emit_u32(lcore_id);\n+)\n+\n+/* Service */\n+RTE_TRACE_POINT(\n+\trte_eal_trace_service_map_lcore,\n+\tRTE_TRACE_POINT_ARGS(unsigned int id, unsigned int lcore_id, unsigned int enabled),\n+\trte_trace_point_emit_u32(id);\n+\trte_trace_point_emit_u32(lcore_id);\n+\trte_trace_point_emit_u32(enabled);\n+)\n+RTE_TRACE_POINT(\n+\trte_eal_trace_service_lcore_state_change,\n+\tRTE_TRACE_POINT_ARGS(unsigned int lcore_id, int lcore_state),\n+\trte_trace_point_emit_u32(lcore_id);\n+\trte_trace_point_emit_i32(lcore_state);\n+)\n+RTE_TRACE_POINT(\n+\trte_eal_trace_service_lcore_start,\n+\tRTE_TRACE_POINT_ARGS(unsigned int lcore_id),\n+\trte_trace_point_emit_u32(lcore_id);\n+)\n+RTE_TRACE_POINT(\n+\trte_eal_trace_service_lcore_stop,\n+\tRTE_TRACE_POINT_ARGS(unsigned int lcore_id),\n+\trte_trace_point_emit_u32(lcore_id);\n+)\n+RTE_TRACE_POINT_FP(\n+\trte_eal_trace_service_run_begin,\n+\tRTE_TRACE_POINT_ARGS(unsigned int id, unsigned int lcore_id),\n+\trte_trace_point_emit_u32(id);\n+\trte_trace_point_emit_u32(lcore_id);\n+)\n+RTE_TRACE_POINT(\n+\trte_eal_trace_service_runstate_set,\n+\tRTE_TRACE_POINT_ARGS(unsigned int id, unsigned int run_state),\n+\trte_trace_point_emit_u32(id);\n+\trte_trace_point_emit_u32(run_state);\n+)\n+RTE_TRACE_POINT(\n+\trte_eal_trace_service_run_end,\n+\tRTE_TRACE_POINT_ARGS(unsigned int id, unsigned int lcore_id),\n+\trte_trace_point_emit_u32(id);\n+\trte_trace_point_emit_u32(lcore_id);\n+)\n+RTE_TRACE_POINT(\n+\trte_eal_trace_service_component_register,\n+\tRTE_TRACE_POINT_ARGS(int id, const char *service_name),\n+\trte_trace_point_emit_i32(id);\n+\trte_trace_point_emit_string(service_name);\n+)\n \n #ifdef __cplusplus\n }\n", "prefixes": [ "1/1" ] }