Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126662/?format=api
{ "id": 126662, "url": "http://patchwork.dpdk.org/api/patches/126662/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230502135045.3541570-2-jerinj@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230502135045.3541570-2-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230502135045.3541570-2-jerinj@marvell.com", "date": "2023-05-02T13:50:45", "name": "[v1] examples/ntb: fix build issue with GCC 13", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b1e93a16c38acc4f82a1c52a9222d2ca9203937f", "submitter": { "id": 1188, "url": "http://patchwork.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230502135045.3541570-2-jerinj@marvell.com/mbox/", "series": [ { "id": 27911, "url": "http://patchwork.dpdk.org/api/series/27911/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=27911", "date": "2023-05-02T13:50:45", "name": "[v1] examples/ntb: fix build issue with GCC 13", "version": 1, "mbox": "http://patchwork.dpdk.org/series/27911/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/126662/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/126662/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 40A5242A2F;\n\tTue, 2 May 2023 15:51:03 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CD20042C76;\n\tTue, 2 May 2023 15:51:02 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 7F44140ED8;\n Tue, 2 May 2023 15:51:01 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 342CVYhV026341; Tue, 2 May 2023 06:51:00 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3qavhehkee-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 02 May 2023 06:51:00 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Tue, 2 May 2023 06:50:58 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Tue, 2 May 2023 06:50:58 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id AC5A33F7040;\n Tue, 2 May 2023 06:50:55 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=xnv0SJdWJ6SFQioyFbMD8pb+N1FP1NXERiTSKc+iyfI=;\n b=ZxnE6W1dT+H6PGBpSQyBXBUOK+SeNblxSI0/Ulk4QTnAqze4y+KXWh5Vr01z3DTCkiFg\n 9Q30PhBmtF7lTzvTO9uO/B7oUps055wiPgmES4TxGVJV/bIUiTPS+i5fTpJtOeF6Ibmi\n ple0U0ZoMcVj1PHBNrwEX89L/oX9+T3L86acROjkTUr1zjF6exlmAldqIVgaxbE5DsUd\n n4e+m+rqex7CAMOpu97PPGaaTVxdMHTMPCg5g6YTclPVGEBGvtpTqgzF9esj+Fz2grpO\n CGHsnGdqIsmbC5RE+iafP6Ti1wG6UHldm/zYIszwRcLHDMaiA5CZnbnmtHUAEtXrQUPP ZA==", "From": "<jerinj@marvell.com>", "To": "<dev@dpdk.org>, Jingjing Wu <jingjing.wu@intel.com>, Junfeng Guo\n <junfeng.guo@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>", "CC": "<thomas@monjalon.net>, <david.marchand@redhat.com>,\n <ferruh.yigit@xilinx.com>, <stephen@networkplumber.org>, Jerin Jacob\n <jerinj@marvell.com>, <stable@dpdk.org>", "Subject": "[dpdk-dev] [PATCH v1] examples/ntb: fix build issue with GCC 13", "Date": "Tue, 2 May 2023 19:20:45 +0530", "Message-ID": "<20230502135045.3541570-2-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.40.1", "In-Reply-To": "<20230502135045.3541570-1-jerinj@marvell.com>", "References": "<20230502135045.3541570-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "FmxX7rlceumkt5IC1myW6fwSr1K3kgZQ", "X-Proofpoint-GUID": "FmxX7rlceumkt5IC1myW6fwSr1K3kgZQ", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22\n definitions=2023-05-02_08,2023-04-27_01,2023-02-09_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nFix the following build issue by not allowing nb_ids to be zero.\nnb_ids can be zero based on rte_rawdev_xstats_get() API\ndocumentation but it is not valid for the case when second\nargument is NULL.\n\nexamples/ntb/ntb_fwd.c: In function 'ntb_stats_display':\nexamples/ntb/ntb_fwd.c:945:23: error: 'rte_rawdev_xstats_get'\naccessing 8 bytes in a region of size 0 [-Werror=stringop-overflow=]\n 945 | if (nb_ids != rte_rawdev_xstats_get(dev_id, ids, values, nb_ids)) {\n | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nexamples/ntb/ntb_fwd.c:945:23: note: referencing argument 3\nof type 'uint64_t[0]' {aka 'long unsigned int[]'}\nIn file included from ../examples/ntb/ntb_fwd.c:17:\nlib/rawdev/rte_rawdev.h:504:1: note: in a call to function\n'rte_rawdev_xstats_get'\n 504 | rte_rawdev_xstats_get(uint16_t dev_id,\n\nFixes: 5194299d6ef5 (\"examples/ntb: support more functions\")\nCc: stable@dpdk.org\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\n---\n examples/ntb/ntb_fwd.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c\nindex f9abed28e4..5489c3b3cd 100644\n--- a/examples/ntb/ntb_fwd.c\n+++ b/examples/ntb/ntb_fwd.c\n@@ -923,7 +923,7 @@ ntb_stats_display(void)\n \n \t/* Get NTB dev stats and stats names */\n \tnb_ids = rte_rawdev_xstats_names_get(dev_id, NULL, 0);\n-\tif (nb_ids < 0) {\n+\tif (nb_ids <= 0) {\n \t\tprintf(\"Error: Cannot get count of xstats\\n\");\n \t\treturn;\n \t}\n", "prefixes": [ "v1" ] }