Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126733/?format=api
http://patchwork.dpdk.org/api/patches/126733/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230506160404.7423-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230506160404.7423-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230506160404.7423-5-stephen@networkplumber.org", "date": "2023-05-06T16:03:53", "name": "[v2,04/14] test: cryptodev use rte_pktmbuf_mtod_offset", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c3601f981abf3172ec1059e6fb90a793cb6001e3", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230506160404.7423-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 27946, "url": "http://patchwork.dpdk.org/api/series/27946/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=27946", "date": "2023-05-06T16:03:49", "name": "rte_pktmbuf_mtod_offset usage", "version": 2, "mbox": "http://patchwork.dpdk.org/series/27946/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/126733/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/126733/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4060042A7F;\n\tSat, 6 May 2023 18:04:40 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7F60442D41;\n\tSat, 6 May 2023 18:04:13 +0200 (CEST)", "from mail-pf1-f175.google.com (mail-pf1-f175.google.com\n [209.85.210.175])\n by mails.dpdk.org (Postfix) with ESMTP id 9839742D35\n for <dev@dpdk.org>; Sat, 6 May 2023 18:04:11 +0200 (CEST)", "by mail-pf1-f175.google.com with SMTP id\n d2e1a72fcca58-64388cf3263so2110846b3a.3\n for <dev@dpdk.org>; Sat, 06 May 2023 09:04:11 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n e14-20020a62ee0e000000b006436ffa3dc4sm3369890pfi.24.2023.05.06.09.04.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 06 May 2023 09:04:09 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1683389050;\n x=1685981050;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=obfMzlWi3rDn2TWW4nI66lcFKACyZD5u0VfdfRYEOtY=;\n b=b/YpGyWkGPJK0JNV+0mrMI/8mquTnJc5rS6S1ZcYk1IP0FnEZn6ELjaIeLW+aqjTwI\n MiabzY4i6XQeKBfV1CUHRd2pem8BZzZh1V/xrRN1+Su8EeniTOwys4MXJEHBfqW2M8hT\n 4NKRIG96P2n2S0X/cPiSTb5VHo/MX/wm+znQYbKvRK5BGxnEbLZfupnF+vUKGaQvou7G\n 05+9WY1AWovM+TH/MMwPoO5BLypHizlMFGpN/k7ovy+usHjkZSG6f+hg2VhS7XHQp/Nz\n fBrt+cUIZ0Y4V8YT+ROtOUQCDEyCRuCeuml7UYnvktNPIUrQYgIHwKsR78grJwRcw+NY\n 3R5Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1683389050; x=1685981050;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=obfMzlWi3rDn2TWW4nI66lcFKACyZD5u0VfdfRYEOtY=;\n b=LRs1f/E0AcP0LyKA3caV8Pca7sVyopjKFVMswlHKkHhF0NLK+0wv9mQOD88uK8IVuA\n DyAwUExrlXfGlYwqbRLMTYwRhenuhjqFSPNlM8S8tfgiTRzv3Mu07WMygVFc2qdwtCCz\n o+sgl7ogySlwI/t4QVlZhVGa20xqcf/LyZ1tN8lS2PeJz6qju1fBNhM1NzS1Q6unNbIm\n ie4f5EZhuu0agAJXKtozUdzB2C1xpBB1U1ecWAugx6UXh+wU/I1ssDqXtzPZHSzZEFJg\n msVZ8osSKXy54A85nT2v/gA2VryqKaFDfJpsYGhgVDYmuuXdYvt2lOIMWecjKqeTLEzu\n to4g==", "X-Gm-Message-State": "AC+VfDyJNLXSS8tBWM37ft8RAYJfGTudHDA6ah1bF3dfgEzoVq4nTQup\n HtYqGw2GjlBKGTbZSU/dtIhzDN5qB9rwK3fPV9AtKg==", "X-Google-Smtp-Source": "\n ACHHUZ6AueJVxwHeWmOvDm3DN3nSQaUnql1RAuFq132iROONeSYTKyu+WW5sQQTtwKXuLrNrLu84Zg==", "X-Received": "by 2002:a05:6a21:3296:b0:f5:9975:5044 with SMTP id\n yt22-20020a056a21329600b000f599755044mr6760884pzb.4.1683389050285;\n Sat, 06 May 2023 09:04:10 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Akhil Goyal <gakhil@marvell.com>, Fan Zhang <fanzhang.oss@gmail.com>", "Subject": "[PATCH v2 04/14] test: cryptodev use rte_pktmbuf_mtod_offset", "Date": "Sat, 6 May 2023 09:03:53 -0700", "Message-Id": "<20230506160404.7423-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230506160404.7423-1-stephen@networkplumber.org>", "References": "<20230505174813.133894-1-stephen@networkplumber.org>\n <20230506160404.7423-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Based off patch generated by cocci/mtod-offset.cocci.\nWith some cleanup to shorten lines by using conditional\nwith ommited operand.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test/test_cryptodev.c | 66 +++++++++++++++++++++------------------\n 1 file changed, 36 insertions(+), 30 deletions(-)", "diff": "diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c\nindex 9c670e9a3554..b4cddcd55f59 100644\n--- a/app/test/test_cryptodev.c\n+++ b/app/test/test_cryptodev.c\n@@ -3151,8 +3151,9 @@ test_snow3g_authentication(const struct snow3g_hash_test_data *tdata)\n \t\t\t\tut_params->op);\n \tut_params->obuf = ut_params->op->sym->m_src;\n \tTEST_ASSERT_NOT_NULL(ut_params->op, \"failed to retrieve obuf\");\n-\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t\t\t+ plaintext_pad_len;\n+\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t plaintext_pad_len);\n \n \t/* Validate obuf */\n \tTEST_ASSERT_BUFFERS_ARE_EQUAL(\n@@ -3243,8 +3244,9 @@ test_snow3g_authentication_verify(const struct snow3g_hash_test_data *tdata)\n \t\t\t\tut_params->op);\n \tTEST_ASSERT_NOT_NULL(ut_params->op, \"failed to retrieve obuf\");\n \tut_params->obuf = ut_params->op->sym->m_src;\n-\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t\t\t\t+ plaintext_pad_len;\n+\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t plaintext_pad_len);\n \n \t/* Validate obuf */\n \tif (ut_params->op->status == RTE_CRYPTO_OP_STATUS_SUCCESS)\n@@ -3331,8 +3333,9 @@ test_kasumi_authentication(const struct kasumi_hash_test_data *tdata)\n \n \tut_params->obuf = ut_params->op->sym->m_src;\n \tTEST_ASSERT_NOT_NULL(ut_params->op, \"failed to retrieve obuf\");\n-\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t\t\t+ plaintext_pad_len;\n+\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t plaintext_pad_len);\n \n \t/* Validate obuf */\n \tTEST_ASSERT_BUFFERS_ARE_EQUAL(\n@@ -3417,8 +3420,9 @@ test_kasumi_authentication_verify(const struct kasumi_hash_test_data *tdata)\n \t\t\t\tut_params->op);\n \tTEST_ASSERT_NOT_NULL(ut_params->op, \"failed to retrieve obuf\");\n \tut_params->obuf = ut_params->op->sym->m_src;\n-\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t\t\t\t+ plaintext_pad_len;\n+\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t plaintext_pad_len);\n \n \t/* Validate obuf */\n \tif (ut_params->op->status == RTE_CRYPTO_OP_STATUS_SUCCESS)\n@@ -4851,8 +4855,9 @@ test_zuc_cipher_auth(const struct wireless_test_data *tdata)\n \t\t\ttdata->validDataLenInBits.len,\n \t\t\t\"ZUC Ciphertext data not as expected\");\n \n-\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t + plaintext_pad_len;\n+\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t plaintext_pad_len);\n \n \t/* Validate obuf */\n \tTEST_ASSERT_BUFFERS_ARE_EQUAL(\n@@ -4963,8 +4968,9 @@ test_snow3g_cipher_auth(const struct snow3g_test_data *tdata)\n \t\t\ttdata->validDataLenInBits.len,\n \t\t\t\"SNOW 3G Ciphertext data not as expected\");\n \n-\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t + plaintext_pad_len;\n+\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t plaintext_pad_len);\n \n \t/* Validate obuf */\n \tTEST_ASSERT_BUFFERS_ARE_EQUAL(\n@@ -5129,9 +5135,9 @@ test_snow3g_auth_cipher(const struct snow3g_test_data *tdata,\n \t\tdebug_hexdump(stdout, \"ciphertext expected:\",\n \t\t\ttdata->ciphertext.data, tdata->ciphertext.len >> 3);\n \n-\t\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t\t\t+ (tdata->digest.offset_bytes == 0 ?\n-\t\tplaintext_pad_len : tdata->digest.offset_bytes);\n+\t\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\tuint8_t *,\n+\t\t\t\t\ttdata->digest.offset_bytes ? : plaintext_pad_len);\n \n \t\tdebug_hexdump(stdout, \"digest:\", ut_params->digest,\n \t\t\ttdata->digest.len);\n@@ -5537,10 +5543,9 @@ test_kasumi_auth_cipher(const struct kasumi_test_data *tdata,\n \t\tdebug_hexdump(stdout, \"ciphertext expected:\",\n \t\t\ttdata->ciphertext.data, tdata->ciphertext.len >> 3);\n \n-\t\tut_params->digest = rte_pktmbuf_mtod(\n-\t\t\tut_params->obuf, uint8_t *) +\n-\t\t\t(tdata->digest.offset_bytes == 0 ?\n-\t\t\tplaintext_pad_len : tdata->digest.offset_bytes);\n+\t\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\tuint8_t *,\n+\t\t\t\t\ttdata->digest.offset_bytes ? : plaintext_pad_len);\n \n \t\tdebug_hexdump(stdout, \"digest:\", ut_params->digest,\n \t\t\ttdata->digest.len);\n@@ -5878,8 +5883,9 @@ test_kasumi_cipher_auth(const struct kasumi_test_data *tdata)\n \tciphertext = rte_pktmbuf_mtod_offset(ut_params->obuf, uint8_t *,\n \t\t\t\ttdata->validCipherOffsetInBits.len >> 3);\n \n-\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t\t\t+ plaintext_pad_len;\n+\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t plaintext_pad_len);\n \n \tconst uint8_t *reference_ciphertext = tdata->ciphertext.data +\n \t\t\t\t(tdata->validCipherOffsetInBits.len >> 3);\n@@ -6292,8 +6298,9 @@ test_zuc_authentication(const struct wireless_test_data *tdata,\n \t\t\t\tut_params->op);\n \tTEST_ASSERT_NOT_NULL(ut_params->op, \"failed to retrieve obuf\");\n \tut_params->obuf = ut_params->op->sym->m_src;\n-\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t\t\t+ plaintext_pad_len;\n+\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\t\t uint8_t *,\n+\t\t\t\t\t\t plaintext_pad_len);\n \n \tif (auth_op != RTE_CRYPTO_AUTH_OP_VERIFY) {\n \t\t/* Validate obuf */\n@@ -6476,10 +6483,9 @@ test_zuc_auth_cipher(const struct wireless_test_data *tdata,\n \t\tdebug_hexdump(stdout, \"ciphertext expected:\",\n \t\t\ttdata->ciphertext.data, tdata->ciphertext.len >> 3);\n \n-\t\tut_params->digest = rte_pktmbuf_mtod(\n-\t\t\tut_params->obuf, uint8_t *) +\n-\t\t\t(tdata->digest.offset_bytes == 0 ?\n-\t\t\tplaintext_pad_len : tdata->digest.offset_bytes);\n+\t\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\tuint8_t *,\n+\t\t\t\t\ttdata->digest.offset_bytes ? : plaintext_pad_len);\n \n \t\tdebug_hexdump(stdout, \"digest:\", ut_params->digest,\n \t\t\ttdata->digest.len);\n@@ -7897,9 +7903,9 @@ test_mixed_auth_cipher(const struct mixed_cipher_auth_test_data *tdata,\n \t\t\t\ttdata->ciphertext.data,\n \t\t\t\ttdata->ciphertext.len_bits >> 3);\n \n-\t\tut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)\n-\t\t\t\t+ (tdata->digest_enc.offset == 0 ?\n-\t\tplaintext_pad_len : tdata->digest_enc.offset);\n+\t\tut_params->digest = rte_pktmbuf_mtod_offset(ut_params->obuf,\n+\t\t\t\t\tuint8_t *,\n+\t\t\t\t\ttdata->digest_enc.offset ? : plaintext_pad_len);\n \n \t\tdebug_hexdump(stdout, \"digest:\", ut_params->digest,\n \t\t\t\ttdata->digest_enc.len);\n", "prefixes": [ "v2", "04/14" ] }{ "id": 126733, "url": "