Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126882/?format=api
{ "id": 126882, "url": "http://patchwork.dpdk.org/api/patches/126882/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230516112548.6848-3-talshn@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230516112548.6848-3-talshn@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230516112548.6848-3-talshn@nvidia.com", "date": "2023-05-16T11:25:47", "name": "[v2,2/3] net/mlx5: support CQE compression on Windows", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b254b5bc6fa1072dc910deefbf7b3acb4f0c855d", "submitter": { "id": 1893, "url": "http://patchwork.dpdk.org/api/people/1893/?format=api", "name": "Tal Shnaiderman", "email": "talshn@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230516112548.6848-3-talshn@nvidia.com/mbox/", "series": [ { "id": 28008, "url": "http://patchwork.dpdk.org/api/series/28008/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28008", "date": "2023-05-16T11:25:45", "name": "Windows performance enhancements", "version": 2, "mbox": "http://patchwork.dpdk.org/series/28008/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/126882/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/126882/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5D7F042B22;\n\tTue, 16 May 2023 13:26:34 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4C6EA41153;\n\tTue, 16 May 2023 13:26:34 +0200 (CEST)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2064.outbound.protection.outlook.com [40.107.223.64])\n by mails.dpdk.org (Postfix) with ESMTP id 43B1D41151\n for <dev@dpdk.org>; Tue, 16 May 2023 13:26:32 +0200 (CEST)", "from MW4PR03CA0023.namprd03.prod.outlook.com (2603:10b6:303:8f::28)\n by PH0PR12MB5418.namprd12.prod.outlook.com (2603:10b6:510:e5::19)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Tue, 16 May\n 2023 11:26:30 +0000", "from CO1NAM11FT008.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:8f:cafe::f7) by MW4PR03CA0023.outlook.office365.com\n (2603:10b6:303:8f::28) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33 via Frontend\n Transport; Tue, 16 May 2023 11:26:30 +0000", "from mail.nvidia.com (216.228.117.161) by\n CO1NAM11FT008.mail.protection.outlook.com (10.13.175.191) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6411.15 via Frontend Transport; Tue, 16 May 2023 11:26:30 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Tue, 16 May 2023\n 04:26:18 -0700", "from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Tue, 16 May\n 2023 04:26:14 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=lFgLSWyKmfM2JRm+wjEpONFC50TmJMLjgYQvGLornUFcCMVPI2B4pBF6JH8mgYlzxtb0EpPQDpvjD6ASBdwYZ64P//SnSXrouYQSs+2HE8eHhslqE8AYcsba0FWsc2xk8Plq5XBthZFYuS5upjuhoi/PtiPOIvdu5O/gVlRbChb0H37ExYMYamSmk3drOgj5+GRpgZO03IBzlsA+rJRlA4ixVwVghIe9vFLJ4N0ArtqpgVK76+qNHEWk8D7eEdy6H1BMNaGPUEWt8AstLqfzN6LVWErC5WKEmAlrTbyyx/bgorklSsj+jmfHq3M1qcKnpvdpZapR7w1t8GbdFjQ43g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=6zKbSQ3ZGCq0yy6J7YWIoaHUH1siHAMsBYfMhefMmTA=;\n b=l04/f2DWUf17q2RZ0kUe8P0C4fowwe0OoDNyl2nQCM3ufBia5xkTTpijRa3DdwGDweI2s2wzj6FuW9ym4aAE+TF8cpWlkQjORwx9Czf0mv5DHf92fZ8CKI3s9iHltNkgG4EQ8vpVAZDzbIsyvEzYPLxrI8yF2ZyyLo/UTPWkTfbFB7K9q6ds2oPxl9UMvZCb3Y+kG+mBAJKwgGS8kqlu/qB5RmgqslSq3PwjkJ9pqK9/MPszfeiCngRRKfRo/aYFexu16KBeQq5nutRoZCBZxkcJIVb95buOZm7YGJob2ky6Gsx6DCO9UZovg/dA9HQGQ4+3PYXEezGl/gaQfbMUhQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=6zKbSQ3ZGCq0yy6J7YWIoaHUH1siHAMsBYfMhefMmTA=;\n b=lZB2APGvkz5aEf1dG6z1oVCfWY5BeGGbIwqF3jY8tQoHxe44851nXyP1aR4ESTYRm4ADgVeVaafkZKIBAOvNzW1JxLShJVR5sHvho6hvLJk1ah6XQEOdPfJUM9X4rGCStT+5mG7vI0ADSfgqUbskO1ze65h78nNZEqf/Kb1IPYiAvJuCmb6rPVaCqEsRlJZCUKsAV524dBJ0QPbrqg/sZA9v+DIRjqYD2/LESnDbvpPdNt7Mjrd0u2zACf+BmYXWNxND3cQkuLtsHL1VtOQNBudSiRFp+Gftd9k4c6Rpc5jEiXCz7D8K7KnfLwB4sOSsq2TPuEWA+IeABhGsQBBotA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Tal Shnaiderman <talshn@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<thomas@monjalon.net>, <matan@nvidia.com>, <viacheslavo@nvidia.com>,\n <rasland@nvidia.com>, <pdamouny@nvidia.com>, <tamerh@nvidia.com>", "Subject": "[PATCH v2 2/3] net/mlx5: support CQE compression on Windows", "Date": "Tue, 16 May 2023 14:25:47 +0300", "Message-ID": "<20230516112548.6848-3-talshn@nvidia.com>", "X-Mailer": "git-send-email 2.16.1.windows.4", "In-Reply-To": "<20230516112548.6848-1-talshn@nvidia.com>", "References": "<20230516112548.6848-1-talshn@nvidia.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.231.37]", "X-ClientProxiedBy": "rnnvmail203.nvidia.com (10.129.68.9) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CO1NAM11FT008:EE_|PH0PR12MB5418:EE_", "X-MS-Office365-Filtering-Correlation-Id": "9bc2e675-aaa0-45cf-d4f8-08db56006551", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n p3SYZIuBm3tnk87XeUQ6lHPiDrkbXV0t1FOQ0Ma3PX3AbnojyXAPGG04Xg8iIXo9vlVBYn5F9z1Pqfznc+piMpgYIcHcpHUS+3SwUOR1hJsnTf+VpNgtSexFLgQk8gp8PoRmA17Ot0bLhVCjyguWEebpg5Y78aEJBCjgLL7lZEMH3dZE6YP1Dd+0v7AIN5y0UftCCtCRarX5aIlMgTHqvrv3TIRfY3uX4wluuc23dpniFOPd1rW/h7SN2GVBcQS0ACZ2mE4QcFgci+++vG7AsZ5D0WfGNF6Kj3E0CzLB7Re+aLS2X8xf4PkZARIOApOb8R5J55koELZtSyxlDbiqMHTti/ZzBSzs/os7ob5+OicLhNVsAOVSokmHHVgkJ2Ty1nHXdGqS6aDhpsIXDA2mCEpie5oaoHZ4GDEqU7BA1yI5bL/lkHSfV2zkHSmEFpG3ow6jCjfIUXwxMYvrTF4Ag/esuHuj5Xo1jxS2iKewoaiNKWHjf9hJzrBZLgyFXhv5k+LTMokF+zK2eK4doqiXxC5MWbEWIePusTyuAckqeqqeVAxRaT9FD1xNaSta3KTEeivLV/p3C1Yz/bGjI7usjdrLsfl4eYZPBaKZgZy3dbYG9h4t6saXM8aFyZXsnFhxByssqhXgdRsATxUwww9eWwJIq/EmJLmoG0xTOcu/2ykQeoE/Wcw/r3uTXUzjwNFPBveADW6IV8NCVWvfbj/k24dTozOGXxHQFQIBG6fF1VKqYOEFnm5ksEbAndcz3Wey", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230028)(4636009)(396003)(39860400002)(346002)(136003)(376002)(451199021)(36840700001)(40470700004)(46966006)(26005)(40460700003)(1076003)(107886003)(47076005)(83380400001)(336012)(426003)(36756003)(36860700001)(55016003)(40480700001)(2616005)(7636003)(86362001)(82310400005)(356005)(82740400003)(6286002)(186003)(16526019)(54906003)(478600001)(2906002)(316002)(41300700001)(5660300002)(8936002)(8676002)(70586007)(4326008)(6916009)(70206006)(7696005)(6666004);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "16 May 2023 11:26:30.1501 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 9bc2e675-aaa0-45cf-d4f8-08db56006551", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT008.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH0PR12MB5418", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "CQE Compression reduces PCI overhead by coalescing and compressing\nmultiple CQEs into a single merged CQE.\n\nAdd supported for the CQE compression feature on Windows.\nfeature is enabled by default unless not supported by the HW\nor if the rxq_cqe_comp_en PMD argument is explicitly disabled.\n\nSigned-off-by: Tal Shnaiderman <talshn@nvidia.com>\nTested-by: Pier Damouny <pdamouny@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++\n drivers/common/mlx5/mlx5_devx_cmds.h | 1 +\n drivers/net/mlx5/windows/mlx5_os.c | 12 ++++++++++++\n 3 files changed, 15 insertions(+)", "diff": "diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c\nindex 096bd1d520..a31e4995f5 100644\n--- a/drivers/common/mlx5/mlx5_devx_cmds.c\n+++ b/drivers/common/mlx5/mlx5_devx_cmds.c\n@@ -1062,6 +1062,8 @@ mlx5_devx_cmd_query_hca_attr(void *ctx,\n \tattr->cqe_compression = MLX5_GET(cmd_hca_cap, hcattr, cqe_compression);\n \tattr->mini_cqe_resp_flow_tag = MLX5_GET(cmd_hca_cap, hcattr,\n \t\t\t\t\t\tmini_cqe_resp_flow_tag);\n+\tattr->cqe_compression_128 = MLX5_GET(cmd_hca_cap, hcattr,\n+\t\t\t\t\t\tcqe_compression_128);\n \tattr->mini_cqe_resp_l3_l4_tag = MLX5_GET(cmd_hca_cap, hcattr,\n \t\t\t\t\t\t mini_cqe_resp_l3_l4_tag);\n \tattr->enhanced_cqe_compression = MLX5_GET(cmd_hca_cap, hcattr,\ndiff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/mlx5_devx_cmds.h\nindex 9e7992b1c6..edcd867c4e 100644\n--- a/drivers/common/mlx5/mlx5_devx_cmds.h\n+++ b/drivers/common/mlx5/mlx5_devx_cmds.h\n@@ -284,6 +284,7 @@ struct mlx5_hca_attr {\n \tuint16_t max_wqe_sz_sq;\n \tuint32_t striding_rq:1;\n \tuint32_t ext_stride_num_range:1;\n+\tuint32_t cqe_compression_128:1;\n \tuint32_t set_reg_c:8;\n \tuint32_t nic_flow_table:1;\n \tuint32_t modify_outer_ip_ecn:1;\ndiff --git a/drivers/net/mlx5/windows/mlx5_os.c b/drivers/net/mlx5/windows/mlx5_os.c\nindex 0caa8931e4..6527269663 100644\n--- a/drivers/net/mlx5/windows/mlx5_os.c\n+++ b/drivers/net/mlx5/windows/mlx5_os.c\n@@ -237,6 +237,18 @@ mlx5_os_capabilities_prepare(struct mlx5_dev_ctx_shared *sh)\n \t} else {\n \t\tDRV_LOG(DEBUG, \"Tunnel offloading is not supported.\");\n \t}\n+\tsh->dev_cap.cqe_comp = 0;\n+#if (RTE_CACHE_LINE_SIZE == 128)\n+\tif (hca_attr->cqe_compression_128)\n+\t\tsh->dev_cap.cqe_comp = 1;\n+\tDRV_LOG(DEBUG, \"Rx CQE 128B compression is %ssupported.\",\n+\t\tsh->dev_cap.cqe_comp ? \"\" : \"not \");\n+#else\n+\tif (hca_attr->cqe_compression)\n+\t\tsh->dev_cap.cqe_comp = 1;\n+\tDRV_LOG(DEBUG, \"Rx CQE compression is %ssupported.\",\n+\t\tsh->dev_cap.cqe_comp ? \"\" : \"not \");\n+#endif\n \tsnprintf(sh->dev_cap.fw_ver, 64, \"%x.%x.%04x\",\n \t\t MLX5_GET(initial_seg, pv_iseg, fw_rev_major),\n \t\t MLX5_GET(initial_seg, pv_iseg, fw_rev_minor),\n", "prefixes": [ "v2", "2/3" ] }