Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126926/?format=api
{ "id": 126926, "url": "http://patchwork.dpdk.org/api/patches/126926/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230517161603.117728-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230517161603.117728-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230517161603.117728-3-stephen@networkplumber.org", "date": "2023-05-17T16:15:45", "name": "[02/20] eal: replace use of sanity check in comments and messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f06109710423444d3620a5b94b8870f11a113e8e", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230517161603.117728-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 28034, "url": "http://patchwork.dpdk.org/api/series/28034/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28034", "date": "2023-05-17T16:15:43", "name": "Replace use of term sanity-check", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28034/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/126926/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/126926/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 70C8A42B2C;\n\tWed, 17 May 2023 18:16:23 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1AF5742B8B;\n\tWed, 17 May 2023 18:16:12 +0200 (CEST)", "from mail-pf1-f180.google.com (mail-pf1-f180.google.com\n [209.85.210.180])\n by mails.dpdk.org (Postfix) with ESMTP id BEA4842D31\n for <dev@dpdk.org>; Wed, 17 May 2023 18:16:10 +0200 (CEST)", "by mail-pf1-f180.google.com with SMTP id\n d2e1a72fcca58-644d9bf05b7so741084b3a.3\n for <dev@dpdk.org>; Wed, 17 May 2023 09:16:10 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n h5-20020a62b405000000b0063f33e216dasm15793009pfn.96.2023.05.17.09.16.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 17 May 2023 09:16:09 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1684340170;\n x=1686932170;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=XQGSRpP/KDwjriwlLt8xDHr3mkn0SDV5wRaNdyE3PWE=;\n b=yG+kHtZYyZfduOA+WYodEpG1/6J2uRyEN0BpDCVF8bZ37NAainpkW6SrkD0FlxdtYO\n cZiiT9PGcKCuFZ3/KD+DfF+lJXb5dQvsGOv4Ql/uXB31HU3r4uWIcbUMomooycMZlJEz\n 7v73Absu6VZPjlKcwhfJ/AXAW+a9OO3CFHiRgdk+cNkwWFgBrxIYF3VwNhNvJokcABbT\n Z6NHOfwgbcrsdJ+OHeyoFpOBl7ZvWw5vx0zQdn5asw7FRkCbI3/0KOeGLsBxBsd3EUgQ\n sVfUNz8S54VgsD5hHTV73OeVigjObDUSQemzqrbCwtTRtDsKVd46pfklOUtev3E6Ao5N\n Q6ow==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1684340170; x=1686932170;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=XQGSRpP/KDwjriwlLt8xDHr3mkn0SDV5wRaNdyE3PWE=;\n b=AsQyZpY/KypCKP9suH0dOATFMsgox5wLa/d3jt3CGr9I+EFhbv7pKcg4kZpkqKF478\n VYfb7sxNP750aO8ALjgIcGvaufNkKBqRWKm2h2zsmGuz/pX5vg4FbBIUuBdpegfcMCY/\n gV7iyPpIczRQ4dCwp5aag/NH0QBVXRmQbeWthyr11xfhE02FjfAcfCcjkNt5Mj05U9Yf\n qFG853ZHXFuYzaiDLnXjuWcYfffex+ymaSuWMm05VG6Cr5oiopDrQUJM8lu/+c+kCJbd\n fQt3O7sKA0+o7FhqqcS3mc0AuYSU0/zW/IGQAKG4TbQx61+yenEifJGMgy2wYh9IxTn9\n dZlw==", "X-Gm-Message-State": "AC+VfDyU64rcaO6J1u3JOxXjF6XVCudfRWnVYI3+5WEN+b8ZpxVf/3Sw\n N+DJupG0DjafE41De1lhLMh3aghsd0W2Qn7mZDuiPA==", "X-Google-Smtp-Source": "\n ACHHUZ7Tqi8SWkwOZeIU7pj2+BGOY6zDlcNCqSthq0G5Ob371WQpv6zCXscMEDkSq+tjgV8Et/X9Mg==", "X-Received": "by 2002:a05:6a00:134b:b0:62d:8376:3712 with SMTP id\n k11-20020a056a00134b00b0062d83763712mr159284pfu.28.1684340169719;\n Wed, 17 May 2023 09:16:09 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>", "Subject": "[PATCH 02/20] eal: replace use of sanity check in comments and\n messages", "Date": "Wed, 17 May 2023 09:15:45 -0700", "Message-Id": "<20230517161603.117728-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230517161603.117728-1-stephen@networkplumber.org>", "References": "<20230517161603.117728-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Sanity check is on the Tier 2 non-inclusive list.\nReplace or remove it.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/common/eal_common_memory.c | 2 +-\n lib/eal/common/eal_common_proc.c | 3 ++-\n lib/eal/common/eal_common_trace.c | 2 +-\n lib/eal/common/eal_memcfg.h | 2 +-\n lib/eal/common/rte_malloc.c | 2 +-\n lib/eal/freebsd/eal.c | 2 +-\n lib/eal/linux/eal.c | 2 +-\n lib/eal/windows/eal.c | 2 +-\n 8 files changed, 9 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c\nindex e21fc7cfaecc..f99c6b43c885 100644\n--- a/lib/eal/common/eal_common_memory.c\n+++ b/lib/eal/common/eal_common_memory.c\n@@ -560,7 +560,7 @@ check_dma_mask(uint8_t maskbits, bool thread_unsafe)\n \tuint64_t mask;\n \tint ret;\n \n-\t/* Sanity check. We only check width can be managed with 64 bits\n+\t/* We only check width can be managed with 64 bits\n \t * variables. Indeed any higher value is likely wrong. */\n \tif (maskbits > MAX_DMA_MASK_BITS) {\n \t\tRTE_LOG(ERR, EAL, \"wrong dma mask size %u (Max: %u)\\n\",\ndiff --git a/lib/eal/common/eal_common_proc.c b/lib/eal/common/eal_common_proc.c\nindex 1fc1d6c53bd2..972f3269d8ae 100644\n--- a/lib/eal/common/eal_common_proc.c\n+++ b/lib/eal/common/eal_common_proc.c\n@@ -309,7 +309,8 @@ read_msg(int fd, struct mp_msg_internal *m, struct sockaddr_un *s)\n \t\t\tbreak;\n \t\t}\n \t}\n-\t/* sanity-check the response */\n+\n+\t/* Check that the response is valid */\n \tif (m->msg.num_fds < 0 || m->msg.num_fds > RTE_MP_MAX_FD_NUM) {\n \t\tRTE_LOG(ERR, EAL, \"invalid number of fd's received\\n\");\n \t\treturn -1;\ndiff --git a/lib/eal/common/eal_common_trace.c b/lib/eal/common/eal_common_trace.c\nindex cb980af06d9f..cadb85b94fde 100644\n--- a/lib/eal/common/eal_common_trace.c\n+++ b/lib/eal/common/eal_common_trace.c\n@@ -465,7 +465,7 @@ __rte_trace_point_register(rte_trace_point_t *handle, const char *name,\n \tstruct trace_point *tp;\n \tuint16_t sz;\n \n-\t/* Sanity checks of arguments */\n+\t/* Check arguments */\n \tif (name == NULL || register_fn == NULL || handle == NULL) {\n \t\ttrace_err(\"invalid arguments\");\n \t\trte_errno = EINVAL;\ndiff --git a/lib/eal/common/eal_memcfg.h b/lib/eal/common/eal_memcfg.h\nindex ea013a9daf17..dc7ef18dc11b 100644\n--- a/lib/eal/common/eal_memcfg.h\n+++ b/lib/eal/common/eal_memcfg.h\n@@ -18,7 +18,7 @@\n * Memory configuration shared across multiple processes.\n */\n struct rte_mem_config {\n-\tvolatile uint32_t magic; /**< Magic number - sanity check. */\n+\tvolatile uint32_t magic; /**< Magic number check. */\n \tuint32_t version;\n \t/**< Prevent secondary processes using different DPDK versions. */\n \ndiff --git a/lib/eal/common/rte_malloc.c b/lib/eal/common/rte_malloc.c\nindex ebafef3f6cf2..e632c395132c 100644\n--- a/lib/eal/common/rte_malloc.c\n+++ b/lib/eal/common/rte_malloc.c\n@@ -654,7 +654,7 @@ rte_malloc_heap_destroy(const char *heap_name)\n \t\tret = -1;\n \t\tgoto unlock;\n \t}\n-\t/* sanity checks done, now we can destroy the heap */\n+\t/* checks done, now we can destroy the heap */\n \trte_spinlock_lock(&heap->lock);\n \tret = malloc_heap_destroy(heap);\n \trte_spinlock_unlock(&heap->lock);\ndiff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex 7daf22e31449..d3499dd5906d 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -501,7 +501,7 @@ eal_parse_args(int argc, char **argv)\n \t\tgoto out;\n \t}\n \n-\t/* sanity checks */\n+\t/* options checks */\n \tif (eal_check_common_options(internal_conf) != 0) {\n \t\teal_usage(prgname);\n \t\tret = -1;\ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex ae323cd492d4..251aa533b274 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -803,7 +803,7 @@ eal_parse_args(int argc, char **argv)\n \t\tgoto out;\n \t}\n \n-\t/* sanity checks */\n+\t/* options checks */\n \tif (eal_check_common_options(internal_conf) != 0) {\n \t\teal_usage(prgname);\n \t\tret = -1;\ndiff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c\nindex 033825c14c67..17a5f9d1ba30 100644\n--- a/lib/eal/windows/eal.c\n+++ b/lib/eal/windows/eal.c\n@@ -194,7 +194,7 @@ eal_parse_args(int argc, char **argv)\n \tif (eal_adjust_config(internal_conf) != 0)\n \t\treturn -1;\n \n-\t/* sanity checks */\n+\t/* options checks */\n \tif (eal_check_common_options(internal_conf) != 0) {\n \t\teal_usage(prgname);\n \t\treturn -1;\n", "prefixes": [ "02/20" ] }