Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126984/?format=api
{ "id": 126984, "url": "http://patchwork.dpdk.org/api/patches/126984/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230518112944.32276-2-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230518112944.32276-2-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230518112944.32276-2-liudongdong3@huawei.com", "date": "2023-05-18T11:29:40", "name": "[1/5] net/hns3: fix never set MAC flow control", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "845e187038859629fdbc2d89043887a95e85d42c", "submitter": { "id": 2718, "url": "http://patchwork.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230518112944.32276-2-liudongdong3@huawei.com/mbox/", "series": [ { "id": 28060, "url": "http://patchwork.dpdk.org/api/series/28060/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28060", "date": "2023-05-18T11:29:39", "name": "] net/hns3: add some features and bugfixes", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28060/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/126984/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/126984/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0BF6042B3A;\n\tThu, 18 May 2023 13:32:06 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1A39242D17;\n\tThu, 18 May 2023 13:32:02 +0200 (CEST)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 9765140E25;\n Thu, 18 May 2023 13:31:59 +0200 (CEST)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.55])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QMSSN6C4fzsSTt;\n Thu, 18 May 2023 19:29:56 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.23; Thu, 18 May 2023 19:31:57 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>,\n <andrew.rybchenko@oktetlabs.ru>, <fengchengwen@huawei.com>", "CC": "<stable@dpdk.org>, <lihuisong@huawei.com>, <liudongdong3@huawei.com>,\n <yisen.zhuang@huawei.com>", "Subject": "[PATCH 1/5] net/hns3: fix never set MAC flow control", "Date": "Thu, 18 May 2023 19:29:40 +0800", "Message-ID": "<20230518112944.32276-2-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20230518112944.32276-1-liudongdong3@huawei.com>", "References": "<20230518112944.32276-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nWhen some hardware and firmware support speed auto-negotiation\nbut do not support flow control auto-negotiation, driver can\nnever successfully set MAC flow control by flow_ctrl_set() API.\nSo only tell user driver doesn't support flow control autoneg\nwhen user enable it.\n\nFixes: 1f411e31a826 (\"net/hns3: support flow control autoneg for copper port\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 11 +----------\n 1 file changed, 1 insertion(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex d97280e647..8f819d5f23 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -5304,16 +5304,7 @@ hns3_check_fc_autoneg_valid(struct hns3_hw *hw, uint8_t autoneg)\n \n \tif (!pf->support_fc_autoneg) {\n \t\tif (autoneg != 0) {\n-\t\t\thns3_err(hw, \"unsupported fc auto-negotiation setting.\");\n-\t\t\treturn -EOPNOTSUPP;\n-\t\t}\n-\n-\t\t/*\n-\t\t * Flow control auto-negotiation of the NIC is not supported,\n-\t\t * but other auto-negotiation features may be supported.\n-\t\t */\n-\t\tif (autoneg != hw->mac.link_autoneg) {\n-\t\t\thns3_err(hw, \"please use 'link_speeds' in struct rte_eth_conf to disable autoneg!\");\n+\t\t\thns3_err(hw, \"unsupported fc auto-negotiation.\");\n \t\t\treturn -EOPNOTSUPP;\n \t\t}\n \n", "prefixes": [ "1/5" ] }