Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127010/?format=api
{ "id": 127010, "url": "http://patchwork.dpdk.org/api/patches/127010/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230518151638.1207021-17-qiming.yang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230518151638.1207021-17-qiming.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230518151638.1207021-17-qiming.yang@intel.com", "date": "2023-05-18T15:16:34", "name": "[v2,16/20] net/ice/base: delete get field vector function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ba151e4ae41744d9ff7de3d0ad00d23a66cbfcd5", "submitter": { "id": 522, "url": "http://patchwork.dpdk.org/api/people/522/?format=api", "name": "Qiming Yang", "email": "qiming.yang@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230518151638.1207021-17-qiming.yang@intel.com/mbox/", "series": [ { "id": 28063, "url": "http://patchwork.dpdk.org/api/series/28063/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28063", "date": "2023-05-18T15:16:18", "name": "net/ice/base: code update", "version": 2, "mbox": "http://patchwork.dpdk.org/series/28063/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/127010/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/127010/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 415D242AF1;\n\tThu, 18 May 2023 17:36:23 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 99D1F42DA9;\n\tThu, 18 May 2023 17:34:46 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 5DD9242D88\n for <dev@dpdk.org>; Thu, 18 May 2023 17:34:44 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 May 2023 08:34:44 -0700", "from dpdk-qiming3.sh.intel.com ([10.67.111.4])\n by fmsmga007.fm.intel.com with ESMTP; 18 May 2023 08:34:42 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1684424084; x=1715960084;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=jFULjqhPqwdGRx+31NdQzWwIG9/wnMemQCl30O4O0MI=;\n b=djpUlar2Gzhmz7pJbiPFO0CsYULaJ7+5Cip3m1GVXSMG4M26O5pmR14n\n sIJSk1fTymgegxeXm/hPB+blRLvXXg7lMfpw3sjFxFKtCkny5aBkxTE7I\n kLF50CiCUymnDHUVvmo67NCk1BkkxA/tuT377FiCBUHgr4E6sBVm5vUoL\n PIMB19WaYuUpAiPMGLcJ3HsbO0gw8d9H8Z7j1lb+7gIZEoY5cSQEC5MG3\n PXnw5I8ajTIFGFhOxnjEv3fQI9PS2gDgVGWodDlSNQTFzYgybuRmBx2I6\n ZEWv0nJ59ALY7+nZAMpqlQdLlGirNcGi09hYCNKoZdSYu4qL6muKOuqr3 w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10714\"; a=\"341527769\"", "E=Sophos;i=\"5.99,285,1677571200\"; d=\"scan'208\";a=\"341527769\"", "E=McAfee;i=\"6600,9927,10714\"; a=\"705235214\"", "E=Sophos;i=\"5.99,285,1677571200\"; d=\"scan'208\";a=\"705235214\"" ], "X-ExtLoop1": "1", "From": "Qiming Yang <qiming.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "qi.z.zhang@intel.com, Qiming Yang <qiming.yang@intel.com>,\n Marcin Szycik <marcin.szycik@intel.com>", "Subject": "[PATCH v2 16/20] net/ice/base: delete get field vector function", "Date": "Thu, 18 May 2023 15:16:34 +0000", "Message-Id": "<20230518151638.1207021-17-qiming.yang@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230518151638.1207021-1-qiming.yang@intel.com>", "References": "<20230427062001.478032-1-qiming.yang@intel.com>\n <20230518151638.1207021-1-qiming.yang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Currently ice_get_fv() is only used inside ice_get_sw_fv_list(). Remove\nice_get_fv() and call ice_get_sw_fv_list() directly.\n\nSigned-off-by: Marcin Szycik <marcin.szycik@intel.com>\nSigned-off-by: Qiming Yang <qiming.yang@intel.com>\n---\n drivers/net/ice/base/ice_ddp.c | 3 +++\n drivers/net/ice/base/ice_switch.c | 23 ++---------------------\n 2 files changed, 5 insertions(+), 21 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_ddp.c b/drivers/net/ice/base/ice_ddp.c\nindex 3e18f2bc70..d88c417faf 100644\n--- a/drivers/net/ice/base/ice_ddp.c\n+++ b/drivers/net/ice/base/ice_ddp.c\n@@ -1579,6 +1579,9 @@ ice_get_sw_fv_list(struct ice_hw *hw, struct ice_prot_lkup_ext *lkups,\n \tstruct ice_fv *fv;\n \tu32 offset;\n \n+\tif (!lkups->n_val_words)\n+\t\treturn ICE_SUCCESS;\n+\n \tice_memset(&state, 0, sizeof(state), ICE_NONDMA_MEM);\n \n \tif (!lkups->n_val_words || !hw->seg)\ndiff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c\nindex 06665a29db..1f391002b8 100644\n--- a/drivers/net/ice/base/ice_switch.c\n+++ b/drivers/net/ice/base/ice_switch.c\n@@ -7733,25 +7733,6 @@ ice_create_recipe_group(struct ice_hw *hw, struct ice_sw_recipe *rm,\n \treturn status;\n }\n \n-/**\n- * ice_get_fv - get field vectors/extraction sequences for spec. lookup types\n- * @hw: pointer to hardware structure\n- * @lkups: lookup elements or match criteria for the advanced recipe, one\n- *\t structure per protocol header\n- * @bm: bitmap of field vectors to consider\n- * @fv_list: pointer to a list that holds the returned field vectors\n- */\n-static enum ice_status\n-ice_get_fv(struct ice_hw *hw, struct ice_prot_lkup_ext *lkups,\n-\t ice_bitmap_t *bm, struct LIST_HEAD_TYPE *fv_list)\n-{\n-\tif (!lkups->n_val_words)\n-\t\treturn ICE_SUCCESS;\n-\n-\t/* Find field vectors that include all specified protocol types */\n-\treturn ice_get_sw_fv_list(hw, lkups, bm, fv_list);\n-}\n-\n /**\n * ice_tun_type_match_word - determine if tun type needs a match mask\n * @rinfo: other information regarding the rule e.g. priority and action info\n@@ -8159,11 +8140,11 @@ ice_add_adv_recipe(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,\n \n \t/* Get bitmap of field vectors (profiles) that are compatible with the\n \t * rule request; only these will be searched in the subsequent call to\n-\t * ice_get_fv.\n+\t * ice_get_sw_fv_list.\n \t */\n \tice_get_compat_fv_bitmap(hw, rinfo, fv_bitmap);\n \n-\tstatus = ice_get_fv(hw, lkup_exts, fv_bitmap, &rm->fv_list);\n+\tstatus = ice_get_sw_fv_list(hw, lkup_exts, fv_bitmap, &rm->fv_list);\n \tif (status)\n \t\tgoto err_unroll;\n \n", "prefixes": [ "v2", "16/20" ] }