Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127660/?format=api
{ "id": 127660, "url": "http://patchwork.dpdk.org/api/patches/127660/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230529092312.3855432-1-jerinj@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230529092312.3855432-1-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230529092312.3855432-1-jerinj@marvell.com", "date": "2023-05-29T09:23:12", "name": "[v1] drivers/cnxk: improve the build time for non arm64 build", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "df8f6fc426b7c82b1677be868fbb3addf261561c", "submitter": { "id": 1188, "url": "http://patchwork.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230529092312.3855432-1-jerinj@marvell.com/mbox/", "series": [ { "id": 28232, "url": "http://patchwork.dpdk.org/api/series/28232/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28232", "date": "2023-05-29T09:23:12", "name": "[v1] drivers/cnxk: improve the build time for non arm64 build", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28232/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/127660/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/127660/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1494142BD1;\n\tMon, 29 May 2023 11:23:35 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DBB58410DD;\n\tMon, 29 May 2023 11:23:34 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 05074410D7\n for <dev@dpdk.org>; Mon, 29 May 2023 11:23:33 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 34T7gEKM002144 for <dev@dpdk.org>; Mon, 29 May 2023 02:23:33 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3quhcm4s98-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Mon, 29 May 2023 02:23:32 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Mon, 29 May 2023 02:23:24 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Mon, 29 May 2023 02:23:24 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id C2B703F7053;\n Mon, 29 May 2023 02:23:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=Shnfb4By/MdAQPpQ7Acngg6w8i3PC3HUC7XnK4zPuBs=;\n b=Ik0+ebplTGTbBijfZGFUDRA4BOKVE26lcWwDW+AcpfHF83KAPJejpVWb3ZpGNvavSpT5\n g9FcDJybmvHGvVSJ3HYcbW7y9tNY3ZQJhAtho25xEM7LJ0rN88DiBZa9yRFkqzS9JH3X\n 8r+Z7g/3bnjEkxGQQ+PF2wHs8isP8wmvRccAMiWfYySXLMOGCz86acCnebHwzyBY6X8e\n rVun/glReLiW00P9obdyIdclu136c3WaLe/JwhiPTviBTD9NpJueqCE3ScSP6Ax/OBWX\n s26wQNRSImi6DmAFaJQsrr0WZDCYwxG/VN8LzBcz6fYSuLXPkSbizU9iLEzKnvRwp45i qQ==", "From": "<jerinj@marvell.com>", "To": "<dev@dpdk.org>, Pavan Nikhilesh <pbhagavatula@marvell.com>, \"Shijith\n Thotton\" <sthotton@marvell.com>, Nithin Kumar Dabilpuram\n <ndabilpuram@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>, \"Sunil\n Kumar Kori\" <skori@marvell.com>, Satha Rao <skoteshwar@marvell.com>", "CC": "Jerin Jacob <jerinj@marvell.com>", "Subject": "[dpdk-dev] [PATCH v1] drivers/cnxk: improve the build time for non\n arm64 build", "Date": "Mon, 29 May 2023 14:53:12 +0530", "Message-ID": "<20230529092312.3855432-1-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.40.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "QaPGoYntjq5FZwH2vdFTfs3ZfQSnGemZ", "X-Proofpoint-ORIG-GUID": "QaPGoYntjq5FZwH2vdFTfs3ZfQSnGemZ", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26\n definitions=2023-05-29_06,2023-05-25_03,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nSpecialized fast path routines are not applicable to non\narm64 build, removing those function contained\nfiles to improve the build time on non arm64 build.\n\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\n---\n drivers/event/cnxk/cn10k_eventdev.c | 5 +++++\n drivers/event/cnxk/cn9k_eventdev.c | 4 ++++\n drivers/event/cnxk/meson.build | 10 ++++++++++\n drivers/net/cnxk/cn10k_rx_select.c | 6 +++++-\n drivers/net/cnxk/cn10k_tx_select.c | 6 +++++-\n drivers/net/cnxk/cn9k_rx_select.c | 6 +++++-\n drivers/net/cnxk/cn9k_tx_select.c | 6 +++++-\n drivers/net/cnxk/meson.build | 4 ++++\n 8 files changed, 43 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/event/cnxk/cn10k_eventdev.c b/drivers/event/cnxk/cn10k_eventdev.c\nindex fd71ff15ca..a7534efad6 100644\n--- a/drivers/event/cnxk/cn10k_eventdev.c\n+++ b/drivers/event/cnxk/cn10k_eventdev.c\n@@ -297,7 +297,9 @@ cn10k_sso_updt_tx_adptr_data(const struct rte_eventdev *event_dev)\n static void\n cn10k_sso_fp_fns_set(struct rte_eventdev *event_dev)\n {\n+#if defined(RTE_ARCH_ARM64)\n \tstruct cnxk_sso_evdev *dev = cnxk_sso_pmd_priv(event_dev);\n+\n \tstruct roc_cpt *cpt = roc_idev_cpt_get();\n \tconst event_dequeue_t sso_hws_deq[NIX_RX_OFFLOAD_MAX] = {\n #define R(name, flags)[flags] = cn10k_sso_hws_deq_##name,\n@@ -614,6 +616,9 @@ cn10k_sso_fp_fns_set(struct rte_eventdev *event_dev)\n \t\tCN10K_SET_EVDEV_ENQ_OP(dev, event_dev->txa_enqueue, sso_hws_tx_adptr_enq);\n \n \tevent_dev->txa_enqueue_same_dest = event_dev->txa_enqueue;\n+#else\n+\tRTE_SET_USED(event_dev);\n+#endif\n }\n \n static void\ndiff --git a/drivers/event/cnxk/cn9k_eventdev.c b/drivers/event/cnxk/cn9k_eventdev.c\nindex b104d19b9b..0656940726 100644\n--- a/drivers/event/cnxk/cn9k_eventdev.c\n+++ b/drivers/event/cnxk/cn9k_eventdev.c\n@@ -309,6 +309,7 @@ cn9k_sso_updt_tx_adptr_data(const struct rte_eventdev *event_dev)\n static void\n cn9k_sso_fp_fns_set(struct rte_eventdev *event_dev)\n {\n+#if defined(RTE_ARCH_ARM64)\n \tstruct cnxk_sso_evdev *dev = cnxk_sso_pmd_priv(event_dev);\n \t/* Single WS modes */\n \tconst event_dequeue_t sso_hws_deq[NIX_RX_OFFLOAD_MAX] = {\n@@ -662,6 +663,9 @@ cn9k_sso_fp_fns_set(struct rte_eventdev *event_dev)\n \n \tevent_dev->txa_enqueue_same_dest = event_dev->txa_enqueue;\n \trte_mb();\n+#else\n+\tRTE_SET_USED(event_dev);\n+#endif\n }\n \n static void *\ndiff --git a/drivers/event/cnxk/meson.build b/drivers/event/cnxk/meson.build\nindex 8a7fd53ebd..4f259988df 100644\n--- a/drivers/event/cnxk/meson.build\n+++ b/drivers/event/cnxk/meson.build\n@@ -31,6 +31,10 @@ if soc_type == 'cn9k' or soc_type == 'all'\n sources += files(\n 'cn9k_eventdev.c',\n 'cn9k_worker.c',\n+)\n+\n+if host_machine.cpu_family().startswith('aarch')\n+sources += files(\n 'deq/cn9k/deq_0_15_burst.c',\n 'deq/cn9k/deq_16_31_burst.c',\n 'deq/cn9k/deq_32_47_burst.c',\n@@ -330,11 +334,16 @@ sources += files(\n 'tx/cn9k/tx_112_127_dual_seg.c',\n )\n endif\n+endif\n \n if soc_type == 'cn10k' or soc_type == 'all'\n sources += files(\n 'cn10k_eventdev.c',\n 'cn10k_worker.c',\n+)\n+\n+if host_machine.cpu_family().startswith('aarch')\n+sources += files(\n 'deq/cn10k/deq_0_15_burst.c',\n 'deq/cn10k/deq_16_31_burst.c',\n 'deq/cn10k/deq_32_47_burst.c',\n@@ -484,6 +493,7 @@ sources += files(\n 'tx/cn10k/tx_112_127_seg.c',\n )\n endif\n+endif\n \n extra_flags = ['-flax-vector-conversions', '-Wno-strict-aliasing']\n foreach flag: extra_flags\ndiff --git a/drivers/net/cnxk/cn10k_rx_select.c b/drivers/net/cnxk/cn10k_rx_select.c\nindex 1e0de1b7ac..1d44f2924e 100644\n--- a/drivers/net/cnxk/cn10k_rx_select.c\n+++ b/drivers/net/cnxk/cn10k_rx_select.c\n@@ -5,7 +5,7 @@\n #include \"cn10k_ethdev.h\"\n #include \"cn10k_rx.h\"\n \n-static inline void\n+static __rte_used void\n pick_rx_func(struct rte_eth_dev *eth_dev,\n \t const eth_rx_burst_t rx_burst[NIX_RX_OFFLOAD_MAX])\n {\n@@ -25,6 +25,7 @@ pick_rx_func(struct rte_eth_dev *eth_dev,\n void\n cn10k_eth_set_rx_function(struct rte_eth_dev *eth_dev)\n {\n+#if defined(RTE_ARCH_ARM64)\n \tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n \n \tconst eth_rx_burst_t nix_eth_rx_burst[NIX_RX_OFFLOAD_MAX] = {\n@@ -111,4 +112,7 @@ cn10k_eth_set_rx_function(struct rte_eth_dev *eth_dev)\n \t\treturn pick_rx_func(eth_dev, nix_eth_rx_vec_burst_reas);\n \telse\n \t\treturn pick_rx_func(eth_dev, nix_eth_rx_vec_burst);\n+#else\n+\tRTE_SET_USED(eth_dev);\n+#endif\n }\ndiff --git a/drivers/net/cnxk/cn10k_tx_select.c b/drivers/net/cnxk/cn10k_tx_select.c\nindex 54023c4234..404f5ba979 100644\n--- a/drivers/net/cnxk/cn10k_tx_select.c\n+++ b/drivers/net/cnxk/cn10k_tx_select.c\n@@ -5,7 +5,7 @@\n #include \"cn10k_ethdev.h\"\n #include \"cn10k_tx.h\"\n \n-static inline void\n+static __rte_used inline void\n pick_tx_func(struct rte_eth_dev *eth_dev,\n \t const eth_tx_burst_t tx_burst[NIX_TX_OFFLOAD_MAX])\n {\n@@ -23,6 +23,7 @@ pick_tx_func(struct rte_eth_dev *eth_dev,\n void\n cn10k_eth_set_tx_function(struct rte_eth_dev *eth_dev)\n {\n+#if defined(RTE_ARCH_ARM64)\n \tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n \n \tconst eth_tx_burst_t nix_eth_tx_burst[NIX_TX_OFFLOAD_MAX] = {\n@@ -64,4 +65,7 @@ cn10k_eth_set_tx_function(struct rte_eth_dev *eth_dev)\n \t}\n \n \trte_mb();\n+#else\n+\tRTE_SET_USED(eth_dev);\n+#endif\n }\ndiff --git a/drivers/net/cnxk/cn9k_rx_select.c b/drivers/net/cnxk/cn9k_rx_select.c\nindex 79f171fcc3..05bc33ce6a 100644\n--- a/drivers/net/cnxk/cn9k_rx_select.c\n+++ b/drivers/net/cnxk/cn9k_rx_select.c\n@@ -5,7 +5,7 @@\n #include \"cn9k_ethdev.h\"\n #include \"cn9k_rx.h\"\n \n-static inline void\n+static __rte_used void\n pick_rx_func(struct rte_eth_dev *eth_dev,\n \t const eth_rx_burst_t rx_burst[NIX_RX_OFFLOAD_MAX])\n {\n@@ -25,6 +25,7 @@ pick_rx_func(struct rte_eth_dev *eth_dev,\n void\n cn9k_eth_set_rx_function(struct rte_eth_dev *eth_dev)\n {\n+#if defined(RTE_ARCH_ARM64)\n \tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n \n \tconst eth_rx_burst_t nix_eth_rx_burst[NIX_RX_OFFLOAD_MAX] = {\n@@ -68,4 +69,7 @@ cn9k_eth_set_rx_function(struct rte_eth_dev *eth_dev)\n \tif (dev->rx_offloads & RTE_ETH_RX_OFFLOAD_SCATTER)\n \t\treturn pick_rx_func(eth_dev, nix_eth_rx_vec_burst_mseg);\n \treturn pick_rx_func(eth_dev, nix_eth_rx_vec_burst);\n+#else\n+\tRTE_SET_USED(eth_dev);\n+#endif\n }\ndiff --git a/drivers/net/cnxk/cn9k_tx_select.c b/drivers/net/cnxk/cn9k_tx_select.c\nindex 62beb1bf38..e08883f032 100644\n--- a/drivers/net/cnxk/cn9k_tx_select.c\n+++ b/drivers/net/cnxk/cn9k_tx_select.c\n@@ -5,7 +5,7 @@\n #include \"cn9k_ethdev.h\"\n #include \"cn9k_tx.h\"\n \n-static inline void\n+static __rte_used void\n pick_tx_func(struct rte_eth_dev *eth_dev,\n \t const eth_tx_burst_t tx_burst[NIX_TX_OFFLOAD_MAX])\n {\n@@ -23,6 +23,7 @@ pick_tx_func(struct rte_eth_dev *eth_dev,\n void\n cn9k_eth_set_tx_function(struct rte_eth_dev *eth_dev)\n {\n+#if defined(RTE_ARCH_ARM64)\n \tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n \n \tconst eth_tx_burst_t nix_eth_tx_burst[NIX_TX_OFFLOAD_MAX] = {\n@@ -60,4 +61,7 @@ cn9k_eth_set_tx_function(struct rte_eth_dev *eth_dev)\n \t}\n \n \trte_mb();\n+#else\n+\tRTE_SET_USED(eth_dev);\n+#endif\n }\ndiff --git a/drivers/net/cnxk/meson.build b/drivers/net/cnxk/meson.build\nindex 62b8bb90fb..394d3d01f4 100644\n--- a/drivers/net/cnxk/meson.build\n+++ b/drivers/net/cnxk/meson.build\n@@ -45,6 +45,7 @@ sources += files(\n 'cn9k_tx_select.c',\n )\n \n+if host_machine.cpu_family().startswith('aarch')\n sources += files(\n 'rx/cn9k/rx_0_15.c',\n 'rx/cn9k/rx_16_31.c',\n@@ -115,6 +116,7 @@ sources += files(\n 'tx/cn9k/tx_112_127_vec_mseg.c',\n )\n endif\n+endif\n \n if soc_type == 'cn10k' or soc_type == 'all'\n # CN10K\n@@ -126,6 +128,7 @@ sources += files(\n 'cn10k_tx_select.c',\n )\n \n+if host_machine.cpu_family().startswith('aarch')\n sources += files(\n 'rx/cn10k/rx_0_15.c',\n 'rx/cn10k/rx_16_31.c',\n@@ -196,6 +199,7 @@ sources += files(\n 'tx/cn10k/tx_112_127_vec_mseg.c',\n )\n endif\n+endif\n \n deps += ['bus_pci', 'cryptodev', 'eventdev', 'security']\n deps += ['common_cnxk', 'mempool_cnxk']\n", "prefixes": [ "v1" ] }