Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127666/?format=api
http://patchwork.dpdk.org/api/patches/127666/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230529130940.1501-4-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230529130940.1501-4-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230529130940.1501-4-liudongdong3@huawei.com", "date": "2023-05-29T13:09:32", "name": "[03/11] net/hns3: add the uninitialization process of PTP", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "9c518aeeeef6b2d78c856980dbc0a28b01ddec74", "submitter": { "id": 2718, "url": "http://patchwork.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230529130940.1501-4-liudongdong3@huawei.com/mbox/", "series": [ { "id": 28237, "url": "http://patchwork.dpdk.org/api/series/28237/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28237", "date": "2023-05-29T13:09:32", "name": "net/hns3: add some bugfixes for hns3", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28237/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/127666/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/127666/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6AC0842BD3;\n\tMon, 29 May 2023 15:12:14 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BD49A42B7E;\n\tMon, 29 May 2023 15:12:13 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 7620D410D7;\n Mon, 29 May 2023 15:12:08 +0200 (CEST)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.56])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QVGC3189GzTkvd;\n Mon, 29 May 2023 21:11:59 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.23; Mon, 29 May 2023 21:12:06 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>,\n <andrew.rybchenko@oktetlabs.ru>, <fengchengwen@huawei.com>", "CC": "<stable@dpdk.org>, <lihuisong@huawei.com>, <liudongdong3@huawei.com>,\n <yisen.zhuang@huawei.com>, <huangdengdui@huawei.com>", "Subject": "[PATCH 03/11] net/hns3: add the uninitialization process of PTP", "Date": "Mon, 29 May 2023 21:09:32 +0800", "Message-ID": "<20230529130940.1501-4-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20230529130940.1501-1-liudongdong3@huawei.com>", "References": "<20230529130940.1501-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems701-chm.china.huawei.com (10.3.19.178) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nThis patch adds the uninitialization process of PTP in case\nof having an impact on PF driver in kernel.\n\nFixes: 38b539d96eb6 (\"net/hns3: support IEEE 1588 PTP\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 2 +\n drivers/net/hns3/hns3_ethdev.h | 1 +\n drivers/net/hns3/hns3_ptp.c | 68 +++++++++++++++++++++-------------\n 3 files changed, 46 insertions(+), 25 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 39bbee1d7b..b62058a0a9 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -4633,6 +4633,7 @@ hns3_init_pf(struct rte_eth_dev *eth_dev)\n \thns3_fdir_filter_uninit(hns);\n err_fdir:\n \thns3_uninit_umv_space(hw);\n+\thns3_ptp_uninit(hw);\n err_init_hw:\n \thns3_stats_uninit(hw);\n err_get_config:\n@@ -4668,6 +4669,7 @@ hns3_uninit_pf(struct rte_eth_dev *eth_dev)\n \thns3_flow_uninit(eth_dev);\n \thns3_fdir_filter_uninit(hns);\n \thns3_uninit_umv_space(hw);\n+\thns3_ptp_uninit(hw);\n \thns3_stats_uninit(hw);\n \thns3_config_mac_tnl_int(hw, false);\n \thns3_pf_disable_irq0(hw);\ndiff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h\nindex 88146f5054..a03dc9fa89 100644\n--- a/drivers/net/hns3/hns3_ethdev.h\n+++ b/drivers/net/hns3/hns3_ethdev.h\n@@ -1043,6 +1043,7 @@ int hns3_restore_ptp(struct hns3_adapter *hns);\n int hns3_mbuf_dyn_rx_timestamp_register(struct rte_eth_dev *dev,\n \t\t\t\t struct rte_eth_conf *conf);\n int hns3_ptp_init(struct hns3_hw *hw);\n+void hns3_ptp_uninit(struct hns3_hw *hw);\n int hns3_timesync_enable(struct rte_eth_dev *dev);\n int hns3_timesync_disable(struct rte_eth_dev *dev);\n int hns3_timesync_read_rx_timestamp(struct rte_eth_dev *dev,\ndiff --git a/drivers/net/hns3/hns3_ptp.c b/drivers/net/hns3/hns3_ptp.c\nindex fb834bb180..44cba29854 100644\n--- a/drivers/net/hns3/hns3_ptp.c\n+++ b/drivers/net/hns3/hns3_ptp.c\n@@ -56,31 +56,6 @@ hns3_ptp_int_en(struct hns3_hw *hw, bool en)\n \treturn ret;\n }\n \n-int\n-hns3_ptp_init(struct hns3_hw *hw)\n-{\n-\tstruct timespec sys_time;\n-\tstruct rte_eth_dev *dev;\n-\tint ret;\n-\n-\tif (!hns3_dev_get_support(hw, PTP))\n-\t\treturn 0;\n-\n-\tret = hns3_ptp_int_en(hw, true);\n-\tif (ret)\n-\t\treturn ret;\n-\n-\t/* Start PTP timer */\n-\thns3_write_dev(hw, HNS3_CFG_TIME_CYC_EN, 1);\n-\n-\t/* Initializing the RTC. */\n-\tdev = &rte_eth_devices[hw->data->port_id];\n-\tclock_gettime(CLOCK_REALTIME, &sys_time);\n-\t(void)hns3_timesync_write_time(dev, &sys_time);\n-\n-\treturn 0;\n-}\n-\n static int\n hns3_timesync_configure(struct hns3_adapter *hns, bool en)\n {\n@@ -301,3 +276,46 @@ hns3_restore_ptp(struct hns3_adapter *hns)\n \n \treturn ret;\n }\n+\n+int\n+hns3_ptp_init(struct hns3_hw *hw)\n+{\n+\tstruct timespec sys_time;\n+\tstruct rte_eth_dev *dev;\n+\tint ret;\n+\n+\tif (!hns3_dev_get_support(hw, PTP))\n+\t\treturn 0;\n+\n+\tret = hns3_ptp_int_en(hw, true);\n+\tif (ret != 0)\n+\t\treturn ret;\n+\n+\t/* Start PTP timer */\n+\thns3_write_dev(hw, HNS3_CFG_TIME_CYC_EN, 1);\n+\n+\t/* Initializing the RTC. */\n+\tdev = &rte_eth_devices[hw->data->port_id];\n+\tclock_gettime(CLOCK_REALTIME, &sys_time);\n+\t(void)hns3_timesync_write_time(dev, &sys_time);\n+\n+\treturn 0;\n+}\n+\n+void\n+hns3_ptp_uninit(struct hns3_hw *hw)\n+{\n+\tstruct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw);\n+\tint ret;\n+\n+\tif (!hns3_dev_get_support(hw, PTP))\n+\t\treturn;\n+\n+\tret = hns3_ptp_int_en(hw, false);\n+\tif (ret != 0)\n+\t\thns3_err(hw, \"disable PTP interrupt failed, ret = %d.\", ret);\n+\n+\tret = hns3_timesync_configure(hns, false);\n+\tif (ret != 0)\n+\t\thns3_err(hw, \"disable timesync failed, ret = %d.\", ret);\n+}\n", "prefixes": [ "03/11" ] }{ "id": 127666, "url": "