Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127671/?format=api
{ "id": 127671, "url": "http://patchwork.dpdk.org/api/patches/127671/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230529130940.1501-10-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230529130940.1501-10-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230529130940.1501-10-liudongdong3@huawei.com", "date": "2023-05-29T13:09:38", "name": "[09/11] net/hns3: make code more clean", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e4e5ec932bc98b96310cbb96042bf0aef4fdcc8f", "submitter": { "id": 2718, "url": "http://patchwork.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230529130940.1501-10-liudongdong3@huawei.com/mbox/", "series": [ { "id": 28237, "url": "http://patchwork.dpdk.org/api/series/28237/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28237", "date": "2023-05-29T13:09:32", "name": "net/hns3: add some bugfixes for hns3", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28237/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/127671/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/127671/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7E9A042BD3;\n\tMon, 29 May 2023 15:12:53 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0A08E42D56;\n\tMon, 29 May 2023 15:12:22 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 9BCEC42D40;\n Mon, 29 May 2023 15:12:17 +0200 (CEST)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.57])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QVG7v0pwyzLqBy;\n Mon, 29 May 2023 21:09:15 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.23; Mon, 29 May 2023 21:12:13 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>,\n <andrew.rybchenko@oktetlabs.ru>, <fengchengwen@huawei.com>", "CC": "<stable@dpdk.org>, <lihuisong@huawei.com>, <liudongdong3@huawei.com>,\n <yisen.zhuang@huawei.com>, <huangdengdui@huawei.com>", "Subject": "[PATCH 09/11] net/hns3: make code more clean", "Date": "Mon, 29 May 2023 21:09:38 +0800", "Message-ID": "<20230529130940.1501-10-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20230529130940.1501-1-liudongdong3@huawei.com>", "References": "<20230529130940.1501-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems704-chm.china.huawei.com (10.3.19.181) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Dengdui Huang <huangdengdui@huawei.com>\n\nThis patch modify the code that violates the coding standards.\n\nSigned-off-by: Dengdui Huang <huangdengdui@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_regs.c | 3 +--\n drivers/net/hns3/hns3_rxtx.c | 10 +++-------\n 2 files changed, 4 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_regs.c b/drivers/net/hns3/hns3_regs.c\nindex 5d6f92e4bb..be1be6a89c 100644\n--- a/drivers/net/hns3/hns3_regs.c\n+++ b/drivers/net/hns3/hns3_regs.c\n@@ -385,10 +385,9 @@ hns3_dfx_reg_cmd_send(struct hns3_hw *hw, struct hns3_cmd_desc *desc,\n \thns3_cmd_setup_basic_desc(&desc[i], opcode, true);\n \n \tret = hns3_cmd_send(hw, desc, bd_num);\n-\tif (ret) {\n+\tif (ret)\n \t\thns3_err(hw, \"fail to query dfx registers, opcode = 0x%04X, \"\n \t\t\t \"ret = %d.\\n\", opcode, ret);\n-\t}\n \n \treturn ret;\n }\ndiff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c\nindex 2493748683..cf04dc857e 100644\n--- a/drivers/net/hns3/hns3_rxtx.c\n+++ b/drivers/net/hns3/hns3_rxtx.c\n@@ -751,7 +751,7 @@ hns3pf_reset_all_tqps(struct hns3_hw *hw)\n \t\tfor (i = 0; i < hw->cfg_max_queues; i++) {\n \t\t\tret = hns3pf_reset_tqp(hw, i);\n \t\t\tif (ret) {\n-\t\t\t\thns3_err(hw, \"fail to reset tqp, queue_id = %d, ret = %d.\",\n+\t\t\t\thns3_err(hw, \"fail to reset tqp, queue_id = %u, ret = %d.\",\n \t\t\t\t\t i, ret);\n \t\t\t\treturn ret;\n \t\t\t}\n@@ -829,15 +829,13 @@ hns3_send_reset_queue_cmd(struct hns3_hw *hw, uint16_t queue_id,\n {\n \tstruct hns3_reset_tqp_queue_cmd *req;\n \tstruct hns3_cmd_desc desc;\n-\tint queue_direction;\n \tint ret;\n \n \thns3_cmd_setup_basic_desc(&desc, HNS3_OPC_RESET_TQP_QUEUE_INDEP, false);\n \n \treq = (struct hns3_reset_tqp_queue_cmd *)desc.data;\n \treq->tqp_id = rte_cpu_to_le_16(queue_id);\n-\tqueue_direction = queue_type == HNS3_RING_TYPE_TX ? 0 : 1;\n-\treq->queue_direction = rte_cpu_to_le_16(queue_direction);\n+\treq->queue_direction = queue_type == HNS3_RING_TYPE_TX ? 0 : 1;\n \thns3_set_bit(req->reset_req, HNS3_TQP_RESET_B, enable ? 1 : 0);\n \n \tret = hns3_cmd_send(hw, &desc, 1);\n@@ -855,15 +853,13 @@ hns3_get_queue_reset_status(struct hns3_hw *hw, uint16_t queue_id,\n {\n \tstruct hns3_reset_tqp_queue_cmd *req;\n \tstruct hns3_cmd_desc desc;\n-\tint queue_direction;\n \tint ret;\n \n \thns3_cmd_setup_basic_desc(&desc, HNS3_OPC_RESET_TQP_QUEUE_INDEP, true);\n \n \treq = (struct hns3_reset_tqp_queue_cmd *)desc.data;\n \treq->tqp_id = rte_cpu_to_le_16(queue_id);\n-\tqueue_direction = queue_type == HNS3_RING_TYPE_TX ? 0 : 1;\n-\treq->queue_direction = rte_cpu_to_le_16(queue_direction);\n+\treq->queue_direction = queue_type == HNS3_RING_TYPE_TX ? 0 : 1;\n \n \tret = hns3_cmd_send(hw, &desc, 1);\n \tif (ret) {\n", "prefixes": [ "09/11" ] }