Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127696/?format=api
{ "id": 127696, "url": "http://patchwork.dpdk.org/api/patches/127696/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230530090510.56812-9-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230530090510.56812-9-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230530090510.56812-9-haijie1@huawei.com", "date": "2023-05-30T09:05:08", "name": "[08/10] ethdev: support telemetry query RSS info", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "2d998089064332c920e7345efd907cc3fb462600", "submitter": { "id": 2935, "url": "http://patchwork.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230530090510.56812-9-haijie1@huawei.com/mbox/", "series": [ { "id": 28245, "url": "http://patchwork.dpdk.org/api/series/28245/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28245", "date": "2023-05-30T09:05:00", "name": "support telemetry query ethdev info", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28245/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/127696/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/127696/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3CACD42BE1;\n\tTue, 30 May 2023 11:08:23 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8DA5B42D48;\n\tTue, 30 May 2023 11:07:49 +0200 (CEST)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id A131F406BC\n for <dev@dpdk.org>; Tue, 30 May 2023 11:07:43 +0200 (CEST)", "from kwepemi500020.china.huawei.com (unknown [172.30.72.57])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QVmdN43GFzqTQr;\n Tue, 30 May 2023 17:03:04 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.23; Tue, 30 May 2023 17:07:42 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit\n <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "CC": "<dev@dpdk.org>, <liudongdong3@huawei.com>", "Subject": "[PATCH 08/10] ethdev: support telemetry query RSS info", "Date": "Tue, 30 May 2023 17:05:08 +0800", "Message-ID": "<20230530090510.56812-9-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20230530090510.56812-1-haijie1@huawei.com>", "References": "<20230530090510.56812-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n kwepemi500020.china.huawei.com (7.221.188.8)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch supports querying RSS info by telemetry command.\nThe command is like:\n--> /ethdev/rss_info,0\n{\n \"/ethdev/rss_info\": {\n \"rss_hf\": \"0x238c\",\n \"rss_key_len\": 40,\n \"rss_key\": \"6d5a56da255b0ec24167253d43a38fb0d0ca2b\\\n\t cbae7b30b477cb2da38030f20c6a42b73bbeac01fa\"\n }\n}\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n lib/ethdev/rte_ethdev.c | 86 +++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 86 insertions(+)", "diff": "diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex dad9c5538149..6699b40d5e15 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -7432,6 +7432,90 @@ eth_dev_handle_port_dcb(const char *cmd __rte_unused,\n \treturn eth_dev_add_dcb_info(port_id, d);\n }\n \n+static int\n+eth_dev_add_rss_info(struct rte_eth_rss_conf *rss_conf, struct rte_tel_data *d)\n+{\n+\tconst uint32_t key_len = rss_conf->rss_key_len * 2 + 1;\n+\tchar *rss_key;\n+\tchar *key;\n+\tuint32_t i;\n+\tint ret;\n+\n+\tkey = rte_malloc(NULL, key_len, 0);\n+\tif (key == NULL)\n+\t\treturn -ENOMEM;\n+\n+\trss_key = rte_malloc(NULL, key_len, 0);\n+\tif (rss_key == NULL) {\n+\t\tret = -ENOMEM;\n+\t\tgoto free_key;\n+\t}\n+\n+\trte_tel_data_start_dict(d);\n+\trte_tel_data_add_dict_uint_hex(d, \"rss_hf\", rss_conf->rss_hf, 0);\n+\trte_tel_data_add_dict_uint(d, \"rss_key_len\", rss_conf->rss_key_len);\n+\n+\tmemset(rss_key, 0, key_len);\n+\tfor (i = 0; i < rss_conf->rss_key_len; i++) {\n+\t\tret = snprintf(key, key_len, \"%02x\", rss_conf->rss_key[i]);\n+\t\tif (ret < 0)\n+\t\t\tgoto free_rss_key;\n+\t\tstrlcat(rss_key, key, key_len);\n+\t}\n+\tret = rte_tel_data_add_dict_string(d, \"rss_key\", rss_key);\n+\n+free_rss_key:\n+\trte_free(rss_key);\n+free_key:\n+\trte_free(key);\n+\treturn ret;\n+}\n+\n+static int\n+eth_dev_handle_port_rss_info(const char *cmd __rte_unused,\n+\t\tconst char *params,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tstruct rte_eth_dev_info dev_info;\n+\tstruct rte_eth_rss_conf rss_conf;\n+\tunsigned long port_id;\n+\tchar *end_param;\n+\tint ret;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -EINVAL;\n+\n+\tport_id = strtoul(params, &end_param, 0);\n+\tif (*end_param != '\\0')\n+\t\tRTE_ETHDEV_LOG(NOTICE,\n+\t\t\t\"Extra parameters passed to ethdev telemetry command, ignoring\\n\");\n+\n+\tif (port_id >= UINT16_MAX || !rte_eth_dev_is_valid_port(port_id))\n+\t\treturn -EINVAL;\n+\n+\tret = rte_eth_dev_info_get(port_id, &dev_info);\n+\tif (ret != 0) {\n+\t\tRTE_ETHDEV_LOG(ERR,\n+\t\t\t\"Failed to get device info, ret = %d\\n\", ret);\n+\t\treturn ret;\n+\t}\n+\n+\trss_conf.rss_key_len = dev_info.hash_key_size;\n+\trss_conf.rss_key = rte_malloc(NULL, dev_info.hash_key_size, 0);\n+\tif (rss_conf.rss_key == NULL)\n+\t\treturn -ENOMEM;\n+\n+\tret = rte_eth_dev_rss_hash_conf_get(port_id, &rss_conf);\n+\tif (ret != 0) {\n+\t\trte_free(rss_conf.rss_key);\n+\t\treturn ret;\n+\t}\n+\n+\tret = eth_dev_add_rss_info(&rss_conf, d);\n+\trte_free(rss_conf.rss_key);\n+\treturn ret;\n+}\n+\n RTE_LOG_REGISTER_DEFAULT(rte_eth_dev_logtype, INFO);\n \n RTE_INIT(ethdev_init_telemetry)\n@@ -7463,4 +7547,6 @@ RTE_INIT(ethdev_init_telemetry)\n \t\t\t\"Returns Tx queue info for a port. Parameters: unsigned port_id, unsigned queue_id (Optional if only one queue)\");\n \trte_telemetry_register_cmd(\"/ethdev/dcb\", eth_dev_handle_port_dcb,\n \t\t\t\"Returns DCB info for a port. Parameters: unsigned port_id\");\n+\trte_telemetry_register_cmd(\"/ethdev/rss_info\", eth_dev_handle_port_rss_info,\n+\t\t\t\"Returns RSS info for a port. Parameters: unsigned port_id\");\n }\n", "prefixes": [ "08/10" ] }