Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 127697,
    "url": "http://patchwork.dpdk.org/api/patches/127697/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230530090510.56812-10-haijie1@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230530090510.56812-10-haijie1@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230530090510.56812-10-haijie1@huawei.com",
    "date": "2023-05-30T09:05:09",
    "name": "[09/10] ethdev: support telemetry query FEC info",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "c366e03b9f2c729975ae353d0e7207952e3353fe",
    "submitter": {
        "id": 2935,
        "url": "http://patchwork.dpdk.org/api/people/2935/?format=api",
        "name": "Jie Hai",
        "email": "haijie1@huawei.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patchwork.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230530090510.56812-10-haijie1@huawei.com/mbox/",
    "series": [
        {
            "id": 28245,
            "url": "http://patchwork.dpdk.org/api/series/28245/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28245",
            "date": "2023-05-30T09:05:00",
            "name": "support telemetry query ethdev info",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/28245/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/127697/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/127697/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 637CC42BE1;\n\tTue, 30 May 2023 11:08:32 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2669D42D55;\n\tTue, 30 May 2023 11:07:51 +0200 (CEST)",
            "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 3E30C42D17\n for <dev@dpdk.org>; Tue, 30 May 2023 11:07:44 +0200 (CEST)",
            "from kwepemi500020.china.huawei.com (unknown [172.30.72.55])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QVmgJ0lGfzLpvK;\n Tue, 30 May 2023 17:04:44 +0800 (CST)",
            "from localhost.localdomain (10.69.192.56) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.23; Tue, 30 May 2023 17:07:42 +0800"
        ],
        "From": "Jie Hai <haijie1@huawei.com>",
        "To": "Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit\n <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>",
        "CC": "<dev@dpdk.org>, <liudongdong3@huawei.com>",
        "Subject": "[PATCH 09/10] ethdev: support telemetry query FEC info",
        "Date": "Tue, 30 May 2023 17:05:09 +0800",
        "Message-ID": "<20230530090510.56812-10-haijie1@huawei.com>",
        "X-Mailer": "git-send-email 2.33.0",
        "In-Reply-To": "<20230530090510.56812-1-haijie1@huawei.com>",
        "References": "<20230530090510.56812-1-haijie1@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.69.192.56]",
        "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n kwepemi500020.china.huawei.com (7.221.188.8)",
        "X-CFilter-Loop": "Reflected",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "This patch supports getting FEC information by telemetry.\nThe command is like:\n--> /ethdev/fec,0\n{\n  \"/ethdev/fec\": {\n    \"fec_mode\": \"off\",\n    \"fec_capability\": {\n      \"10_Gbps\": \"off auto baser\"\n    }\n  }\n}\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n lib/ethdev/rte_ethdev.c | 145 ++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 145 insertions(+)",
    "diff": "diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex 6699b40d5e15..f7a84ae6c35d 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -160,6 +160,16 @@ enum {\n \tSTAT_QMAP_RX\n };\n \n+static const struct {\n+\tuint32_t capa;\n+\tconst char *name;\n+} rte_eth_fec_capa_name[] = {\n+\t{ RTE_ETH_FEC_MODE_CAPA_MASK(NOFEC),\t\"off\"\t},\n+\t{ RTE_ETH_FEC_MODE_CAPA_MASK(AUTO),\t\"auto\"\t},\n+\t{ RTE_ETH_FEC_MODE_CAPA_MASK(BASER),\t\"baser\"\t},\n+\t{ RTE_ETH_FEC_MODE_CAPA_MASK(RS),\t\"rs\"\t},\n+};\n+\n int\n rte_eth_iterator_init(struct rte_dev_iterator *iter, const char *devargs_str)\n {\n@@ -7516,6 +7526,139 @@ eth_dev_handle_port_rss_info(const char *cmd __rte_unused,\n \treturn ret;\n }\n \n+static const char *\n+eth_dev_fec_capa_to_string(uint32_t fec_capa)\n+{\n+\tuint32_t i;\n+\n+\tfor (i = 0; i < RTE_DIM(rte_eth_fec_capa_name); i++) {\n+\t\tif ((fec_capa & rte_eth_fec_capa_name[i].capa) != 0)\n+\t\t\treturn rte_eth_fec_capa_name[i].name;\n+\t}\n+\n+\treturn \"unknown\";\n+}\n+\n+static void\n+eth_dev_fec_capas_to_string(uint32_t fec_capa, char *fec_name, uint32_t len)\n+{\n+\tbool valid = false;\n+\tsize_t count = 0;\n+\tuint32_t i;\n+\n+\tfor (i = 0; i < RTE_DIM(rte_eth_fec_capa_name); i++) {\n+\t\tif ((fec_capa & rte_eth_fec_capa_name[i].capa) != 0) {\n+\t\t\tstrlcat(fec_name, rte_eth_fec_capa_name[i].name, len);\n+\t\t\tcount = strlcat(fec_name, \" \", len);\n+\t\t\tvalid = true;\n+\t\t}\n+\t}\n+\n+\tif (!valid)\n+\t\tcount = snprintf(fec_name, len, \"unknown \");\n+\n+\tif (count >= len) {\n+\t\tRTE_ETHDEV_LOG(WARNING, \"FEC capa names may be truncated\\n\");\n+\t\tcount = len;\n+\t}\n+\n+\tfec_name[count - 1] = '\\0';\n+}\n+\n+static int\n+eth_dev_get_fec_capability(uint16_t port_id, struct rte_tel_data *d)\n+{\n+\tstruct rte_eth_fec_capa *speed_fec_capa;\n+\tchar fec_name[RTE_TEL_MAX_STRING_LEN];\n+\tchar speed[RTE_TEL_MAX_STRING_LEN];\n+\tuint32_t capa_num;\n+\tuint32_t i, j;\n+\tint ret;\n+\n+\tret = rte_eth_fec_get_capability(port_id, NULL, 0);\n+\tif (ret <= 0)\n+\t\treturn ret == 0 ? -EINVAL : ret;\n+\n+\tcapa_num = ret;\n+\tspeed_fec_capa = calloc(capa_num, sizeof(struct rte_eth_fec_capa));\n+\tif (speed_fec_capa == NULL)\n+\t\treturn -ENOMEM;\n+\n+\tret = rte_eth_fec_get_capability(port_id, speed_fec_capa, capa_num);\n+\tif (ret <= 0) {\n+\t\tret = ret == 0 ? -EINVAL : ret;\n+\t\tgoto out;\n+\t}\n+\n+\tfor (i = 0; i < capa_num; i++) {\n+\t\tmemset(fec_name, 0, RTE_TEL_MAX_STRING_LEN);\n+\t\teth_dev_fec_capas_to_string(speed_fec_capa[i].capa, fec_name,\n+\t\t\t\t\t    RTE_TEL_MAX_STRING_LEN);\n+\n+\t\tmemset(speed, 0, RTE_TEL_MAX_STRING_LEN);\n+\t\tret = snprintf(speed, RTE_TEL_MAX_STRING_LEN, \"%s\",\n+\t\t\trte_eth_link_speed_to_str(speed_fec_capa[i].speed));\n+\t\tif (ret < 0)\n+\t\t\tgoto out;\n+\n+\t\tfor (j = 0; j < strlen(speed); j++) {\n+\t\t\tif (speed[j] == ' ')\n+\t\t\t\tspeed[j] = '_';\n+\t\t}\n+\n+\t\trte_tel_data_add_dict_string(d, speed, fec_name);\n+\t}\n+\n+out:\n+\tfree(speed_fec_capa);\n+\treturn ret > 0 ? 0 : ret;\n+}\n+\n+static int\n+eth_dev_handle_port_fec(const char *cmd __rte_unused,\n+\t\tconst char *params,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tstruct rte_tel_data *fec_capas;\n+\tunsigned long port_id;\n+\tuint32_t fec_mode;\n+\tchar *end_param;\n+\tint ret;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -EINVAL;\n+\n+\tport_id = strtoul(params, &end_param, 0);\n+\tif (*end_param != '\\0')\n+\t\tRTE_ETHDEV_LOG(NOTICE,\n+\t\t\t\"Extra parameters passed to ethdev telemetry command, ignoring\\n\");\n+\n+\tif (port_id >= UINT16_MAX || !rte_eth_dev_is_valid_port(port_id))\n+\t\treturn -EINVAL;\n+\n+\tret = rte_eth_fec_get(port_id, &fec_mode);\n+\tif (ret != 0)\n+\t\treturn ret;\n+\n+\trte_tel_data_start_dict(d);\n+\trte_tel_data_add_dict_string(d, \"fec_mode\",\n+\t\t\t\t     eth_dev_fec_capa_to_string(fec_mode));\n+\n+\tfec_capas = rte_tel_data_alloc();\n+\tif (fec_capas == NULL)\n+\t\treturn -ENOMEM;\n+\n+\trte_tel_data_start_dict(fec_capas);\n+\tret = eth_dev_get_fec_capability(port_id, fec_capas);\n+\tif (ret != 0) {\n+\t\trte_tel_data_free(fec_capas);\n+\t\treturn ret;\n+\t}\n+\n+\trte_tel_data_add_dict_container(d, \"fec_capability\", fec_capas, 0);\n+\treturn 0;\n+}\n+\n RTE_LOG_REGISTER_DEFAULT(rte_eth_dev_logtype, INFO);\n \n RTE_INIT(ethdev_init_telemetry)\n@@ -7549,4 +7692,6 @@ RTE_INIT(ethdev_init_telemetry)\n \t\t\t\"Returns DCB info for a port. Parameters: unsigned port_id\");\n \trte_telemetry_register_cmd(\"/ethdev/rss_info\", eth_dev_handle_port_rss_info,\n \t\t\t\"Returns RSS info for a port. Parameters: unsigned port_id\");\n+\trte_telemetry_register_cmd(\"/ethdev/fec\", eth_dev_handle_port_fec,\n+\t\t\t\"Returns FEC info for a port. Parameters: unsigned port_id\");\n }\n",
    "prefixes": [
        "09/10"
    ]
}