Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127805/?format=api
{ "id": 127805, "url": "http://patchwork.dpdk.org/api/patches/127805/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230531134122.119508-4-artemii.morozov@arknetworks.am/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230531134122.119508-4-artemii.morozov@arknetworks.am>", "list_archive_url": "https://inbox.dpdk.org/dev/20230531134122.119508-4-artemii.morozov@arknetworks.am", "date": "2023-05-31T13:41:22", "name": "[3/3] net/sfc: support VLAN stripping offload", "commit_ref": null, "pull_url": null, "state": "awaiting-upstream", "archived": true, "hash": "aa0e071a92c6c3365e7492f321e142b5e0995a9e", "submitter": { "id": 3083, "url": "http://patchwork.dpdk.org/api/people/3083/?format=api", "name": "Artemii Morozov", "email": "Artemii.Morozov@arknetworks.am" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230531134122.119508-4-artemii.morozov@arknetworks.am/mbox/", "series": [ { "id": 28281, "url": "http://patchwork.dpdk.org/api/series/28281/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28281", "date": "2023-05-31T13:41:19", "name": "net/sfc: support VLAN stripping offload", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28281/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/127805/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/127805/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A8F5B42BF4;\n\tWed, 31 May 2023 15:41:43 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 41C2642D32;\n\tWed, 31 May 2023 15:41:32 +0200 (CEST)", "from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80])\n by mails.dpdk.org (Postfix) with ESMTP id 6B504410EA\n for <dev@dpdk.org>; Wed, 31 May 2023 15:41:28 +0200 (CEST)", "from angrod.. (unknown [37.252.88.70])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by agw.arknetworks.am (Postfix) with ESMTPSA id A1E37E12C3;\n Wed, 31 May 2023 17:41:27 +0400 (+04)" ], "From": "Artemii Morozov <artemii.morozov@arknetworks.am>", "To": "dev@dpdk.org", "Cc": "Ivan Malov <ivan.malov@arknetworks.am>,\n Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Andy Moreton <amoreton@xilinx.com>", "Subject": "[PATCH 3/3] net/sfc: support VLAN stripping offload", "Date": "Wed, 31 May 2023 17:41:22 +0400", "Message-Id": "<20230531134122.119508-4-artemii.morozov@arknetworks.am>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230531134122.119508-1-artemii.morozov@arknetworks.am>", "References": "<20230531134122.119508-1-artemii.morozov@arknetworks.am>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Extract vlan tci provided by the HW in the prefix and put it to mbuf.\nVLAN stripping is supported for ef100 datapath only.\n\nSigned-off-by: Artemii Morozov <artemii.morozov@arknetworks.am>\nReviewed-by: Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>\nReviewed-by: Ivan Malov <ivan.malov@arknetworks.am>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n doc/guides/nics/sfc_efx.rst | 4 ++--\n drivers/net/sfc/sfc_ef100_rx.c | 21 ++++++++++++++++++++-\n drivers/net/sfc/sfc_rx.c | 19 +++++++++++++++++++\n 3 files changed, 41 insertions(+), 3 deletions(-)", "diff": "diff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst\nindex 88d0fdf3c1..98702465f7 100644\n--- a/doc/guides/nics/sfc_efx.rst\n+++ b/doc/guides/nics/sfc_efx.rst\n@@ -80,6 +80,8 @@ SFC EFX PMD has support for:\n \n - Port representors (see :ref: switch_representation)\n \n+- VLAN stripping (if running firmware variant supports it)\n+\n \n Non-supported Features\n ----------------------\n@@ -92,8 +94,6 @@ The features not yet supported include:\n \n - VLAN filtering\n \n-- VLAN stripping\n-\n - LRO\n \n \ndiff --git a/drivers/net/sfc/sfc_ef100_rx.c b/drivers/net/sfc/sfc_ef100_rx.c\nindex 16cd8524d3..b7e3397f77 100644\n--- a/drivers/net/sfc/sfc_ef100_rx.c\n+++ b/drivers/net/sfc/sfc_ef100_rx.c\n@@ -68,6 +68,7 @@ struct sfc_ef100_rxq {\n #define SFC_EF100_RXQ_INGRESS_MPORT\t0x80\n #define SFC_EF100_RXQ_USER_FLAG\t\t0x100\n #define SFC_EF100_RXQ_NIC_DMA_MAP\t0x200\n+#define SFC_EF100_RXQ_VLAN_STRIP\t0x400\n \tunsigned int\t\t\tptr_mask;\n \tunsigned int\t\t\tevq_phase_bit_shift;\n \tunsigned int\t\t\tready_pkts;\n@@ -392,6 +393,7 @@ static const efx_rx_prefix_layout_t sfc_ef100_rx_prefix_layout = {\n \t\tSFC_EF100_RX_PREFIX_FIELD(RSS_HASH, B_FALSE),\n \t\tSFC_EF100_RX_PREFIX_FIELD(USER_FLAG, B_FALSE),\n \t\tSFC_EF100_RX_PREFIX_FIELD(USER_MARK, B_FALSE),\n+\t\tSFC_EF100_RX_PREFIX_FIELD(VLAN_STRIP_TCI, B_FALSE),\n \n #undef\tSFC_EF100_RX_PREFIX_FIELD\n \t}\n@@ -472,6 +474,17 @@ sfc_ef100_rx_prefix_to_offloads(const struct sfc_ef100_rxq *rxq,\n \t\t\t\t\t\tESF_GZ_RX_PREFIX_INGRESS_MPORT);\n \t}\n \n+\tif (rxq->flags & SFC_EF100_RXQ_VLAN_STRIP) {\n+\t\tuint32_t vlan_stripped;\n+\t\tvlan_stripped = EFX_XWORD_FIELD(rx_prefix[0], ESF_GZ_RX_PREFIX_VLAN_STRIPPED);\n+\n+\t\tif (vlan_stripped != 0) {\n+\t\t\tol_flags |= RTE_MBUF_F_RX_VLAN | RTE_MBUF_F_RX_VLAN_STRIPPED;\n+\t\t\tm->vlan_tci = EFX_XWORD_FIELD(rx_prefix[0],\n+\t\t\t\t\t\t\tESF_GZ_RX_PREFIX_VLAN_STRIP_TCI);\n+\t\t}\n+\t}\n+\n \tm->ol_flags = ol_flags;\n \treturn true;\n }\n@@ -882,6 +895,12 @@ sfc_ef100_rx_qstart(struct sfc_dp_rxq *dp_rxq, unsigned int evq_read_ptr,\n \telse\n \t\trxq->flags &= ~SFC_EF100_RXQ_INGRESS_MPORT;\n \n+\tif ((unsup_rx_prefix_fields &\n+\t (1U << EFX_RX_PREFIX_FIELD_VLAN_STRIP_TCI)) == 0)\n+\t\trxq->flags |= SFC_EF100_RXQ_VLAN_STRIP;\n+\telse\n+\t\trxq->flags &= ~SFC_EF100_RXQ_VLAN_STRIP;\n+\n \trxq->prefix_size = pinfo->erpl_length;\n \trxq->rearm_data = sfc_ef100_mk_mbuf_rearm_data(rxq->dp.dpq.port_id,\n \t\t\t\t\t\t rxq->prefix_size);\n@@ -994,7 +1013,7 @@ struct sfc_dp_rx sfc_ef100_rx = {\n \t\t\t\t SFC_DP_RX_FEAT_FLOW_MARK |\n \t\t\t\t SFC_DP_RX_FEAT_INTR |\n \t\t\t\t SFC_DP_RX_FEAT_STATS,\n-\t.dev_offload_capa\t= 0,\n+\t.dev_offload_capa\t= RTE_ETH_RX_OFFLOAD_VLAN_STRIP,\n \t.queue_offload_capa\t= RTE_ETH_RX_OFFLOAD_CHECKSUM |\n \t\t\t\t RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM |\n \t\t\t\t RTE_ETH_RX_OFFLOAD_OUTER_UDP_CKSUM |\ndiff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c\nindex 921d9d9ca0..aae815a653 100644\n--- a/drivers/net/sfc/sfc_rx.c\n+++ b/drivers/net/sfc/sfc_rx.c\n@@ -942,6 +942,9 @@ sfc_rx_get_offload_mask(struct sfc_adapter *sa)\n \tif (encp->enc_rx_include_fcs_supported == 0)\n \t\tno_caps |= RTE_ETH_RX_OFFLOAD_KEEP_CRC;\n \n+\tif (encp->enc_rx_vlan_stripping == 0)\n+\t\tno_caps |= RTE_ETH_RX_OFFLOAD_VLAN_STRIP;\n+\n \treturn ~no_caps;\n }\n \n@@ -1190,6 +1193,16 @@ sfc_rx_qinit(struct sfc_adapter *sa, sfc_sw_index_t sw_index,\n \tif (offloads & RTE_ETH_RX_OFFLOAD_RSS_HASH)\n \t\trxq_info->type_flags |= EFX_RXQ_FLAG_RSS_HASH;\n \n+\n+\tif (sa->eth_dev->data->dev_conf.rxmode.offloads &\n+\t RTE_ETH_RX_OFFLOAD_VLAN_STRIP) {\n+\t\trxq_info->type_flags |= EFX_RXQ_FLAG_VLAN_STRIP;\n+\t} else if (rx_conf->offloads & RTE_ETH_RX_OFFLOAD_VLAN_STRIP) {\n+\t\tsfc_err(sa, \"VLAN stripping must be configured during device configure\");\n+\t\trc = EINVAL;\n+\t\tgoto fail_bad_conf;\n+\t}\n+\n \tif ((sa->negotiated_rx_metadata & RTE_ETH_RX_METADATA_USER_FLAG) != 0)\n \t\trxq_info->type_flags |= EFX_RXQ_FLAG_USER_FLAG;\n \n@@ -1692,6 +1705,12 @@ sfc_rx_check_mode(struct sfc_adapter *sa, struct rte_eth_rxmode *rxmode)\n \t\trxmode->offloads |= RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM;\n \t}\n \n+\tif ((rxmode->offloads & RTE_ETH_RX_OFFLOAD_VLAN_STRIP) &&\n+\t (~offloads_supported & RTE_ETH_RX_OFFLOAD_VLAN_STRIP)) {\n+\t\tsfc_err(sa, \"VLAN stripping offload is requested but not supported\");\n+\t\trc = ENOTSUP;\n+\t}\n+\n \treturn rc;\n }\n \n", "prefixes": [ "3/3" ] }