Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127835/?format=api
{ "id": 127835, "url": "http://patchwork.dpdk.org/api/patches/127835/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230601114220.17796-5-denis.pryazhennikov@arknetworks.am/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230601114220.17796-5-denis.pryazhennikov@arknetworks.am>", "list_archive_url": "https://inbox.dpdk.org/dev/20230601114220.17796-5-denis.pryazhennikov@arknetworks.am", "date": "2023-06-01T11:42:20", "name": "[4/4] net/sfc: add configurable Rx CRC stripping", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e143b1ec8f110057eb6c6d3e23273d0776904769", "submitter": { "id": 3057, "url": "http://patchwork.dpdk.org/api/people/3057/?format=api", "name": "Denis Pryazhennikov", "email": "denis.pryazhennikov@arknetworks.am" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230601114220.17796-5-denis.pryazhennikov@arknetworks.am/mbox/", "series": [ { "id": 28300, "url": "http://patchwork.dpdk.org/api/series/28300/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28300", "date": "2023-06-01T11:42:16", "name": "net/sfc: support KEEP_CRC offload", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28300/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/127835/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/127835/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EEACB42C02;\n\tThu, 1 Jun 2023 13:42:50 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 023CC42D3A;\n\tThu, 1 Jun 2023 13:42:30 +0200 (CEST)", "from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80])\n by mails.dpdk.org (Postfix) with ESMTP id 769FB4161A\n for <dev@dpdk.org>; Thu, 1 Jun 2023 13:42:25 +0200 (CEST)", "from localhost.localdomain (unknown [37.252.90.53])\n (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA512)\n (No client certificate requested)\n by agw.arknetworks.am (Postfix) with ESMTPSA id DBF1FE12C3;\n Thu, 1 Jun 2023 15:42:24 +0400 (+04)" ], "From": "Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>", "To": "dev@dpdk.org", "Cc": "Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>,\n Ferruh Yigit <ferruh.yigit@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Roman Zhukov <roman.zhukov@arknetworks.am>,\n Andy Moreton <amoreton@xilinx.com>", "Subject": "[PATCH 4/4] net/sfc: add configurable Rx CRC stripping", "Date": "Thu, 1 Jun 2023 15:42:20 +0400", "Message-Id": "<20230601114220.17796-5-denis.pryazhennikov@arknetworks.am>", "X-Mailer": "git-send-email 2.37.0 (Apple Git-136)", "In-Reply-To": "<20230601114220.17796-1-denis.pryazhennikov@arknetworks.am>", "References": "<20230601114220.17796-1-denis.pryazhennikov@arknetworks.am>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Configurable Rx CRC stripping is allowed only if\nrunning firmware variant supports it and if NIC is\nconfigured with single PF per port and without VFs.\n\nSigned-off-by: Roman Zhukov <roman.zhukov@arknetworks.am>\nSigned-off-by: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n doc/guides/nics/features/sfc.ini | 1 +\n doc/guides/nics/sfc_efx.rst | 6 ++++--\n drivers/net/sfc/sfc.h | 1 +\n drivers/net/sfc/sfc_ef10_rx.c | 3 ++-\n drivers/net/sfc/sfc_port.c | 12 ++++++++++++\n drivers/net/sfc/sfc_rx.c | 6 +++++-\n 6 files changed, 25 insertions(+), 4 deletions(-)", "diff": "diff --git a/doc/guides/nics/features/sfc.ini b/doc/guides/nics/features/sfc.ini\nindex f5ac644278ae..c41c47a63d49 100644\n--- a/doc/guides/nics/features/sfc.ini\n+++ b/doc/guides/nics/features/sfc.ini\n@@ -23,6 +23,7 @@ RSS key update = Y\n RSS reta update = Y\n SR-IOV = Y\n Flow control = Y\n+CRC offload = Y\n VLAN offload = P\n L3 checksum offload = Y\n L4 checksum offload = Y\ndiff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst\nindex de0656876b96..b3a44e7ddd92 100644\n--- a/doc/guides/nics/sfc_efx.rst\n+++ b/doc/guides/nics/sfc_efx.rst\n@@ -114,6 +114,10 @@ SFC EFX PMD has support for:\n \n - Loopback\n \n+- Configurable Rx CRC stripping (if running firmware variant supports it and\n+ if NIC is configured with single PF per port and without VFs, otherwise\n+ always stripped)\n+\n - SR-IOV PF\n \n - Port representors (see :ref: switch_representation)\n@@ -126,8 +130,6 @@ The features not yet supported include:\n \n - Priority-based flow control\n \n-- Configurable RX CRC stripping (always stripped)\n-\n - Header split on receive\n \n - VLAN filtering\ndiff --git a/drivers/net/sfc/sfc.h b/drivers/net/sfc/sfc.h\nindex 730d054aea74..5c97d5911eb2 100644\n--- a/drivers/net/sfc/sfc.h\n+++ b/drivers/net/sfc/sfc.h\n@@ -72,6 +72,7 @@ struct sfc_port {\n \tunsigned int\t\t\tflow_ctrl;\n \tboolean_t\t\t\tflow_ctrl_autoneg;\n \tsize_t\t\t\t\tpdu;\n+\tboolean_t\t\t\tinclude_fcs;\n \n \t/*\n \t * Flow API isolated mode overrides promisc and allmulti settings;\ndiff --git a/drivers/net/sfc/sfc_ef10_rx.c b/drivers/net/sfc/sfc_ef10_rx.c\nindex 7be224c9c412..08fe41fe5d94 100644\n--- a/drivers/net/sfc/sfc_ef10_rx.c\n+++ b/drivers/net/sfc/sfc_ef10_rx.c\n@@ -826,7 +826,8 @@ struct sfc_dp_rx sfc_ef10_rx = {\n \t.dev_offload_capa\t= RTE_ETH_RX_OFFLOAD_CHECKSUM |\n \t\t\t\t RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM |\n \t\t\t\t RTE_ETH_RX_OFFLOAD_RSS_HASH,\n-\t.queue_offload_capa\t= RTE_ETH_RX_OFFLOAD_SCATTER,\n+\t.queue_offload_capa\t= RTE_ETH_RX_OFFLOAD_SCATTER |\n+\t\t\t\t RTE_ETH_RX_OFFLOAD_KEEP_CRC,\n \t.get_dev_info\t\t= sfc_ef10_rx_get_dev_info,\n \t.qsize_up_rings\t\t= sfc_ef10_rx_qsize_up_rings,\n \t.qcreate\t\t= sfc_ef10_rx_qcreate,\ndiff --git a/drivers/net/sfc/sfc_port.c b/drivers/net/sfc/sfc_port.c\nindex 5f312ab1ba83..24d2daf6282b 100644\n--- a/drivers/net/sfc/sfc_port.c\n+++ b/drivers/net/sfc/sfc_port.c\n@@ -250,6 +250,11 @@ sfc_port_start(struct sfc_adapter *sa)\n \tif (rc != 0)\n \t\tgoto fail_mac_pdu_set;\n \n+\tsfc_log_init(sa, \"set include FCS=%u\", port->include_fcs);\n+\trc = efx_mac_include_fcs_set(sa->nic, port->include_fcs);\n+\tif (rc != 0)\n+\t\tgoto fail_include_fcs_set;\n+\n \tif (!sfc_sa2shared(sa)->isolated) {\n \t\tstruct rte_ether_addr *addr = &port->default_mac_addr;\n \n@@ -337,6 +342,7 @@ sfc_port_start(struct sfc_adapter *sa)\n \t(void)efx_mac_drain(sa->nic, B_TRUE);\n \n fail_mac_drain:\n+fail_include_fcs_set:\n fail_mac_stats_upload:\n \t(void)efx_mac_stats_periodic(sa->nic, &port->mac_stats_dma_mem,\n \t\t\t\t 0, B_FALSE);\n@@ -384,11 +390,17 @@ sfc_port_configure(struct sfc_adapter *sa)\n {\n \tconst struct rte_eth_dev_data *dev_data = sa->eth_dev->data;\n \tstruct sfc_port *port = &sa->port;\n+\tconst struct rte_eth_rxmode *rxmode = &dev_data->dev_conf.rxmode;\n \n \tsfc_log_init(sa, \"entry\");\n \n \tport->pdu = EFX_MAC_PDU(dev_data->mtu);\n \n+\tif (rxmode->offloads & RTE_ETH_RX_OFFLOAD_KEEP_CRC)\n+\t\tport->include_fcs = true;\n+\telse\n+\t\tport->include_fcs = false;\n+\n \treturn 0;\n }\n \ndiff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c\nindex edd0f0c03842..f80771778c64 100644\n--- a/drivers/net/sfc/sfc_rx.c\n+++ b/drivers/net/sfc/sfc_rx.c\n@@ -655,7 +655,8 @@ struct sfc_dp_rx sfc_efx_rx = {\n \t.features\t\t= SFC_DP_RX_FEAT_INTR,\n \t.dev_offload_capa\t= RTE_ETH_RX_OFFLOAD_CHECKSUM |\n \t\t\t\t RTE_ETH_RX_OFFLOAD_RSS_HASH,\n-\t.queue_offload_capa\t= RTE_ETH_RX_OFFLOAD_SCATTER,\n+\t.queue_offload_capa\t= RTE_ETH_RX_OFFLOAD_SCATTER |\n+\t\t\t\t RTE_ETH_RX_OFFLOAD_KEEP_CRC,\n \t.qsize_up_rings\t\t= sfc_efx_rx_qsize_up_rings,\n \t.qcreate\t\t= sfc_efx_rx_qcreate,\n \t.qdestroy\t\t= sfc_efx_rx_qdestroy,\n@@ -938,6 +939,9 @@ sfc_rx_get_offload_mask(struct sfc_adapter *sa)\n \tif (encp->enc_tunnel_encapsulations_supported == 0)\n \t\tno_caps |= RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM;\n \n+\tif (encp->enc_rx_include_fcs_supported == 0)\n+\t\tno_caps |= RTE_ETH_RX_OFFLOAD_KEEP_CRC;\n+\n \treturn ~no_caps;\n }\n \n", "prefixes": [ "4/4" ] }