Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 127842,
    "url": "http://patchwork.dpdk.org/api/patches/127842/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230601150106.18375-3-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230601150106.18375-3-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230601150106.18375-3-stephen@networkplumber.org",
    "date": "2023-06-01T15:00:43",
    "name": "[02/25] examples: use strlcpy instead of snprintf",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "5752eebaa646d7dbe0c25b720227aa35cea00fc3",
    "submitter": {
        "id": 27,
        "url": "http://patchwork.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230601150106.18375-3-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 28302,
            "url": "http://patchwork.dpdk.org/api/series/28302/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28302",
            "date": "2023-06-01T15:00:41",
            "name": "replace snprintf with strlcpy",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/28302/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/127842/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/127842/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5AF2742C04;\n\tThu,  1 Jun 2023 17:01:35 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D826C42D38;\n\tThu,  1 Jun 2023 17:01:16 +0200 (CEST)",
            "from mail-pl1-f173.google.com (mail-pl1-f173.google.com\n [209.85.214.173])\n by mails.dpdk.org (Postfix) with ESMTP id 3FEDF42D32\n for <dev@dpdk.org>; Thu,  1 Jun 2023 17:01:16 +0200 (CEST)",
            "by mail-pl1-f173.google.com with SMTP id\n d9443c01a7336-1b01d3bb571so4235445ad.2\n for <dev@dpdk.org>; Thu, 01 Jun 2023 08:01:16 -0700 (PDT)",
            "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.13\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 01 Jun 2023 08:01:14 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631675;\n x=1688223675;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=gIvha0+GOXub4tzHETH9R4qYWzELpkNT71kklhQwYlo=;\n b=hEMT5RGZpn3MtPKmGSBFliiRRmY8G14b2wQCxTR150FxOSaPmEACmzYGghejomwzSf\n 9loocmBfKj0n3j+FwKOxc0/Yd6tqpp3OcjhP0I5tYxx8NplEulzEYwoJZAsROjgDUgan\n U/YBu6wua0isiEF6/5C6mqBM6OyTc9dV+XhOaX26ubBWF8FFhp/F7BCjd/qEyeIcunjT\n zSxbjdryP8NaeClbKgYj7sDC9Xprrpr4g+ECtEr30HdR9/Mpmort4KcG1Us9uatF9trD\n RMqcDJoZdGuOLvFUAOzpmcHpRer/nrdSz9wg8UQrydwCrUpceZdFEz5oVl+TrQ738hg+\n 0jzw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1685631675; x=1688223675;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=gIvha0+GOXub4tzHETH9R4qYWzELpkNT71kklhQwYlo=;\n b=FrRxKIe4yVPaOLmN8lckg17SZVaL+M//9TDkfKRQeSdihJXRIlYHLH8eqv/2Ss+Sjt\n cA1m1h2QgI3C+etlStO2RI5J+0squ8kmlutc7IOe+meXxANmEUWnz4ngiuV4jizNQuPP\n NSayzNLdlkFWT2kPs2rwZ/21x75frfPJcOkSYs4mF+2Eqp2ytU4EARGuVFqM9tPWFcOO\n +MlvWDteuj1LEXfdOzI2i8HNBj2mmb3phreUihurPzTjk489Zx8wJYsbddq+jTv21lJs\n VI4bdv6joH0kGwT0txV1t+341K3cYCTGENmNflrtA93dqJJD++q5qkWzv2XPPgh6DvP7\n jVpQ==",
        "X-Gm-Message-State": "AC+VfDylGdIdKxEooLpItztV+s97k1ihPHUtoKpoUHFidAuzFSBBTXb3\n SbasRsgPJBxmy8N7is12eGG9UzjvddyvnibyAZnjsA==",
        "X-Google-Smtp-Source": "\n ACHHUZ6TFasnnPaCaLcFYKWvNUyTwQ45V7kAW2JXrYjjwgbRbDPKbahPZxPuQAXGUJCvafXx5jbXHw==",
        "X-Received": "by 2002:a17:902:d4c4:b0:19f:8ad5:4331 with SMTP id\n o4-20020a170902d4c400b0019f8ad54331mr7602155plg.38.1685631675230;\n Thu, 01 Jun 2023 08:01:15 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Brian Dooley <brian.dooley@intel.com>,\n Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>,\n Jerin Jacob <jerinj@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbo.xia@intel.com>",
        "Subject": "[PATCH 02/25] examples: use strlcpy instead of snprintf",
        "Date": "Thu,  1 Jun 2023 08:00:43 -0700",
        "Message-Id": "<20230601150106.18375-3-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.39.2",
        "In-Reply-To": "<20230601150106.18375-1-stephen@networkplumber.org>",
        "References": "<20230601150106.18375-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Replace snprintf() with strlcpy() where possible.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n examples/fips_validation/fips_validation.c | 8 ++++----\n examples/l3fwd-graph/main.c                | 2 +-\n examples/pipeline/cli.c                    | 2 +-\n examples/vhost_blk/vhost_blk.c             | 5 ++---\n 4 files changed, 8 insertions(+), 9 deletions(-)",
    "diff": "diff --git a/examples/fips_validation/fips_validation.c b/examples/fips_validation/fips_validation.c\nindex f840804009ed..6e913898074d 100644\n--- a/examples/fips_validation/fips_validation.c\n+++ b/examples/fips_validation/fips_validation.c\n@@ -505,8 +505,8 @@ fips_test_parse_one_json_group(void)\n \n \t\t\tswitch (json_typeof(param)) {\n \t\t\tcase JSON_STRING:\n-\t\t\t\tsnprintf(json_value, sizeof(json_value), \"%s\",\n-\t\t\t\t\t\t json_string_value(param));\n+\t\t\t\tstrlcpy(json_value, json_string_value(param),\n+\t\t\t\t\tsizeof(json_value));\n \t\t\t\tbreak;\n \n \t\t\tcase JSON_INTEGER:\n@@ -550,8 +550,8 @@ fips_test_parse_one_json_case(void)\n \n \t\tswitch (json_typeof(param)) {\n \t\tcase JSON_STRING:\n-\t\t\tsnprintf(info.one_line_text, MAX_LINE_CHAR, \"%s\",\n-\t\t\t\t\t json_string_value(param));\n+\t\t\tstrlcpy(info.one_line_text, json_string_value(param),\n+\t\t\t\tMAX_LINE_CHAR);\n \t\t\tbreak;\n \n \t\tcase JSON_INTEGER:\ndiff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c\nindex 5feeab4f0fb0..ee8f247108ad 100644\n--- a/examples/l3fwd-graph/main.c\n+++ b/examples/l3fwd-graph/main.c\n@@ -546,7 +546,7 @@ parse_args(int argc, char **argv)\n \t\t\tbreak;\n \n \t\tcase CMD_LINE_OPT_PCAP_FILENAME_CAP:\n-\t\t\trte_strlcpy(pcap_filename, optarg,\n+\t\t\tstrlcpy(pcap_filename, optarg,\n \t\t\t\t    sizeof(pcap_filename));\n \t\t\tprintf(\"Pcap file name: %s\\n\", pcap_filename);\n \t\t\tbreak;\ndiff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c\nindex 2ae6cc579ff2..514b6d779212 100644\n--- a/examples/pipeline/cli.c\n+++ b/examples/pipeline/cli.c\n@@ -3164,7 +3164,7 @@ cmd_ipsec_sa_add(char **tokens,\n \t\t\tgoto free;\n \t\t}\n \n-\t\tsnprintf(out, out_size, \"%s\", line);\n+\t\tstrlcpy(out, line, out_size);\n \t\tout_size -= strlen(out);\n \t\tout += strlen(out);\n \ndiff --git a/examples/vhost_blk/vhost_blk.c b/examples/vhost_blk/vhost_blk.c\nindex 3709d7ed06ba..3b05df390cce 100644\n--- a/examples/vhost_blk/vhost_blk.c\n+++ b/examples/vhost_blk/vhost_blk.c\n@@ -771,9 +771,8 @@ vhost_blk_bdev_construct(const char *bdev_name,\n \tif (!bdev)\n \t\treturn NULL;\n \n-\tsnprintf(bdev->name, sizeof(bdev->name), \"%s\", bdev_name);\n-\tsnprintf(bdev->product_name, sizeof(bdev->product_name), \"%s\",\n-\t\t bdev_serial);\n+\tstrlcpy(bdev->name, bdev_name, sizeof(bdev->name));\n+\tstrlcpy(bdev->product_name, bdev_serial, sizeof(bdev->product_name));\n \tbdev->blocklen = blk_size;\n \tbdev->blockcnt = blk_cnt;\n \tbdev->write_cache = wce_enable;\n",
    "prefixes": [
        "02/25"
    ]
}