Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127857/?format=api
{ "id": 127857, "url": "http://patchwork.dpdk.org/api/patches/127857/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230601150106.18375-18-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230601150106.18375-18-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230601150106.18375-18-stephen@networkplumber.org", "date": "2023-06-01T15:00:58", "name": "[17/25] net/hinic: replace snptintf with strlcpy", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "2bf37f0eda0784bd5bf6cdc19bfa27cc3339a623", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230601150106.18375-18-stephen@networkplumber.org/mbox/", "series": [ { "id": 28302, "url": "http://patchwork.dpdk.org/api/series/28302/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28302", "date": "2023-06-01T15:00:41", "name": "replace snprintf with strlcpy", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28302/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/127857/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/127857/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C9BC142C04;\n\tThu, 1 Jun 2023 17:04:16 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8BDF742DBF;\n\tThu, 1 Jun 2023 17:01:35 +0200 (CEST)", "from mail-pl1-f171.google.com (mail-pl1-f171.google.com\n [209.85.214.171])\n by mails.dpdk.org (Postfix) with ESMTP id B72D042DAB\n for <dev@dpdk.org>; Thu, 1 Jun 2023 17:01:32 +0200 (CEST)", "by mail-pl1-f171.google.com with SMTP id\n d9443c01a7336-1b0218c979cso5065735ad.3\n for <dev@dpdk.org>; Thu, 01 Jun 2023 08:01:32 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.30\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 01 Jun 2023 08:01:31 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631691;\n x=1688223691;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=CTvwsqDlltB9bgXoPUp/FsEl/z0wa37pIpMd9rwJ9rk=;\n b=wXu0wNwT5SlTXf4IP5yuooHR/9mCHMI6HZ7wedYvESlTKQXebo6Vr6oe1/5GmVAIBb\n G9FrUbXvIdPVy1yaPCwy23vTaiQ40Js2iRDOis3sN7ls+dKke6ejX6V4vMewotsHCcuE\n BK4CYXtfRhq05bNCqNYjphCkGkEc70pTwKsn8NVQp05cCqajU6YhhR/Cv6V8uDTEPw9E\n xDXiH7u1x3WBJb9QsEXnw9uUXWVGHAHA+czU2kuQvLB8nxRWiOmpOrFeZKI2fKtwBfjr\n vG2dhEJQI15kjFgLX28/3ucidSThvin5KI7AXukrXWwnrpr9RHTghd2m+FjsQbsFtIjD\n +dMw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1685631691; x=1688223691;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=CTvwsqDlltB9bgXoPUp/FsEl/z0wa37pIpMd9rwJ9rk=;\n b=Nn72GJOHbwFKCXw94YzxTMNtk0BTywT8Za7yoVBOsci+kmBv379wr4iAnXrsgV07XT\n f8Fw7+P4BQFcz2DkulzvPZkiL8QIqVyG5YUHJFuGDyMA8FYwS9B93O3j2aGcz+eZwS5H\n Hs9sON08yt5KzueHyceJBSB8eyY571UL11gys2CyOydjfURm04KPwruLljJMWJIEtAf0\n inPs8F2BjwMTPxNvfJAJj4ZbURj+SSu4Yrjias9N+f8cHIU+ioKjKkrs+fHKmxJkUk9h\n hRJGVTmOIHe4ize8Z7dz6RjHmL8hWOJH7d18/b3UlWrc9bVJCmMNEJLqzf6WTfdVpq6h\n ypUg==", "X-Gm-Message-State": "AC+VfDxDLsa+Tl1SLyzRuet9A7dD2J1ADnQ5reNqIh3+bY3Hqwq2UggH\n ehxhfntddLVfVZ2znLMex+YCEq/daReZBQRL02+WRg==", "X-Google-Smtp-Source": "\n ACHHUZ4K5q+LxL0u6snECZ9ZD/leM8UXB6gik353uU27L8A1tlTVNV2jq2fJuSdfeIFtfEUYQ14QsQ==", "X-Received": "by 2002:a17:902:aa09:b0:1ad:edbd:8541 with SMTP id\n be9-20020a170902aa0900b001adedbd8541mr6124504plb.13.1685631691536;\n Thu, 01 Jun 2023 08:01:31 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Ziyang Xuan <xuanziyang2@huawei.com>,\n Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,\n Guoyang Zhou <zhouguoyang@huawei.com>", "Subject": "[PATCH 17/25] net/hinic: replace snptintf with strlcpy", "Date": "Thu, 1 Jun 2023 08:00:58 -0700", "Message-Id": "<20230601150106.18375-18-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230601150106.18375-1-stephen@networkplumber.org>", "References": "<20230601150106.18375-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Suggested by devtools/cocci/strlcpy-with-header.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/hinic/base/hinic_compat.h | 1 +\n drivers/net/hinic/base/hinic_pmd_niccfg.c | 4 +---\n drivers/net/hinic/hinic_pmd_ethdev.c | 14 +++++++-------\n 3 files changed, 9 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/hinic/base/hinic_compat.h b/drivers/net/hinic/base/hinic_compat.h\nindex aea332046ede..e8d0badb792a 100644\n--- a/drivers/net/hinic/base/hinic_compat.h\n+++ b/drivers/net/hinic/base/hinic_compat.h\n@@ -19,6 +19,7 @@\n #include <rte_spinlock.h>\n #include <rte_cycles.h>\n #include <rte_log.h>\n+#include <rte_string_fns.h>\n \n typedef uint8_t u8;\n typedef int8_t s8;\ndiff --git a/drivers/net/hinic/base/hinic_pmd_niccfg.c b/drivers/net/hinic/base/hinic_pmd_niccfg.c\nindex 8c08d63286df..eb127a308a0b 100644\n--- a/drivers/net/hinic/base/hinic_pmd_niccfg.c\n+++ b/drivers/net/hinic/base/hinic_pmd_niccfg.c\n@@ -1337,7 +1337,7 @@ int hinic_get_mgmt_version(void *hwdev, char *fw)\n \t\treturn -EIO;\n \t}\n \n-\tsnprintf(fw, HINIC_MGMT_VERSION_MAX_LEN, \"%s\", fw_ver.ver);\n+\tstrlcpy(fw, (const char *)fw_ver.ver, HINIC_MGMT_VERSION_MAX_LEN);\n \n \treturn 0;\n }\n@@ -2115,5 +2115,3 @@ int hinic_set_fdir_tcam_rule_filter(void *hwdev, bool enable)\n \n \treturn err;\n }\n-\n-\ndiff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c\nindex 7aa5e7d8e929..bb4d5a3f0f85 100644\n--- a/drivers/net/hinic/hinic_pmd_ethdev.c\n+++ b/drivers/net/hinic/hinic_pmd_ethdev.c\n@@ -786,7 +786,7 @@ static int hinic_fw_version_get(struct rte_eth_dev *dev, char *fw_version,\n \tif (fw_size < strlen(fw_ver) + 1)\n \t\treturn (strlen(fw_ver) + 1);\n \n-\tsnprintf(fw_version, fw_size, \"%s\", fw_ver);\n+\tstrlcpy(fw_version, fw_ver, fw_size);\n \n \treturn 0;\n }\n@@ -2302,9 +2302,9 @@ static int hinic_dev_xstats_get_names(struct rte_eth_dev *dev,\n \n \t/* get vport stats */\n \tfor (i = 0; i < HINIC_VPORT_XSTATS_NUM; i++) {\n-\t\tsnprintf(xstats_names[count].name,\n-\t\t\t sizeof(xstats_names[count].name),\n-\t\t\t \"%s\", hinic_vport_stats_strings[i].name);\n+\t\tstrlcpy(xstats_names[count].name,\n+\t\t\thinic_vport_stats_strings[i].name,\n+\t\t\tsizeof(xstats_names[count].name));\n \t\tcount++;\n \t}\n \n@@ -2313,9 +2313,9 @@ static int hinic_dev_xstats_get_names(struct rte_eth_dev *dev,\n \n \t/* get phy port stats */\n \tfor (i = 0; i < HINIC_PHYPORT_XSTATS_NUM; i++) {\n-\t\tsnprintf(xstats_names[count].name,\n-\t\t\t sizeof(xstats_names[count].name),\n-\t\t\t \"%s\", hinic_phyport_stats_strings[i].name);\n+\t\tstrlcpy(xstats_names[count].name,\n+\t\t\thinic_phyport_stats_strings[i].name,\n+\t\t\tsizeof(xstats_names[count].name));\n \t\tcount++;\n \t}\n \n", "prefixes": [ "17/25" ] }