Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 127859,
    "url": "http://patchwork.dpdk.org/api/patches/127859/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230601150106.18375-20-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230601150106.18375-20-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230601150106.18375-20-stephen@networkplumber.org",
    "date": "2023-06-01T15:01:00",
    "name": "[19/25] net/intel: replace snprintf with strlcpy",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "01b7217f95bee3723a8f93df8e1e7a448aa9f376",
    "submitter": {
        "id": 27,
        "url": "http://patchwork.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230601150106.18375-20-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 28302,
            "url": "http://patchwork.dpdk.org/api/series/28302/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28302",
            "date": "2023-06-01T15:00:41",
            "name": "replace snprintf with strlcpy",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/28302/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/127859/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/127859/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B365B42C04;\n\tThu,  1 Jun 2023 17:04:38 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 01AD942F94;\n\tThu,  1 Jun 2023 17:01:38 +0200 (CEST)",
            "from mail-pl1-f176.google.com (mail-pl1-f176.google.com\n [209.85.214.176])\n by mails.dpdk.org (Postfix) with ESMTP id A4DEF42DBC\n for <dev@dpdk.org>; Thu,  1 Jun 2023 17:01:34 +0200 (CEST)",
            "by mail-pl1-f176.google.com with SMTP id\n d9443c01a7336-1b0201d9a9eso8160545ad.0\n for <dev@dpdk.org>; Thu, 01 Jun 2023 08:01:34 -0700 (PDT)",
            "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.32\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 01 Jun 2023 08:01:33 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631693;\n x=1688223693;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=jgRGa9fj99icTw6Fj7eUMSpK1g2HT9wjEmFLEFL4/bA=;\n b=xSu9HtwammUZJUsOd8kcOZoPhgCWSfjERRvFVIH96/1MGFMh7SIx/JsQ2szw5WZrib\n K2GLiSNyw/HAz96v80N6RR76APvLRmyGXWDxYgG6fCD6DyGtvNalAY4jb7yP+JkDArq3\n gW/6qMV3/IDZeNDPKDBUfkanlfg+Way/p7fF84Xk2J2BsZLVHMCotmGwHrrMJ+j/CAUV\n HRhclmjSkQigY6zUfPIKBVUdVAOIuqrST8InuJcnkgepCcTFawuNnQlN6a7dIZaFcfvc\n eUFSlmyrGlmhPb5ztLbFDtZqBf5FHkOV6MC8Bfqn8XR9sa/6qThiz35KYi16+LT3uv7p\n Oehg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1685631693; x=1688223693;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=jgRGa9fj99icTw6Fj7eUMSpK1g2HT9wjEmFLEFL4/bA=;\n b=AYKH7KIHkI13/Ymzs/4Yq8x/B/3Zd8naQaLN9rw3RU3vhzbTKssSHSRBC9yEREUl+H\n KfLOL7504GjYHavqQm6Jbc5r5Vw4+yZ0yJeCWs1KzasFKHQs1+8rbrUb0ulftu1Fyjdn\n 7cP66H+JurM/Apn+3mHuYCk8JbsW8/q+pIlW/79UyY6S8KTi8yb8uwwKpoZpg8nQz4Yv\n 00EZth7BDuCZArputCYvKp6XYj9oRnXAgjlm5EHRB0L+IprP9zT/qGgmdXdwdbpHbipc\n BqmZ7pbyZOUF9vBRx+js1p0Ssm0KD+q8f1jLqDE3v08U6qp4GKsvAlLAuI56XVS1+JTg\n ftXw==",
        "X-Gm-Message-State": "AC+VfDyuLR1sSmQzDUeM1IoXw637fzy/2/9Fi46j20sPWgFtm6mRAOzG\n YAlL4f/PwDQ9wy3zs2x0tCAeoGzhZ0XJBQaqO9IFLg==",
        "X-Google-Smtp-Source": "\n ACHHUZ5IroQoBo5fm39sl9qPqrLY4HkrFXej9ZZ+b5GmyFWdFWNPZBP8wyJfBtgh79JnvlRhwAAYsw==",
        "X-Received": "by 2002:a17:902:ea0b:b0:1b0:56cf:b89d with SMTP id\n s11-20020a170902ea0b00b001b056cfb89dmr2650501plg.12.1685631693593;\n Thu, 01 Jun 2023 08:01:33 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Qi Zhang <qi.z.zhang@intel.com>, Xiao Wang <xiao.w.wang@intel.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>, Beilei Xing <beilei.xing@intel.com>,\n Jingjing Wu <jingjing.wu@intel.com>, Qiming Yang <qiming.yang@intel.com>",
        "Subject": "[PATCH 19/25] net/intel: replace snprintf with strlcpy",
        "Date": "Thu,  1 Jun 2023 08:01:00 -0700",
        "Message-Id": "<20230601150106.18375-20-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.39.2",
        "In-Reply-To": "<20230601150106.18375-1-stephen@networkplumber.org>",
        "References": "<20230601150106.18375-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Suggested by devtools/cocci/strlcpy-with-header.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/fm10k/fm10k_ethdev.c | 6 +++---\n drivers/net/i40e/i40e_rxtx.c     | 8 ++++----\n drivers/net/iavf/iavf_ethdev.c   | 6 +++---\n drivers/net/ice/ice_dcf_ethdev.c | 6 +++---\n drivers/net/ice/ice_rxtx.c       | 8 ++++----\n drivers/net/idpf/idpf_ethdev.c   | 6 +++---\n 6 files changed, 20 insertions(+), 20 deletions(-)",
    "diff": "diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex 4d3c4c10cfa4..cb8cf1a8a8ea 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -1244,9 +1244,9 @@ static int fm10k_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n \n \t\t/* Global stats */\n \t\tfor (i = 0; i < FM10K_NB_HW_XSTATS; i++) {\n-\t\t\tsnprintf(xstats_names[count].name,\n-\t\t\t\tsizeof(xstats_names[count].name),\n-\t\t\t\t\"%s\", fm10k_hw_stats_strings[count].name);\n+\t\t\tstrlcpy(xstats_names[count].name,\n+\t\t\t\tfm10k_hw_stats_strings[count].name,\n+\t\t\t\tsizeof(xstats_names[count].name));\n \t\t\tcount++;\n \t\t}\n \ndiff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c\nindex 788ffb51c272..54fb9b9c15ec 100644\n--- a/drivers/net/i40e/i40e_rxtx.c\n+++ b/drivers/net/i40e/i40e_rxtx.c\n@@ -3395,8 +3395,8 @@ i40e_rx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id,\n \n \tfor (i = 0; i < RTE_DIM(i40e_rx_burst_infos); ++i) {\n \t\tif (pkt_burst == i40e_rx_burst_infos[i].pkt_burst) {\n-\t\t\tsnprintf(mode->info, sizeof(mode->info), \"%s\",\n-\t\t\t\t i40e_rx_burst_infos[i].info);\n+\t\t\tstrlcpy(mode->info, i40e_rx_burst_infos[i].info,\n+\t\t\t\tsizeof(mode->info));\n \t\t\tret = 0;\n \t\t\tbreak;\n \t\t}\n@@ -3526,8 +3526,8 @@ i40e_tx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id,\n \n \tfor (i = 0; i < RTE_DIM(i40e_tx_burst_infos); ++i) {\n \t\tif (pkt_burst == i40e_tx_burst_infos[i].pkt_burst) {\n-\t\t\tsnprintf(mode->info, sizeof(mode->info), \"%s\",\n-\t\t\t\t i40e_tx_burst_infos[i].info);\n+\t\t\tstrlcpy(mode->info, i40e_tx_burst_infos[i].info,\n+\t\t\t\tsizeof(mode->info));\n \t\t\tret = 0;\n \t\t\tbreak;\n \t\t}\ndiff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex f6d68403ce71..f3474f6faccb 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -1802,9 +1802,9 @@ static int iavf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n \n \tif (xstats_names != NULL)\n \t\tfor (i = 0; i < IAVF_NB_XSTATS; i++) {\n-\t\t\tsnprintf(xstats_names[i].name,\n-\t\t\t\tsizeof(xstats_names[i].name),\n-\t\t\t\t\"%s\", rte_iavf_stats_strings[i].name);\n+\t\t\tstrlcpy(xstats_names[i].name,\n+\t\t\t\trte_iavf_stats_strings[i].name,\n+\t\t\t\tsizeof(xstats_names[i].name));\n \t\t}\n \treturn IAVF_NB_XSTATS;\n }\ndiff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c\nindex dcbf2af5b039..ea5296b54246 100644\n--- a/drivers/net/ice/ice_dcf_ethdev.c\n+++ b/drivers/net/ice/ice_dcf_ethdev.c\n@@ -1549,9 +1549,9 @@ static int ice_dcf_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n \n \tif (xstats_names != NULL)\n \t\tfor (i = 0; i < ICE_DCF_NB_XSTATS; i++) {\n-\t\t\tsnprintf(xstats_names[i].name,\n-\t\t\t\tsizeof(xstats_names[i].name),\n-\t\t\t\t\"%s\", rte_ice_dcf_stats_strings[i].name);\n+\t\t\tstrlcpy(xstats_names[i].name,\n+\t\t\t\trte_ice_dcf_stats_strings[i].name,\n+\t\t\t\tsizeof(xstats_names[i].name));\n \t\t}\n \treturn ICE_DCF_NB_XSTATS;\n }\ndiff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c\nindex 0ea0045836cc..bde52f7532fb 100644\n--- a/drivers/net/ice/ice_rxtx.c\n+++ b/drivers/net/ice/ice_rxtx.c\n@@ -3605,8 +3605,8 @@ ice_rx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id,\n \n \tfor (i = 0; i < RTE_DIM(ice_rx_burst_infos); ++i) {\n \t\tif (pkt_burst == ice_rx_burst_infos[i].pkt_burst) {\n-\t\t\tsnprintf(mode->info, sizeof(mode->info), \"%s\",\n-\t\t\t\t ice_rx_burst_infos[i].info);\n+\t\t\tstrlcpy(mode->info, ice_rx_burst_infos[i].info,\n+\t\t\t\tsizeof(mode->info));\n \t\t\tret = 0;\n \t\t\tbreak;\n \t\t}\n@@ -3846,8 +3846,8 @@ ice_tx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id,\n \n \tfor (i = 0; i < RTE_DIM(ice_tx_burst_infos); ++i) {\n \t\tif (pkt_burst == ice_tx_burst_infos[i].pkt_burst) {\n-\t\t\tsnprintf(mode->info, sizeof(mode->info), \"%s\",\n-\t\t\t\t ice_tx_burst_infos[i].info);\n+\t\t\tstrlcpy(mode->info, ice_tx_burst_infos[i].info,\n+\t\t\t\tsizeof(mode->info));\n \t\t\tret = 0;\n \t\t\tbreak;\n \t\t}\ndiff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c\nindex e02ec2ec5ace..39c9edbb3c19 100644\n--- a/drivers/net/idpf/idpf_ethdev.c\n+++ b/drivers/net/idpf/idpf_ethdev.c\n@@ -384,9 +384,9 @@ static int idpf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n \n \tif (xstats_names)\n \t\tfor (i = 0; i < IDPF_NB_XSTATS; i++) {\n-\t\t\tsnprintf(xstats_names[i].name,\n-\t\t\t\t sizeof(xstats_names[i].name),\n-\t\t\t\t \"%s\", rte_idpf_stats_strings[i].name);\n+\t\t\tstrlcpy(xstats_names[i].name,\n+\t\t\t\trte_idpf_stats_strings[i].name,\n+\t\t\t\tsizeof(xstats_names[i].name));\n \t\t}\n \treturn IDPF_NB_XSTATS;\n }\n",
    "prefixes": [
        "19/25"
    ]
}