Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 127860,
    "url": "http://patchwork.dpdk.org/api/patches/127860/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230601150106.18375-21-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230601150106.18375-21-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230601150106.18375-21-stephen@networkplumber.org",
    "date": "2023-06-01T15:01:01",
    "name": "[20/25] net/ionic: replace snprintf with strlcpy",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "627d440404600859a9b8733b69fdf75cddce6be7",
    "submitter": {
        "id": 27,
        "url": "http://patchwork.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230601150106.18375-21-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 28302,
            "url": "http://patchwork.dpdk.org/api/series/28302/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28302",
            "date": "2023-06-01T15:00:41",
            "name": "replace snprintf with strlcpy",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/28302/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/127860/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/127860/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A000842C04;\n\tThu,  1 Jun 2023 17:04:56 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EE88A42F9E;\n\tThu,  1 Jun 2023 17:01:38 +0200 (CEST)",
            "from mail-pl1-f173.google.com (mail-pl1-f173.google.com\n [209.85.214.173])\n by mails.dpdk.org (Postfix) with ESMTP id 7E84042DC8\n for <dev@dpdk.org>; Thu,  1 Jun 2023 17:01:36 +0200 (CEST)",
            "by mail-pl1-f173.google.com with SMTP id\n d9443c01a7336-1b02497f4cfso4712265ad.3\n for <dev@dpdk.org>; Thu, 01 Jun 2023 08:01:36 -0700 (PDT)",
            "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 01 Jun 2023 08:01:35 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631695;\n x=1688223695;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=8dqrjxEsQL5vuVPAXCkZC0SCxHc+z1y3yRa7Zuhkn5c=;\n b=zDaHNyhpHM1zUREyQ4s/t/09fpCK3s+8ASDpujCR/Jbi9vNva0vYoiqT79KXiPiKC5\n A8SBreSQ7u2R0BxzpVjJgCKNCzeZJ/IuBWsKXNWlv/noq/lJ6YFYddWVuJKQhq+6/f/f\n 9dRPBo6Ejy2eRlVTCx+6Mz/jq4khD0gucLKtgJGx1tSU5gHrgdOwqW0+DbsRU+OsE/H9\n PfFkzVpy3XMrWbUmRCQ6VTxm8oTvqysIqnuZtC3n+n3rDZdUgQjcUt5SnS1hmZqtRTwS\n lzJsfb87uphV+3qe2ZhGuIX/ac1OIzXb2LAwj+R6hx+bnEhisC7Ph4fZvcrnVflCj+G8\n naMA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1685631695; x=1688223695;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=8dqrjxEsQL5vuVPAXCkZC0SCxHc+z1y3yRa7Zuhkn5c=;\n b=DHuEUbyiuiekaUlrFwVdRv80DyRxLdPtxn5OqBKcSnXskzqiDLXqC9L3n8rzR93ONV\n hZXpm2qcC6G24LSuaqDSPt0FS7ZSYQGyVzar+CMs1PkXbipnpoUw/NDw7JZ4Yyef/58W\n PA/po7tjOZzMFIKx4LT1ooYLdhL/ER33RGof9HbstT2xwOQNqdRJZxicn3Vg67eFhNrY\n Tc+3407WVo3JvdJiSCYp2ir0bbw48FPA0QXAdi1QakM93IlsrFuWmz/dVtt+o1Uan7zZ\n +0bnuHv2nFO66kLz9zC25uf8c/VpR94uOjzotaz/SU2hbdooUpdNjXv+v2KlF5uWI2RO\n AOZA==",
        "X-Gm-Message-State": "AC+VfDwXLQy5P4nCLrSB7o1s0RMshba38XlPP3AYxJzaA914dYJkfl1Q\n ax8ypwYXrWpQBVdeJ/EkNDRbE6QaNb7EzdAuYBHX7A==",
        "X-Google-Smtp-Source": "\n ACHHUZ5xmZsDnZCNiMtGxbzZWiUDjnFnlUyf+MtM2aIG3gVqAqkAvvoLk6ENL9NF3HDDhVN2OYQffg==",
        "X-Received": "by 2002:a17:902:9002:b0:1a9:7ffb:5ed0 with SMTP id\n a2-20020a170902900200b001a97ffb5ed0mr5791644plp.59.1685631695512;\n Thu, 01 Jun 2023 08:01:35 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Andrew Boyer <andrew.boyer@amd.com>, Rosen Xu <rosen.xu@intel.com>",
        "Subject": "[PATCH 20/25] net/ionic: replace snprintf with strlcpy",
        "Date": "Thu,  1 Jun 2023 08:01:01 -0700",
        "Message-Id": "<20230601150106.18375-21-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.39.2",
        "In-Reply-To": "<20230601150106.18375-1-stephen@networkplumber.org>",
        "References": "<20230601150106.18375-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Suggested by devtools/cocci/strlcpy-with-header.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/ionic/ionic_ethdev.c        | 15 +++++++--------\n drivers/net/ipn3ke/ipn3ke_representor.c | 17 +++++++----------\n 2 files changed, 14 insertions(+), 18 deletions(-)",
    "diff": "diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c\nindex 340fd0cd5923..c6f6342e52f8 100644\n--- a/drivers/net/ionic/ionic_ethdev.c\n+++ b/drivers/net/ionic/ionic_ethdev.c\n@@ -208,8 +208,7 @@ ionic_dev_fw_version_get(struct rte_eth_dev *eth_dev,\n \tstruct ionic_adapter *adapter = lif->adapter;\n \tint ret;\n \n-\tret = snprintf(fw_version, fw_size, \"%s\",\n-\t\t adapter->fw_version);\n+\tret = strlcpy(fw_version, adapter->fw_version, fw_size);\n \tif (ret < 0)\n \t\treturn -EINVAL;\n \n@@ -705,9 +704,9 @@ ionic_dev_xstats_get_names(__rte_unused struct rte_eth_dev *eth_dev,\n \n \tif (xstats_names != NULL) {\n \t\tfor (i = 0; i < IONIC_NB_HW_STATS; i++) {\n-\t\t\tsnprintf(xstats_names[i].name,\n-\t\t\t\t\tsizeof(xstats_names[i].name),\n-\t\t\t\t\t\"%s\", rte_ionic_xstats_strings[i].name);\n+\t\t\tstrlcpy(xstats_names[i].name,\n+\t\t\t\trte_ionic_xstats_strings[i].name,\n+\t\t\t\tsizeof(xstats_names[i].name));\n \t\t}\n \t}\n \n@@ -725,9 +724,9 @@ ionic_dev_xstats_get_names_by_id(struct rte_eth_dev *eth_dev,\n \tif (!ids) {\n \t\tif (xstats_names != NULL) {\n \t\t\tfor (i = 0; i < IONIC_NB_HW_STATS; i++) {\n-\t\t\t\tsnprintf(xstats_names[i].name,\n-\t\t\t\t\tsizeof(xstats_names[i].name),\n-\t\t\t\t\t\"%s\", rte_ionic_xstats_strings[i].name);\n+\t\t\t\tstrlcpy(xstats_names[i].name,\n+\t\t\t\t\trte_ionic_xstats_strings[i].name,\n+\t\t\t\t\tsizeof(xstats_names[i].name));\n \t\t\t}\n \t\t}\n \ndiff --git a/drivers/net/ipn3ke/ipn3ke_representor.c b/drivers/net/ipn3ke/ipn3ke_representor.c\nindex e50fc73f43c4..feafe9679907 100644\n--- a/drivers/net/ipn3ke/ipn3ke_representor.c\n+++ b/drivers/net/ipn3ke/ipn3ke_representor.c\n@@ -124,8 +124,7 @@ ipn3ke_rpst_dev_start(struct rte_eth_dev *dev)\n \trawdev = hw->rawdev;\n \n \tmemset(attr_name, 0, sizeof(attr_name));\n-\tsnprintf(attr_name, IPN3KE_RAWDEV_ATTR_LEN_MAX, \"%s\",\n-\t\t\t\"LineSideBaseMAC\");\n+\tstrlcpy(attr_name, \"LineSideBaseMAC\", IPN3KE_RAWDEV_ATTR_LEN_MAX);\n \trawdev->dev_ops->attr_get(rawdev, attr_name, &base_mac);\n \trte_ether_addr_copy((struct rte_ether_addr *)&base_mac,\n \t\t\t&rpst->mac_addr);\n@@ -2330,19 +2329,17 @@ __rte_unused unsigned int limit)\n \n \t/* Get stats from ipn3ke_rpst_stats */\n \tfor (i = 0; i < IPN3KE_RPST_ETH_XSTATS_CNT; i++) {\n-\t\tsnprintf(xstats_names[count].name,\n-\t\t\t sizeof(xstats_names[count].name),\n-\t\t\t \"%s\",\n-\t\t\t ipn3ke_rpst_stats_strings[i].name);\n+\t\tstrlcpy(xstats_names[count].name,\n+\t\t\tipn3ke_rpst_stats_strings[i].name,\n+\t\t\tsizeof(xstats_names[count].name));\n \t\tcount++;\n \t}\n \n \t/* Get individual stats from ipn3ke_rpst_hw_port */\n \tfor (i = 0; i < IPN3KE_RPST_HW_PORT_XSTATS_CNT; i++) {\n-\t\tsnprintf(xstats_names[count].name,\n-\t\t\t sizeof(xstats_names[count].name),\n-\t\t\t \"%s\",\n-\t\t\t ipn3ke_rpst_hw_port_strings[i].name);\n+\t\tstrlcpy(xstats_names[count].name,\n+\t\t\tipn3ke_rpst_hw_port_strings[i].name,\n+\t\t\tsizeof(xstats_names[count].name));\n \t\tcount++;\n \t}\n \n",
    "prefixes": [
        "20/25"
    ]
}