Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127936/?format=api
{ "id": 127936, "url": "http://patchwork.dpdk.org/api/patches/127936/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230601222349.28965-2-denis.pryazhennikov@arknetworks.am/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230601222349.28965-2-denis.pryazhennikov@arknetworks.am>", "list_archive_url": "https://inbox.dpdk.org/dev/20230601222349.28965-2-denis.pryazhennikov@arknetworks.am", "date": "2023-06-01T22:23:47", "name": "[1/3] net/sfc: split link update function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "443cb3c9b99603c49348fac38652eec979bd8dd8", "submitter": { "id": 3057, "url": "http://patchwork.dpdk.org/api/people/3057/?format=api", "name": "Denis Pryazhennikov", "email": "denis.pryazhennikov@arknetworks.am" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230601222349.28965-2-denis.pryazhennikov@arknetworks.am/mbox/", "series": [ { "id": 28309, "url": "http://patchwork.dpdk.org/api/series/28309/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28309", "date": "2023-06-01T22:23:46", "name": "net/sfc: support FEC feature", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28309/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/127936/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/127936/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A6A5642C08;\n\tFri, 2 Jun 2023 00:24:02 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 995B9427E9;\n\tFri, 2 Jun 2023 00:23:58 +0200 (CEST)", "from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80])\n by mails.dpdk.org (Postfix) with ESMTP id 8FEA640693\n for <dev@dpdk.org>; Fri, 2 Jun 2023 00:23:56 +0200 (CEST)", "from localhost.localdomain (unknown [37.252.90.53])\n (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA512)\n (No client certificate requested)\n by agw.arknetworks.am (Postfix) with ESMTPSA id E78C6E126C;\n Fri, 2 Jun 2023 02:23:55 +0400 (+04)" ], "From": "Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>", "To": "dev@dpdk.org", "Cc": "Ferruh Yigit <ferruh.yigit@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Ivan Malov <ivan.malov@arknetworks.am>, Andy Moreton <amoreton@xilinx.com>", "Subject": "[PATCH 1/3] net/sfc: split link update function", "Date": "Fri, 2 Jun 2023 02:23:47 +0400", "Message-Id": "<20230601222349.28965-2-denis.pryazhennikov@arknetworks.am>", "X-Mailer": "git-send-email 2.37.0 (Apple Git-136)", "In-Reply-To": "<20230601222349.28965-1-denis.pryazhennikov@arknetworks.am>", "References": "<20230601222349.28965-1-denis.pryazhennikov@arknetworks.am>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Separate the original link update function into\ntwo functions: state retrieval and update.\nThis improves code clarity and maintainability.\n\nSigned-off-by: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>\nReviewed-by: Ivan Malov <ivan.malov@arknetworks.am>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/net/sfc/sfc_ethdev.c | 28 +++++++++++++++++++---------\n 1 file changed, 19 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex 320043145495..6d41eb000345 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -248,28 +248,38 @@ sfc_dev_start(struct rte_eth_dev *dev)\n \treturn -rc;\n }\n \n-static int\n-sfc_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)\n+static void\n+sfc_dev_get_rte_link(struct rte_eth_dev *dev, int wait_to_complete,\n+\t\t struct rte_eth_link *link)\n {\n \tstruct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);\n-\tstruct rte_eth_link current_link;\n-\tint ret;\n \n-\tsfc_log_init(sa, \"entry\");\n+\tSFC_ASSERT(link != NULL);\n \n \tif (sa->state != SFC_ETHDEV_STARTED) {\n-\t\tsfc_port_link_mode_to_info(EFX_LINK_UNKNOWN, ¤t_link);\n+\t\tsfc_port_link_mode_to_info(EFX_LINK_UNKNOWN, link);\n \t} else if (wait_to_complete) {\n \t\tefx_link_mode_t link_mode;\n \n \t\tif (efx_port_poll(sa->nic, &link_mode) != 0)\n \t\t\tlink_mode = EFX_LINK_UNKNOWN;\n-\t\tsfc_port_link_mode_to_info(link_mode, ¤t_link);\n-\n+\t\tsfc_port_link_mode_to_info(link_mode, link);\n \t} else {\n \t\tsfc_ev_mgmt_qpoll(sa);\n-\t\trte_eth_linkstatus_get(dev, ¤t_link);\n+\t\trte_eth_linkstatus_get(dev, link);\n \t}\n+}\n+\n+static int\n+sfc_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)\n+{\n+\tstruct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);\n+\tstruct rte_eth_link current_link;\n+\tint ret;\n+\n+\tsfc_log_init(sa, \"entry\");\n+\n+\tsfc_dev_get_rte_link(dev, wait_to_complete, ¤t_link);\n \n \tret = rte_eth_linkstatus_set(dev, ¤t_link);\n \tif (ret == 0)\n", "prefixes": [ "1/3" ] }