Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 127982,
    "url": "http://patchwork.dpdk.org/api/patches/127982/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1685735107-19208-2-git-send-email-roretzla@linux.microsoft.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1685735107-19208-2-git-send-email-roretzla@linux.microsoft.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1685735107-19208-2-git-send-email-roretzla@linux.microsoft.com",
    "date": "2023-06-02T19:45:02",
    "name": "[v4,1/6] stack: replace rte atomics with GCC builtin atomics",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "f45048108f30dcc64b538c1aa779e57448f780a0",
    "submitter": {
        "id": 2077,
        "url": "http://patchwork.dpdk.org/api/people/2077/?format=api",
        "name": "Tyler Retzlaff",
        "email": "roretzla@linux.microsoft.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1685735107-19208-2-git-send-email-roretzla@linux.microsoft.com/mbox/",
    "series": [
        {
            "id": 28333,
            "url": "http://patchwork.dpdk.org/api/series/28333/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28333",
            "date": "2023-06-02T19:45:02",
            "name": "replace rte atomics with GCC builtin atomics",
            "version": 4,
            "mbox": "http://patchwork.dpdk.org/series/28333/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/127982/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/127982/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 66BBB42C12;\n\tFri,  2 Jun 2023 21:45:14 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 55D654161A;\n\tFri,  2 Jun 2023 21:45:14 +0200 (CEST)",
            "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 14DA2406B8\n for <dev@dpdk.org>; Fri,  2 Jun 2023 21:45:13 +0200 (CEST)",
            "by linux.microsoft.com (Postfix, from userid 1086)\n id 5A43820520BB; Fri,  2 Jun 2023 12:45:12 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 5A43820520BB",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1685735112;\n bh=tNjsjmgyVpQS4YZksCdikAWkG/+NSrX4VAAyh33yl24=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=KbxpaQWOPr+YdTJNOOTCIwcBxODEJSLJ1NEi16lrPl1by8xrhKf0J3ugaX1MCSmxS\n x8I/YRtCsgts+sWfxCJLKK+1xiyp/+JyBaFFrhH3O2ftbV1RLIs851qhshfE+Y86Ag\n oo4Mjl5yqMPGxuagYyW1UI81r0dVlBoYBqTINH0s=",
        "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "To": "dev@dpdk.org,\n\tdavid.marchand@redhat.com",
        "Cc": "Olivier Matz <olivier.matz@6wind.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>, Qiming Yang <qiming.yang@intel.com>,\n Qi Zhang <qi.z.zhang@intel.com>, Wenjun Wu <wenjun1.wu@intel.com>,\n Tetsuya Mukawa <mtetsuyah@gmail.com>, Honnappa.Nagarahalli@arm.com,\n thomas@monjalon.net, Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "Subject": "[PATCH v4 1/6] stack: replace rte atomics with GCC builtin atomics",
        "Date": "Fri,  2 Jun 2023 12:45:02 -0700",
        "Message-Id": "<1685735107-19208-2-git-send-email-roretzla@linux.microsoft.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1685735107-19208-1-git-send-email-roretzla@linux.microsoft.com>",
        "References": "<1679084388-19267-1-git-send-email-roretzla@linux.microsoft.com>\n <1685735107-19208-1-git-send-email-roretzla@linux.microsoft.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Replace the use of rte_atomic.h types and functions, instead use GCC\nsupplied C++11 memory model builtins.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/stack/rte_stack_lf_generic.h | 16 +++++++++-------\n 1 file changed, 9 insertions(+), 7 deletions(-)",
    "diff": "diff --git a/lib/stack/rte_stack_lf_generic.h b/lib/stack/rte_stack_lf_generic.h\nindex 7fa29ce..aad3747 100644\n--- a/lib/stack/rte_stack_lf_generic.h\n+++ b/lib/stack/rte_stack_lf_generic.h\n@@ -26,8 +26,8 @@\n \t * elements. If the mempool is near-empty to the point that this is a\n \t * concern, the user should consider increasing the mempool size.\n \t */\n-\treturn (unsigned int)rte_atomic64_read((rte_atomic64_t *)\n-\t\t\t&s->stack_lf.used.len);\n+\t/* NOTE: review for potential ordering optimization */\n+\treturn __atomic_load_n(&s->stack_lf.used.len, __ATOMIC_SEQ_CST);\n }\n \n static __rte_always_inline void\n@@ -67,8 +67,8 @@\n \t\t\t\t1, __ATOMIC_RELEASE,\n \t\t\t\t__ATOMIC_RELAXED);\n \t} while (success == 0);\n-\n-\trte_atomic64_add((rte_atomic64_t *)&list->len, num);\n+\t/* NOTE: review for potential ordering optimization */\n+\t__atomic_fetch_add(&list->len, num, __ATOMIC_SEQ_CST);\n }\n \n static __rte_always_inline struct rte_stack_lf_elem *\n@@ -82,14 +82,16 @@\n \n \t/* Reserve num elements, if available */\n \twhile (1) {\n-\t\tuint64_t len = rte_atomic64_read((rte_atomic64_t *)&list->len);\n+\t\t/* NOTE: review for potential ordering optimization */\n+\t\tuint64_t len = __atomic_load_n(&list->len, __ATOMIC_SEQ_CST);\n \n \t\t/* Does the list contain enough elements? */\n \t\tif (unlikely(len < num))\n \t\t\treturn NULL;\n \n-\t\tif (rte_atomic64_cmpset((volatile uint64_t *)&list->len,\n-\t\t\t\t\tlen, len - num))\n+\t\t/* NOTE: review for potential ordering optimization */\n+\t\tif (__atomic_compare_exchange_n(&list->len, &len, len - num,\n+\t\t\t0, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST))\n \t\t\tbreak;\n \t}\n \n",
    "prefixes": [
        "v4",
        "1/6"
    ]
}