Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 128064,
    "url": "http://patchwork.dpdk.org/api/patches/128064/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230605022741.1473230-3-huangdengdui@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230605022741.1473230-3-huangdengdui@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230605022741.1473230-3-huangdengdui@huawei.com",
    "date": "2023-06-05T02:27:41",
    "name": "[v5,2/2] app/testpmd: fix segment fault with invalid queue ID",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "12bc3a82c7c93674ed65f5241823b0f741818242",
    "submitter": {
        "id": 3066,
        "url": "http://patchwork.dpdk.org/api/people/3066/?format=api",
        "name": "huangdengdui",
        "email": "huangdengdui@huawei.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patchwork.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230605022741.1473230-3-huangdengdui@huawei.com/mbox/",
    "series": [
        {
            "id": 28338,
            "url": "http://patchwork.dpdk.org/api/series/28338/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28338",
            "date": "2023-06-05T02:27:41",
            "name": "add Rx/Tx queue ID check API and use it to fix a bug",
            "version": 5,
            "mbox": "http://patchwork.dpdk.org/series/28338/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/128064/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/128064/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A3AE942C2F;\n\tMon,  5 Jun 2023 04:27:46 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 29B5740DF6;\n\tMon,  5 Jun 2023 04:27:46 +0200 (CEST)",
            "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 1DB174003C\n for <dev@dpdk.org>; Mon,  5 Jun 2023 04:27:43 +0200 (CEST)",
            "from dggpeml500011.china.huawei.com (unknown [172.30.72.53])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QZHVw51fPzLq9k;\n Mon,  5 Jun 2023 10:24:40 +0800 (CST)",
            "from localhost.huawei.com (10.50.163.32) by\n dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.23; Mon, 5 Jun 2023 10:27:41 +0800"
        ],
        "From": "Dengdui Huang <huangdengdui@huawei.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<ferruh.yigit@amd.com>, <stephen@networkplumber.org>,\n <thomas@monjalon.net>, <aman.deep.singh@intel.com>, <yuying.zhang@intel.com>,\n <andrew.rybchenko@oktetlabs.ru>, <anatoly.burakov@intel.com>,\n <lihuisong@huawei.com>, <liuyonglong@huawei.com>, <liudongdong3@huawei.com>",
        "Subject": "[PATCH v5 2/2] app/testpmd: fix segment fault with invalid queue ID",
        "Date": "Mon, 5 Jun 2023 10:27:41 +0800",
        "Message-ID": "<20230605022741.1473230-3-huangdengdui@huawei.com>",
        "X-Mailer": "git-send-email 2.33.0",
        "In-Reply-To": "<20230605022741.1473230-1-huangdengdui@huawei.com>",
        "References": "<20230516110021.1801443-1-huangdengdui@huawei.com>\n <20230605022741.1473230-1-huangdengdui@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.50.163.32]",
        "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n dggpeml500011.china.huawei.com (7.185.36.84)",
        "X-CFilter-Loop": "Reflected",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "When input queue ID is invalid, it will lead to\nSegmentation fault, like:\n\ndpdk-testpmd -a 0000:01:00.0 -- -i\ntestpmd> show port 0 txq/rxq 99 desc 0 status\nSegmentation fault\n\ndpdk-testpmd -a 0000:01:00.0 -- -i\ntestpmd> show port 0 rxq 99 desc used count\nSegmentation fault\n\nThis patch fixes it.\n\nFixes: fae9aa717d6c (\"app/testpmd: support checking descriptor status\")\nFixes: 3f9acb5c83bb (\"ethdev: avoid non-dataplane checks in Rx queue count\")\nCc: stable@dpdk.org\n\nSigned-off-by: Dengdui Huang <huangdengdui@huawei.com>\nAcked-by: Ferruh Yigit <ferruh.yigit@amd.com>\n---\n app/test-pmd/cmdline.c | 23 ++++++++++++++++-------\n 1 file changed, 16 insertions(+), 7 deletions(-)",
    "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 5333ba72c3..a15a442a06 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -12282,12 +12282,13 @@ cmd_show_rx_tx_desc_status_parsed(void *parsed_result,\n \tstruct cmd_show_rx_tx_desc_status_result *res = parsed_result;\n \tint rc;\n \n-\tif (!rte_eth_dev_is_valid_port(res->cmd_pid)) {\n-\t\tfprintf(stderr, \"invalid port id %u\\n\", res->cmd_pid);\n-\t\treturn;\n-\t}\n-\n \tif (!strcmp(res->cmd_keyword, \"rxq\")) {\n+\t\tif (rte_eth_dev_is_valid_rxq(res->cmd_pid, res->cmd_qid) != 0) {\n+\t\t\tfprintf(stderr,\n+\t\t\t\t\"Invalid input: port id = %d, queue id = %d\\n\",\n+\t\t\t\tres->cmd_pid, res->cmd_qid);\n+\t\t\treturn;\n+\t\t}\n \t\trc = rte_eth_rx_descriptor_status(res->cmd_pid, res->cmd_qid,\n \t\t\t\t\t     res->cmd_did);\n \t\tif (rc < 0) {\n@@ -12303,6 +12304,12 @@ cmd_show_rx_tx_desc_status_parsed(void *parsed_result,\n \t\telse\n \t\t\tprintf(\"Desc status = UNAVAILABLE\\n\");\n \t} else if (!strcmp(res->cmd_keyword, \"txq\")) {\n+\t\tif (rte_eth_dev_is_valid_txq(res->cmd_pid, res->cmd_qid) != 0) {\n+\t\t\tfprintf(stderr,\n+\t\t\t\t\"Invalid input: port id = %d, queue id = %d\\n\",\n+\t\t\t\tres->cmd_pid, res->cmd_qid);\n+\t\t\treturn;\n+\t\t}\n \t\trc = rte_eth_tx_descriptor_status(res->cmd_pid, res->cmd_qid,\n \t\t\t\t\t     res->cmd_did);\n \t\tif (rc < 0) {\n@@ -12382,8 +12389,10 @@ cmd_show_rx_queue_desc_used_count_parsed(void *parsed_result,\n \tstruct cmd_show_rx_queue_desc_used_count_result *res = parsed_result;\n \tint rc;\n \n-\tif (!rte_eth_dev_is_valid_port(res->cmd_pid)) {\n-\t\tfprintf(stderr, \"invalid port id %u\\n\", res->cmd_pid);\n+\tif (rte_eth_dev_is_valid_rxq(res->cmd_pid, res->cmd_qid) != 0) {\n+\t\tfprintf(stderr,\n+\t\t\t\"Invalid input: port id = %d, queue id = %d\\n\",\n+\t\t\tres->cmd_pid, res->cmd_qid);\n \t\treturn;\n \t}\n \n",
    "prefixes": [
        "v5",
        "2/2"
    ]
}