Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128197/?format=api
{ "id": 128197, "url": "http://patchwork.dpdk.org/api/patches/128197/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230606100258.26532-5-nipun.gupta@amd.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230606100258.26532-5-nipun.gupta@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230606100258.26532-5-nipun.gupta@amd.com", "date": "2023-06-06T10:02:58", "name": "[v7,4/4] bus/cdx: support plug unplug and dev iterator", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5ee5ab24ae3b8d4df59007efcb0afb9fd7fc916a", "submitter": { "id": 2928, "url": "http://patchwork.dpdk.org/api/people/2928/?format=api", "name": "Gupta, Nipun", "email": "nipun.gupta@amd.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230606100258.26532-5-nipun.gupta@amd.com/mbox/", "series": [ { "id": 28367, "url": "http://patchwork.dpdk.org/api/series/28367/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28367", "date": "2023-06-06T10:02:54", "name": "Support AMD CDX bus", "version": 7, "mbox": "http://patchwork.dpdk.org/series/28367/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/128197/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/128197/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2285142C3E;\n\tTue, 6 Jun 2023 12:03:43 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1500F42D35;\n\tTue, 6 Jun 2023 12:03:31 +0200 (CEST)", "from NAM02-BN1-obe.outbound.protection.outlook.com\n (mail-bn1nam02on2066.outbound.protection.outlook.com [40.107.212.66])\n by mails.dpdk.org (Postfix) with ESMTP id 3763642D31\n for <dev@dpdk.org>; Tue, 6 Jun 2023 12:03:29 +0200 (CEST)", "from MW2PR16CA0072.namprd16.prod.outlook.com (2603:10b6:907:1::49)\n by DM6PR12MB4530.namprd12.prod.outlook.com (2603:10b6:5:2aa::19) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Tue, 6 Jun\n 2023 10:03:27 +0000", "from CO1NAM11FT085.eop-nam11.prod.protection.outlook.com\n (2603:10b6:907:1:cafe::b3) by MW2PR16CA0072.outlook.office365.com\n (2603:10b6:907:1::49) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33 via Frontend\n Transport; Tue, 6 Jun 2023 10:03:26 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n CO1NAM11FT085.mail.protection.outlook.com (10.13.174.137) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.6455.33 via Frontend Transport; Tue, 6 Jun 2023 10:03:26 +0000", "from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 6 Jun\n 2023 05:03:26 -0500", "from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com\n (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 6 Jun\n 2023 03:03:25 -0700", "from xhdipdslab41.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via\n Frontend Transport; Tue, 6 Jun 2023 05:03:22 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=O4yc3fJHdrcYWwApzDsjs6oGP1LjWU8GnxXNw3BnTGNeKiltyVUka1+AdrN8/SenjakiqMNBf0rNs5uD/AuIpklt9EOjmsKP+u3w3h0bVFJ0RzUIg0CQw87ARWiQbllx67jesQUD+1AKnQtZ+qM2HUXlLZH2Ey9zcC0hxIgysW7iNTKEHZvvWlMawbF2/6mgx2bvk6uuUtybG5xdJWMrnAcXjepQ0tMHtjorG4D4c/8Pon2o+XHlGsdGqZcaOQ12U+Mh+PlImtxCHs0bGoemVEARTgKxEfBTCcsOTjRlOKslSVmTOlQK+SibTzyCERqatn2XLqPEjTjpyas4F4Qgrw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=XnyCN+WUseRdtROemicjyCKHzNj6FRLtKtPcgGJPLiU=;\n b=DTTS4mKuluUy/DioPyHPbFTkuuIuJWPZo0ItkB3Zqfsj6hPdZa07wcMvztE5fXaBilaGJS/zjGImJL6u1QR67wLg9BP/+LY8ojGrg6J+zfxokIRuhIWQoSbSK/jz+yEHVtD1z44fOyOMCLcCNDxApJfgCY9Kgn09HOWMLVJZT6ISlmNgjtp4dkAXr6qc2ikxX27c0U4J+dVJvkCJA3bF5s+qPnVazOT/fG1p54HBslWrWvwt7R50d+N4MJ2FgfCchdZV/n7OpCSlW3UaWVyb5ViDLYgxR3xyWiJGOx69XlZkYbjWgJpT4mGlqv2QAfeeKv9mTjfd39Y98+8NJ2u+Ig==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=XnyCN+WUseRdtROemicjyCKHzNj6FRLtKtPcgGJPLiU=;\n b=V04q7R5HNdXqOi6N9zw9GyfNW79YG8fNk5oi85UqsrR7askmhIQR17kcJ5pvKJPyPrQDwbyCGUvImHVZCcfA1iRYPU2CUP3BCfYkMt5DOTZ8Epb2KanypTfQewS6RTnb4douxaJRiH4FhIHG3reqldrmH586mfSqAgmD6gZm1y8=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Nipun Gupta <nipun.gupta@amd.com>", "To": "<dev@dpdk.org>, <thomas@monjalon.net>, <david.marchand@redhat.com>,\n <hkalra@marvell.com>, <anatoly.burakov@intel.com>,\n <stephen@networkplumber.org>", "CC": "<ferruh.yigit@amd.com>, <harpreet.anand@amd.com>,\n <nikhil.agarwal@amd.com>, Nipun Gupta <nipun.gupta@amd.com>", "Subject": "[PATCH v7 4/4] bus/cdx: support plug unplug and dev iterator", "Date": "Tue, 6 Jun 2023 15:32:58 +0530", "Message-ID": "<20230606100258.26532-5-nipun.gupta@amd.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20230606100258.26532-1-nipun.gupta@amd.com>", "References": "<20230124140746.594066-1-nipun.gupta@amd.com>\n <20230606100258.26532-1-nipun.gupta@amd.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CO1NAM11FT085:EE_|DM6PR12MB4530:EE_", "X-MS-Office365-Filtering-Correlation-Id": "9f2078fb-fb71-4faa-cd86-08db667545ac", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n YmubWqNJsnt+B9tSfgxU3p8qSwVniVBtj8oP1+lGfnPDns0aYV11gAinWuEXzSgp+R2uoFUTDexjAVavaO7LcCpXe+FL7z2GerE+vfP76jjCwde0/37nBVMLKy14v1w1zi/t0VMD72p8fDfvQ9gvvi7Cp07Z5MZ7kKfKDIVUNf/ADPZ5ZoMD7w03KO3G+1fMFgDe+OgIUU4KAzrW8z/kIUtRuUeEt6yVmGVWtb8rNlTDEazpne6wSwNfqQriTHxPx+dAlCFvcmbZRQqLpSnnZSFRdW9Q9396qM0XpqJJ0J60DlW+dUfR45F1YAsgj7dhvu1aJNQBhdGvCPDjrlDgkryjn8J5elo5lmdItueaPMcjgWU0i9Ka0KQpdLlvWkd2W3DfoWCdycVishkCq/5ur2rp0c+4kTD+EsC7Z6RS6SNsOGGbhBuQHauCkT+6m8U3oA2EymCVj7xGG5emV6npPt0jyw0l45yo6Xeot4V7BAcHos0nK7G39D4DwGi8nlkFui9m74WAzZ0c6wpvFFH4LFo87RY9li/DsrXAogQcrW49W783DJwhlc576VOwtilaxUS9J1xB5swLBP3+Kq0gOfKFc6RMW0EjKGCn+YbBnZ5dwDPXk/7pM0PkBVUNh4af/NCN46au31aPsq3HrIGUeFYNOeUv/BSUm5Uq5tsuRDcNVn/TzNWjkB88f+VmIazJB8jlh3f1cKETnKoPf4UGJYk3FgFofYpvpiOwpG7fpxGjiziUakmfm2G5cTTkvx37DRSJfmBhB0urK2MAw8sSUA==", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230028)(4636009)(396003)(376002)(346002)(39860400002)(136003)(451199021)(40470700004)(36840700001)(46966006)(26005)(110136005)(40480700001)(1076003)(70206006)(82740400003)(70586007)(4326008)(81166007)(356005)(82310400005)(36860700001)(336012)(426003)(47076005)(478600001)(2616005)(36756003)(2906002)(40460700003)(41300700001)(316002)(44832011)(8676002)(54906003)(8936002)(186003)(5660300002)(86362001)(6666004)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "06 Jun 2023 10:03:26.7810 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 9f2078fb-fb71-4faa-cd86-08db667545ac", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT085.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR12MB4530", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This change adds support for plugging and unplugging\nCDX devices on AMD CDX bus. Also, CDX dev iterator support\nhas been added for the CDX bus.\n\nSigned-off-by: Nipun Gupta <nipun.gupta@amd.com>\nAcked-by: Ferruh Yigit <ferruh.yigit@amd.com>\n---\n drivers/bus/cdx/bus_cdx_driver.h | 1 +\n drivers/bus/cdx/cdx.c | 122 +++++++++++++++++++++++++++++++\n 2 files changed, 123 insertions(+)", "diff": "diff --git a/drivers/bus/cdx/bus_cdx_driver.h b/drivers/bus/cdx/bus_cdx_driver.h\nindex cb99c13636..04ccdf7c53 100644\n--- a/drivers/bus/cdx/bus_cdx_driver.h\n+++ b/drivers/bus/cdx/bus_cdx_driver.h\n@@ -52,6 +52,7 @@ struct rte_cdx_id {\n struct rte_cdx_device {\n \tRTE_TAILQ_ENTRY(rte_cdx_device) next;\t/**< Next probed CDX device. */\n \tstruct rte_device device;\t\t/**< Inherit core device */\n+\tstruct rte_cdx_driver *driver;\t\t/**< CDX driver used in probing */\n \tchar name[RTE_DEV_NAME_MAX_LEN];\t/**< Device name */\n \tstruct rte_cdx_id id;\t\t\t/**< CDX ID. */\n \tstruct rte_mem_resource mem_resource[CDX_MAX_RESOURCE];\ndiff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c\nindex e5e6a665c3..2165486bc3 100644\n--- a/drivers/bus/cdx/cdx.c\n+++ b/drivers/bus/cdx/cdx.c\n@@ -71,6 +71,7 @@\n #include <rte_eal_paging.h>\n #include <rte_errno.h>\n #include <rte_devargs.h>\n+#include <rte_kvargs.h>\n #include <rte_malloc.h>\n #include <rte_vfio.h>\n \n@@ -92,6 +93,15 @@\n \n struct rte_cdx_bus rte_cdx_bus;\n \n+enum cdx_params {\n+\tRTE_CDX_PARAM_NAME,\n+};\n+\n+static const char * const cdx_params_keys[] = {\n+\t[RTE_CDX_PARAM_NAME] = \"name\",\n+\tNULL,\n+};\n+\n /* Add a device to CDX bus */\n static void\n cdx_add_device(struct rte_cdx_device *cdx_dev)\n@@ -385,6 +395,7 @@ cdx_probe_one_driver(struct rte_cdx_driver *dr,\n \t} else {\n \t\tdev->device.driver = &dr->driver;\n \t}\n+\tdev->driver = dr;\n \n \treturn ret;\n \n@@ -499,6 +510,71 @@ cdx_find_device(const struct rte_device *start, rte_dev_cmp_t cmp,\n \treturn NULL;\n }\n \n+/* Remove a device from CDX bus */\n+static void\n+cdx_remove_device(struct rte_cdx_device *cdx_dev)\n+{\n+\tTAILQ_REMOVE(&rte_cdx_bus.device_list, cdx_dev, next);\n+}\n+\n+/*\n+ * If vendor/device ID match, call the remove() function of the\n+ * driver.\n+ */\n+static int\n+cdx_detach_dev(struct rte_cdx_device *dev)\n+{\n+\tstruct rte_cdx_driver *dr;\n+\tint ret = 0;\n+\n+\tif (dev == NULL)\n+\t\treturn -EINVAL;\n+\n+\tdr = dev->driver;\n+\n+\tCDX_BUS_DEBUG(\"detach device %s using driver: %s\",\n+\t\tdev->device.name, dr->driver.name);\n+\n+\tif (dr->remove) {\n+\t\tret = dr->remove(dev);\n+\t\tif (ret < 0)\n+\t\t\treturn ret;\n+\t}\n+\n+\t/* clear driver structure */\n+\tdev->driver = NULL;\n+\tdev->device.driver = NULL;\n+\n+\trte_cdx_unmap_device(dev);\n+\n+\trte_intr_instance_free(dev->intr_handle);\n+\tdev->intr_handle = NULL;\n+\n+\treturn 0;\n+}\n+\n+static int\n+cdx_plug(struct rte_device *dev)\n+{\n+\treturn cdx_probe_all_drivers(RTE_DEV_TO_CDX_DEV(dev));\n+}\n+\n+static int\n+cdx_unplug(struct rte_device *dev)\n+{\n+\tstruct rte_cdx_device *cdx_dev;\n+\tint ret;\n+\n+\tcdx_dev = RTE_DEV_TO_CDX_DEV(dev);\n+\tret = cdx_detach_dev(cdx_dev);\n+\tif (ret == 0) {\n+\t\tcdx_remove_device(cdx_dev);\n+\t\trte_devargs_remove(dev->devargs);\n+\t\tfree(cdx_dev);\n+\t}\n+\treturn ret;\n+}\n+\n static int\n cdx_dma_map(struct rte_device *dev, void *addr, uint64_t iova, size_t len)\n {\n@@ -526,15 +602,61 @@ cdx_get_iommu_class(void)\n \treturn RTE_IOVA_VA;\n }\n \n+static int\n+cdx_dev_match(const struct rte_device *dev,\n+\t\tconst void *_kvlist)\n+{\n+\tconst struct rte_kvargs *kvlist = _kvlist;\n+\tconst char *key = cdx_params_keys[RTE_CDX_PARAM_NAME];\n+\tconst char *name;\n+\n+\t/* no kvlist arg, all devices match */\n+\tif (kvlist == NULL)\n+\t\treturn 0;\n+\n+\t/* if key is present in kvlist and does not match, filter device */\n+\tname = rte_kvargs_get(kvlist, key);\n+\tif (name != NULL && strcmp(name, dev->name))\n+\t\treturn -1;\n+\n+\treturn 0;\n+}\n+\n+static void *\n+cdx_dev_iterate(const void *start,\n+\t\tconst char *str,\n+\t\tconst struct rte_dev_iterator *it __rte_unused)\n+{\n+\trte_bus_find_device_t find_device;\n+\tstruct rte_kvargs *kvargs = NULL;\n+\tstruct rte_device *dev;\n+\n+\tif (str != NULL) {\n+\t\tkvargs = rte_kvargs_parse(str, cdx_params_keys);\n+\t\tif (kvargs == NULL) {\n+\t\t\tCDX_BUS_ERR(\"cannot parse argument list %s\", str);\n+\t\t\trte_errno = EINVAL;\n+\t\t\treturn NULL;\n+\t\t}\n+\t}\n+\tfind_device = rte_cdx_bus.bus.find_device;\n+\tdev = find_device(start, cdx_dev_match, kvargs);\n+\trte_kvargs_free(kvargs);\n+\treturn dev;\n+}\n+\n struct rte_cdx_bus rte_cdx_bus = {\n \t.bus = {\n \t\t.scan = cdx_scan,\n \t\t.probe = cdx_probe,\n \t\t.find_device = cdx_find_device,\n+\t\t.plug = cdx_plug,\n+\t\t.unplug = cdx_unplug,\n \t\t.parse = cdx_parse,\n \t\t.dma_map = cdx_dma_map,\n \t\t.dma_unmap = cdx_dma_unmap,\n \t\t.get_iommu_class = cdx_get_iommu_class,\n+\t\t.dev_iterate = cdx_dev_iterate,\n \t},\n \t.device_list = TAILQ_HEAD_INITIALIZER(rte_cdx_bus.device_list),\n \t.driver_list = TAILQ_HEAD_INITIALIZER(rte_cdx_bus.driver_list),\n", "prefixes": [ "v7", "4/4" ] }