Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128234/?format=api
{ "id": 128234, "url": "http://patchwork.dpdk.org/api/patches/128234/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1686087947-15471-7-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1686087947-15471-7-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1686087947-15471-7-git-send-email-roretzla@linux.microsoft.com", "date": "2023-06-06T21:45:47", "name": "[v5,6/6] net/ring: replace rte atomics with GCC builtin atomics", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a8ec970cfcaf74e8c3c481597cd582f0cbc103a9", "submitter": { "id": 2077, "url": "http://patchwork.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1686087947-15471-7-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 28379, "url": "http://patchwork.dpdk.org/api/series/28379/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28379", "date": "2023-06-06T21:45:42", "name": "replace rte atomics with GCC builtin atomics", "version": 5, "mbox": "http://patchwork.dpdk.org/series/28379/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/128234/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/128234/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AB56642C44;\n\tTue, 6 Jun 2023 23:46:27 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A90E442D50;\n\tTue, 6 Jun 2023 23:45:57 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 8E05A4067B\n for <dev@dpdk.org>; Tue, 6 Jun 2023 23:45:50 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 29D4D20BE4A1; Tue, 6 Jun 2023 14:45:48 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 29D4D20BE4A1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1686087949;\n bh=Lxhemo2pH3rc7mE4mkJx0FAz1wuSiXo89XvTSikhKDw=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=LpakH0vGokW26urweCdxHZaZH1HpsSQfNsLabMEAo872EtIVHRpv9GY0TII1HnkPc\n /5HZQsdmwt1a2uVMubhAaSkf7WYOvX5lhmbG4DNK1YrDXz81jP9vXSrLoCNQG6lqZE\n DBs5wuYnexCfLGyDQ7YSPDYscHJGSIQSJDZmGLOQ=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org,\n\tdavid.marchand@redhat.com", "Cc": "Olivier Matz <olivier.matz@6wind.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>, Qiming Yang <qiming.yang@intel.com>,\n Qi Zhang <qi.z.zhang@intel.com>, Wenjun Wu <wenjun1.wu@intel.com>,\n Tetsuya Mukawa <mtetsuyah@gmail.com>, Honnappa.Nagarahalli@arm.com,\n thomas@monjalon.net, Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v5 6/6] net/ring: replace rte atomics with GCC builtin atomics", "Date": "Tue, 6 Jun 2023 14:45:47 -0700", "Message-Id": "<1686087947-15471-7-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1686087947-15471-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1679084388-19267-1-git-send-email-roretzla@linux.microsoft.com>\n <1686087947-15471-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace the use of rte_atomic.h types and functions, instead use GCC\nsupplied C++11 memory model builtins.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/net/ring/rte_eth_ring.c | 20 ++++++++++----------\n 1 file changed, 10 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c\nindex e8bc9b6..c43dcce 100644\n--- a/drivers/net/ring/rte_eth_ring.c\n+++ b/drivers/net/ring/rte_eth_ring.c\n@@ -44,8 +44,8 @@ enum dev_action {\n \n struct ring_queue {\n \tstruct rte_ring *rng;\n-\trte_atomic64_t rx_pkts;\n-\trte_atomic64_t tx_pkts;\n+\tuint64_t rx_pkts;\n+\tuint64_t tx_pkts;\n };\n \n struct pmd_internals {\n@@ -80,9 +80,9 @@ struct pmd_internals {\n \tconst uint16_t nb_rx = (uint16_t)rte_ring_dequeue_burst(r->rng,\n \t\t\tptrs, nb_bufs, NULL);\n \tif (r->rng->flags & RING_F_SC_DEQ)\n-\t\tr->rx_pkts.cnt += nb_rx;\n+\t\tr->rx_pkts += nb_rx;\n \telse\n-\t\trte_atomic64_add(&(r->rx_pkts), nb_rx);\n+\t\t__atomic_fetch_add(&r->rx_pkts, nb_rx, __ATOMIC_RELAXED);\n \treturn nb_rx;\n }\n \n@@ -94,9 +94,9 @@ struct pmd_internals {\n \tconst uint16_t nb_tx = (uint16_t)rte_ring_enqueue_burst(r->rng,\n \t\t\tptrs, nb_bufs, NULL);\n \tif (r->rng->flags & RING_F_SP_ENQ)\n-\t\tr->tx_pkts.cnt += nb_tx;\n+\t\tr->tx_pkts += nb_tx;\n \telse\n-\t\trte_atomic64_add(&(r->tx_pkts), nb_tx);\n+\t\t__atomic_fetch_add(&r->tx_pkts, nb_tx, __ATOMIC_RELAXED);\n \treturn nb_tx;\n }\n \n@@ -184,13 +184,13 @@ struct pmd_internals {\n \n \tfor (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS &&\n \t\t\ti < dev->data->nb_rx_queues; i++) {\n-\t\tstats->q_ipackets[i] = internal->rx_ring_queues[i].rx_pkts.cnt;\n+\t\tstats->q_ipackets[i] = internal->rx_ring_queues[i].rx_pkts;\n \t\trx_total += stats->q_ipackets[i];\n \t}\n \n \tfor (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS &&\n \t\t\ti < dev->data->nb_tx_queues; i++) {\n-\t\tstats->q_opackets[i] = internal->tx_ring_queues[i].tx_pkts.cnt;\n+\t\tstats->q_opackets[i] = internal->tx_ring_queues[i].tx_pkts;\n \t\ttx_total += stats->q_opackets[i];\n \t}\n \n@@ -207,9 +207,9 @@ struct pmd_internals {\n \tstruct pmd_internals *internal = dev->data->dev_private;\n \n \tfor (i = 0; i < dev->data->nb_rx_queues; i++)\n-\t\tinternal->rx_ring_queues[i].rx_pkts.cnt = 0;\n+\t\tinternal->rx_ring_queues[i].rx_pkts = 0;\n \tfor (i = 0; i < dev->data->nb_tx_queues; i++)\n-\t\tinternal->tx_ring_queues[i].tx_pkts.cnt = 0;\n+\t\tinternal->tx_ring_queues[i].tx_pkts = 0;\n \n \treturn 0;\n }\n", "prefixes": [ "v5", "6/6" ] }