Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128510/?format=api
{ "id": 128510, "url": "http://patchwork.dpdk.org/api/patches/128510/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230612162104.170749-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230612162104.170749-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230612162104.170749-1-bruce.richardson@intel.com", "date": "2023-06-12T16:21:03", "name": "[1/2] build: change flag variable type to boolean", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9811a4ca0ce3c4fb8d27f5804ddf2e71022778ff", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230612162104.170749-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 28457, "url": "http://patchwork.dpdk.org/api/series/28457/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28457", "date": "2023-06-12T16:21:03", "name": "[1/2] build: change flag variable type to boolean", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28457/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/128510/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/128510/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 07E4642C50;\n\tMon, 12 Jun 2023 18:21:14 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DAAEC41138;\n\tMon, 12 Jun 2023 18:21:13 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id 34A4740698\n for <dev@dpdk.org>; Mon, 12 Jun 2023 18:21:12 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Jun 2023 09:21:11 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.11])\n by FMSMGA003.fm.intel.com with ESMTP; 12 Jun 2023 09:21:10 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1686586872; x=1718122872;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=GHpc5EDfdbwYljNEe1JpWyD7xZ2Y/LRx4ZlLrlH2fWU=;\n b=XN4qZqm2M+XLS9yDH61gMY3Iex8idJeHoF2HRinNGGnkFPRJKjKVwD9V\n lV9w4zenPz3Lhblr2vBjmI7gumSWci7gXKRrYEl7I/cCp9AMA4H51mqaW\n Wme7MbHUrKipz8fv9OfylP2W9opuFxxXFrnq1kxUCwSo8aH6+VdfARHIU\n C5p3QqpoG8vflHpqLy4MS1RciwHzxgwbadih0QsguP2saY4MOmrHfKdOm\n gabRHQ8mty/mRfBr4ylxgu4BwGu1YtuXQpACDir8FW2Y9lpAx875jLurO\n EUWZztjEhumqHqFy4O4f+BksBVXvl85xP+k47sWMRr7OoXIxcOptAQ7Dj Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10739\"; a=\"337726736\"", "E=Sophos;i=\"6.00,236,1681196400\"; d=\"scan'208\";a=\"337726736\"", "E=McAfee;i=\"6600,9927,10739\"; a=\"801076179\"", "E=Sophos;i=\"6.00,236,1681196400\"; d=\"scan'208\";a=\"801076179\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH 1/2] build: change flag variable type to boolean", "Date": "Mon, 12 Jun 2023 17:21:03 +0100", "Message-Id": "<20230612162104.170749-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.39.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The has_libnuma flag was using 0 and 1 integer values, instead of the\nmore appropriate boolean type. Change to use true/false instead.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n config/arm/meson.build | 2 +-\n config/meson.build | 4 ++--\n lib/eal/linux/meson.build | 2 +-\n lib/vhost/meson.build | 2 +-\n 4 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/config/arm/meson.build b/config/arm/meson.build\nindex 43f6a551a2..faba5e38cf 100644\n--- a/config/arm/meson.build\n+++ b/config/arm/meson.build\n@@ -592,7 +592,7 @@ if update_flags\n part_number = soc_config['part_number']\n soc_flags = soc_config.get('flags', [])\n if not soc_config.get('numa', true)\n- has_libnuma = 0\n+ has_libnuma = false\n endif\n \n disable_drivers += ',' + soc_config.get('disable_drivers', '')\ndiff --git a/config/meson.build b/config/meson.build\nindex 65087ce090..8aebccbbdc 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -174,7 +174,7 @@ if link_lib != ''\n endif\n \n # check for libraries used in multiple places in DPDK\n-has_libnuma = 0\n+has_libnuma = false\n find_libnuma = true\n if meson.is_cross_build() and not meson.get_cross_property('numa', true)\n # don't look for libnuma if explicitly disabled in cross build\n@@ -184,7 +184,7 @@ if find_libnuma\n numa_dep = cc.find_library('numa', required: false)\n if numa_dep.found() and cc.has_header('numaif.h')\n dpdk_conf.set10('RTE_HAS_LIBNUMA', true)\n- has_libnuma = 1\n+ has_libnuma = true\n add_project_link_arguments('-lnuma', language: 'c')\n dpdk_extra_ldflags += '-lnuma'\n endif\ndiff --git a/lib/eal/linux/meson.build b/lib/eal/linux/meson.build\nindex 1b913acc06..e99ebed256 100644\n--- a/lib/eal/linux/meson.build\n+++ b/lib/eal/linux/meson.build\n@@ -20,6 +20,6 @@ sources += files(\n )\n \n deps += ['kvargs', 'telemetry']\n-if has_libnuma == 1\n+if has_libnuma\n dpdk_conf.set10('RTE_EAL_NUMA_AWARE_HUGEPAGES', true)\n endif\ndiff --git a/lib/vhost/meson.build b/lib/vhost/meson.build\nindex 0d1abf6283..9e39d221a1 100644\n--- a/lib/vhost/meson.build\n+++ b/lib/vhost/meson.build\n@@ -5,7 +5,7 @@ if not is_linux\n build = false\n reason = 'only supported on Linux'\n endif\n-if has_libnuma == 1\n+if has_libnuma\n dpdk_conf.set10('RTE_LIBRTE_VHOST_NUMA', true)\n endif\n if (toolchain == 'gcc' and cc.version().version_compare('>=8.3.0'))\n", "prefixes": [ "1/2" ] }