Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128511/?format=api
{ "id": 128511, "url": "http://patchwork.dpdk.org/api/patches/128511/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230612162104.170749-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230612162104.170749-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230612162104.170749-2-bruce.richardson@intel.com", "date": "2023-06-12T16:21:04", "name": "[2/2] build: prevent accidentally building without NUMA support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dae1ba438ebd015107da72848fd81cfd14990520", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230612162104.170749-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 28457, "url": "http://patchwork.dpdk.org/api/series/28457/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28457", "date": "2023-06-12T16:21:03", "name": "[1/2] build: change flag variable type to boolean", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28457/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/128511/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/128511/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3312442C50;\n\tMon, 12 Jun 2023 18:21:21 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2CA9B42B8E;\n\tMon, 12 Jun 2023 18:21:19 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id 051F140698\n for <dev@dpdk.org>; Mon, 12 Jun 2023 18:21:16 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Jun 2023 09:21:16 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.11])\n by FMSMGA003.fm.intel.com with ESMTP; 12 Jun 2023 09:21:15 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1686586877; x=1718122877;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=ppTtWLIDDhvRVck7wc/qKql3Dsr8lAITzWCyabdpBSY=;\n b=esLCOdwnSNPUIWK+NPUBHRcUEHDWd22VdaDqxb10LhaCNkHWPHhuUTuZ\n g4TWasNF2Oxwg2WehJh5eF5JQdBCLRzCL3mNrfLV/Wvs3ZBaAW6iAisOU\n HE9xZI5PJKH4e5rS3oHkeNwAkTAqD6gsex9tVIn6QdHSlR2C65tqDvFgf\n 6q+abGP+JtX7/1Z6PGLLB9y1eKBlx6xozZc0+WjglnSwZ2PGlpzoWoniZ\n IvWvAWzWOeXDGIT60fgIC5TywTpnOgateV1xnda7kkgnr5g9883lN1TIm\n 5FNQ5i/EJ/cU0k1kC1tx2+bEwdhJ4ALTFsPimd36gkIrD7zxHh0tX+UHf A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10739\"; a=\"337726752\"", "E=Sophos;i=\"6.00,236,1681196400\"; d=\"scan'208\";a=\"337726752\"", "E=McAfee;i=\"6600,9927,10739\"; a=\"801076199\"", "E=Sophos;i=\"6.00,236,1681196400\"; d=\"scan'208\";a=\"801076199\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH 2/2] build: prevent accidentally building without NUMA support", "Date": "Mon, 12 Jun 2023 17:21:04 +0100", "Message-Id": "<20230612162104.170749-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230612162104.170749-1-bruce.richardson@intel.com>", "References": "<20230612162104.170749-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When libnuma development package is missing on a system, DPDK can still\nbe built but will be missing much-needed support for NUMA memory\nmanagement. This may later cause issues at runtime if the resulting\nbinary is run on a NUMA system.\n\nWe can reduce the incidence of such runtime error by ensuring that, for\nnative builds*, libnuma is present - unless the user actually specifies\nvia \"max_numa_nodes\" that they don't require NUMA support. Having this\nas an error condition is also in keeping with what is documented in the\nLinux GSG doc, where libnuma is listed as a requirement for building\nDPDK [1].\n\n* NOTE: cross-compilation builds have a different logic set, with a\n separate \"numa\" value indicating if numa support is necessary.\n\n[1] https://doc.dpdk.org/guides-23.03/linux_gsg/sys_reqs.html\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n config/meson.build | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex 8aebccbbdc..bffd3600c6 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -381,6 +381,12 @@ endif\n if not dpdk_conf.has('RTE_MAX_NUMA_NODES')\n error('Number of NUMA nodes not specified.')\n endif\n+if not meson.is_cross_build() and dpdk_conf.get('RTE_MAX_NUMA_NODES') > 1 and not has_libnuma\n+ error('''\n+No NUMA library (development package) found, yet DPDK configured for multiple NUMA nodes.\n+Please install libnuma, or set 'max_numa_nodes' option to '1' to build without NUMA support.\n+''')\n+endif\n \n # set the install path for the drivers\n dpdk_conf.set_quoted('RTE_EAL_PMD_PATH', eal_pmd_path)\n", "prefixes": [ "2/2" ] }