Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128578/?format=api
{ "id": 128578, "url": "http://patchwork.dpdk.org/api/patches/128578/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230613102009.2390568-16-gakhil@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230613102009.2390568-16-gakhil@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230613102009.2390568-16-gakhil@marvell.com", "date": "2023-06-13T10:20:09", "name": "[v4,15/15] net/cnxk: add MACsec stats", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "d4cf5018d9df0f88a6891fd43823a3bffca722d9", "submitter": { "id": 2094, "url": "http://patchwork.dpdk.org/api/people/2094/?format=api", "name": "Akhil Goyal", "email": "gakhil@marvell.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230613102009.2390568-16-gakhil@marvell.com/mbox/", "series": [ { "id": 28480, "url": "http://patchwork.dpdk.org/api/series/28480/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28480", "date": "2023-06-13T10:19:54", "name": "net/cnxk: add MACsec support", "version": 4, "mbox": "http://patchwork.dpdk.org/series/28480/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/128578/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/128578/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6A84A42CA8;\n\tTue, 13 Jun 2023 12:22:19 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6364242D9B;\n\tTue, 13 Jun 2023 12:21:03 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 193A842D8E\n for <dev@dpdk.org>; Tue, 13 Jun 2023 12:21:01 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 35D5riwM007661; Tue, 13 Jun 2023 03:21:00 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3r4rpkfpvf-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 13 Jun 2023 03:21:00 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Tue, 13 Jun 2023 03:20:58 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Tue, 13 Jun 2023 03:20:58 -0700", "from localhost.localdomain (unknown [10.28.36.102])\n by maili.marvell.com (Postfix) with ESMTP id EBE0D3F7092;\n Tue, 13 Jun 2023 03:20:55 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=C1L8gg+zHBHBH2u/vQyCGUYW7sSZRy/smjvnMyhEaJ0=;\n b=a8XtRJtuJYijPVB7ghAkv8r1wVT35CqHB+c8aw/sJ3Vi+gRv4ZA+1xTeDowpzZ/Dxm7O\n UeMc/fuEq69Y3PjCzJKrxPfRoy6tXIt+dIkioKkRD9tLIlqaV11DEo9+1KnbxDwNj954\n 46b61T1TGsJZj3PSLo26WGI+Rd1aLrwInIvExgbHBOAFsQfAi28YmdSnqroBC7bBOxls\n cnn3qZ/3JL6mPGt3fhw7f5jUAxZcHfws5BfMj1ZoKpW5P/F8Z5K80rXWy/qY2gJmj3Hy\n Yk0ThQKFsWjlQtIbpqTV1PLfhRkP039/CL/IHrbI8MFomdiaUGl0kGNQuR3ZHLcA9cTN PQ==", "From": "Akhil Goyal <gakhil@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<thomas@monjalon.net>, <david.marchand@redhat.com>,\n <vattunuru@marvell.com>, <jerinj@marvell.com>, <adwivedi@marvell.com>,\n <ndabilpuram@marvell.com>, Akhil Goyal <gakhil@marvell.com>", "Subject": "[PATCH v4 15/15] net/cnxk: add MACsec stats", "Date": "Tue, 13 Jun 2023 15:50:09 +0530", "Message-ID": "<20230613102009.2390568-16-gakhil@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230613102009.2390568-1-gakhil@marvell.com>", "References": "<20230613071614.2259604-1-gakhil@marvell.com>\n <20230613102009.2390568-1-gakhil@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "LwnKlDUiaoxf9OQpWpYtKTq8CAwrB7Xv", "X-Proofpoint-GUID": "LwnKlDUiaoxf9OQpWpYtKTq8CAwrB7Xv", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26\n definitions=2023-06-13_04,2023-06-12_02,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Added support for MACsec SC/flow/session stats.\n\nSigned-off-by: Akhil Goyal <gakhil@marvell.com>\n---\n doc/guides/rel_notes/release_23_07.rst | 5 ++\n drivers/net/cnxk/cn10k_ethdev_sec.c | 11 +++--\n drivers/net/cnxk/cnxk_ethdev_mcs.c | 64 ++++++++++++++++++++++++++\n drivers/net/cnxk/cnxk_ethdev_mcs.h | 9 ++++\n 4 files changed, 86 insertions(+), 3 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/release_23_07.rst\nindex 915c37529a..f126be1435 100644\n--- a/doc/guides/rel_notes/release_23_07.rst\n+++ b/doc/guides/rel_notes/release_23_07.rst\n@@ -139,6 +139,11 @@ New Features\n for new capability registers, large passthrough BAR and some\n performance enhancements for UPT.\n \n+* **Updated Marvell cnxk ethdev driver.**\n+\n+ Added support for Inline MACsec processing using rte_security framework\n+ for CN103 platform.\n+\n * **Added new algorithms to cryptodev.**\n \n * Added asymmetric algorithm ShangMi 2 (SM2) along with prime field curve support.\ndiff --git a/drivers/net/cnxk/cn10k_ethdev_sec.c b/drivers/net/cnxk/cn10k_ethdev_sec.c\nindex f20e573338..b98fc9378e 100644\n--- a/drivers/net/cnxk/cn10k_ethdev_sec.c\n+++ b/drivers/net/cnxk/cn10k_ethdev_sec.c\n@@ -1058,12 +1058,17 @@ cn10k_eth_sec_session_stats_get(void *device, struct rte_security_session *sess,\n {\n \tstruct rte_eth_dev *eth_dev = (struct rte_eth_dev *)device;\n \tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n+\tstruct cnxk_macsec_sess *macsec_sess;\n \tstruct cnxk_eth_sec_sess *eth_sec;\n \tint rc;\n \n \teth_sec = cnxk_eth_sec_sess_get_by_sess(dev, sess);\n-\tif (eth_sec == NULL)\n+\tif (eth_sec == NULL) {\n+\t\tmacsec_sess = cnxk_eth_macsec_sess_get_by_sess(dev, sess);\n+\t\tif (macsec_sess)\n+\t\t\treturn cnxk_eth_macsec_session_stats_get(dev, macsec_sess, stats);\n \t\treturn -EINVAL;\n+\t}\n \n \trc = roc_nix_inl_sa_sync(&dev->nix, eth_sec->sa, eth_sec->inb,\n \t\t\t ROC_NIX_INL_SA_OP_FLUSH);\n@@ -1107,6 +1112,6 @@ cn10k_eth_sec_ops_override(void)\n \tcnxk_eth_sec_ops.capabilities_get = cn10k_eth_sec_capabilities_get;\n \tcnxk_eth_sec_ops.session_update = cn10k_eth_sec_session_update;\n \tcnxk_eth_sec_ops.session_stats_get = cn10k_eth_sec_session_stats_get;\n-\tcnxk_eth_sec_ops.macsec_sc_stats_get = NULL;\n-\tcnxk_eth_sec_ops.macsec_sa_stats_get = NULL;\n+\tcnxk_eth_sec_ops.macsec_sc_stats_get = cnxk_eth_macsec_sc_stats_get;\n+\tcnxk_eth_sec_ops.macsec_sa_stats_get = cnxk_eth_macsec_sa_stats_get;\n }\ndiff --git a/drivers/net/cnxk/cnxk_ethdev_mcs.c b/drivers/net/cnxk/cnxk_ethdev_mcs.c\nindex 87bfcb8b4e..5264774394 100644\n--- a/drivers/net/cnxk/cnxk_ethdev_mcs.c\n+++ b/drivers/net/cnxk/cnxk_ethdev_mcs.c\n@@ -521,6 +521,70 @@ cnxk_mcs_flow_destroy(struct cnxk_eth_dev *dev, void *flow)\n \treturn ret;\n }\n \n+int\n+cnxk_eth_macsec_sa_stats_get(void *device, uint16_t sa_id, enum rte_security_macsec_direction dir,\n+\t\t\t struct rte_security_macsec_sa_stats *stats)\n+{\n+\tRTE_SET_USED(device);\n+\tRTE_SET_USED(sa_id);\n+\tRTE_SET_USED(dir);\n+\tRTE_SET_USED(stats);\n+\n+\treturn 0;\n+}\n+\n+int\n+cnxk_eth_macsec_sc_stats_get(void *device, uint16_t sc_id, enum rte_security_macsec_direction dir,\n+\t\t\t struct rte_security_macsec_sc_stats *stats)\n+{\n+\tstruct rte_eth_dev *eth_dev = (struct rte_eth_dev *)device;\n+\tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n+\tstruct cnxk_mcs_dev *mcs_dev = dev->mcs_dev;\n+\tstruct roc_mcs_stats_req req = {0};\n+\n+\tif (!roc_feature_nix_has_macsec())\n+\t\treturn -ENOTSUP;\n+\n+\treq.id = sc_id;\n+\treq.dir = (dir == RTE_SECURITY_MACSEC_DIR_RX) ? MCS_RX : MCS_TX;\n+\n+\treturn roc_mcs_sc_stats_get(mcs_dev->mdev, &req, (struct roc_mcs_sc_stats *)stats);\n+}\n+\n+int\n+cnxk_eth_macsec_session_stats_get(struct cnxk_eth_dev *dev, struct cnxk_macsec_sess *sess,\n+\t\t\t\t struct rte_security_stats *stats)\n+{\n+\tstruct cnxk_mcs_dev *mcs_dev = dev->mcs_dev;\n+\tstruct roc_mcs_flowid_stats flow_stats = {0};\n+\tstruct roc_mcs_port_stats port_stats = {0};\n+\tstruct roc_mcs_stats_req req = {0};\n+\n+\tif (!roc_feature_nix_has_macsec())\n+\t\treturn -ENOTSUP;\n+\n+\treq.id = sess->flow_id;\n+\treq.dir = sess->dir;\n+\troc_mcs_flowid_stats_get(mcs_dev->mdev, &req, &flow_stats);\n+\tplt_nix_dbg(\"\\n******* FLOW_ID IDX[%u] STATS dir: %u********\\n\", sess->flow_id, sess->dir);\n+\tplt_nix_dbg(\"TX: tcam_hit_cnt: 0x%\" PRIx64 \"\\n\", flow_stats.tcam_hit_cnt);\n+\n+\treq.id = mcs_dev->port_id;\n+\treq.dir = sess->dir;\n+\troc_mcs_port_stats_get(mcs_dev->mdev, &req, &port_stats);\n+\tplt_nix_dbg(\"\\n********** PORT[0] STATS ****************\\n\");\n+\tplt_nix_dbg(\"RX tcam_miss_cnt: 0x%\" PRIx64 \"\\n\", port_stats.tcam_miss_cnt);\n+\tplt_nix_dbg(\"RX parser_err_cnt: 0x%\" PRIx64 \"\\n\", port_stats.parser_err_cnt);\n+\tplt_nix_dbg(\"RX preempt_err_cnt: 0x%\" PRIx64 \"\\n\", port_stats.preempt_err_cnt);\n+\tplt_nix_dbg(\"RX sectag_insert_err_cnt: 0x%\" PRIx64 \"\\n\", port_stats.sectag_insert_err_cnt);\n+\n+\treq.id = sess->secy_id;\n+\treq.dir = sess->dir;\n+\n+\treturn roc_mcs_secy_stats_get(mcs_dev->mdev, &req,\n+\t\t\t\t (struct roc_mcs_secy_stats *)(&stats->macsec));\n+}\n+\n static int\n cnxk_mcs_event_cb(void *userdata, struct roc_mcs_event_desc *desc, void *cb_arg)\n {\ndiff --git a/drivers/net/cnxk/cnxk_ethdev_mcs.h b/drivers/net/cnxk/cnxk_ethdev_mcs.h\nindex 2b1a6f2c90..4a59dd3df9 100644\n--- a/drivers/net/cnxk/cnxk_ethdev_mcs.h\n+++ b/drivers/net/cnxk/cnxk_ethdev_mcs.h\n@@ -97,6 +97,15 @@ int cnxk_eth_macsec_sa_destroy(void *device, uint16_t sa_id,\n int cnxk_eth_macsec_sc_destroy(void *device, uint16_t sc_id,\n \t\t\t enum rte_security_macsec_direction dir);\n \n+int cnxk_eth_macsec_sa_stats_get(void *device, uint16_t sa_id,\n+\t\t\t\t enum rte_security_macsec_direction dir,\n+\t\t\t\t struct rte_security_macsec_sa_stats *stats);\n+int cnxk_eth_macsec_sc_stats_get(void *device, uint16_t sa_id,\n+\t\t\t\t enum rte_security_macsec_direction dir,\n+\t\t\t\t struct rte_security_macsec_sc_stats *stats);\n+int cnxk_eth_macsec_session_stats_get(struct cnxk_eth_dev *dev, struct cnxk_macsec_sess *sess,\n+\t\t\t\t struct rte_security_stats *stats);\n+\n int cnxk_eth_macsec_session_create(struct cnxk_eth_dev *dev, struct rte_security_session_conf *conf,\n \t\t\t\t struct rte_security_session *sess);\n int cnxk_eth_macsec_session_destroy(struct cnxk_eth_dev *dev, struct rte_security_session *sess);\n", "prefixes": [ "v4", "15/15" ] }