Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128658/?format=api
{ "id": 128658, "url": "http://patchwork.dpdk.org/api/patches/128658/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230614051423.176572-1-junfeng.guo@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230614051423.176572-1-junfeng.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230614051423.176572-1-junfeng.guo@intel.com", "date": "2023-06-14T05:14:23", "name": "examples/ntb: remove redundant logic for dev close", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3495c8359364cf1eb482a7f05633e1fb3d920087", "submitter": { "id": 1785, "url": "http://patchwork.dpdk.org/api/people/1785/?format=api", "name": "Junfeng Guo", "email": "junfeng.guo@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230614051423.176572-1-junfeng.guo@intel.com/mbox/", "series": [ { "id": 28500, "url": "http://patchwork.dpdk.org/api/series/28500/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28500", "date": "2023-06-14T05:14:23", "name": "examples/ntb: remove redundant logic for dev close", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28500/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/128658/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/128658/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2855E42CAD;\n\tWed, 14 Jun 2023 07:14:34 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C39FC40DDB;\n\tWed, 14 Jun 2023 07:14:33 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id 07BB040A7D;\n Wed, 14 Jun 2023 07:14:31 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Jun 2023 22:14:30 -0700", "from dpdk-jf-ntb-one.sh.intel.com ([10.67.111.149])\n by fmsmga005.fm.intel.com with ESMTP; 13 Jun 2023 22:14:28 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1686719672; x=1718255672;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=BePV7NMt8U+4CD+o2rE0xlOcoBavcGwGJpIOWlP2OSc=;\n b=WifZmqIBtkRJUT+w9mGGK+4MKIgNQXDOz/JvlATnwbEEpFuMF2BGHi+A\n oSGsHtu84geVX4ynjmB6XZzsBBijJ3lmysTljbwOx11FtBXsXbs18fLUH\n B5rciaxMWiLUcFt3NR0/j0DY0cVwFbytGjyqJZPPyt1XklDY43nFiP0U9\n 3u2VWxt46tI8Dkr21irGgmY3Zuu3/nlEq7zh0tRp2JHNlikC4XECCmMKX\n +Al+lA2IBLwCMPqe8y4pMNH0yPy0UXwkDHhd06fLv3AlvTNGBbe5IDa7U\n JlsN9fAx27cVjkATO/Yw7ea5axNKbGe6Y63mEQLEu//kVZ7tn5gcOMVJN w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10740\"; a=\"361895301\"", "E=Sophos;i=\"6.00,241,1681196400\"; d=\"scan'208\";a=\"361895301\"", "E=McAfee;i=\"6600,9927,10740\"; a=\"1042052155\"", "E=Sophos;i=\"6.00,241,1681196400\"; d=\"scan'208\";a=\"1042052155\"" ], "X-ExtLoop1": "1", "From": "Junfeng Guo <junfeng.guo@intel.com>", "To": "jingjing.wu@intel.com", "Cc": "dev@dpdk.org, stable@dpdk.org, xingguang.he@intel.com,\n kevin.laatz@intel.com, Junfeng Guo <junfeng.guo@intel.com>", "Subject": "[PATCH] examples/ntb: remove redundant logic for dev close", "Date": "Wed, 14 Jun 2023 13:14:23 +0800", "Message-Id": "<20230614051423.176572-1-junfeng.guo@intel.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "During EAL cleanup stage, all bus devices are cleaned up properly.\nBased on this, there is no need to do extra device close process,\nwhich may call the dev ops '*dev->dev_ops->dev_close' twice.\n\nIf this dev ops for ntb was called twice, the interrupt handle for\nEAL will be disabled twice and will lead to error for the seconde\ntime. Like this: \"EAL: Error disabling MSI-X interrupts for fd xx\"\n\nThus, this patch just remove the redundant logic for device close.\nPorts will be closed at rte_eal_cleanup() in the main loop.\n\nFixes: 1cab1a40ea9b (\"bus: cleanup devices on shutdown\")\nCc: stable@dpdk.org\n\nSigned-off-by: Junfeng Guo <junfeng.guo@intel.com>\n---\n examples/ntb/ntb_fwd.c | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c\nindex 585aad9d70..3385b4b73c 100644\n--- a/examples/ntb/ntb_fwd.c\n+++ b/examples/ntb/ntb_fwd.c\n@@ -177,13 +177,11 @@ cmd_quit_parsed(__rte_unused void *parsed_result,\n \trte_eal_mp_wait_lcore();\n \tin_test = 0;\n \n-\t/* Stop traffic and Close port. */\n+\t/* Stop traffic only. */\n \trte_rawdev_stop(dev_id);\n-\trte_rawdev_close(dev_id);\n-\tif (eth_port_id < RTE_MAX_ETHPORTS && fwd_mode == IOFWD) {\n+\tif (eth_port_id < RTE_MAX_ETHPORTS && fwd_mode == IOFWD)\n \t\trte_eth_dev_stop(eth_port_id);\n-\t\trte_eth_dev_close(eth_port_id);\n-\t}\n+\t/* Ports will be closed at rte_eal_cleanup() in the main loop. */\n \n \tcmdline_quit(cl);\n }\n", "prefixes": [] }