Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128667/?format=api
{ "id": 128667, "url": "http://patchwork.dpdk.org/api/patches/128667/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230614102424.224679-1-abhijit.gangurde@amd.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230614102424.224679-1-abhijit.gangurde@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230614102424.224679-1-abhijit.gangurde@amd.com", "date": "2023-06-14T10:24:24", "name": "bus/cdx: Fix resource leak", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "73497633da3915f9fe365f10baab057933611482", "submitter": { "id": 3110, "url": "http://patchwork.dpdk.org/api/people/3110/?format=api", "name": "Abhijit Gangurde", "email": "abhijit.gangurde@amd.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230614102424.224679-1-abhijit.gangurde@amd.com/mbox/", "series": [ { "id": 28507, "url": "http://patchwork.dpdk.org/api/series/28507/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28507", "date": "2023-06-14T10:24:24", "name": "bus/cdx: Fix resource leak", "version": 1, "mbox": "http://patchwork.dpdk.org/series/28507/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/128667/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/128667/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CBB3742CB7;\n\tWed, 14 Jun 2023 12:24:36 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BDA2440E0F;\n\tWed, 14 Jun 2023 12:24:36 +0200 (CEST)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2042.outbound.protection.outlook.com [40.107.223.42])\n by mails.dpdk.org (Postfix) with ESMTP id 128FE40DDB\n for <dev@dpdk.org>; Wed, 14 Jun 2023 12:24:35 +0200 (CEST)", "from CY5PR15CA0087.namprd15.prod.outlook.com (2603:10b6:930:18::13)\n by CH0PR12MB5123.namprd12.prod.outlook.com (2603:10b6:610:be::12)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37; Wed, 14 Jun\n 2023 10:24:33 +0000", "from CY4PEPF0000EE34.namprd05.prod.outlook.com\n (2603:10b6:930:18:cafe::17) by CY5PR15CA0087.outlook.office365.com\n (2603:10b6:930:18::13) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37 via Frontend\n Transport; Wed, 14 Jun 2023 10:24:33 +0000", "from SATLEXMB03.amd.com (165.204.84.17) by\n CY4PEPF0000EE34.mail.protection.outlook.com (10.167.242.40) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.6500.25 via Frontend Transport; Wed, 14 Jun 2023 10:24:32 +0000", "from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com\n (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 14 Jun\n 2023 05:24:30 -0500", "from xhdipdslab59.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.23 via\n Frontend Transport; Wed, 14 Jun 2023 05:24:28 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=cDWw6MnIGIs/YdmBVyHV9GhuHpXpuUMd4qdvT9YX54mtK/+PS8nHxyAE7jFTqdiSspJo52adyJBKdO3vhaIYyzhN+oilbarQMIVtvdANR5XbE4tdKeC9sgauQLxO6lJQU6DT0+gTcwzzydvqK1jMZAXCAqxqDXpLmFvvnRfcbpGa5EzGmulWpyKmIneLoAvrEOms1aGK5i2FhXqd4jN6oHTyQtIgJtHW5S+c0DFbJkFqhQYIGxZVQ5cbQOBd71tNT+JlMqM1vZtvBMXyjJvk8bwfc6N0UqmpU17YEtAp9dnsBc7jHOL3rU5kpOGdial77isltGFKA8PKVaW9PwhVfA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=4X2x4cRjuXz2AoQovMnQHb32X9Q2RRPKUHB9qx60UZs=;\n b=U743AKDymvhrrB4Ta1kCsYFZGG8qYMC8F3oVbAQACm3agtE3aZZG9TY63n07WPOOdFp01giVVoF0kz9SuTyHUsE+PpsBeJ6f74hdhOsuWcJjIbmtihYcSLtmQ106o11zKqvUPl6MtuqoAePU9eklkufHW4qBnGFUeSHdx+AZE2JeMliijbtYaWmHK3+8dO2M3CeURfUvMWBgLyaLGnzSid++3nFR7OoKKfHc+U8aqYi9N3hU/F0iOBRmzHGMKlltXLvpP7LP5/yEaYZG28HQ/XNSZyKX7KeCyz/qEcWY+70q5P4l4Y5dp9e5CrgjeOi1mUOOB6CGC7qQX8qQ7rn+mw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=4X2x4cRjuXz2AoQovMnQHb32X9Q2RRPKUHB9qx60UZs=;\n b=C+8itJt5/ECA2A/VMWYx2Cvu85lZ0G7WuR97++HK5MHohZQjuaPiQer1I/PcNdPuUYnQaGTAHf3dC8/w6uQCFZ/Ql1lSeccUvzF7dseF/BFOvwnzXMzCPndGpyRMM7jv2QfU1xBFwWg9i+j+GibRgBGoe606n3PhnpVgkJE+ga0=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C", "From": "Abhijit Gangurde <abhijit.gangurde@amd.com>", "To": "<Nipun.Gupta@amd.com>, <nikhil.agarwal@amd.com>", "CC": "<dev@dpdk.org>, <david.marchand@redhat.com>, <ferruh.yigit@amd.com>,\n Abhijit Gangurde <abhijit.gangurde@amd.com>", "Subject": "[PATCH] bus/cdx: Fix resource leak", "Date": "Wed, 14 Jun 2023 15:54:24 +0530", "Message-ID": "<20230614102424.224679-1-abhijit.gangurde@amd.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CY4PEPF0000EE34:EE_|CH0PR12MB5123:EE_", "X-MS-Office365-Filtering-Correlation-Id": "8232c3fc-0492-4eb3-62c0-08db6cc18b9b", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n qf83WbnstgDxzkaDoMAXO3425E4uElQhHoZuFgpwd46vhItK4NBoZXnD3vgMu825qGv29VDKxAwQ1v0VrQ8I3WwB17BCLrAh3bTFBDT4QhENsSJ+/V2OwWCNku9vW+fG88Y6trz2jcI+UKm5FNmcjNYmZVpzKdqLZC5SUPwGWkWai0U5xgTWOxddRLCBWBg0IfyjSjIwoTXhhuZOQNfKfYhPxTmROqwVRDvdzcoij/gP9fqwZl2W6nuERmOVggSr+LULEDtbPBR3RUX9g6gGKvlEoOIC5FvCkN82l8A2oErfCuBKY64Op3Xkk/c2nl2RpKP4Pdv0heip/RssGfohHKaL3ldLMAFhVaOQVi2oS04ZSElF08V+uJMFiLMtDgnqTbAjBJt7z9TEVBaL2xAIk5KKukawXWOaldlM8gp3bw/XQwtUJiQ6Wqzg/tjZk1jiL4uWPsqntO+Px5GpKrk6FqlHf26waEqkAkOj6i3fPIedKrac8sdl54ebox/SM7accjHthnFLMOlyqitCDTuz4AyQHz+nqLRK8CRbw5WqyOIUhI7IIh55OmcwiTpAYwn/YyzjJW43qTkQTALKr6EcqkjgKPmVhVofBREI597iUpIzGQU7CLDUUtnbEUSZqE33uuSw1PTc6n5/b+5pwrQJKucsgATUeUoiHU/CQOib/Hk3qJMqEn0yZygDsf+K3eprFDqY/Rf7pTGsbOR78qO/kpwnD+AmJFM2zpLc4W4cs3EeeneabqDuoW+8SK0dK9eb+aSIG+6oSn86UXrYGPhqtw==", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB03.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230028)(4636009)(39860400002)(346002)(136003)(396003)(376002)(451199021)(36840700001)(46966006)(40470700004)(8676002)(8936002)(2906002)(5660300002)(41300700001)(316002)(36860700001)(4326008)(6636002)(70206006)(70586007)(83380400001)(47076005)(336012)(426003)(2616005)(36756003)(186003)(82740400003)(54906003)(110136005)(356005)(1076003)(26005)(81166007)(40480700001)(478600001)(82310400005)(6666004)(40460700003)(44832011)(86362001)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "14 Jun 2023 10:24:32.8823 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 8232c3fc-0492-4eb3-62c0-08db6cc18b9b", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB03.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CY4PEPF0000EE34.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CH0PR12MB5123", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Freeing the allocated resources on error scenarios.\n\nCoverity issue: 385377\nFixes: f29fb5caa135 (\"bus/cdx: support MSI\")\nSigned-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>\n---\n drivers/bus/cdx/cdx.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c\nindex 28bbf92ed5..0f643ad2cb 100644\n--- a/drivers/bus/cdx/cdx.c\n+++ b/drivers/bus/cdx/cdx.c\n@@ -208,8 +208,8 @@ cdx_scan_one(const char *dirname, const char *dev_name)\n \tret = cdx_get_kernel_driver_by_path(filename, driver, sizeof(driver));\n \tif (ret < 0) {\n \t\tCDX_BUS_ERR(\"Fail to get kernel driver\");\n-\t\tret = -1;\n-\t\tgoto err;\n+\t\tfree(dev);\n+\t\treturn -1;\n \t}\n \n \t/* Allocate interrupt instance for cdx device */\n@@ -218,6 +218,7 @@ cdx_scan_one(const char *dirname, const char *dev_name)\n \tif (dev->intr_handle == NULL) {\n \t\tCDX_BUS_ERR(\"Failed to create interrupt instance for %s\",\n \t\t\tdev->device.name);\n+\t\tfree(dev);\n \t\treturn -ENOMEM;\n \t}\n \n@@ -241,8 +242,8 @@ cdx_scan_one(const char *dirname, const char *dev_name)\n \t/* get device id */\n \tsnprintf(filename, sizeof(filename), \"%s/device\", dirname);\n \tif (eal_parse_sysfs_value(filename, &tmp) < 0) {\n-\t\tfree(dev);\n-\t\treturn -1;\n+\t\tret = -1;\n+\t\tgoto err;\n \t}\n \tdev->id.device_id = (uint16_t)tmp;\n \n@@ -251,6 +252,7 @@ cdx_scan_one(const char *dirname, const char *dev_name)\n \treturn 0;\n \n err:\n+\trte_intr_instance_free(dev->intr_handle);\n \tfree(dev);\n \treturn ret;\n }\n", "prefixes": [] }